[jira] Updated: (WICKET-2332) Open up Markup ctor and MarkupContainer#renderNext
[ https://issues.apache.org/jira/browse/WICKET-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2332: Attachment: WICKET-2332-2.patch Second patch also makes org.apache.wicket.markup.Markup.makeImmutable() public. Again, please apply in trunk. > Open up Markup ctor and MarkupContainer#renderNext > -- > > Key: WICKET-2332 > URL: https://issues.apache.org/jira/browse/WICKET-2332 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4-RC4 >Reporter: Erik van Oosten > Fix For: 1.4-RC6 > > Attachments: WICKET-2332-2.patch, WICKET-2332.patch > > > -1- Change org.apache.wicket.markup.Markup#Markup(): from default to public > -2- Change org.apache.wicket.MarkupContainer#renderNext(MarkupStream): from > private to protected (it stays final) > Rationale from the dev e-mail list: > Erik van Oosten wrote: > --- > Hi, > I am writing a Swing like layout manager (with MIG layout manager's API > as inspiration). The layout manager will generate HTML, but also has the > ability to override this with HTML defined by the user. I have a > prototype that does this. It takes elements from the current > Markupstream, adds the elements that are missing, and then some more to > facilitate the layouting (well the last step is next on my todo list). > These elements are then put in a new markupstream that is used to drive > onComponentTagBody of the layout component. > For this to work I had to open up 2 things: > - org.apache.wicket.markup.Markup#Markup(): from default to public > I could have written my own implementation of IMarkup, but that seems > a bit overkill as I need exactly what is in Markup. > - org.apache.wicket.MarkupContainer#renderNext(MarkupStream): from > private to protected (don't care if it stays final) > My onComponentTagBody implementation is loosely based on method > org.apache.wicket.MarkupContainer#renderAssociatedMarkup(String,String). > One of the methods I need to call to render children seems to be renderNext. > Could these two be opened up? > --- > Juergen Donnerstag wrote: > --- > I don't mind open up both, as long as renderNext() stays final and we > tag it as "THIS IS WICKET INTERNAL". > --- -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2332) Open up Markup ctor and MarkupContainer#renderNext
[ https://issues.apache.org/jira/browse/WICKET-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2332: Fix Version/s: (was: 1.4-RC5) 1.4-RC6 > Open up Markup ctor and MarkupContainer#renderNext > -- > > Key: WICKET-2332 > URL: https://issues.apache.org/jira/browse/WICKET-2332 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4-RC4 >Reporter: Erik van Oosten > Fix For: 1.4-RC6 > > Attachments: WICKET-2332.patch > > > -1- Change org.apache.wicket.markup.Markup#Markup(): from default to public > -2- Change org.apache.wicket.MarkupContainer#renderNext(MarkupStream): from > private to protected (it stays final) > Rationale from the dev e-mail list: > Erik van Oosten wrote: > --- > Hi, > I am writing a Swing like layout manager (with MIG layout manager's API > as inspiration). The layout manager will generate HTML, but also has the > ability to override this with HTML defined by the user. I have a > prototype that does this. It takes elements from the current > Markupstream, adds the elements that are missing, and then some more to > facilitate the layouting (well the last step is next on my todo list). > These elements are then put in a new markupstream that is used to drive > onComponentTagBody of the layout component. > For this to work I had to open up 2 things: > - org.apache.wicket.markup.Markup#Markup(): from default to public > I could have written my own implementation of IMarkup, but that seems > a bit overkill as I need exactly what is in Markup. > - org.apache.wicket.MarkupContainer#renderNext(MarkupStream): from > private to protected (don't care if it stays final) > My onComponentTagBody implementation is loosely based on method > org.apache.wicket.MarkupContainer#renderAssociatedMarkup(String,String). > One of the methods I need to call to render children seems to be renderNext. > Could these two be opened up? > --- > Juergen Donnerstag wrote: > --- > I don't mind open up both, as long as renderNext() stays final and we > tag it as "THIS IS WICKET INTERNAL". > --- -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2332) Open up Markup ctor and MarkupContainer#renderNext
[ https://issues.apache.org/jira/browse/WICKET-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2332: Attachment: WICKET-2332.patch Please apply path in trunk. > Open up Markup ctor and MarkupContainer#renderNext > -- > > Key: WICKET-2332 > URL: https://issues.apache.org/jira/browse/WICKET-2332 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4-RC4 >Reporter: Erik van Oosten > Fix For: 1.4-RC5 > > Attachments: WICKET-2332.patch > > > -1- Change org.apache.wicket.markup.Markup#Markup(): from default to public > -2- Change org.apache.wicket.MarkupContainer#renderNext(MarkupStream): from > private to protected (it stays final) > Rationale from the dev e-mail list: > Erik van Oosten wrote: > --- > Hi, > I am writing a Swing like layout manager (with MIG layout manager's API > as inspiration). The layout manager will generate HTML, but also has the > ability to override this with HTML defined by the user. I have a > prototype that does this. It takes elements from the current > Markupstream, adds the elements that are missing, and then some more to > facilitate the layouting (well the last step is next on my todo list). > These elements are then put in a new markupstream that is used to drive > onComponentTagBody of the layout component. > For this to work I had to open up 2 things: > - org.apache.wicket.markup.Markup#Markup(): from default to public > I could have written my own implementation of IMarkup, but that seems > a bit overkill as I need exactly what is in Markup. > - org.apache.wicket.MarkupContainer#renderNext(MarkupStream): from > private to protected (don't care if it stays final) > My onComponentTagBody implementation is loosely based on method > org.apache.wicket.MarkupContainer#renderAssociatedMarkup(String,String). > One of the methods I need to call to render children seems to be renderNext. > Could these two be opened up? > --- > Juergen Donnerstag wrote: > --- > I don't mind open up both, as long as renderNext() stays final and we > tag it as "THIS IS WICKET INTERNAL". > --- -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.