git commit: [WICKET-5596] DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page

2014-05-19 Thread adelbene 
Repository: wicket
Updated Branches:
  refs/heads/wicket-6.x 3c6c41f19 - 6dfd3d9d2


[WICKET-5596] DropDownChoice#wantsOnSelectionChangedNotifications(T) not
being called on unmounted page

Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/6dfd3d9d
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/6dfd3d9d
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/6dfd3d9d

Branch: refs/heads/wicket-6.x
Commit: 6dfd3d9d2cb7e378275db0458c9d241de8e7e7d8
Parents: 3c6c41f
Author: adelbene an.delb...@gmail.com
Authored: Mon May 19 22:24:55 2014 +0200
Committer: adelbene an.delb...@gmail.com
Committed: Mon May 19 22:24:55 2014 +0200

--
 .../org/apache/wicket/markup/html/form/DropDownChoice.java | 6 +-
 .../extensions/yui/calendar/DatesPage1_ExpectedResult.html | 2 +-
 2 files changed, 2 insertions(+), 6 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/6dfd3d9d/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
 
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
index 0db8dc6..1da483a 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
@@ -21,8 +21,6 @@ import java.util.List;
 import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior;
 import org.apache.wicket.markup.ComponentTag;
 import org.apache.wicket.model.IModel;
-import org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler;
-import org.apache.wicket.core.request.handler.PageAndComponentProvider;
 import org.apache.wicket.request.mapper.parameter.PageParameters;
 
 
@@ -233,9 +231,7 @@ public class DropDownChoiceT extends 
AbstractSingleSelectChoiceT implements
{
// we do not want relative URL here, because it will be 
used by
// Form#dispatchEvent
-   CharSequence url = urlFor(new 
ListenerInterfaceRequestHandler(
-   new PageAndComponentProvider(getPage(), this, 
new PageParameters()),
-   IOnChangeListener.INTERFACE));
+   CharSequence url = urlFor(IOnChangeListener.INTERFACE, 
new PageParameters());
 
Form? form = findParent(Form.class);
if (form != null)

http://git-wip-us.apache.org/repos/asf/wicket/blob/6dfd3d9d/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
--
diff --git 
a/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
 
b/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
index 45bc50e..e32bce0 100644
--- 
a/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
+++ 
b/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
@@ -105,7 +105,7 @@ Wicket.DateTimeInit.CalendarAdd(function() {
 /head
 body
 form wicket:id=localeForm id=localeForm2 method=post 
action=./org.apache.wicket.extensions.yui.calendar.DatesPage1?0-1.IFormSubmitListener-localeFormdiv
 
style=width:0px;height:0px;position:absolute;left:-100px;top:-100px;overflow:hiddeninput
 type=hidden name=localeForm2_hf_0 id=localeForm2_hf_0 //div
-pselect wicket:id=localeSelect 
onchange=document.getElementById(#039;localeForm2_hf_0#039;).value=#039;../../page?0-1.IOnChangeListener-localeForm-localeSelect#039;;document.getElementById(#039;localeForm2#039;).submit();
 name=localeSelect
+pselect wicket:id=localeSelect 
onchange=document.getElementById(#039;localeForm2_hf_0#039;).value=#039;./org.apache.wicket.extensions.yui.calendar.DatesPage1?0-1.IOnChangeListener-localeForm-localeSelect#039;;document.getElementById(#039;localeForm2#039;).submit();
 name=localeSelect
 option value=0cinese (Cina) (Chinese (China))/option
 option value=1cinese (Cina) (Chinese (China))/option
 option value=2cinese (Cina) (Chinese (China))/option

git commit: [WICKET-5596] DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page

2014-05-19 Thread adelbene 
Repository: wicket
Updated Branches:
  refs/heads/master ccff0802a - 0102b9db3


[WICKET-5596] DropDownChoice#wantsOnSelectionChangedNotifications(T) not
being called on unmounted page


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0102b9db
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0102b9db
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0102b9db

Branch: refs/heads/master
Commit: 0102b9db3f093b415d1a646c5d7590bd3b10d00e
Parents: ccff080
Author: adelbene an.delb...@gmail.com
Authored: Mon May 19 22:24:55 2014 +0200
Committer: adelbene an.delb...@gmail.com
Committed: Mon May 19 23:03:40 2014 +0200

--
 .../apache/wicket/markup/html/form/DropDownChoice.java   | 11 ---
 .../yui/calendar/DatesPage1_ExpectedResult.html  |  2 +-
 2 files changed, 5 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/0102b9db/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
 
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
index e6ec9ca..3f97479 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
@@ -19,10 +19,10 @@ package org.apache.wicket.markup.html.form;
 import java.util.List;
 
 import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior;
-import org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler;
-import org.apache.wicket.core.request.handler.PageAndComponentProvider;
 import org.apache.wicket.markup.ComponentTag;
 import org.apache.wicket.model.IModel;
+import org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler;
+import org.apache.wicket.core.request.handler.PageAndComponentProvider;
 import org.apache.wicket.request.mapper.parameter.PageParameters;
 
 
@@ -233,9 +233,7 @@ public class DropDownChoiceT extends 
AbstractSingleSelectChoiceT implements
{
// we do not want relative URL here, because it will be 
used by
// Form#dispatchEvent
-   CharSequence url = urlFor(new 
ListenerInterfaceRequestHandler(
-   new PageAndComponentProvider(getPage(), this, 
new PageParameters()),
-   IOnChangeListener.INTERFACE));
+   CharSequence url = urlFor(IOnChangeListener.INTERFACE, 
new PageParameters());
 
Form? form = findParent(Form.class);
if (form != null)
@@ -263,7 +261,6 @@ public class DropDownChoiceT extends 
AbstractSingleSelectChoiceT implements
 * @param newSelection
 *The newly selected object of the backing model NOTE this 
is the same as you would
 *get by calling getModelObject() if the new selection were 
current
-* @see #wantOnSelectionChangedNotifications()
 */
protected void onSelectionChanged(final T newSelection)
{
@@ -297,4 +294,4 @@ public class DropDownChoiceT extends 
AbstractSingleSelectChoiceT implements
}
return super.getStatelessHint();
}
-}
+}
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/wicket/blob/0102b9db/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
--
diff --git 
a/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
 
b/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
index 45bc50e..e32bce0 100644
--- 
a/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
+++ 
b/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
@@ -105,7 +105,7 @@ Wicket.DateTimeInit.CalendarAdd(function() {
 /head
 body
 form wicket:id=localeForm id=localeForm2 method=post 
action=./org.apache.wicket.extensions.yui.calendar.DatesPage1?0-1.IFormSubmitListener-localeFormdiv
 
style=width:0px;height:0px;position:absolute;left:-100px;top:-100px;overflow:hiddeninput
 type=hidden name=localeForm2_hf_0 id=localeForm2_hf_0 //div
-pselect wicket:id=localeSelect 
onchange=document.getElementById(#039;localeForm2_hf_0#039;).value=#039;../../page?0-1.IOnChangeListener-localeForm-localeSelect#039;;document.getElementById(#039;localeForm2#039;).submit();
 name=localeSelect
+pselect