Author: mgrigorov
Date: Wed Oct 20 15:49:38 2010
New Revision: 1025621

URL: http://svn.apache.org/viewvc?rev=1025621&view=rev
Log:
WICKET-3123 MockSessionStore doesn't bind sessions properly

Actually it appeared that the session is inproperly bound for tests.
All later calls to store.lookup(session) always return true and thus a session 
id is never created

Modified:
    
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
    
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java?rev=1025621&r1=1025620&r2=1025621&view=diff
==============================================================================
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
 Wed Oct 20 15:49:38 2010
@@ -356,7 +356,6 @@ public class BaseWicketTester
        private void createNewSession()
        {
                session = Session.get();
-               application.getSessionStore().bind(null, session);
                ThreadContext.setSession(session);
        }
 

Modified: 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java?rev=1025621&r1=1025620&r2=1025621&view=diff
==============================================================================
--- 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java
 (original)
+++ 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java
 Wed Oct 20 15:49:38 2010
@@ -46,7 +46,6 @@ import org.apache.wicket.util.tester.app
 import org.apache.wicket.util.tester.apps_1.ViewBook;
 import org.apache.wicket.util.tester.apps_6.LinkPage;
 import org.apache.wicket.util.tester.apps_6.ResultPage;
-import org.junit.Ignore;
 
 /**
  * 
@@ -692,7 +691,6 @@ public class WicketTesterTest extends Te
        /**
         * Test for WICKET-3123
         */
-       @Ignore("Ignored until WICKET-3123 is fixed")
        public void testSessionBinding()
        {
                Session session = tester.getSession();


Reply via email to