[33/50] [abbrv] wicket git commit: WICKET-6462 added regression test

2017-09-22 Thread solomax 
WICKET-6462 added regression test

Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/72a5d312
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/72a5d312
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/72a5d312

Branch: refs/heads/WICKET-6105-java.time
Commit: 72a5d312a1dfe63349a8ab963d9126cab5525a20
Parents: 48f4580
Author: Andrea Del Bene 
Authored: Tue Sep 5 12:53:08 2017 +0200
Committer: Andrea Del Bene 
Committed: Tue Sep 5 12:53:08 2017 +0200

--
 .../ajax/form/AjaxFormSubmitBehaviorTest.java   | 44 +-
 .../org/apache/wicket/ajax/form/PanelEdit.html  | 47 +++
 .../org/apache/wicket/ajax/form/PanelEdit.java  | 60 
 3 files changed, 136 insertions(+), 15 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/72a5d312/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
--
diff --git 
a/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
 
b/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
index 48f55a9..a0cab5d 100644
--- 
a/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
+++ 
b/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
@@ -16,6 +16,8 @@
  */
 package org.apache.wicket.ajax.form;
 
+import org.apache.wicket.Component;
+import org.apache.wicket.ajax.AjaxRequestTarget;
 import org.apache.wicket.ajax.markup.html.form.AjaxButton;
 import org.apache.wicket.markup.html.form.Form;
 import org.apache.wicket.util.tester.FormTester;
@@ -53,43 +55,55 @@ public class AjaxFormSubmitBehaviorTest extends 
WicketTestCase
tester.startPage(NestedFormTestPage.class);

NestedFormTestPage homePage = 
(NestedFormTestPage)tester.getLastRenderedPage();
-   assertFalse(homePage.innerFormSubmitted);
+   assertFalse(homePage.innerSubmitted);

FormTester formTester = tester.newFormTester("outer:inner");
formTester.submit("submit");

-   assertTrue(homePage.innerFormSubmitted);
+   assertTrue(homePage.innerSubmitted);
}

+   /**
+* https://issues.apache.org/jira/browse/WICKET-6462
+* 
+* onSubmit must be called once.
+*/
+   @Test
+   public void formReplacement() 
+   {
+   PanelEdit panelEdit = 
tester.startComponentInPage(PanelEdit.class);
+   FormTester formTester = tester.newFormTester(panelEdit.getId() 
+ ":form");
+   //AjaxFormSubmitBehavior onSubmit must not be called when form 
is removed
+   formTester.submit("submit");
+   }
+
public static class NestedFormTestPage extends NestedFormPage
{

-   public boolean innerFormSubmitted = false;
+   /**
+* 
+*/
+   private static final long serialVersionUID = 
-515262294201762225L;
+   

public NestedFormTestPage() 
{
-   Form outer = new Form("outer");
-   replace(outer);
-   
-   Form inner = new Form("inner")
-   {
+   Form inner = new Form("inner") {
@Override
-   protected boolean 
wantSubmitOnParentFormSubmit() 
-   {
+   protected boolean 
wantSubmitOnParentFormSubmit() {
return false;
}

@Override
-   protected void onSubmit() 
-   {
+   protected void onSubmit() {
super.onSubmit();
-   innerFormSubmitted = true;
+   innerSubmitted = true;
}
};

-   outer.add(inner);
-   
inner.add(new AjaxButton("submit", inner) {});
+   
+   get("outer:inner").replaceWith(inner);
}
}
 }
\ No newline at end of file

[2/2] wicket git commit: WICKET-6462 added regression test

2017-09-05 Thread adelbene 
WICKET-6462 added regression test

Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/08be805e
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/08be805e
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/08be805e

Branch: refs/heads/wicket-7.x
Commit: 08be805e120a08e5acd659b8c94f10702cbc5c49
Parents: bedf3fd
Author: Andrea Del Bene 
Authored: Tue Sep 5 12:53:08 2017 +0200
Committer: Andrea Del Bene 
Committed: Tue Sep 5 17:54:08 2017 +0200

--
 .../ajax/form/AjaxFormSubmitBehaviorTest.java   | 44 +-
 .../org/apache/wicket/ajax/form/PanelEdit.html  | 47 +++
 .../org/apache/wicket/ajax/form/PanelEdit.java  | 60 
 3 files changed, 136 insertions(+), 15 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/08be805e/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
--
diff --git 
a/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
 
b/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
index 48f55a9..a0cab5d 100644
--- 
a/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
+++ 
b/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
@@ -16,6 +16,8 @@
  */
 package org.apache.wicket.ajax.form;
 
+import org.apache.wicket.Component;
+import org.apache.wicket.ajax.AjaxRequestTarget;
 import org.apache.wicket.ajax.markup.html.form.AjaxButton;
 import org.apache.wicket.markup.html.form.Form;
 import org.apache.wicket.util.tester.FormTester;
@@ -53,43 +55,55 @@ public class AjaxFormSubmitBehaviorTest extends 
WicketTestCase
tester.startPage(NestedFormTestPage.class);

NestedFormTestPage homePage = 
(NestedFormTestPage)tester.getLastRenderedPage();
-   assertFalse(homePage.innerFormSubmitted);
+   assertFalse(homePage.innerSubmitted);

FormTester formTester = tester.newFormTester("outer:inner");
formTester.submit("submit");

-   assertTrue(homePage.innerFormSubmitted);
+   assertTrue(homePage.innerSubmitted);
}

+   /**
+* https://issues.apache.org/jira/browse/WICKET-6462
+* 
+* onSubmit must be called once.
+*/
+   @Test
+   public void formReplacement() 
+   {
+   PanelEdit panelEdit = 
tester.startComponentInPage(PanelEdit.class);
+   FormTester formTester = tester.newFormTester(panelEdit.getId() 
+ ":form");
+   //AjaxFormSubmitBehavior onSubmit must not be called when form 
is removed
+   formTester.submit("submit");
+   }
+
public static class NestedFormTestPage extends NestedFormPage
{

-   public boolean innerFormSubmitted = false;
+   /**
+* 
+*/
+   private static final long serialVersionUID = 
-515262294201762225L;
+   

public NestedFormTestPage() 
{
-   Form outer = new Form("outer");
-   replace(outer);
-   
-   Form inner = new Form("inner")
-   {
+   Form inner = new Form("inner") {
@Override
-   protected boolean 
wantSubmitOnParentFormSubmit() 
-   {
+   protected boolean 
wantSubmitOnParentFormSubmit() {
return false;
}

@Override
-   protected void onSubmit() 
-   {
+   protected void onSubmit() {
super.onSubmit();
-   innerFormSubmitted = true;
+   innerSubmitted = true;
}
};

-   outer.add(inner);
-   
inner.add(new AjaxButton("submit", inner) {});
+   
+   get("outer:inner").replaceWith(inner);
}
}
 }
\ No newline at end of file

wicket git commit: WICKET-6462 added regression test

2017-09-05 Thread adelbene 
Repository: wicket
Updated Branches:
  refs/heads/master 48f458091 -> 72a5d312a


WICKET-6462 added regression test

Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/72a5d312
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/72a5d312
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/72a5d312

Branch: refs/heads/master
Commit: 72a5d312a1dfe63349a8ab963d9126cab5525a20
Parents: 48f4580
Author: Andrea Del Bene 
Authored: Tue Sep 5 12:53:08 2017 +0200
Committer: Andrea Del Bene 
Committed: Tue Sep 5 12:53:08 2017 +0200

--
 .../ajax/form/AjaxFormSubmitBehaviorTest.java   | 44 +-
 .../org/apache/wicket/ajax/form/PanelEdit.html  | 47 +++
 .../org/apache/wicket/ajax/form/PanelEdit.java  | 60 
 3 files changed, 136 insertions(+), 15 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/72a5d312/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
--
diff --git 
a/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
 
b/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
index 48f55a9..a0cab5d 100644
--- 
a/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
+++ 
b/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
@@ -16,6 +16,8 @@
  */
 package org.apache.wicket.ajax.form;
 
+import org.apache.wicket.Component;
+import org.apache.wicket.ajax.AjaxRequestTarget;
 import org.apache.wicket.ajax.markup.html.form.AjaxButton;
 import org.apache.wicket.markup.html.form.Form;
 import org.apache.wicket.util.tester.FormTester;
@@ -53,43 +55,55 @@ public class AjaxFormSubmitBehaviorTest extends 
WicketTestCase
tester.startPage(NestedFormTestPage.class);

NestedFormTestPage homePage = 
(NestedFormTestPage)tester.getLastRenderedPage();
-   assertFalse(homePage.innerFormSubmitted);
+   assertFalse(homePage.innerSubmitted);

FormTester formTester = tester.newFormTester("outer:inner");
formTester.submit("submit");

-   assertTrue(homePage.innerFormSubmitted);
+   assertTrue(homePage.innerSubmitted);
}

+   /**
+* https://issues.apache.org/jira/browse/WICKET-6462
+* 
+* onSubmit must be called once.
+*/
+   @Test
+   public void formReplacement() 
+   {
+   PanelEdit panelEdit = 
tester.startComponentInPage(PanelEdit.class);
+   FormTester formTester = tester.newFormTester(panelEdit.getId() 
+ ":form");
+   //AjaxFormSubmitBehavior onSubmit must not be called when form 
is removed
+   formTester.submit("submit");
+   }
+
public static class NestedFormTestPage extends NestedFormPage
{

-   public boolean innerFormSubmitted = false;
+   /**
+* 
+*/
+   private static final long serialVersionUID = 
-515262294201762225L;
+   

public NestedFormTestPage() 
{
-   Form outer = new Form("outer");
-   replace(outer);
-   
-   Form inner = new Form("inner")
-   {
+   Form inner = new Form("inner") {
@Override
-   protected boolean 
wantSubmitOnParentFormSubmit() 
-   {
+   protected boolean 
wantSubmitOnParentFormSubmit() {
return false;
}

@Override
-   protected void onSubmit() 
-   {
+   protected void onSubmit() {
super.onSubmit();
-   innerFormSubmitted = true;
+   innerSubmitted = true;
}
};

-   outer.add(inner);
-   
inner.add(new AjaxButton("submit", inner) {});
+   
+   get("outer:inner").replaceWith(inner);
}
}
 }
\ No newline at end of file