[jira] [Commented] (WICKET-5898) StackOverflowError after form submit with a validation error
[ https://issues.apache.org/jira/browse/WICKET-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647382#comment-14647382 ] Andrea Del Bene commented on WICKET-5898: - [~vitiate] Thank you for your fast reply. The last commits (cherry picks from 7.x) you see above solve the problem with your quickstart. You can see it using version 6.21.0-SNAPSHOT. I will try to further improve the fix for 6.x to cover more potential problems as the 7.x already does. StackOverflowError after form submit with a validation error Key: WICKET-5898 URL: https://issues.apache.org/jira/browse/WICKET-5898 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5 Reporter: Vojtěch Krása Assignee: Andrea Del Bene Fix For: 7.0.0-M6, 6.21.0 Attachments: NestedTransparentContainer.zip I was not able to find a cause or make a small quickstart, but it has something to do with a form validation, my workaround was to setDefaultFormProcessing(false) or not use required TextFields. It can be reproduced on https://github.com/krasa/DevSupportApp/tree/stackOverflow 1) run StartVojtitkoDummy 2) go to http://localhost:8765/wicket/bookmarkable/krasa.release.frontend.TokenizationPage 3) click on Generate Release json button - instead of SOE, it should give a validation error, probably even on fields which I would not want to validate, but that's just because I've made the page badly... {code} java.lang.StackOverflowError: null ... at org.apache.wicket.Component.getMarkup(Component.java:755) at org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.getMarkup(DefaultMarkupSourcingStrategy.java:81) at org.apache.wicket.MarkupContainer.getMarkup(MarkupContainer.java:453) at org.apache.wicket.markup.html.panel.AbstractMarkupSourcingStrategy$1.component(AbstractMarkupSourcingStrategy.java:74) at org.apache.wicket.markup.html.panel.AbstractMarkupSourcingStrategy$1.component(AbstractMarkupSourcingStrategy.java:66) at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:144) at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:123) at org.apache.wicket.MarkupContainer.visitChildren(MarkupContainer.java:862) at org.apache.wicket.markup.html.panel.AbstractMarkupSourcingStrategy.searchMarkupInTransparentResolvers(AbstractMarkupSourcingStrategy.java:65) at org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.getMarkup(DefaultMarkupSourcingStrategy.java:99) at org.apache.wicket.MarkupContainer.getMarkup(MarkupContainer.java:453) at org.apache.wicket.Component.getMarkup(Component.java:755) at org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.getMarkup(DefaultMarkupSourcingStrategy.java:81) at org.apache.wicket.MarkupContainer.getMarkup(MarkupContainer.java:453) at org.apache.wicket.markup.html.panel.AbstractMarkupSourcingStrategy$1.component(AbstractMarkupSourcingStrategy.java:74) at org.apache.wicket.markup.html.panel.AbstractMarkupSourcingStrategy$1.component(AbstractMarkupSourcingStrategy.java:66) at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:144) at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:123) at org.apache.wicket.MarkupContainer.visitChildren(MarkupContainer.java:862) at org.apache.wicket.markup.html.panel.AbstractMarkupSourcingStrategy.searchMarkupInTransparentResolvers(AbstractMarkupSourcingStrategy.java:65) at org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.getMarkup(DefaultMarkupSourcingStrategy.java:99) at org.apache.wicket.MarkupContainer.getMarkup(MarkupContainer.java:453) at org.apache.wicket.Component.getMarkup(Component.java:755) at org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.getMarkup(DefaultMarkupSourcingStrategy.java:81) at org.apache.wicket.MarkupContainer.getMarkup(MarkupContainer.java:453) at org.apache.wicket.markup.html.panel.AbstractMarkupSourcingStrategy$1.component(AbstractMarkupSourcingStrategy.java:74) at org.apache.wicket.markup.html.panel.AbstractMarkupSourcingStrategy$1.component(AbstractMarkupSourcingStrategy.java:66) at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:144) at org.apache.wicket.util.visit.Visits.visitChildren(Visits.java:123) at org.apache.wicket.MarkupContainer.visitChildren(MarkupContainer.java:862) at org.apache.wicket.markup.html.panel.AbstractMarkupSourcingStrategy.searchMarkupInTransparentResolvers(AbstractMarkupSourcingStrategy.java:65) at
[jira] [Resolved] (WICKET-5907) Wicket autocomplete poput is not removed.
[ https://issues.apache.org/jira/browse/WICKET-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene resolved WICKET-5907. - Resolution: Not A Problem The culprit is in your MyAutoCompleteTextField. You change the markup id after the component is initialized: {code} setMarkupId(id_ + System.currentTimeMillis()); {code} If you remove it everything is ok Wicket autocomplete poput is not removed. - Key: WICKET-5907 URL: https://issues.apache.org/jira/browse/WICKET-5907 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.19.0 Reporter: Artem Morozov Assignee: Andrea Del Bene Labels: autocomplete, autocompletetextfield Attachments: autocompleteScenario.zip There is a situation when wicket-autocomplete popup is not removed after search is performed. See simple project attached. This case is a combination of RepeatingView + Wicket autocomplete. Please, consider to add an option, to hide this popup after a form is submitted. Ho to reproduce: * open and run attached project * type any string and press Enter * type any string and press Enter Result - there are several popups displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (WICKET-5965) Queuing a component in head
[ https://issues.apache.org/jira/browse/WICKET-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-5965: --- Assignee: Andrea Del Bene Queuing a component in head --- Key: WICKET-5965 URL: https://issues.apache.org/jira/browse/WICKET-5965 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0 Reporter: Palancher aurélien Assignee: Andrea Del Bene Attachments: WicketQuickstart2.war Queuing a component which is in the head section doesn't work : head meta charset=utf-8 / title wicket:id=titreTest/title /head -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (WICKET-5962) Queuing : test existance of components in markup
[ https://issues.apache.org/jira/browse/WICKET-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-5962: --- Assignee: Andrea Del Bene Queuing : test existance of components in markup Key: WICKET-5962 URL: https://issues.apache.org/jira/browse/WICKET-5962 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0 Reporter: Palancher aurélien Assignee: Andrea Del Bene Priority: Minor In my Web Application, i can have many html files associated to one component Java class. eg CompTest.java and CompTest.html, CompTest_1.html. Each of html files contains all or only a part of the wicket components queued in the Java class. In the 7.0.0 version, it seems that this case doesn't work (or i may be wrong ?) It would be great to have the possibility to queue a component even if the markup doesn't contain it. My 6.x Wicket application works fine this way. Simple example : a cart component (cart.html) that can show many details before validating, or the same Java class with a cart_1.html which is the minified version you can see on the top of the site. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (WICKET-5964) Queuing a component within an enclosure
[ https://issues.apache.org/jira/browse/WICKET-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-5964: --- Assignee: Andrea Del Bene Queuing a component within an enclosure --- Key: WICKET-5964 URL: https://issues.apache.org/jira/browse/WICKET-5964 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0 Reporter: Palancher aurélien Assignee: Andrea Del Bene Attachments: WicketQuickstartFix.war Queueing doesn't work if component is in a enclosure tag. wicket:enclosure child=inlink a href=panier.html span wicket:id=inlink/span /a /wicket:enclosure -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5964) Queuing a component within an enclosure
[ https://issues.apache.org/jira/browse/WICKET-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5964: Fix Version/s: 7.1.0 Queuing a component within an enclosure --- Key: WICKET-5964 URL: https://issues.apache.org/jira/browse/WICKET-5964 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0 Reporter: Palancher aurélien Assignee: Andrea Del Bene Fix For: 7.1.0 Attachments: WicketQuickstartFix.war Queueing doesn't work if component is in a enclosure tag. wicket:enclosure child=inlink a href=panier.html span wicket:id=inlink/span /a /wicket:enclosure -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (WICKET-5954) Broken links in new site
[ https://issues.apache.org/jira/browse/WICKET-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-5954. --- Resolution: Fixed I couldn't regenerate the API docs for 1.3, but the rest of the links are ok now. Broken links in new site Key: WICKET-5954 URL: https://issues.apache.org/jira/browse/WICKET-5954 Project: Wicket Issue Type: Bug Components: site Reporter: Filipe Roque Assignee: Andrea Del Bene Priority: Minor there seems to be a lot of broken links in the new site, as reported by http://www.deadlinkchecker.com/website-dead-link-checker.asp : ||Error||URL||Anchor Text||Linked From|| |404|http://archive.apache.org/dist/wicket/6.20.0/CHANG ELOG-6.x|change log|http://wicket.apache.org/start/download.html |404|http://stackoverflow.com/questions/wicket|stackoverflow|http://wicket.apache.org/help/ |404|http://oodt.apache.org/components/maven/webapp/filemgr/|CAS File Manager|http://wicket.apache.org/apache/ |404|http://oodt.apache.org/components/maven/webapp/workflow/|CAS Workflow monitor|http://wicket.apache.org/apache/ |-1 Not found: The server returned an invalid or unrecognized response|http://wicket.apache.org/news/2011/04/02/wicket-1.4.17-released.html|more|http://wicket.apache.org/news/ |-1 Not found: The server returned an invalid or unrecognized response|http://wicket.apache.org/news/2011/03/25/wicket-cookbook-published.html|more|http://wicket.apache.org/news/ |404|http://mail-archives.apache.org/mod_mbox/wicket-user|Browse|http://wicket.apache.org/help/email.html |404|https://ci.apache.org/projects/wicket/apidocs/1.5.x/index.html|Redirected 301 (JavaDoc 1.5.x http://wicket.apache.org/learn/)|http://ci.apache.org/projects/wicket/apidocs/1.5.x/index.html |404|https://ci.apache.org/projects/wicket/apidocs/1.4.x/index.html|Redirected 301 (JavaDoc 1.4.x http://wicket.apache.org/learn/)|http://ci.apache.org/projects/wicket/apidocs/1.4.x/index.html |404|https://ci.apache.org/projects/wicket/apidocs/1.3.x/index.html|Redirected 301 (JavaDoc 1.3.x http://wicket.apache.org/learn/)|http://ci.apache.org/projects/wicket/apidocs/1.3.x/index.html |404|http://wicket.apache.org/2014/09/15/wicket-1.5.12-released.html|Apache Wicket 1.5.12|http://wicket.apache.org/news/2014/09/22/cve-2014-3526.html |404|http://wicket.apache.org/2014/08/24/wicket-6.17.0-released.html|Apache Wicket 6.17.0|http://wicket.apache.org/news/2014/09/22/cve-2014-3526.html |-1 Not found: The server returned an invalid or unrecognized response|http://wicket.apache.org/2014/08/23/wicket-7.0.0-M3-released.html|Apache Wicket 7.0.0-M3|http://wicket.apache.org/news/2014/09/22/cve-2014-3526.html |404|http://wicket.apache.org/2014/02/21/cve-2014-0043.html|CVE-2014-0043|http://wicket.apache.org/news/2014/02/20/wicket-6.14.0-released.html |404|http://wicket.apache.org/2014/02/06/wicket-1.5.11-released.html|Apache Wicket 1.5.11|http://wicket.apache.org/news/2014/02/21/cve-2014-0043.html |404|http://wicket.apache.org/2014/02/20/wicket-6.14.0-released.html|Apache Wicket 6.14.0|http://wicket.apache.org/news/2014/02/21/cve-2014-0043.html |404|http://wicket.apache.org/2014/02/06/cve-2013-2055.html|CVE-2013-2055|http://wicket.apache.org/news/2014/02/06/wicket-1.4.23-released.html |404|http://wicket.apache.org/2014/02/06/wicket-1.4.23-released.html|Apache Wicket 1.4.23|http://wicket.apache.org/news/2014/02/06/cve-2013-2055.html |404|http://wicket.apache.org/2013/05/17/wicket-6.8.0-released.html|Apache Wicket 6.8.0|http://wicket.apache.org/news/2014/02/06/cve-2013-2055.html |404|http://wicket.apache.org/start/userguide.html|âUser guideâ|http://wicket.apache.org/news/2014/01/05/wicket-6.13.0-released.html |404|https://wicket.apache.org/2012/12/14/wicket-6.4.0-released.html|Apache Wicket 6.4.0|http://wicket.apache.org/news/2013/03/03/cve-2012-5636.html |404|https://wicket.apache.org/2013/02/26/wicket-1.5.10-released.html|Apache Wicket 1.5.10|http://wicket.apache.org/news/2013/03/03/cve-2012-5636.html |404|http://wicket.apache.org/news/2012/12/14/WICKET-4880|WICKET-4880|http://wicket.apache.org/news/2012/12/14/wicket-6.4.0-released.html |404|https://wicket.apache.org/2012/09/05/wicket-1.4.21-released.html|Apache Wicket 1.4.21|http://wicket.apache.org/news/2012/09/06/cve-2012-3373.html |404|https://wicket.apache.org/2012/08/24/wicket-1.5.8-released.html|Apache Wicket 1.5.8|http://wicket.apache.org/news/2012/09/06/cve-2012-3373.html |404|https://wicket.apache.org/2012/09/05/wicket-6.0.0-released.html|Apache Wicket 6.0.0|http://wicket.apache.org/news/2012/09/06/cve-2012-3373.html |404|http://wicket.apache.org/2012/03/12/wicket-1.4.20-released.html|Apache Wicket 1.4.20|http://wicket.apache.org/news/2012/03/22/wicket-cve-2012-0047.html
[jira] [Assigned] (WICKET-5882) AutoComplete suggestion list disappear when I click on autoComplete scrollbar in IE
[ https://issues.apache.org/jira/browse/WICKET-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-5882: --- Assignee: Andrea Del Bene AutoComplete suggestion list disappear when I click on autoComplete scrollbar in IE --- Key: WICKET-5882 URL: https://issues.apache.org/jira/browse/WICKET-5882 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 6.19.0 Environment: operating system : 64-bit, Windows 7 Professional. Reporter: ramesh valasa Assignee: Andrea Del Bene Attachments: autocomplete.zip, autocompleteScroll.png I am using Wicket's(version 6.19.0) AutoCompleteTextField in my application to a form component, when I type something I will get the suggestion list and we will get a horizontal scroll bar for the suggestion list. The problem is when I scroll to view the text suggestion list is disappearing. This happens in all IE browser versions IE8, IE9, IE10 and IE11. I have attached the image to show suggestion list with scroll bar. and also the example zip file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (WICKET-5954) Broken links in new site
[ https://issues.apache.org/jira/browse/WICKET-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-5954: --- Assignee: Andrea Del Bene Broken links in new site Key: WICKET-5954 URL: https://issues.apache.org/jira/browse/WICKET-5954 Project: Wicket Issue Type: Bug Components: site Reporter: Filipe Roque Assignee: Andrea Del Bene Priority: Minor there seems to be a lot of broken links in the new site, as reported by http://www.deadlinkchecker.com/website-dead-link-checker.asp : ||Error||URL||Anchor Text||Linked From|| |404|http://archive.apache.org/dist/wicket/6.20.0/CHANG ELOG-6.x|change log|http://wicket.apache.org/start/download.html |404|http://stackoverflow.com/questions/wicket|stackoverflow|http://wicket.apache.org/help/ |404|http://oodt.apache.org/components/maven/webapp/filemgr/|CAS File Manager|http://wicket.apache.org/apache/ |404|http://oodt.apache.org/components/maven/webapp/workflow/|CAS Workflow monitor|http://wicket.apache.org/apache/ |-1 Not found: The server returned an invalid or unrecognized response|http://wicket.apache.org/news/2011/04/02/wicket-1.4.17-released.html|more|http://wicket.apache.org/news/ |-1 Not found: The server returned an invalid or unrecognized response|http://wicket.apache.org/news/2011/03/25/wicket-cookbook-published.html|more|http://wicket.apache.org/news/ |404|http://mail-archives.apache.org/mod_mbox/wicket-user|Browse|http://wicket.apache.org/help/email.html |404|https://ci.apache.org/projects/wicket/apidocs/1.5.x/index.html|Redirected 301 (JavaDoc 1.5.x http://wicket.apache.org/learn/)|http://ci.apache.org/projects/wicket/apidocs/1.5.x/index.html |404|https://ci.apache.org/projects/wicket/apidocs/1.4.x/index.html|Redirected 301 (JavaDoc 1.4.x http://wicket.apache.org/learn/)|http://ci.apache.org/projects/wicket/apidocs/1.4.x/index.html |404|https://ci.apache.org/projects/wicket/apidocs/1.3.x/index.html|Redirected 301 (JavaDoc 1.3.x http://wicket.apache.org/learn/)|http://ci.apache.org/projects/wicket/apidocs/1.3.x/index.html |404|http://wicket.apache.org/2014/09/15/wicket-1.5.12-released.html|Apache Wicket 1.5.12|http://wicket.apache.org/news/2014/09/22/cve-2014-3526.html |404|http://wicket.apache.org/2014/08/24/wicket-6.17.0-released.html|Apache Wicket 6.17.0|http://wicket.apache.org/news/2014/09/22/cve-2014-3526.html |-1 Not found: The server returned an invalid or unrecognized response|http://wicket.apache.org/2014/08/23/wicket-7.0.0-M3-released.html|Apache Wicket 7.0.0-M3|http://wicket.apache.org/news/2014/09/22/cve-2014-3526.html |404|http://wicket.apache.org/2014/02/21/cve-2014-0043.html|CVE-2014-0043|http://wicket.apache.org/news/2014/02/20/wicket-6.14.0-released.html |404|http://wicket.apache.org/2014/02/06/wicket-1.5.11-released.html|Apache Wicket 1.5.11|http://wicket.apache.org/news/2014/02/21/cve-2014-0043.html |404|http://wicket.apache.org/2014/02/20/wicket-6.14.0-released.html|Apache Wicket 6.14.0|http://wicket.apache.org/news/2014/02/21/cve-2014-0043.html |404|http://wicket.apache.org/2014/02/06/cve-2013-2055.html|CVE-2013-2055|http://wicket.apache.org/news/2014/02/06/wicket-1.4.23-released.html |404|http://wicket.apache.org/2014/02/06/wicket-1.4.23-released.html|Apache Wicket 1.4.23|http://wicket.apache.org/news/2014/02/06/cve-2013-2055.html |404|http://wicket.apache.org/2013/05/17/wicket-6.8.0-released.html|Apache Wicket 6.8.0|http://wicket.apache.org/news/2014/02/06/cve-2013-2055.html |404|http://wicket.apache.org/start/userguide.html|âUser guideâ|http://wicket.apache.org/news/2014/01/05/wicket-6.13.0-released.html |404|https://wicket.apache.org/2012/12/14/wicket-6.4.0-released.html|Apache Wicket 6.4.0|http://wicket.apache.org/news/2013/03/03/cve-2012-5636.html |404|https://wicket.apache.org/2013/02/26/wicket-1.5.10-released.html|Apache Wicket 1.5.10|http://wicket.apache.org/news/2013/03/03/cve-2012-5636.html |404|http://wicket.apache.org/news/2012/12/14/WICKET-4880|WICKET-4880|http://wicket.apache.org/news/2012/12/14/wicket-6.4.0-released.html |404|https://wicket.apache.org/2012/09/05/wicket-1.4.21-released.html|Apache Wicket 1.4.21|http://wicket.apache.org/news/2012/09/06/cve-2012-3373.html |404|https://wicket.apache.org/2012/08/24/wicket-1.5.8-released.html|Apache Wicket 1.5.8|http://wicket.apache.org/news/2012/09/06/cve-2012-3373.html |404|https://wicket.apache.org/2012/09/05/wicket-6.0.0-released.html|Apache Wicket 6.0.0|http://wicket.apache.org/news/2012/09/06/cve-2012-3373.html |404|http://wicket.apache.org/2012/03/12/wicket-1.4.20-released.html|Apache Wicket 1.4.20|http://wicket.apache.org/news/2012/03/22/wicket-cve-2012-0047.html |404|http://wicket.apache.org/2012/03/12/wicket-1.5.5-released.html|Apache Wicket
[jira] [Updated] (WICKET-5941) Headers not rendered for components inside TransparentWebMarkupContainer on ajax update
[ https://issues.apache.org/jira/browse/WICKET-5941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5941: Fix Version/s: 7.1.0 Headers not rendered for components inside TransparentWebMarkupContainer on ajax update --- Key: WICKET-5941 URL: https://issues.apache.org/jira/browse/WICKET-5941 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Emond Papegaaij Assignee: Andrea Del Bene Fix For: 6.21.0, 7.1.0 Attachments: refreshhead.tar.gz When a TransparentWebMarkupContainer is refreshed using ajax, components inside it do not render headers. The attached quickstart shows this problem. The AjaxLink only works once. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5941) Headers not rendered for components inside TransparentWebMarkupContainer on ajax update
[ https://issues.apache.org/jira/browse/WICKET-5941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626955#comment-14626955 ] Andrea Del Bene commented on WICKET-5941: - I haven't seen 7.1.0. Now it's set to this version, than you. Headers not rendered for components inside TransparentWebMarkupContainer on ajax update --- Key: WICKET-5941 URL: https://issues.apache.org/jira/browse/WICKET-5941 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Emond Papegaaij Assignee: Andrea Del Bene Fix For: 6.21.0, 7.1.0 Attachments: refreshhead.tar.gz When a TransparentWebMarkupContainer is refreshed using ajax, components inside it do not render headers. The attached quickstart shows this problem. The AjaxLink only works once. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5941) Headers not rendered for components inside TransparentWebMarkupContainer on ajax update
[ https://issues.apache.org/jira/browse/WICKET-5941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5941: Fix Version/s: 6.21.0 Headers not rendered for components inside TransparentWebMarkupContainer on ajax update --- Key: WICKET-5941 URL: https://issues.apache.org/jira/browse/WICKET-5941 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Emond Papegaaij Assignee: Andrea Del Bene Fix For: 6.21.0 Attachments: refreshhead.tar.gz When a TransparentWebMarkupContainer is refreshed using ajax, components inside it do not render headers. The attached quickstart shows this problem. The AjaxLink only works once. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-5941) Headers not rendered for components inside TransparentWebMarkupContainer on ajax update
[ https://issues.apache.org/jira/browse/WICKET-5941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene resolved WICKET-5941. - Resolution: Fixed Headers not rendered for components inside TransparentWebMarkupContainer on ajax update --- Key: WICKET-5941 URL: https://issues.apache.org/jira/browse/WICKET-5941 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Emond Papegaaij Assignee: Andrea Del Bene Fix For: 6.21.0 Attachments: refreshhead.tar.gz When a TransparentWebMarkupContainer is refreshed using ajax, components inside it do not render headers. The attached quickstart shows this problem. The AjaxLink only works once. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5882) AutoComplete suggestion list disappear when I click on autoComplete scrollbar in IE
[ https://issues.apache.org/jira/browse/WICKET-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5882: Affects Version/s: 7.0.0-M6 AutoComplete suggestion list disappear when I click on autoComplete scrollbar in IE --- Key: WICKET-5882 URL: https://issues.apache.org/jira/browse/WICKET-5882 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 6.19.0, 7.0.0-M6 Environment: operating system : 64-bit, Windows 7 Professional. Reporter: ramesh valasa Assignee: Andrea Del Bene Fix For: 6.21.0, 7.1.0 Attachments: autocomplete.zip, autocompleteScroll.png I am using Wicket's(version 6.19.0) AutoCompleteTextField in my application to a form component, when I type something I will get the suggestion list and we will get a horizontal scroll bar for the suggestion list. The problem is when I scroll to view the text suggestion list is disappearing. This happens in all IE browser versions IE8, IE9, IE10 and IE11. I have attached the image to show suggestion list with scroll bar. and also the example zip file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5882) AutoComplete suggestion list disappear when I click on autoComplete scrollbar in IE
[ https://issues.apache.org/jira/browse/WICKET-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5882: Fix Version/s: 7.1.0 6.21.0 AutoComplete suggestion list disappear when I click on autoComplete scrollbar in IE --- Key: WICKET-5882 URL: https://issues.apache.org/jira/browse/WICKET-5882 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 6.19.0, 7.0.0-M6 Environment: operating system : 64-bit, Windows 7 Professional. Reporter: ramesh valasa Assignee: Andrea Del Bene Fix For: 6.21.0, 7.1.0 Attachments: autocomplete.zip, autocompleteScroll.png I am using Wicket's(version 6.19.0) AutoCompleteTextField in my application to a form component, when I type something I will get the suggestion list and we will get a horizontal scroll bar for the suggestion list. The problem is when I scroll to view the text suggestion list is disappearing. This happens in all IE browser versions IE8, IE9, IE10 and IE11. I have attached the image to show suggestion list with scroll bar. and also the example zip file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-5882) AutoComplete suggestion list disappear when I click on autoComplete scrollbar in IE
[ https://issues.apache.org/jira/browse/WICKET-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene resolved WICKET-5882. - Resolution: Fixed AutoComplete suggestion list disappear when I click on autoComplete scrollbar in IE --- Key: WICKET-5882 URL: https://issues.apache.org/jira/browse/WICKET-5882 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 6.19.0, 7.0.0-M6 Environment: operating system : 64-bit, Windows 7 Professional. Reporter: ramesh valasa Assignee: Andrea Del Bene Fix For: 6.21.0, 7.1.0 Attachments: autocomplete.zip, autocompleteScroll.png I am using Wicket's(version 6.19.0) AutoCompleteTextField in my application to a form component, when I type something I will get the suggestion list and we will get a horizontal scroll bar for the suggestion list. The problem is when I scroll to view the text suggestion list is disappearing. This happens in all IE browser versions IE8, IE9, IE10 and IE11. I have attached the image to show suggestion list with scroll bar. and also the example zip file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (WICKET-5962) Queuing : test existance of components in markup
[ https://issues.apache.org/jira/browse/WICKET-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-5962. --- Resolution: Duplicate > Queuing : test existance of components in markup > > > Key: WICKET-5962 > URL: https://issues.apache.org/jira/browse/WICKET-5962 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene >Priority: Minor > > In my Web Application, i can have many html files associated to one component > Java class. eg CompTest.java and CompTest.html, CompTest_1.html. > Each of html files contains all or only a part of the wicket components > queued in the Java class. > In the 7.0.0 version, it seems that this case doesn't work (or i may be wrong > ?) It would be great to have the possibility to queue a component even if the > markup doesn't contain it. > My 6.x Wicket application works fine this way. > Simple example : a cart component (cart.html) that can show many details > before validating, or the same Java class with a cart_1.html which is the > minified version you can see on the top of the site. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6028) Detach called on enclosure component while it had a non-empty queue
[ https://issues.apache.org/jira/browse/WICKET-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6028: Attachment: myproject.zip > Detach called on enclosure component while it had a non-empty queue > --- > > Key: WICKET-6028 > URL: https://issues.apache.org/jira/browse/WICKET-6028 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Attachments: BasePage.html, BasePage.java, EnclosurePage.html, > EnclosurePage.java, myproject.zip, stacktrace.txt > > > In the attached example EnclosurePage is extended from BasePage. In BasePage > there is a TransparentWebmarkupContainer attached to > The page is rendered, but a stacktrace "Error detaching RequestHandler" is > logged (see stacktrace.txt). > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (WICKET-6029) Make Border's methods consistent with commit f14e03f
[ https://issues.apache.org/jira/browse/WICKET-6029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-6029. --- Resolution: Fixed Fix Version/s: 8.0.0-M1 7.2.0 > Make Border's methods consistent with commit f14e03f > > > Key: WICKET-6029 > URL: https://issues.apache.org/jira/browse/WICKET-6029 > Project: Wicket > Issue Type: Improvement >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > > The commit in the summary > (https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=f14e03f) requires the > other container methods of Border to be changed in order to be consistent > with #add(Component... children) method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6024) Possible issue with Border and LoadableDetachableModel in 7.1.0
[ https://issues.apache.org/jira/browse/WICKET-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6024: Fix Version/s: 8.0.0-M1 7.2.0 > Possible issue with Border and LoadableDetachableModel in 7.1.0 > --- > > Key: WICKET-6024 > URL: https://issues.apache.org/jira/browse/WICKET-6024 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Lieven Poelman >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > > I have encountered an issue with Border objects and LoadableDetachableModels > in wicket 7.1.0. This issue does NOT occurr in 7.0.0. > The issue is the following: > - When wrapping a FormComponent in a Border object, everything works as it > should > - However for each FormComponent per Border in the Page/Parent component, the > detach/load is called once. > - This causes a load call on the LoadableDetachableModel per component on the > page, for 20 input fields this causes 20 loads! > It seems the Border's remove function is called twice. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6027) Nested TransparentWebMarkupContainer, markup of inner component not found
[ https://issues.apache.org/jira/browse/WICKET-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005454#comment-15005454 ] Andrea Del Bene commented on WICKET-6027: - I've finished to work to a fix. Still have to add JavaDocs and a unit test. > Nested TransparentWebMarkupContainer, markup of inner component not found > - > > Key: WICKET-6027 > URL: https://issues.apache.org/jira/browse/WICKET-6027 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Attachments: MarkupNotFoundPage.html, MarkupNotFoundPage.java > > > In the attached example page a FeedbackPanel should be rendered on > AJAX-Request by pressing an AjaxButton. If you submit the form with empty > input in TextField 'username" you get a MarkupNotFoundError for the > FeedbackPanel: > "org.apache.wicket.markup.MarkupNotFoundException: Markup not found for > Component: [FeedbackPanel [Component id = feedback]] > at org.apache.wicket.Component.internalRender(Component.java:2348) > at org.apache.wicket.Component.render(Component.java:2308) > at > org.apache.wicket.page.XmlPartialPageUpdate.writeComponent(XmlPartialPageUpdate.java:119) > at > org.apache.wicket.page.PartialPageUpdate.writeComponents(PartialPageUpdate.java:245)" > The MarkupNotFoundError is associated to the two > TransparentWebMarkupContainer's in the page. If you remove one of them for > example, the problem is gone. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6027) Nested TransparentWebMarkupContainer, markup of inner component not found
[ https://issues.apache.org/jira/browse/WICKET-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005435#comment-15005435 ] Andrea Del Bene commented on WICKET-6027: - Right. That's why 6.x is not affected. > Nested TransparentWebMarkupContainer, markup of inner component not found > - > > Key: WICKET-6027 > URL: https://issues.apache.org/jira/browse/WICKET-6027 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Attachments: MarkupNotFoundPage.html, MarkupNotFoundPage.java > > > In the attached example page a FeedbackPanel should be rendered on > AJAX-Request by pressing an AjaxButton. If you submit the form with empty > input in TextField 'username" you get a MarkupNotFoundError for the > FeedbackPanel: > "org.apache.wicket.markup.MarkupNotFoundException: Markup not found for > Component: [FeedbackPanel [Component id = feedback]] > at org.apache.wicket.Component.internalRender(Component.java:2348) > at org.apache.wicket.Component.render(Component.java:2308) > at > org.apache.wicket.page.XmlPartialPageUpdate.writeComponent(XmlPartialPageUpdate.java:119) > at > org.apache.wicket.page.PartialPageUpdate.writeComponents(PartialPageUpdate.java:245)" > The MarkupNotFoundError is associated to the two > TransparentWebMarkupContainer's in the page. If you remove one of them for > example, the problem is gone. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene resolved WICKET-6001. - Resolution: Fixed > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6001: Fix Version/s: 8.0.0-M1 7.2.0 > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6027) Nested TransparentWebMarkupContainer, markup of inner component not found
[ https://issues.apache.org/jira/browse/WICKET-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6027: Fix Version/s: 8.0.0-M1 7.2.0 > Nested TransparentWebMarkupContainer, markup of inner component not found > - > > Key: WICKET-6027 > URL: https://issues.apache.org/jira/browse/WICKET-6027 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > Attachments: MarkupNotFoundPage.html, MarkupNotFoundPage.java > > > In the attached example page a FeedbackPanel should be rendered on > AJAX-Request by pressing an AjaxButton. If you submit the form with empty > input in TextField 'username" you get a MarkupNotFoundError for the > FeedbackPanel: > "org.apache.wicket.markup.MarkupNotFoundException: Markup not found for > Component: [FeedbackPanel [Component id = feedback]] > at org.apache.wicket.Component.internalRender(Component.java:2348) > at org.apache.wicket.Component.render(Component.java:2308) > at > org.apache.wicket.page.XmlPartialPageUpdate.writeComponent(XmlPartialPageUpdate.java:119) > at > org.apache.wicket.page.PartialPageUpdate.writeComponents(PartialPageUpdate.java:245)" > The MarkupNotFoundError is associated to the two > TransparentWebMarkupContainer's in the page. If you remove one of them for > example, the problem is gone. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-6027) Nested TransparentWebMarkupContainer, markup of inner component not found
[ https://issues.apache.org/jira/browse/WICKET-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene resolved WICKET-6027. - Resolution: Fixed > Nested TransparentWebMarkupContainer, markup of inner component not found > - > > Key: WICKET-6027 > URL: https://issues.apache.org/jira/browse/WICKET-6027 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > Attachments: MarkupNotFoundPage.html, MarkupNotFoundPage.java > > > In the attached example page a FeedbackPanel should be rendered on > AJAX-Request by pressing an AjaxButton. If you submit the form with empty > input in TextField 'username" you get a MarkupNotFoundError for the > FeedbackPanel: > "org.apache.wicket.markup.MarkupNotFoundException: Markup not found for > Component: [FeedbackPanel [Component id = feedback]] > at org.apache.wicket.Component.internalRender(Component.java:2348) > at org.apache.wicket.Component.render(Component.java:2308) > at > org.apache.wicket.page.XmlPartialPageUpdate.writeComponent(XmlPartialPageUpdate.java:119) > at > org.apache.wicket.page.PartialPageUpdate.writeComponents(PartialPageUpdate.java:245)" > The MarkupNotFoundError is associated to the two > TransparentWebMarkupContainer's in the page. If you remove one of them for > example, the problem is gone. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (WICKET-6024) Possible issue with Border and LoadableDetachableModel in 7.1.0
[ https://issues.apache.org/jira/browse/WICKET-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-6024. --- Resolution: Fixed > Possible issue with Border and LoadableDetachableModel in 7.1.0 > --- > > Key: WICKET-6024 > URL: https://issues.apache.org/jira/browse/WICKET-6024 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Lieven Poelman >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > > I have encountered an issue with Border objects and LoadableDetachableModels > in wicket 7.1.0. This issue does NOT occurr in 7.0.0. > The issue is the following: > - When wrapping a FormComponent in a Border object, everything works as it > should > - However for each FormComponent per Border in the Page/Parent component, the > detach/load is called once. > - This causes a load call on the LoadableDetachableModel per component on the > page, for 20 input fields this causes 20 loads! > It seems the Border's remove function is called twice. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (WICKET-6027) Nested TransparentWebMarkupContainer, markup of inner component not found
[ https://issues.apache.org/jira/browse/WICKET-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-6027: --- Assignee: Andrea Del Bene > Nested TransparentWebMarkupContainer, markup of inner component not found > - > > Key: WICKET-6027 > URL: https://issues.apache.org/jira/browse/WICKET-6027 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Attachments: MarkupNotFoundPage.html, MarkupNotFoundPage.java > > > In the attached example page a FeedbackPanel should be rendered on > AJAX-Request by pressing an AjaxButton. If you submit the form with empty > input in TextField 'username" you get a MarkupNotFoundError for the > FeedbackPanel: > "org.apache.wicket.markup.MarkupNotFoundException: Markup not found for > Component: [FeedbackPanel [Component id = feedback]] > at org.apache.wicket.Component.internalRender(Component.java:2348) > at org.apache.wicket.Component.render(Component.java:2308) > at > org.apache.wicket.page.XmlPartialPageUpdate.writeComponent(XmlPartialPageUpdate.java:119) > at > org.apache.wicket.page.PartialPageUpdate.writeComponents(PartialPageUpdate.java:245)" > The MarkupNotFoundError is associated to the two > TransparentWebMarkupContainer's in the page. If you remove one of them for > example, the problem is gone. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6028) Detach called on enclosure component while it had a non-empty queue
[ https://issues.apache.org/jira/browse/WICKET-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6028: Attachment: WICKET-6028.patch > Detach called on enclosure component while it had a non-empty queue > --- > > Key: WICKET-6028 > URL: https://issues.apache.org/jira/browse/WICKET-6028 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Attachments: BasePage.html, BasePage.java, EnclosurePage.html, > EnclosurePage.java, WICKET-6028.patch, myproject.zip, stacktrace.txt > > > In the attached example EnclosurePage is extended from BasePage. In BasePage > there is a TransparentWebmarkupContainer attached to > The page is rendered, but a stacktrace "Error detaching RequestHandler" is > logged (see stacktrace.txt). > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6028) Detach called on enclosure component while it had a non-empty queue
[ https://issues.apache.org/jira/browse/WICKET-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6028: Attachment: (was: myproject.zip) > Detach called on enclosure component while it had a non-empty queue > --- > > Key: WICKET-6028 > URL: https://issues.apache.org/jira/browse/WICKET-6028 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Attachments: BasePage.html, BasePage.java, EnclosurePage.html, > EnclosurePage.java, WICKET-6028.patch, myproject.tar.gz, stacktrace.txt > > > In the attached example EnclosurePage is extended from BasePage. In BasePage > there is a TransparentWebmarkupContainer attached to > The page is rendered, but a stacktrace "Error detaching RequestHandler" is > logged (see stacktrace.txt). > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6028) Detach called on enclosure component while it had a non-empty queue
[ https://issues.apache.org/jira/browse/WICKET-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6028: Attachment: myproject.tar.gz > Detach called on enclosure component while it had a non-empty queue > --- > > Key: WICKET-6028 > URL: https://issues.apache.org/jira/browse/WICKET-6028 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Attachments: BasePage.html, BasePage.java, EnclosurePage.html, > EnclosurePage.java, WICKET-6028.patch, myproject.tar.gz, stacktrace.txt > > > In the attached example EnclosurePage is extended from BasePage. In BasePage > there is a TransparentWebmarkupContainer attached to > The page is rendered, but a stacktrace "Error detaching RequestHandler" is > logged (see stacktrace.txt). > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6029) Make Border's methods consistent with commit f14e03f
Andrea Del Bene created WICKET-6029: --- Summary: Make Border's methods consistent with commit f14e03f Key: WICKET-6029 URL: https://issues.apache.org/jira/browse/WICKET-6029 Project: Wicket Issue Type: Improvement Reporter: Andrea Del Bene Assignee: Andrea Del Bene The commit in the summary (https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=f14e03f) requires the other container methods of Border to be changed in order to be consistent with #add(Components...) method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6029) Make Border's methods consistent with commit f14e03f
[ https://issues.apache.org/jira/browse/WICKET-6029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6029: Description: The commit in the summary (https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=f14e03f) requires the other container methods of Border to be changed in order to be consistent with #add(Component... children) method. (was: The commit in the summary (https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=f14e03f) requires the other container methods of Border to be changed in order to be consistent with #add(Components...) method.) > Make Border's methods consistent with commit f14e03f > > > Key: WICKET-6029 > URL: https://issues.apache.org/jira/browse/WICKET-6029 > Project: Wicket > Issue Type: Improvement >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > > The commit in the summary > (https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=f14e03f) requires the > other container methods of Border to be changed in order to be consistent > with #add(Component... children) method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6018) TransparentWebMarkupContainer is not really "transparent"
[ https://issues.apache.org/jira/browse/WICKET-6018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6018: Fix Version/s: 8.0.0-M1 > TransparentWebMarkupContainer is not really "transparent" > - > > Key: WICKET-6018 > URL: https://issues.apache.org/jira/browse/WICKET-6018 > Project: Wicket > Issue Type: Bug >Affects Versions: 7.1.0 >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > Attachments: myproject.zip > > > TransparentWebMarkupContainer is not really "transparent" in component > hierarchy. See quickstart -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6018) TransparentWebMarkupContainer is not really "transparent"
[ https://issues.apache.org/jira/browse/WICKET-6018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6018: Attachment: myproject.zip > TransparentWebMarkupContainer is not really "transparent" > - > > Key: WICKET-6018 > URL: https://issues.apache.org/jira/browse/WICKET-6018 > Project: Wicket > Issue Type: Bug >Affects Versions: 7.1.0 >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > Fix For: 7.2.0 > > Attachments: myproject.zip > > > TransparentWebMarkupContainer is not really "transparent" in component > hierarchy. See quickstart -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6018) TransparentWebMarkupContainer is not really "transparent"
Andrea Del Bene created WICKET-6018: --- Summary: TransparentWebMarkupContainer is not really "transparent" Key: WICKET-6018 URL: https://issues.apache.org/jira/browse/WICKET-6018 Project: Wicket Issue Type: Bug Affects Versions: 7.1.0 Reporter: Andrea Del Bene Assignee: Andrea Del Bene Fix For: 7.2.0 TransparentWebMarkupContainer is not really "transparent" in component hierarchy. See quickstart -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6014) TransparentWebMarkupContainer breaks OnChangeAjaxBehavior for Select2
[ https://issues.apache.org/jira/browse/WICKET-6014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984537#comment-14984537 ] Andrea Del Bene commented on WICKET-6014: - [~tahitiangabriel] I will open a new issue to track your specific problem. > TransparentWebMarkupContainer breaks OnChangeAjaxBehavior for Select2 > - > > Key: WICKET-6014 > URL: https://issues.apache.org/jira/browse/WICKET-6014 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 > Environment: Linux, Java 8, tomcat 7.54 >Reporter: Peter Henderson > Attachments: TransparentMarkupContainerBug.tar.gz, myproject.zip > > > A TransparentWebMarkupContainer which contains a Select2Choice control. > Select2Choice control has an OnChangeAjaxBehavior add. > Wicket 7.0.0 change events are processed correctly. > Wicket 7.1.0 change events are not processes correctly, a > ComponentNotFoundException is thrown. > Please excuse the quality of the Java in the quick start. It was converted > from Scala (with me cursing Java's verbosity) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6014) TransparentWebMarkupContainer breaks OnChangeAjaxBehavior for Select2
[ https://issues.apache.org/jira/browse/WICKET-6014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6014: Fix Version/s: 7.2.0 > TransparentWebMarkupContainer breaks OnChangeAjaxBehavior for Select2 > - > > Key: WICKET-6014 > URL: https://issues.apache.org/jira/browse/WICKET-6014 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 > Environment: Linux, Java 8, tomcat 7.54 >Reporter: Peter Henderson > Fix For: 7.2.0 > > Attachments: TransparentMarkupContainerBug.tar.gz, myproject.zip > > > A TransparentWebMarkupContainer which contains a Select2Choice control. > Select2Choice control has an OnChangeAjaxBehavior add. > Wicket 7.0.0 change events are processed correctly. > Wicket 7.1.0 change events are not processes correctly, a > ComponentNotFoundException is thrown. > Please excuse the quality of the Java in the quick start. It was converted > from Scala (with me cursing Java's verbosity) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-6014) TransparentWebMarkupContainer breaks OnChangeAjaxBehavior for Select2
[ https://issues.apache.org/jira/browse/WICKET-6014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene resolved WICKET-6014. - Resolution: Fixed > TransparentWebMarkupContainer breaks OnChangeAjaxBehavior for Select2 > - > > Key: WICKET-6014 > URL: https://issues.apache.org/jira/browse/WICKET-6014 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 > Environment: Linux, Java 8, tomcat 7.54 >Reporter: Peter Henderson > Fix For: 7.2.0 > > Attachments: TransparentMarkupContainerBug.tar.gz, myproject.zip > > > A TransparentWebMarkupContainer which contains a Select2Choice control. > Select2Choice control has an OnChangeAjaxBehavior add. > Wicket 7.0.0 change events are processed correctly. > Wicket 7.1.0 change events are not processes correctly, a > ComponentNotFoundException is thrown. > Please excuse the quality of the Java in the quick start. It was converted > from Scala (with me cursing Java's verbosity) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6014) TransparentWebMarkupContainer breaks OnChangeAjaxBehavior for Select2
[ https://issues.apache.org/jira/browse/WICKET-6014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982687#comment-14982687 ] Andrea Del Bene commented on WICKET-6014: - I solved the issue slightly changing the queueing algorithm (now MarkupContainer#dequeueChild propagates queueing also to IQueueRegionS). > TransparentWebMarkupContainer breaks OnChangeAjaxBehavior for Select2 > - > > Key: WICKET-6014 > URL: https://issues.apache.org/jira/browse/WICKET-6014 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 > Environment: Linux, Java 8, tomcat 7.54 >Reporter: Peter Henderson > Attachments: TransparentMarkupContainerBug.tar.gz > > > A TransparentWebMarkupContainer which contains a Select2Choice control. > Select2Choice control has an OnChangeAjaxBehavior add. > Wicket 7.0.0 change events are processed correctly. > Wicket 7.1.0 change events are not processes correctly, a > ComponentNotFoundException is thrown. > Please excuse the quality of the Java in the quick start. It was converted > from Scala (with me cursing Java's verbosity) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6014) TransparentWebMarkupContainer breaks OnChangeAjaxBehavior for Select2
[ https://issues.apache.org/jira/browse/WICKET-6014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982656#comment-14982656 ] Andrea Del Bene commented on WICKET-6014: - [~tahitiangabriel] Could you provide another quickstart showing your problem with transparent containers? I'm not 100% sure that the two problems are caused by the same change in the code. > TransparentWebMarkupContainer breaks OnChangeAjaxBehavior for Select2 > - > > Key: WICKET-6014 > URL: https://issues.apache.org/jira/browse/WICKET-6014 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 > Environment: Linux, Java 8, tomcat 7.54 >Reporter: Peter Henderson > Attachments: TransparentMarkupContainerBug.tar.gz > > > A TransparentWebMarkupContainer which contains a Select2Choice control. > Select2Choice control has an OnChangeAjaxBehavior add. > Wicket 7.0.0 change events are processed correctly. > Wicket 7.1.0 change events are not processes correctly, a > ComponentNotFoundException is thrown. > Please excuse the quality of the Java in the quick start. It was converted > from Scala (with me cursing Java's verbosity) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (WICKET-6026) Problem in detecting child id on nested
[ https://issues.apache.org/jira/browse/WICKET-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-6026: --- Assignee: Andrea Del Bene > Problem in detecting child id on nested > -- > > Key: WICKET-6026 > URL: https://issues.apache.org/jira/browse/WICKET-6026 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Fix For: 7.2.0 > > > If you nest as following > > Outer Enclosure > > Inner Enclosure > > > you get an error: > "You most likely forgot to register the EnclosureHandler with the > MarkupParserFactory > MarkupStream: [unknown] > at > org.apache.wicket.markup.html.internal.Enclosure.(Enclosure.java:112) > at > org.apache.wicket.markup.parser.filter.EnclosureHandler$1.newComponent(EnclosureHandler.java:62)" > The error occurs independent of the visibility of the enclosed components. > This markup works perfect in Wicket 6.20.0 > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6026) Problem in detecting child id on nested
[ https://issues.apache.org/jira/browse/WICKET-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6026: Fix Version/s: 7.2.0 > Problem in detecting child id on nested > -- > > Key: WICKET-6026 > URL: https://issues.apache.org/jira/browse/WICKET-6026 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther > Fix For: 7.2.0 > > > If you nest as following > > Outer Enclosure > > Inner Enclosure > > > you get an error: > "You most likely forgot to register the EnclosureHandler with the > MarkupParserFactory > MarkupStream: [unknown] > at > org.apache.wicket.markup.html.internal.Enclosure.(Enclosure.java:112) > at > org.apache.wicket.markup.parser.filter.EnclosureHandler$1.newComponent(EnclosureHandler.java:62)" > The error occurs independent of the visibility of the enclosed components. > This markup works perfect in Wicket 6.20.0 > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (WICKET-6023) small tweak for component queuing for the AbstractRepeater
[ https://issues.apache.org/jira/browse/WICKET-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-6023. --- Resolution: Not A Problem I will open a new issue with a qucikstart and a full description of the problem. > small tweak for component queuing for the AbstractRepeater > -- > > Key: WICKET-6023 > URL: https://issues.apache.org/jira/browse/WICKET-6023 > Project: Wicket > Issue Type: Improvement >Affects Versions: 7.1.0 >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6026) Problem in detecting child id on nested
[ https://issues.apache.org/jira/browse/WICKET-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6026: Fix Version/s: 8.0.0-M1 > Problem in detecting child id on nested > -- > > Key: WICKET-6026 > URL: https://issues.apache.org/jira/browse/WICKET-6026 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > > If you nest as following > > Outer Enclosure > > Inner Enclosure > > > you get an error: > "You most likely forgot to register the EnclosureHandler with the > MarkupParserFactory > MarkupStream: [unknown] > at > org.apache.wicket.markup.html.internal.Enclosure.(Enclosure.java:112) > at > org.apache.wicket.markup.parser.filter.EnclosureHandler$1.newComponent(EnclosureHandler.java:62)" > The error occurs independent of the visibility of the enclosed components. > This markup works perfect in Wicket 6.20.0 > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-6026) Problem in detecting child id on nested
[ https://issues.apache.org/jira/browse/WICKET-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene resolved WICKET-6026. - Resolution: Fixed > Problem in detecting child id on nested > -- > > Key: WICKET-6026 > URL: https://issues.apache.org/jira/browse/WICKET-6026 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > > If you nest as following > > Outer Enclosure > > Inner Enclosure > > > you get an error: > "You most likely forgot to register the EnclosureHandler with the > MarkupParserFactory > MarkupStream: [unknown] > at > org.apache.wicket.markup.html.internal.Enclosure.(Enclosure.java:112) > at > org.apache.wicket.markup.parser.filter.EnclosureHandler$1.newComponent(EnclosureHandler.java:62)" > The error occurs independent of the visibility of the enclosed components. > This markup works perfect in Wicket 6.20.0 > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995360#comment-14995360 ] Andrea Del Bene commented on WICKET-6001: - Well, I think the title of this issue is a little bit misleading. The problem is not about component queueing working bad. The really problem is that the exception is not re-throw and, as a result, it goes unnoticed by user. If the same exception (thrown by MarkupContainer#onDetach) occurs during rendering phase, it's correctly displayed to user. I just asked you if my proposed change could break something you did in your commit. > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995277#comment-14995277 ] Andrea Del Bene commented on WICKET-6001: - I see your war contains also source files so I could build a quickstart with them. A quickstart is much more helpful to spot an issue as we can see the code. [~mgrigorov] the problem is inside RequestHandlerStack#detach(). Every exception is caught and silently logged. I see you have changed the try/catch statement with this: https://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=a5954823353f20a6157156704ae91d6067a1f5c8 A possible solution for this current issue could be adding another catch block for RuntimeException: {code} try { detach(handler); } catch (RuntimeException exception) { throw exception; } catch (Exception exception) { log.error("Error detaching RequestHandler", exception); } {code} Could be this a problem in your opinion? > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (WICKET-6028) Detach called on enclosure component while it had a non-empty queue
[ https://issues.apache.org/jira/browse/WICKET-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-6028: --- Assignee: Andrea Del Bene > Detach called on enclosure component while it had a non-empty queue > --- > > Key: WICKET-6028 > URL: https://issues.apache.org/jira/browse/WICKET-6028 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Attachments: BasePage.html, BasePage.java, EnclosurePage.html, > EnclosurePage.java, stacktrace.txt > > > In the attached example EnclosurePage is extended from BasePage. In BasePage > there is a TransparentWebmarkupContainer attached to > The page is rendered, but a stacktrace "Error detaching RequestHandler" is > logged (see stacktrace.txt). > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-6001: --- Assignee: Andrea Del Bene > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988103#comment-14988103 ] Andrea Del Bene commented on WICKET-6001: - Hi, could you provide a quickstart (with source code) that reproduces the problem? > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6014) TransparentWebMarkupContainer breaks OnChangeAjaxBehavior for Select2
[ https://issues.apache.org/jira/browse/WICKET-6014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6014: Fix Version/s: 8.0.0-M1 > TransparentWebMarkupContainer breaks OnChangeAjaxBehavior for Select2 > - > > Key: WICKET-6014 > URL: https://issues.apache.org/jira/browse/WICKET-6014 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 > Environment: Linux, Java 8, tomcat 7.54 >Reporter: Peter Henderson > Fix For: 7.2.0, 8.0.0-M1 > > Attachments: TransparentMarkupContainerBug.tar.gz, myproject.zip > > > A TransparentWebMarkupContainer which contains a Select2Choice control. > Select2Choice control has an OnChangeAjaxBehavior add. > Wicket 7.0.0 change events are processed correctly. > Wicket 7.1.0 change events are not processes correctly, a > ComponentNotFoundException is thrown. > Please excuse the quality of the Java in the quick start. It was converted > from Scala (with me cursing Java's verbosity) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (WICKET-6023) small tweak for component queuing for the AbstractRepeater
[ https://issues.apache.org/jira/browse/WICKET-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-6023. --- Resolution: Fixed > small tweak for component queuing for the AbstractRepeater > -- > > Key: WICKET-6023 > URL: https://issues.apache.org/jira/browse/WICKET-6023 > Project: Wicket > Issue Type: Improvement >Affects Versions: 7.1.0 >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6023) small tweak for component queuing for the AbstractRepeater
Andrea Del Bene created WICKET-6023: --- Summary: small tweak for component queuing for the AbstractRepeater Key: WICKET-6023 URL: https://issues.apache.org/jira/browse/WICKET-6023 Project: Wicket Issue Type: Improvement Affects Versions: 7.1.0 Reporter: Andrea Del Bene Assignee: Andrea Del Bene Fix For: 7.2.0, 8.0.0-M1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (WICKET-6024) Possible issue with Border and LoadableDetachableModel in 7.1.0
[ https://issues.apache.org/jira/browse/WICKET-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-6024: --- Assignee: Andrea Del Bene > Possible issue with Border and LoadableDetachableModel in 7.1.0 > --- > > Key: WICKET-6024 > URL: https://issues.apache.org/jira/browse/WICKET-6024 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Lieven Poelman >Assignee: Andrea Del Bene > > I have encountered an issue with Border objects and LoadableDetachableModels > in wicket 7.1.0. This issue does NOT occurr in 7.0.0. > The issue is the following: > - When wrapping a FormComponent in a Border object, everything works as it > should > - However for each FormComponent per Border in the Page/Parent component, the > detach/load is called once. > - This causes a load call on the LoadableDetachableModel per component on the > page, for 20 input fields this causes 20 loads! > It seems the Border's remove function is called twice. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6024) Possible issue with Border and LoadableDetachableModel in 7.1.0
[ https://issues.apache.org/jira/browse/WICKET-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993825#comment-14993825 ] Andrea Del Bene commented on WICKET-6024: - Hi, could you provide a quickstart end/or try your app with snapshot version (7.2.0-SNAPSHOT)? We have done some fixing for borders since 7.1.0. > Possible issue with Border and LoadableDetachableModel in 7.1.0 > --- > > Key: WICKET-6024 > URL: https://issues.apache.org/jira/browse/WICKET-6024 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Lieven Poelman >Assignee: Andrea Del Bene > > I have encountered an issue with Border objects and LoadableDetachableModels > in wicket 7.1.0. This issue does NOT occurr in 7.0.0. > The issue is the following: > - When wrapping a FormComponent in a Border object, everything works as it > should > - However for each FormComponent per Border in the Page/Parent component, the > detach/load is called once. > - This causes a load call on the LoadableDetachableModel per component on the > page, for 20 input fields this causes 20 loads! > It seems the Border's remove function is called twice. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5947) AjaxPagingNavigationLink throws exception that Behavior is not enabled
[ https://issues.apache.org/jira/browse/WICKET-5947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620607#comment-14620607 ] Andrea Del Bene commented on WICKET-5947: - Yah sorry, too much sun. But I think I've discovered how to have e similar error with multiple tabs. I will try to provide more details. AjaxPagingNavigationLink throws exception that Behavior is not enabled -- Key: WICKET-5947 URL: https://issues.apache.org/jira/browse/WICKET-5947 Project: Wicket Issue Type: Bug Affects Versions: 7.0.0 Reporter: Martijn Dashorst Priority: Blocker When clicking on an AjaxPagingNavigationLink I get the exception below, based on wicket-7.0.0-SNAPSHOT from yesterday. {code} 13:12:23,425 WARN [org.apache.wicket.RequestListenerInterface] (default task-10) behavior not enabled; ignore call. Behavior org.apache.wicket.ajax.markup.html.navigation.paging.AjaxPagingNavigationLink$1@2281aefc at component [AjaxPagingNavigationLink [Component id = pageLink]] 13:12:23,431 WARN [RequestCycleExtra] (default task-10) 13:12:23,431 WARN [RequestCycleExtra] (default task-10) Handling the following exception: org.apache.wicket.core.request.handler.ListenerInvocationNotAllowedException: Behavior rejected interface invocation. Component: [AjaxPagingNavigationLink [Component id = pageLink]] Behavior: org.apache.wicket.ajax.markup.html.navigation.paging.AjaxPagingNavigationLink$1@2281aefc Listener: [RequestListenerInterface name=IBehaviorListener, method=public abstract void org.apache.wicket.behavior.IBehaviorListener.onRequest()] at org.apache.wicket.RequestListenerInterface.invoke(RequestListenerInterface.java:237) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.invokeListener(ListenerInterfaceRequestHandler.java:248) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.respond(ListenerInterfaceRequestHandler.java:234) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:865) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.request.RequestHandlerStack.execute(RequestHandlerStack.java:64) [wicket-request-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:265) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:222) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.request.cycle.RequestCycle.processRequestAndDetach(RequestCycle.java:293) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:261) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:203) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:284) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:60) [undertow-servlet-1.1.0.Final.jar:1.1.0.Final] {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-5949) Dead Links for Wicket User Guide
[ https://issues.apache.org/jira/browse/WICKET-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene resolved WICKET-5949. - Resolution: Fixed Dead Links for Wicket User Guide Key: WICKET-5949 URL: https://issues.apache.org/jira/browse/WICKET-5949 Project: Wicket Issue Type: Bug Components: site Reporter: Smail Louahchi Assignee: Andrea Del Bene Priority: Trivial On 'https://wicket.apache.org/learn/' the Wicket User Guide Links are dead. They are pointing to HTML | https://wicket.apache.org/guide/guide/index.html HTML (single page) https://wicket.apache.org/guide/guide/single.html The only working URI is under https://ci.apache.org/projects/wicket/guide/6.x and https://ci.apache.org/projects/wicket/guide/7.x Kind regards Smail -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5941) Headers not rendered for components inside TransparentWebMarkupContainer on ajax update
[ https://issues.apache.org/jira/browse/WICKET-5941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5941: Affects Version/s: 7.0.0-M6 Headers not rendered for components inside TransparentWebMarkupContainer on ajax update --- Key: WICKET-5941 URL: https://issues.apache.org/jira/browse/WICKET-5941 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Emond Papegaaij Assignee: Andrea Del Bene Attachments: refreshhead.tar.gz When a TransparentWebMarkupContainer is refreshed using ajax, components inside it do not render headers. The attached quickstart shows this problem. The AjaxLink only works once. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5947) AjaxPagingNavigationLink throws exception that Behavior is not enabled
[ https://issues.apache.org/jira/browse/WICKET-5947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620480#comment-14620480 ] Andrea Del Bene commented on WICKET-5947: - The problem is that AJAX requests in Wicket 7 do not increase page version indicator. The problem can be seen in example page pageables. If we open two tabs pointing at the same page version (i.e. open a navigation link in another tab) and then we try to click on a link previously disabled in the other tab (for example first/ last page links), we obtain the exception reported in this issue. We might solve it overriding AjaxPagingNavigationLink#canCallListenerInterface(Method method) but maybe there are better options. AjaxPagingNavigationLink throws exception that Behavior is not enabled -- Key: WICKET-5947 URL: https://issues.apache.org/jira/browse/WICKET-5947 Project: Wicket Issue Type: Bug Affects Versions: 7.0.0 Reporter: Martijn Dashorst Priority: Blocker When clicking on an AjaxPagingNavigationLink I get the exception below, based on wicket-7.0.0-SNAPSHOT from yesterday. {code} 13:12:23,425 WARN [org.apache.wicket.RequestListenerInterface] (default task-10) behavior not enabled; ignore call. Behavior org.apache.wicket.ajax.markup.html.navigation.paging.AjaxPagingNavigationLink$1@2281aefc at component [AjaxPagingNavigationLink [Component id = pageLink]] 13:12:23,431 WARN [RequestCycleExtra] (default task-10) 13:12:23,431 WARN [RequestCycleExtra] (default task-10) Handling the following exception: org.apache.wicket.core.request.handler.ListenerInvocationNotAllowedException: Behavior rejected interface invocation. Component: [AjaxPagingNavigationLink [Component id = pageLink]] Behavior: org.apache.wicket.ajax.markup.html.navigation.paging.AjaxPagingNavigationLink$1@2281aefc Listener: [RequestListenerInterface name=IBehaviorListener, method=public abstract void org.apache.wicket.behavior.IBehaviorListener.onRequest()] at org.apache.wicket.RequestListenerInterface.invoke(RequestListenerInterface.java:237) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.invokeListener(ListenerInterfaceRequestHandler.java:248) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.respond(ListenerInterfaceRequestHandler.java:234) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:865) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.request.RequestHandlerStack.execute(RequestHandlerStack.java:64) [wicket-request-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:265) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:222) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.request.cycle.RequestCycle.processRequestAndDetach(RequestCycle.java:293) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:261) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:203) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:284) [wicket-core-7.0.0-SNAPSHOT.jar:7.0.0-SNAPSHOT] at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:60) [undertow-servlet-1.1.0.Final.jar:1.1.0.Final] {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6036) Failure to process markup with nested tags inside a Label
[ https://issues.apache.org/jira/browse/WICKET-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011262#comment-15011262 ] Andrea Del Bene commented on WICKET-6036: - It's ok also for me. Just one thing. I'd prefer to add a test method to the existing ComponentQueueingTest class rather than creating a new one just for it. > Failure to process markup with nested tags inside a Label > - > > Key: WICKET-6036 > URL: https://issues.apache.org/jira/browse/WICKET-6036 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0, 7.1.0 >Reporter: Emond Papegaaij >Assignee: Andrea Del Bene > > The fix for WICKET-5730 causes previously accepted markup to be rejected > under some circumstances. In our case, we have a Label, which renders some > markup (text and an image), and expressed this in the markup for the panel: > {code} > >test > > {code} > When you add this Label to the panel, the following Exception is triggered: > {code} > java.lang.IllegalStateException: Tag '' should be the > closing one for '' > at > org.apache.wicket.MarkupContainer.dequeueChild(MarkupContainer.java:2163) > at org.apache.wicket.MarkupContainer.dequeue(MarkupContainer.java:2120) > at > org.apache.wicket.MarkupContainer.dequeuePreamble(MarkupContainer.java:2075) > at org.apache.wicket.MarkupContainer.dequeue(MarkupContainer.java:1993) > at > org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:1049) > at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:239) > at > org.apache.wicket.util.tester.BaseWicketTester.startComponentInPage(BaseWicketTester.java:1460) > at > org.apache.wicket.util.tester.BaseWicketTester.startComponentInPage(BaseWicketTester.java:1386) > at > org.apache.wicket.queueing.ComponentQueueingCompatibilityTest.nestedTags(ComponentQueueingCompatibilityTest.java:28) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > at > org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50) > at > org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) > at > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459) > at > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675) > at > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382) > at > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192) > {code} > This is a regression since 6.x, introduced by commit > db5be6ab05545e1bb95f566c3aeb23e05cf93437. I've added a disabled testcase to > demonstrate the problem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (WICKET-5981) Significant Performance Degradation From Wicket 6.20.0 to Wicket 7.0.0
[ https://issues.apache.org/jira/browse/WICKET-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-5981: --- Assignee: Andrea Del Bene > Significant Performance Degradation From Wicket 6.20.0 to Wicket 7.0.0 > -- > > Key: WICKET-5981 > URL: https://issues.apache.org/jira/browse/WICKET-5981 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 > Environment: OpenSuse 13.1 > Intellij 14.1.4 > JDK 1.8.0_60 > Solid State Hard Drive > 24 GB RAM >Reporter: Aaron J. Garcia >Assignee: Andrea Del Bene > Labels: performance > Attachments: quickstart.tar > > > I am experiencing a significant performance degradation for component adds in > Wicket 7.0.0, once the component tree for a page gets reasonably large. > The attached quick start can be used to reproduce the issue. Please note > that NUM_ROWS is set to 10,000 to exaggerate the performance degradation as > the size of the component tree increases. The same degradation (to a lesser > extent) can be viewed with a smaller NUM_ROWS variable. > In Wicket 6.20.0, as the size of the component tree increases, the cost of > add() remains relatively constant time-wise. In Wicket 7.0.0, a component > add () is much more expensive (and actually makes our internal web > application unusable) with form submits taking more than two or three minutes > to come back from the server. > Here's some timing examples. > = > NUM_ROWS = 5000 > Wicket 6.20.0 -> ~200 milliseconds of server side rendering (before browser > paints HTML). > Wicket 7.0.0 -> ~ 10 seconds of server side rendering > NUM_ROWS = 1 > Wicket 6.20.0 -> ~ 500 milliseconds of server side rendering > Wicket 7.0.0 -> ~ 40 seconds of server side rendering > = > The attached quickstart can be used to reproduce the issue on your side. My > guess is that this has to do with the new component queuing feature that was > added as part of Wicket 7.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5981) Significant Performance Degradation From Wicket 6.20.0 to Wicket 7.0.0
[ https://issues.apache.org/jira/browse/WICKET-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5981: Attachment: WICKET-5981.patch > Significant Performance Degradation From Wicket 6.20.0 to Wicket 7.0.0 > -- > > Key: WICKET-5981 > URL: https://issues.apache.org/jira/browse/WICKET-5981 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 > Environment: OpenSuse 13.1 > Intellij 14.1.4 > JDK 1.8.0_60 > Solid State Hard Drive > 24 GB RAM >Reporter: Aaron J. Garcia >Assignee: Andrea Del Bene > Labels: performance > Attachments: WICKET-5981.patch, quickstart.tar > > > I am experiencing a significant performance degradation for component adds in > Wicket 7.0.0, once the component tree for a page gets reasonably large. > The attached quick start can be used to reproduce the issue. Please note > that NUM_ROWS is set to 10,000 to exaggerate the performance degradation as > the size of the component tree increases. The same degradation (to a lesser > extent) can be viewed with a smaller NUM_ROWS variable. > In Wicket 6.20.0, as the size of the component tree increases, the cost of > add() remains relatively constant time-wise. In Wicket 7.0.0, a component > add () is much more expensive (and actually makes our internal web > application unusable) with form submits taking more than two or three minutes > to come back from the server. > Here's some timing examples. > = > NUM_ROWS = 5000 > Wicket 6.20.0 -> ~200 milliseconds of server side rendering (before browser > paints HTML). > Wicket 7.0.0 -> ~ 10 seconds of server side rendering > NUM_ROWS = 1 > Wicket 6.20.0 -> ~ 500 milliseconds of server side rendering > Wicket 7.0.0 -> ~ 40 seconds of server side rendering > = > The attached quickstart can be used to reproduce the issue on your side. My > guess is that this has to do with the new component queuing feature that was > added as part of Wicket 7.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5981) Significant Performance Degradation From Wicket 6.20.0 to Wicket 7.0.0
[ https://issues.apache.org/jira/browse/WICKET-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5981: Attachment: (was: WICKET-5981.patch) > Significant Performance Degradation From Wicket 6.20.0 to Wicket 7.0.0 > -- > > Key: WICKET-5981 > URL: https://issues.apache.org/jira/browse/WICKET-5981 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 > Environment: OpenSuse 13.1 > Intellij 14.1.4 > JDK 1.8.0_60 > Solid State Hard Drive > 24 GB RAM >Reporter: Aaron J. Garcia >Assignee: Andrea Del Bene > Labels: performance > Attachments: quickstart.tar > > > I am experiencing a significant performance degradation for component adds in > Wicket 7.0.0, once the component tree for a page gets reasonably large. > The attached quick start can be used to reproduce the issue. Please note > that NUM_ROWS is set to 10,000 to exaggerate the performance degradation as > the size of the component tree increases. The same degradation (to a lesser > extent) can be viewed with a smaller NUM_ROWS variable. > In Wicket 6.20.0, as the size of the component tree increases, the cost of > add() remains relatively constant time-wise. In Wicket 7.0.0, a component > add () is much more expensive (and actually makes our internal web > application unusable) with form submits taking more than two or three minutes > to come back from the server. > Here's some timing examples. > = > NUM_ROWS = 5000 > Wicket 6.20.0 -> ~200 milliseconds of server side rendering (before browser > paints HTML). > Wicket 7.0.0 -> ~ 10 seconds of server side rendering > NUM_ROWS = 1 > Wicket 6.20.0 -> ~ 500 milliseconds of server side rendering > Wicket 7.0.0 -> ~ 40 seconds of server side rendering > = > The attached quickstart can be used to reproduce the issue on your side. My > guess is that this has to do with the new component queuing feature that was > added as part of Wicket 7.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5981) Significant Performance Degradation From Wicket 6.20.0 to Wicket 7.0.0
[ https://issues.apache.org/jira/browse/WICKET-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5981: Attachment: WICKET-5981-Significant-Performance-Degradation-From.patch > Significant Performance Degradation From Wicket 6.20.0 to Wicket 7.0.0 > -- > > Key: WICKET-5981 > URL: https://issues.apache.org/jira/browse/WICKET-5981 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 > Environment: OpenSuse 13.1 > Intellij 14.1.4 > JDK 1.8.0_60 > Solid State Hard Drive > 24 GB RAM >Reporter: Aaron J. Garcia >Assignee: Andrea Del Bene > Labels: performance > Attachments: > WICKET-5981-Significant-Performance-Degradation-From.patch, quickstart.tar > > > I am experiencing a significant performance degradation for component adds in > Wicket 7.0.0, once the component tree for a page gets reasonably large. > The attached quick start can be used to reproduce the issue. Please note > that NUM_ROWS is set to 10,000 to exaggerate the performance degradation as > the size of the component tree increases. The same degradation (to a lesser > extent) can be viewed with a smaller NUM_ROWS variable. > In Wicket 6.20.0, as the size of the component tree increases, the cost of > add() remains relatively constant time-wise. In Wicket 7.0.0, a component > add () is much more expensive (and actually makes our internal web > application unusable) with form submits taking more than two or three minutes > to come back from the server. > Here's some timing examples. > = > NUM_ROWS = 5000 > Wicket 6.20.0 -> ~200 milliseconds of server side rendering (before browser > paints HTML). > Wicket 7.0.0 -> ~ 10 seconds of server side rendering > NUM_ROWS = 1 > Wicket 6.20.0 -> ~ 500 milliseconds of server side rendering > Wicket 7.0.0 -> ~ 40 seconds of server side rendering > = > The attached quickstart can be used to reproduce the issue on your side. My > guess is that this has to do with the new component queuing feature that was > added as part of Wicket 7.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5981) Significant Performance Degradation From Wicket 6.20.0 to Wicket 7.0.0
[ https://issues.apache.org/jira/browse/WICKET-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14769014#comment-14769014 ] Andrea Del Bene commented on WICKET-5981: - I've also prepared a slightly different patch, but the idea behind it is exactly the same. See attachment. > Significant Performance Degradation From Wicket 6.20.0 to Wicket 7.0.0 > -- > > Key: WICKET-5981 > URL: https://issues.apache.org/jira/browse/WICKET-5981 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 > Environment: OpenSuse 13.1 > Intellij 14.1.4 > JDK 1.8.0_60 > Solid State Hard Drive > 24 GB RAM >Reporter: Aaron J. Garcia >Assignee: Andrea Del Bene > Labels: performance > Attachments: quickstart.tar > > > I am experiencing a significant performance degradation for component adds in > Wicket 7.0.0, once the component tree for a page gets reasonably large. > The attached quick start can be used to reproduce the issue. Please note > that NUM_ROWS is set to 10,000 to exaggerate the performance degradation as > the size of the component tree increases. The same degradation (to a lesser > extent) can be viewed with a smaller NUM_ROWS variable. > In Wicket 6.20.0, as the size of the component tree increases, the cost of > add() remains relatively constant time-wise. In Wicket 7.0.0, a component > add () is much more expensive (and actually makes our internal web > application unusable) with form submits taking more than two or three minutes > to come back from the server. > Here's some timing examples. > = > NUM_ROWS = 5000 > Wicket 6.20.0 -> ~200 milliseconds of server side rendering (before browser > paints HTML). > Wicket 7.0.0 -> ~ 10 seconds of server side rendering > NUM_ROWS = 1 > Wicket 6.20.0 -> ~ 500 milliseconds of server side rendering > Wicket 7.0.0 -> ~ 40 seconds of server side rendering > = > The attached quickstart can be used to reproduce the issue on your side. My > guess is that this has to do with the new component queuing feature that was > added as part of Wicket 7.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5988) WICKET-5981 breaks forms inside borders
[ https://issues.apache.org/jira/browse/WICKET-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5988: Attachment: queueIssue.tar.gz > WICKET-5981 breaks forms inside borders > --- > > Key: WICKET-5988 > URL: https://issues.apache.org/jira/browse/WICKET-5988 > Project: Wicket > Issue Type: Bug >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > Attachments: queueIssue.tar.gz > > > Due to WICKET-5981 border component doesn't invoke dequeue() anymore when a > child component is added. This is a problem if we have a form inside border's > body and some form input fields in the border's markup (see quickstart). In > such a case form fields are not submitted because they are not form's > descendants. > To solve this issue we should trigger dequeue() after border has been > initialized and let component queueing 'fix' descendants hierarchy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-5988) WICKET-5981 breaks forms inside borders
Andrea Del Bene created WICKET-5988: --- Summary: WICKET-5981 breaks forms inside borders Key: WICKET-5988 URL: https://issues.apache.org/jira/browse/WICKET-5988 Project: Wicket Issue Type: Bug Reporter: Andrea Del Bene Assignee: Andrea Del Bene Due to WICKET-5981 border component doesn't invoke dequeue() anymore when a child component is added. This is a problem if we have a form inside border's body and some form input fields in the border's markup (see quickstart). In such a case form fields are not submitted because they are not form's descendants. To solve this issue we should trigger dequeue() after border has been initialized and let component queueing 'fix' descendants hierarchy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5988) WICKET-5981 breaks forms inside borders
[ https://issues.apache.org/jira/browse/WICKET-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5988: Fix Version/s: 7.1.0 > WICKET-5981 breaks forms inside borders > --- > > Key: WICKET-5988 > URL: https://issues.apache.org/jira/browse/WICKET-5988 > Project: Wicket > Issue Type: Bug >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > Fix For: 7.1.0 > > Attachments: queueIssue.tar.gz > > > Due to WICKET-5981 border component doesn't invoke dequeue() anymore when a > child component is added. This is a problem if we have a form inside border's > body and some form input fields in the border's markup (see quickstart). In > such a case form fields are not submitted because they are not form's > descendants. > To solve this issue we should trigger dequeue() after border has been > initialized and let component queueing 'fix' descendants hierarchy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (WICKET-5988) WICKET-5981 breaks forms inside borders
[ https://issues.apache.org/jira/browse/WICKET-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-5988. --- Resolution: Fixed > WICKET-5981 breaks forms inside borders > --- > > Key: WICKET-5988 > URL: https://issues.apache.org/jira/browse/WICKET-5988 > Project: Wicket > Issue Type: Bug >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > Fix For: 7.1.0 > > Attachments: queueIssue.tar.gz > > > Due to WICKET-5981 border component doesn't invoke dequeue() anymore when a > child component is added. This is a problem if we have a form inside border's > body and some form input fields in the border's markup (see quickstart). In > such a case form fields are not submitted because they are not form's > descendants. > To solve this issue we should trigger dequeue() after border has been > initialized and let component queueing 'fix' descendants hierarchy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6041) Nested forms / parent FormComponents do not reflect updated model when nested form submitted
[ https://issues.apache.org/jira/browse/WICKET-6041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030041#comment-15030041 ] Andrea Del Bene commented on WICKET-6041: - I'm also ok with the current behavior of form processing, but as Martin also said, I'd also like to have a more consistent code and behavior. Starting from the fact that by default a nested form doesn't submit any parent one, I would say that : - it's correct if raw input of the surrounding form is lost since by default it's not submitted. - the proposed change doesn't break #wantSubmitOnNestedFormSubmit(). If an outer form overrides this method returning true it will be submitted instead of the nested one (see Form#findFormToProcess). - non-Ajax buttons should not be affected by the proposed change as they are not AJAX-based. Am I correct? > Nested forms / parent FormComponents do not reflect updated model when nested > form submitted > > > Key: WICKET-6041 > URL: https://issues.apache.org/jira/browse/WICKET-6041 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.21.0, 7.1.0 >Reporter: Patrick Davids >Assignee: Andrea Del Bene > Attachments: NonReflectingFormComponent.zip > > > Hi, > as discussed in user-list, here the ticket and quickstart attached. > I guess the quickstart looks quite unusual, because it is reduced to its > minimum to show what happens. > The use-case of such an nested form component tree is more clearer when > considering the usage in wizards, which holds its own form to be able to do > step-transitions. > In combination with dialogs (e.g. wicket-jquery-ui / greetings to [~sebfz1] > by the way), which also needed a form to work, you will get such a nested > form situation. > kind regards > Patrick -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6043) Cannot set wicket:enclosure on queued component in ListView
[ https://issues.apache.org/jira/browse/WICKET-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030046#comment-15030046 ] Andrea Del Bene commented on WICKET-6043: - Since ListItemS are not resolvable by markup, they can be turned to IQueueRegion, so they can provide their own markup, > Cannot set wicket:enclosure on queued component in ListView > --- > > Key: WICKET-6043 > URL: https://issues.apache.org/jira/browse/WICKET-6043 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Attachments: WicketQuickstart2.war > > > An exception is raised if we target the enclosure child to a queued component > in a ListView : > org.apache.wicket.WicketRuntimeException: Could not find child with id: test > in the wicket:enclosure -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6049) Update the site to point to the new deployments of the examples
[ https://issues.apache.org/jira/browse/WICKET-6049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043460#comment-15043460 ] Andrea Del Bene commented on WICKET-6049: - Hi, I've updated the links of the site to the new examples site: http://wicket.apache.org/learn/examples/index.html > Update the site to point to the new deployments of the examples > --- > > Key: WICKET-6049 > URL: https://issues.apache.org/jira/browse/WICKET-6049 > Project: Wicket > Issue Type: Task > Components: site >Reporter: Martin Grigorov >Priority: Minor > > Wicket-Examples are now available at: > - http://examples7x.wicket.apache.org/index.html > - http://examples6x.wicket.apache.org/index.html > We should link to them in the site. > An additional task is to update > http://www.wicket-library.com/wicket-examples-6.0.x/index.html to redirect to > the new server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6041) Nested forms / parent FormComponents do not reflect updated model when nested form submitted
[ https://issues.apache.org/jira/browse/WICKET-6041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052904#comment-15052904 ] Andrea Del Bene commented on WICKET-6041: - I think Yoann got the point. AFAIK form submitting also includes form processing. If this assumption is true a possible simple fix could be moving markFormsSubmitted at the bottom of Form#onFormSubmitted(IFormSubmitter), after we have invoked formToProcess.process(submitter); {code} else { // the submit request might be for one of the nested forms, so let's // find the right one: final Form formToProcess = findFormToProcess(submitter); // process the form for this request formToProcess.process(submitter); //mark form as submitted formToProcess.markFormsSubmitted(); } {code} > Nested forms / parent FormComponents do not reflect updated model when nested > form submitted > > > Key: WICKET-6041 > URL: https://issues.apache.org/jira/browse/WICKET-6041 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.21.0, 7.1.0 >Reporter: Patrick Davids >Assignee: Andrea Del Bene > Attachments: NonReflectingFormComponent.zip > > > Hi, > as discussed in user-list, here the ticket and quickstart attached. > I guess the quickstart looks quite unusual, because it is reduced to its > minimum to show what happens. > The use-case of such an nested form component tree is more clearer when > considering the usage in wizards, which holds its own form to be able to do > step-transitions. > In combination with dialogs (e.g. wicket-jquery-ui / greetings to [~sebfz1] > by the way), which also needed a form to work, you will get such a nested > form situation. > kind regards > Patrick -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (WICKET-6041) Nested forms / parent FormComponents do not reflect updated model when nested form submitted
[ https://issues.apache.org/jira/browse/WICKET-6041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052904#comment-15052904 ] Andrea Del Bene edited comment on WICKET-6041 at 12/11/15 3:49 PM: --- I think Yoann got the point. AFAIK form submitting also includes form processing. If this assumption is true a possible simple fix could be moving markFormsSubmitted at the bottom of Form#onFormSubmitted(IFormSubmitter), after we have invoked formToProcess.process(submitter); {code} else { // the submit request might be for one of the nested forms, so let's // find the right one: final Form formToProcess = findFormToProcess(submitter); // process the form for this request formToProcess.process(submitter); //mark form as submitted formToProcess.markFormsSubmitted(); } {code} This solution would preserve the current behavior with not submitted forms and would make the overall form behavior more consistent. was (Author: bitstorm): I think Yoann got the point. AFAIK form submitting also includes form processing. If this assumption is true a possible simple fix could be moving markFormsSubmitted at the bottom of Form#onFormSubmitted(IFormSubmitter), after we have invoked formToProcess.process(submitter); {code} else { // the submit request might be for one of the nested forms, so let's // find the right one: final Form formToProcess = findFormToProcess(submitter); // process the form for this request formToProcess.process(submitter); //mark form as submitted formToProcess.markFormsSubmitted(); } {code} > Nested forms / parent FormComponents do not reflect updated model when nested > form submitted > > > Key: WICKET-6041 > URL: https://issues.apache.org/jira/browse/WICKET-6041 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.21.0, 7.1.0 >Reporter: Patrick Davids >Assignee: Andrea Del Bene > Attachments: NonReflectingFormComponent.zip > > > Hi, > as discussed in user-list, here the ticket and quickstart attached. > I guess the quickstart looks quite unusual, because it is reduced to its > minimum to show what happens. > The use-case of such an nested form component tree is more clearer when > considering the usage in wizards, which holds its own form to be able to do > step-transitions. > In combination with dialogs (e.g. wicket-jquery-ui / greetings to [~sebfz1] > by the way), which also needed a form to work, you will get such a nested > form situation. > kind regards > Patrick -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (WICKET-5768) Improve class hierarchy of package org.apache.wicket.util.crypt
[ https://issues.apache.org/jira/browse/WICKET-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-5768. --- Resolution: Won't Fix We might consider it in future. > Improve class hierarchy of package org.apache.wicket.util.crypt > > > Key: WICKET-5768 > URL: https://issues.apache.org/jira/browse/WICKET-5768 > Project: Wicket > Issue Type: Improvement >Affects Versions: 7.0.0-M4 >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene >Priority: Minor > Labels: wicket8 > > Following the work done for WICKET-5756, it would be nice to have a more > flexible and clear hierarchy for cryptography classes in package > org.apache.wicket.util.crypt. Currently we base our chipers on interface > ICrypt which assumes we want to use a string as "secret" key. > We can apply some refactoring to support keys of generic type and make the > whole implementation more clear. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6061) Improved PackageResource#getCacheKey
Andrea Del Bene created WICKET-6061: --- Summary: Improved PackageResource#getCacheKey Key: WICKET-6061 URL: https://issues.apache.org/jira/browse/WICKET-6061 Project: Wicket Issue Type: Improvement Affects Versions: 7.1.0, 8.0.0-M1 Reporter: Andrea Del Bene Assignee: Andrea Del Bene Fix For: 7.2.0, 8.0.0-M1 Method 'getCacheKey' (which is called multiple times for each request) indirectly calls internalGetResourceStream to check if package resource exists. For this purpose we should use instead static method 'exists', which is lighter than internalGetResourceStream. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (WICKET-6061) Improved PackageResource#getCacheKey
[ https://issues.apache.org/jira/browse/WICKET-6061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-6061. --- Resolution: Fixed > Improved PackageResource#getCacheKey > > > Key: WICKET-6061 > URL: https://issues.apache.org/jira/browse/WICKET-6061 > Project: Wicket > Issue Type: Improvement >Affects Versions: 7.1.0, 8.0.0-M1 >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > > Method 'getCacheKey' (which is called multiple times for each request) > indirectly calls internalGetResourceStream to check if package resource > exists. For this purpose we should use instead static method 'exists', which > is lighter than internalGetResourceStream. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (WICKET-6060) Deprecate org.apache.wicket.util.IProvider
[ https://issues.apache.org/jira/browse/WICKET-6060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-6060. --- Resolution: Fixed > Deprecate org.apache.wicket.util.IProvider > -- > > Key: WICKET-6060 > URL: https://issues.apache.org/jira/browse/WICKET-6060 > Project: Wicket > Issue Type: Improvement >Affects Versions: 8.0.0-M1 >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > Fix For: 8.0.0-M1 > > > Deprecate org.apache.wicket.util.IProvider and replace it with standard Java > 8 java.util.function.Supplier which is virtually identical. Also apply > Lambdas where possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (WICKET-6065) Calling http://examples7x.wicket.apache.org/resourceaggregation/ generate Internal error
[ https://issues.apache.org/jira/browse/WICKET-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-6065: --- Assignee: Andrea Del Bene > Calling http://examples7x.wicket.apache.org/resourceaggregation/ generate > Internal error > > > Key: WICKET-6065 > URL: https://issues.apache.org/jira/browse/WICKET-6065 > Project: Wicket > Issue Type: Bug > Components: wicket-examples >Affects Versions: 7.1.0 >Reporter: francois >Assignee: Andrea Del Bene >Priority: Trivial > > Root cause: > java.util.MissingResourceException: Unable to get cache key for scope: > org.apache.wicket.examples.resourcedecoration.HomePage; name: footer.css; > locale: null; style: null; variation: null > at > org.apache.wicket.resource.bundles.ConcatBundleResource.reportError(ConcatBundleResource.java:248) > at > org.apache.wicket.resource.bundles.ConcatBundleResource.getCacheKey(ConcatBundleResource.java:223) > at > org.apache.wicket.request.resource.caching.version.RequestCycleCachedResourceVersion.getVersion(RequestCycleCachedResourceVersion.java:82) > at > org.apache.wicket.request.resource.caching.FilenameWithVersionResourceCachingStrategy.decorateUrl(FilenameWithVersionResourceCachingStrategy.java:105) > at > org.apache.wicket.core.request.mapper.BasicResourceReferenceMapper.mapHandler(BasicResourceReferenceMapper.java:240) > at > org.apache.wicket.request.mapper.ParentPathReferenceRewriter.mapHandler(ParentPathReferenceRewriter.java:92) > at > org.apache.wicket.request.mapper.CompoundRequestMapper.mapHandler(CompoundRequestMapper.java:213) > at > org.apache.wicket.request.cycle.RequestCycle.mapUrlFor(RequestCycle.java:434) > at > org.apache.wicket.request.cycle.RequestCycle.urlFor(RequestCycle.java:534) > at > org.apache.wicket.markup.head.CssReferenceHeaderItem.getUrl(CssReferenceHeaderItem.java:125) > at > org.apache.wicket.markup.head.CssReferenceHeaderItem.getRenderTokens(CssReferenceHeaderItem.java:112) > at > org.apache.wicket.markup.head.internal.HeaderResponse.wasItemRendered(HeaderResponse.java:61) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6065) Calling http://examples7x.wicket.apache.org/resourceaggregation/ generate Internal error
[ https://issues.apache.org/jira/browse/WICKET-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6065: Fix Version/s: 8.0.0-M1 7.2.0 > Calling http://examples7x.wicket.apache.org/resourceaggregation/ generate > Internal error > > > Key: WICKET-6065 > URL: https://issues.apache.org/jira/browse/WICKET-6065 > Project: Wicket > Issue Type: Bug > Components: wicket-examples >Affects Versions: 7.1.0 >Reporter: francois >Assignee: Andrea Del Bene >Priority: Trivial > Fix For: 7.2.0, 8.0.0-M1 > > > Root cause: > java.util.MissingResourceException: Unable to get cache key for scope: > org.apache.wicket.examples.resourcedecoration.HomePage; name: footer.css; > locale: null; style: null; variation: null > at > org.apache.wicket.resource.bundles.ConcatBundleResource.reportError(ConcatBundleResource.java:248) > at > org.apache.wicket.resource.bundles.ConcatBundleResource.getCacheKey(ConcatBundleResource.java:223) > at > org.apache.wicket.request.resource.caching.version.RequestCycleCachedResourceVersion.getVersion(RequestCycleCachedResourceVersion.java:82) > at > org.apache.wicket.request.resource.caching.FilenameWithVersionResourceCachingStrategy.decorateUrl(FilenameWithVersionResourceCachingStrategy.java:105) > at > org.apache.wicket.core.request.mapper.BasicResourceReferenceMapper.mapHandler(BasicResourceReferenceMapper.java:240) > at > org.apache.wicket.request.mapper.ParentPathReferenceRewriter.mapHandler(ParentPathReferenceRewriter.java:92) > at > org.apache.wicket.request.mapper.CompoundRequestMapper.mapHandler(CompoundRequestMapper.java:213) > at > org.apache.wicket.request.cycle.RequestCycle.mapUrlFor(RequestCycle.java:434) > at > org.apache.wicket.request.cycle.RequestCycle.urlFor(RequestCycle.java:534) > at > org.apache.wicket.markup.head.CssReferenceHeaderItem.getUrl(CssReferenceHeaderItem.java:125) > at > org.apache.wicket.markup.head.CssReferenceHeaderItem.getRenderTokens(CssReferenceHeaderItem.java:112) > at > org.apache.wicket.markup.head.internal.HeaderResponse.wasItemRendered(HeaderResponse.java:61) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6061) Improved PackageResource#getCacheKey
[ https://issues.apache.org/jira/browse/WICKET-6061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083261#comment-15083261 ] Andrea Del Bene commented on WICKET-6061: - `Packages.absolutePath(scope, name)` was called twice: once in the constructor and another one inside `exists` method > Improved PackageResource#getCacheKey > > > Key: WICKET-6061 > URL: https://issues.apache.org/jira/browse/WICKET-6061 > Project: Wicket > Issue Type: Improvement >Affects Versions: 7.1.0, 8.0.0-M1 >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > > Method 'getCacheKey' (which is called multiple times for each request) > indirectly calls internalGetResourceStream to check if package resource > exists. For this purpose we should use instead static method 'exists', which > is lighter than internalGetResourceStream. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (WICKET-6065) Calling http://examples7x.wicket.apache.org/resourceaggregation/ generate Internal error
[ https://issues.apache.org/jira/browse/WICKET-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-6065. --- Resolution: Fixed > Calling http://examples7x.wicket.apache.org/resourceaggregation/ generate > Internal error > > > Key: WICKET-6065 > URL: https://issues.apache.org/jira/browse/WICKET-6065 > Project: Wicket > Issue Type: Bug > Components: wicket-examples >Affects Versions: 7.1.0, 8.0.0-M1 >Reporter: francois >Assignee: Andrea Del Bene >Priority: Trivial > Fix For: 7.2.0, 8.0.0-M1 > > > Root cause: > java.util.MissingResourceException: Unable to get cache key for scope: > org.apache.wicket.examples.resourcedecoration.HomePage; name: footer.css; > locale: null; style: null; variation: null > at > org.apache.wicket.resource.bundles.ConcatBundleResource.reportError(ConcatBundleResource.java:248) > at > org.apache.wicket.resource.bundles.ConcatBundleResource.getCacheKey(ConcatBundleResource.java:223) > at > org.apache.wicket.request.resource.caching.version.RequestCycleCachedResourceVersion.getVersion(RequestCycleCachedResourceVersion.java:82) > at > org.apache.wicket.request.resource.caching.FilenameWithVersionResourceCachingStrategy.decorateUrl(FilenameWithVersionResourceCachingStrategy.java:105) > at > org.apache.wicket.core.request.mapper.BasicResourceReferenceMapper.mapHandler(BasicResourceReferenceMapper.java:240) > at > org.apache.wicket.request.mapper.ParentPathReferenceRewriter.mapHandler(ParentPathReferenceRewriter.java:92) > at > org.apache.wicket.request.mapper.CompoundRequestMapper.mapHandler(CompoundRequestMapper.java:213) > at > org.apache.wicket.request.cycle.RequestCycle.mapUrlFor(RequestCycle.java:434) > at > org.apache.wicket.request.cycle.RequestCycle.urlFor(RequestCycle.java:534) > at > org.apache.wicket.markup.head.CssReferenceHeaderItem.getUrl(CssReferenceHeaderItem.java:125) > at > org.apache.wicket.markup.head.CssReferenceHeaderItem.getRenderTokens(CssReferenceHeaderItem.java:112) > at > org.apache.wicket.markup.head.internal.HeaderResponse.wasItemRendered(HeaderResponse.java:61) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6065) Calling http://examples7x.wicket.apache.org/resourceaggregation/ generate Internal error
[ https://issues.apache.org/jira/browse/WICKET-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6065: Affects Version/s: 8.0.0-M1 > Calling http://examples7x.wicket.apache.org/resourceaggregation/ generate > Internal error > > > Key: WICKET-6065 > URL: https://issues.apache.org/jira/browse/WICKET-6065 > Project: Wicket > Issue Type: Bug > Components: wicket-examples >Affects Versions: 7.1.0, 8.0.0-M1 >Reporter: francois >Assignee: Andrea Del Bene >Priority: Trivial > Fix For: 7.2.0, 8.0.0-M1 > > > Root cause: > java.util.MissingResourceException: Unable to get cache key for scope: > org.apache.wicket.examples.resourcedecoration.HomePage; name: footer.css; > locale: null; style: null; variation: null > at > org.apache.wicket.resource.bundles.ConcatBundleResource.reportError(ConcatBundleResource.java:248) > at > org.apache.wicket.resource.bundles.ConcatBundleResource.getCacheKey(ConcatBundleResource.java:223) > at > org.apache.wicket.request.resource.caching.version.RequestCycleCachedResourceVersion.getVersion(RequestCycleCachedResourceVersion.java:82) > at > org.apache.wicket.request.resource.caching.FilenameWithVersionResourceCachingStrategy.decorateUrl(FilenameWithVersionResourceCachingStrategy.java:105) > at > org.apache.wicket.core.request.mapper.BasicResourceReferenceMapper.mapHandler(BasicResourceReferenceMapper.java:240) > at > org.apache.wicket.request.mapper.ParentPathReferenceRewriter.mapHandler(ParentPathReferenceRewriter.java:92) > at > org.apache.wicket.request.mapper.CompoundRequestMapper.mapHandler(CompoundRequestMapper.java:213) > at > org.apache.wicket.request.cycle.RequestCycle.mapUrlFor(RequestCycle.java:434) > at > org.apache.wicket.request.cycle.RequestCycle.urlFor(RequestCycle.java:534) > at > org.apache.wicket.markup.head.CssReferenceHeaderItem.getUrl(CssReferenceHeaderItem.java:125) > at > org.apache.wicket.markup.head.CssReferenceHeaderItem.getRenderTokens(CssReferenceHeaderItem.java:112) > at > org.apache.wicket.markup.head.internal.HeaderResponse.wasItemRendered(HeaderResponse.java:61) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (WICKET-6065) Calling http://examples7x.wicket.apache.org/resourceaggregation/ generate Internal error
[ https://issues.apache.org/jira/browse/WICKET-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-6065. --- Resolution: Fixed fixed with WICKET-6061 > Calling http://examples7x.wicket.apache.org/resourceaggregation/ generate > Internal error > > > Key: WICKET-6065 > URL: https://issues.apache.org/jira/browse/WICKET-6065 > Project: Wicket > Issue Type: Bug > Components: wicket-examples >Affects Versions: 7.1.0 >Reporter: francois >Assignee: Andrea Del Bene >Priority: Trivial > > Root cause: > java.util.MissingResourceException: Unable to get cache key for scope: > org.apache.wicket.examples.resourcedecoration.HomePage; name: footer.css; > locale: null; style: null; variation: null > at > org.apache.wicket.resource.bundles.ConcatBundleResource.reportError(ConcatBundleResource.java:248) > at > org.apache.wicket.resource.bundles.ConcatBundleResource.getCacheKey(ConcatBundleResource.java:223) > at > org.apache.wicket.request.resource.caching.version.RequestCycleCachedResourceVersion.getVersion(RequestCycleCachedResourceVersion.java:82) > at > org.apache.wicket.request.resource.caching.FilenameWithVersionResourceCachingStrategy.decorateUrl(FilenameWithVersionResourceCachingStrategy.java:105) > at > org.apache.wicket.core.request.mapper.BasicResourceReferenceMapper.mapHandler(BasicResourceReferenceMapper.java:240) > at > org.apache.wicket.request.mapper.ParentPathReferenceRewriter.mapHandler(ParentPathReferenceRewriter.java:92) > at > org.apache.wicket.request.mapper.CompoundRequestMapper.mapHandler(CompoundRequestMapper.java:213) > at > org.apache.wicket.request.cycle.RequestCycle.mapUrlFor(RequestCycle.java:434) > at > org.apache.wicket.request.cycle.RequestCycle.urlFor(RequestCycle.java:534) > at > org.apache.wicket.markup.head.CssReferenceHeaderItem.getUrl(CssReferenceHeaderItem.java:125) > at > org.apache.wicket.markup.head.CssReferenceHeaderItem.getRenderTokens(CssReferenceHeaderItem.java:112) > at > org.apache.wicket.markup.head.internal.HeaderResponse.wasItemRendered(HeaderResponse.java:61) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6059) TransparentWebMarkupContainer can not resolve autocomponents in its parent
[ https://issues.apache.org/jira/browse/WICKET-6059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6059: Fix Version/s: 8.0.0-M1 7.2.0 > TransparentWebMarkupContainer can not resolve autocomponents in its parent > -- > > Key: WICKET-6059 > URL: https://issues.apache.org/jira/browse/WICKET-6059 > Project: Wicket > Issue Type: Bug >Affects Versions: 7.1.0, 8.0.0-M1 >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > > TransparentWebMarkupContainer cannot resolve autocomponents in its parent. > This is caused by commit 50e9fb1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6060) Deprecate org.apache.wicket.util.IProvider
Andrea Del Bene created WICKET-6060: --- Summary: Deprecate org.apache.wicket.util.IProvider Key: WICKET-6060 URL: https://issues.apache.org/jira/browse/WICKET-6060 Project: Wicket Issue Type: Improvement Affects Versions: 8.0.0-M1 Reporter: Andrea Del Bene Assignee: Andrea Del Bene Fix For: 8.0.0-M1 Deprecate org.apache.wicket.util.IProvider and replace it with standard Java 8 java.util.function.Supplier which is virtually identical. Also apply Lambdas where possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6060) Deprecate org.apache.wicket.util.IProvider
[ https://issues.apache.org/jira/browse/WICKET-6060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075950#comment-15075950 ] Andrea Del Bene commented on WICKET-6060: - Commit https://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commit;h=17e540cb5328def36c99aa709b8a78136b850d94 > Deprecate org.apache.wicket.util.IProvider > -- > > Key: WICKET-6060 > URL: https://issues.apache.org/jira/browse/WICKET-6060 > Project: Wicket > Issue Type: Improvement >Affects Versions: 8.0.0-M1 >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > Fix For: 8.0.0-M1 > > > Deprecate org.apache.wicket.util.IProvider and replace it with standard Java > 8 java.util.function.Supplier which is virtually identical. Also apply > Lambdas where possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6059) TransparentWebMarkupContainer can not resolve autocomponents in its parent
[ https://issues.apache.org/jira/browse/WICKET-6059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6059: Description: TransparentWebMarkupContainer cannot resolve autocomponents in its parent. This is caused by commit 50e9fb1. (was: TransparentWebMarkupContainer cannot resolve autocomponents ) > TransparentWebMarkupContainer can not resolve autocomponents in its parent > -- > > Key: WICKET-6059 > URL: https://issues.apache.org/jira/browse/WICKET-6059 > Project: Wicket > Issue Type: Bug >Affects Versions: 7.1.0, 8.0.0-M1 >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > > TransparentWebMarkupContainer cannot resolve autocomponents in its parent. > This is caused by commit 50e9fb1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6059) TransparentWebMarkupContainer can not resolve autocomponents in its parent
[ https://issues.apache.org/jira/browse/WICKET-6059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6059: Description: TransparentWebMarkupContainer cannot resolve autocomponents > TransparentWebMarkupContainer can not resolve autocomponents in its parent > -- > > Key: WICKET-6059 > URL: https://issues.apache.org/jira/browse/WICKET-6059 > Project: Wicket > Issue Type: Bug >Affects Versions: 7.1.0, 8.0.0-M1 >Reporter: Andrea Del Bene >Assignee: Andrea Del Bene > > TransparentWebMarkupContainer cannot resolve autocomponents -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6059) TransparentWebMarkupContainer can not resolve autocomponents in its parent
Andrea Del Bene created WICKET-6059: --- Summary: TransparentWebMarkupContainer can not resolve autocomponents in its parent Key: WICKET-6059 URL: https://issues.apache.org/jira/browse/WICKET-6059 Project: Wicket Issue Type: Bug Affects Versions: 7.1.0, 8.0.0-M1 Reporter: Andrea Del Bene Assignee: Andrea Del Bene -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6041) Nested forms / parent FormComponents do not reflect updated model when nested form submitted
[ https://issues.apache.org/jira/browse/WICKET-6041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028831#comment-15028831 ] Andrea Del Bene commented on WICKET-6041: - As we said on the users list (http://apache-wicket.1842946.n4.nabble.com/Quetsion-to-nesting-Forms-and-reflecting-states-of-FormComponents-after-ajax-refreshs-td4672670.html) I would solve this issue removing getRootForm from AjaxFormSubmitBehavior#onEvent: {code} getForm().getRootForm().onFormSubmitted(new AjaxFormSubmitter(this, target)); {code} > Nested forms / parent FormComponents do not reflect updated model when nested > form submitted > > > Key: WICKET-6041 > URL: https://issues.apache.org/jira/browse/WICKET-6041 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.21.0, 7.1.0 >Reporter: Patrick Davids >Assignee: Andrea Del Bene > Attachments: NonReflectingFormComponent.zip > > > Hi, > as discussed in user-list, here the ticket and quickstart attached. > I guess the quickstart looks quite unusual, because it is reduced to its > minimum to show what happens. > The use-case of such an nested form component tree is more clearer when > considering the usage in wizards, which holds its own form to be able to do > step-transitions. > In combination with dialogs (e.g. wicket-jquery-ui / greetings to [~sebfz1] > by the way), which also needed a form to work, you will get such a nested > form situation. > kind regards > Patrick -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6043) Cannot set wicket:enclosure on queued component in ListView
[ https://issues.apache.org/jira/browse/WICKET-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6043: Fix Version/s: 8.0.0-M1 7.2.0 > Cannot set wicket:enclosure on queued component in ListView > --- > > Key: WICKET-6043 > URL: https://issues.apache.org/jira/browse/WICKET-6043 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > Attachments: WicketQuickstart2.war > > > An exception is raised if we target the enclosure child to a queued component > in a ListView : > org.apache.wicket.WicketRuntimeException: Could not find child with id: test > in the wicket:enclosure -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (WICKET-6043) Cannot set wicket:enclosure on queued component in ListView
[ https://issues.apache.org/jira/browse/WICKET-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-6043. --- Resolution: Fixed > Cannot set wicket:enclosure on queued component in ListView > --- > > Key: WICKET-6043 > URL: https://issues.apache.org/jira/browse/WICKET-6043 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > Attachments: WicketQuickstart2.war > > > An exception is raised if we target the enclosure child to a queued component > in a ListView : > org.apache.wicket.WicketRuntimeException: Could not find child with id: test > in the wicket:enclosure -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (WICKET-6028) Detach called on enclosure component while it had a non-empty queue
[ https://issues.apache.org/jira/browse/WICKET-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-6028. --- Resolution: Fixed > Detach called on enclosure component while it had a non-empty queue > --- > > Key: WICKET-6028 > URL: https://issues.apache.org/jira/browse/WICKET-6028 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > Attachments: BasePage.html, BasePage.java, EnclosurePage.html, > EnclosurePage.java, WICKET-6028.patch, myproject.tar.gz, stacktrace.txt > > > In the attached example EnclosurePage is extended from BasePage. In BasePage > there is a TransparentWebmarkupContainer attached to > The page is rendered, but a stacktrace "Error detaching RequestHandler" is > logged (see stacktrace.txt). > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (WICKET-6043) Cannot set wicket:enclosure on queued component in ListView
[ https://issues.apache.org/jira/browse/WICKET-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-6043: --- Assignee: Andrea Del Bene > Cannot set wicket:enclosure on queued component in ListView > --- > > Key: WICKET-6043 > URL: https://issues.apache.org/jira/browse/WICKET-6043 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Attachments: WicketQuickstart2.war > > > An exception is raised if we target the enclosure child to a queued component > in a ListView : > org.apache.wicket.WicketRuntimeException: Could not find child with id: test > in the wicket:enclosure -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6043) Cannot set wicket:enclosure on queued component in ListView
[ https://issues.apache.org/jira/browse/WICKET-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022233#comment-15022233 ] Andrea Del Bene commented on WICKET-6043: - I thought Mr "Queue Components" was me... :D > Cannot set wicket:enclosure on queued component in ListView > --- > > Key: WICKET-6043 > URL: https://issues.apache.org/jira/browse/WICKET-6043 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Palancher aurélien > Attachments: WicketQuickstart2.war > > > An exception is raised if we target the enclosure child to a queued component > in a ListView : > org.apache.wicket.WicketRuntimeException: Could not find child with id: test > in the wicket:enclosure -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (WICKET-6041) Nested forms / parent FormComponents do not reflect updated model when nested form submitted
[ https://issues.apache.org/jira/browse/WICKET-6041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-6041: --- Assignee: Andrea Del Bene > Nested forms / parent FormComponents do not reflect updated model when nested > form submitted > > > Key: WICKET-6041 > URL: https://issues.apache.org/jira/browse/WICKET-6041 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.21.0, 7.1.0 >Reporter: Patrick Davids >Assignee: Andrea Del Bene > Attachments: NonReflectingFormComponent.zip > > > Hi, > as discussed in user-list, here the ticket and quickstart attached. > I guess the quickstart looks quite unusual, because it is reduced to its > minimum to show what happens. > The use-case of such an nested form component tree is more clearer when > considering the usage in wizards, which holds its own form to be able to do > step-transitions. > In combination with dialogs (e.g. wicket-jquery-ui / greetings to [~sebfz1] > by the way), which also needed a form to work, you will get such a nested > form situation. > kind regards > Patrick -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6028) Detach called on enclosure component while it had a non-empty queue
[ https://issues.apache.org/jira/browse/WICKET-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6028: Fix Version/s: 8.0.0-M1 7.2.0 > Detach called on enclosure component while it had a non-empty queue > --- > > Key: WICKET-6028 > URL: https://issues.apache.org/jira/browse/WICKET-6028 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0 >Reporter: Roland Foerther >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > Attachments: BasePage.html, BasePage.java, EnclosurePage.html, > EnclosurePage.java, WICKET-6028.patch, myproject.tar.gz, stacktrace.txt > > > In the attached example EnclosurePage is extended from BasePage. In BasePage > there is a TransparentWebmarkupContainer attached to > The page is rendered, but a stacktrace "Error detaching RequestHandler" is > logged (see stacktrace.txt). > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6178) MetaDataHeaderItem # generateString() should return specials characters escaped like StringEscapeUtils.escapeHtml(s) does
[ https://issues.apache.org/jira/browse/WICKET-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6178: Fix Version/s: 6.24.0 8.0.0 8.0.0-M1 > MetaDataHeaderItem # generateString() should return specials characters > escaped like StringEscapeUtils.escapeHtml(s) does > - > > Key: WICKET-6178 > URL: https://issues.apache.org/jira/browse/WICKET-6178 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 7.3.0, 6.23.0 >Reporter: francois >Assignee: Andrea Del Bene >Priority: Minor > Fix For: 8.0.0-M1, 8.0.0, 6.24.0 > > > I think MetaDataHeaderItem # generateString() should return specials > characters escaped like > StringEscapeUtils.escapeHtml(s) does. > Apache Wicket 7.3.0 - MetaDataHeaderItem - Line 126 : > append(JavaScriptUtils.escapeQuotes(value.toString())) > return qwerty'qwerty as qwerty\’qwerty > I would like the return to be qwerty'qwerty (for example for the metatag > description). > Martin's answer : > Looking at > https://github.com/apache/wicket/blob/39fb20b112e2005dab8e17667e5a763b1d89f18e/wicket-core/src/main/java/org/apache/wicket/markup/head/MetaDataHeaderItem.java#L125-L127 > I agree that only double quotes should be escaped because only double > quotes may end prematurely the value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)