zeppelin git commit: [HOTFIX][ZEPPELIN-2294]. Interpreter fail exception is not propagated to frontend
Repository: zeppelin
Updated Branches:
refs/heads/branch-0.7 ab15bad6f -> ddf237805
[HOTFIX][ZEPPELIN-2294]. Interpreter fail exception is not propagated to
frontend
### What is this PR for?
This PR would address the issue of Interpreter fail exception is not propagated
to frontend. This is due to the bug fix of restarting button issue. Make
referenceCount as number of sessions attached to this process. Open and close
all the interpreters in one session together. I don't think there's scenario
for close a single interpreter for now.
### What type of PR is it?
[Bug Fix | Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2294
### How should this be tested?
I don't have time to write test, just verify zombie process issue manually in
the following scenario
* Per User + Isolated
* Per Note + Isolated
* Per User + Scoped
* Per Note + Scoped
### Screenshots (if appropriate)
Before
After
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jeff Zhang
Closes #2175 from zjffdu/ZEPPELIN-2294 and squashes the following commits:
a3f8aa0b [Jeff Zhang] [ZEPPELIN-2294]. Interpreter fail exception is not
propagated to frontend
(cherry picked from commit 0aea2416dc60fb6e2e181ee1c593d9d2c575bcb7)
Signed-off-by: Jongyoul Lee
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/ddf23780
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/ddf23780
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/ddf23780
Branch: refs/heads/branch-0.7
Commit: ddf237805ff697a817c0ae4659fdfe87541fa947
Parents: ab15bad
Author: Jeff Zhang
Authored: Wed Mar 22 15:19:42 2017 +0800
Committer: Jongyoul Lee
Committed: Thu Mar 23 22:56:37 2017 +0900
--
.../zeppelin/interpreter/InterpreterGroup.java | 1 +
.../interpreter/LazyOpenInterpreter.java| 13 ++
.../interpreter/remote/RemoteInterpreter.java | 48 ++--
.../remote/RemoteInterpreterProcess.java| 2 +
.../remote/RemoteInterpreterTest.java | 6 +--
.../interpreter/InterpreterSetting.java | 18
.../interpreter/InterpreterSettingManager.java | 1 -
7 files changed, 55 insertions(+), 34 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/ddf23780/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterGroup.java
--
diff --git
a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterGroup.java
b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterGroup.java
index 7367588..5cbab6b 100644
---
a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterGroup.java
+++
b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterGroup.java
@@ -182,6 +182,7 @@ public class InterpreterGroup extends
ConcurrentHashMap interpreterGroupRef,
final String processKey, final String sessionKey) {
+LOGGER.info("Close interpreter group " + getId() + " for session: " +
sessionKey);
close(interpreterGroupRef, processKey, sessionKey, this.get(sessionKey));
}
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/ddf23780/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/LazyOpenInterpreter.java
--
diff --git
a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/LazyOpenInterpreter.java
b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/LazyOpenInterpreter.java
index 0340632..ad85ded 100644
---
a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/LazyOpenInterpreter.java
+++
b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/LazyOpenInterpreter.java
@@ -75,11 +75,11 @@ public class LazyOpenInterpreter
@Override
public void close() {
-// TODO(jl): Remove this trick!!
-// intp.close() should be called to reduce referenceCount
-if (isOpen() || intp instanceof RemoteInterpreter) {
- intp.close();
- opened = false;
+synchronized (intp) {
+ if (opened == true) {
+intp.close();
+opened = false;
+ }
}
}
@@ -103,9 +103,6 @@ public class LazyOpenInterpreter
@Override
public FormType getFormType() {
-// RemoteInterpreter's this method calls init() internally, and wh
zeppelin git commit: [HOTFIX][ZEPPELIN-2294]. Interpreter fail exception is not propagated to frontend
Repository: zeppelin
Updated Branches:
refs/heads/master 9d40013a9 -> 0aea2416d
[HOTFIX][ZEPPELIN-2294]. Interpreter fail exception is not propagated to
frontend
### What is this PR for?
This PR would address the issue of Interpreter fail exception is not propagated
to frontend. This is due to the bug fix of restarting button issue. Make
referenceCount as number of sessions attached to this process. Open and close
all the interpreters in one session together. I don't think there's scenario
for close a single interpreter for now.
### What type of PR is it?
[Bug Fix | Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2294
### How should this be tested?
I don't have time to write test, just verify zombie process issue manually in
the following scenario
* Per User + Isolated
* Per Note + Isolated
* Per User + Scoped
* Per Note + Scoped
### Screenshots (if appropriate)
Before
After
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jeff Zhang
Closes #2175 from zjffdu/ZEPPELIN-2294 and squashes the following commits:
a3f8aa0b [Jeff Zhang] [ZEPPELIN-2294]. Interpreter fail exception is not
propagated to frontend
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/0aea2416
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/0aea2416
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/0aea2416
Branch: refs/heads/master
Commit: 0aea2416dc60fb6e2e181ee1c593d9d2c575bcb7
Parents: 9d40013
Author: Jeff Zhang
Authored: Wed Mar 22 15:19:42 2017 +0800
Committer: Jongyoul Lee
Committed: Thu Mar 23 22:56:24 2017 +0900
--
.../zeppelin/interpreter/InterpreterGroup.java | 1 +
.../interpreter/LazyOpenInterpreter.java| 13 ++
.../interpreter/remote/RemoteInterpreter.java | 48 ++--
.../remote/RemoteInterpreterProcess.java| 2 +
.../remote/RemoteInterpreterTest.java | 6 +--
.../interpreter/InterpreterSetting.java | 18
.../interpreter/InterpreterSettingManager.java | 1 -
7 files changed, 55 insertions(+), 34 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/0aea2416/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterGroup.java
--
diff --git
a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterGroup.java
b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterGroup.java
index 7367588..5cbab6b 100644
---
a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterGroup.java
+++
b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterGroup.java
@@ -182,6 +182,7 @@ public class InterpreterGroup extends
ConcurrentHashMap interpreterGroupRef,
final String processKey, final String sessionKey) {
+LOGGER.info("Close interpreter group " + getId() + " for session: " +
sessionKey);
close(interpreterGroupRef, processKey, sessionKey, this.get(sessionKey));
}
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/0aea2416/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/LazyOpenInterpreter.java
--
diff --git
a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/LazyOpenInterpreter.java
b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/LazyOpenInterpreter.java
index 0340632..ad85ded 100644
---
a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/LazyOpenInterpreter.java
+++
b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/LazyOpenInterpreter.java
@@ -75,11 +75,11 @@ public class LazyOpenInterpreter
@Override
public void close() {
-// TODO(jl): Remove this trick!!
-// intp.close() should be called to reduce referenceCount
-if (isOpen() || intp instanceof RemoteInterpreter) {
- intp.close();
- opened = false;
+synchronized (intp) {
+ if (opened == true) {
+intp.close();
+opened = false;
+ }
}
}
@@ -103,9 +103,6 @@ public class LazyOpenInterpreter
@Override
public FormType getFormType() {
-// RemoteInterpreter's this method calls init() internally, and which
cause to increase the
-// number of referenceCount and it affects incorrectly
-open();
re
[2/2] zeppelin git commit: Preparing development version 0.7.2-SNAPSHOT
Preparing development version 0.7.2-SNAPSHOT Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/94474b5f Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/94474b5f Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/94474b5f Branch: refs/heads/branch-0.7 Commit: 94474b5f32ec1db4987ca0d84891a41b882ba162 Parents: 163f673 Author: Mina Lee Authored: Fri Mar 24 10:42:21 2017 +0900 Committer: Mina Lee Committed: Fri Mar 24 10:42:21 2017 +0900 -- alluxio/pom.xml | 4 ++-- angular/pom.xml | 4 ++-- beam/pom.xml | 4 ++-- bigquery/pom.xml | 4 ++-- cassandra/pom.xml| 4 ++-- elasticsearch/pom.xml| 4 ++-- file/pom.xml | 4 ++-- flink/pom.xml| 4 ++-- geode/pom.xml| 4 ++-- hbase/pom.xml| 4 ++-- helium-dev/pom.xml | 4 ++-- ignite/pom.xml | 4 ++-- jdbc/pom.xml | 4 ++-- kylin/pom.xml| 4 ++-- lens/pom.xml | 4 ++-- livy/pom.xml | 4 ++-- markdown/pom.xml | 4 ++-- pig/pom.xml | 4 ++-- pom.xml | 2 +- postgresql/pom.xml | 4 ++-- python/pom.xml | 4 ++-- r/pom.xml| 2 +- scalding/pom.xml | 4 ++-- scio/pom.xml | 4 ++-- shell/pom.xml| 4 ++-- spark-dependencies/pom.xml | 4 ++-- spark/pom.xml| 4 ++-- zeppelin-display/pom.xml | 4 ++-- zeppelin-distribution/pom.xml| 2 +- zeppelin-examples/pom.xml| 4 ++-- zeppelin-examples/zeppelin-example-clock/pom.xml | 4 ++-- .../zeppelin-example-clock/zeppelin-example-clock.json | 2 +- zeppelin-examples/zeppelin-example-horizontalbar/pom.xml | 4 ++-- zeppelin-interpreter/pom.xml | 4 ++-- zeppelin-server/pom.xml | 4 ++-- zeppelin-web/pom.xml | 4 ++-- zeppelin-web/src/app/tabledata/package.json | 2 +- zeppelin-web/src/app/visualization/package.json | 2 +- zeppelin-zengine/pom.xml | 4 ++-- 39 files changed, 72 insertions(+), 72 deletions(-) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/94474b5f/alluxio/pom.xml -- diff --git a/alluxio/pom.xml b/alluxio/pom.xml index bed29a8..b862aa6 100644 --- a/alluxio/pom.xml +++ b/alluxio/pom.xml @@ -22,14 +22,14 @@ zeppelin org.apache.zeppelin -0.7.1 +0.7.2-SNAPSHOT .. org.apache.zeppelin zeppelin-alluxio jar -0.7.1 +0.7.2-SNAPSHOT Zeppelin: Alluxio interpreter http://git-wip-us.apache.org/repos/asf/zeppelin/blob/94474b5f/angular/pom.xml -- diff --git a/angular/pom.xml b/angular/pom.xml index 36ddc4d..3ceb564 100644 --- a/angular/pom.xml +++ b/angular/pom.xml @@ -22,14 +22,14 @@ zeppelin org.apache.zeppelin -0.7.1 +0.7.2-SNAPSHOT .. org.apache.zeppelin zeppelin-angular jar - 0.7.1 + 0.7.2-SNAPSHOT Zeppelin: Angular interpreter http://git-wip-us.apache.org/repos/asf/zeppelin/blob/94474b5f/beam/pom.xml -- diff --git a/beam/pom.xml b/beam/pom.xml index 943b92c..f4ca076 100644 --- a/beam/pom.xml +++ b/beam/pom.xml @@ -22,14 +22,14 @@ zeppelin org.apache.zeppelin -0
[zeppelin] Git Push Summary
Repository: zeppelin Updated Tags: refs/tags/v0.7.1-rc2 [created] 163f6730e
[1/2] zeppelin git commit: Preparing Apache Zeppelin release 0.7.1
Repository: zeppelin Updated Branches: refs/heads/branch-0.7 ddf237805 -> 94474b5f3 Preparing Apache Zeppelin release 0.7.1 Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/163f6730 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/163f6730 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/163f6730 Branch: refs/heads/branch-0.7 Commit: 163f6730ea91486c581f502863fe62b3cd9b06d4 Parents: ddf2378 Author: Mina Lee Authored: Fri Mar 24 10:42:16 2017 +0900 Committer: Mina Lee Committed: Fri Mar 24 10:42:16 2017 +0900 -- alluxio/pom.xml | 4 ++-- angular/pom.xml | 4 ++-- beam/pom.xml | 4 ++-- bigquery/pom.xml | 4 ++-- cassandra/pom.xml| 4 ++-- elasticsearch/pom.xml| 4 ++-- file/pom.xml | 4 ++-- flink/pom.xml| 4 ++-- geode/pom.xml| 4 ++-- hbase/pom.xml| 4 ++-- helium-dev/pom.xml | 4 ++-- ignite/pom.xml | 4 ++-- jdbc/pom.xml | 4 ++-- kylin/pom.xml| 4 ++-- lens/pom.xml | 4 ++-- livy/pom.xml | 4 ++-- markdown/pom.xml | 4 ++-- pig/pom.xml | 4 ++-- pom.xml | 2 +- postgresql/pom.xml | 4 ++-- python/pom.xml | 4 ++-- r/pom.xml| 2 +- scalding/pom.xml | 4 ++-- scio/pom.xml | 4 ++-- shell/pom.xml| 4 ++-- spark-dependencies/pom.xml | 4 ++-- spark/pom.xml| 4 ++-- zeppelin-display/pom.xml | 4 ++-- zeppelin-distribution/pom.xml| 2 +- zeppelin-examples/pom.xml| 4 ++-- zeppelin-examples/zeppelin-example-clock/pom.xml | 4 ++-- .../zeppelin-example-clock/zeppelin-example-clock.json | 2 +- zeppelin-examples/zeppelin-example-horizontalbar/pom.xml | 4 ++-- zeppelin-interpreter/pom.xml | 4 ++-- zeppelin-server/pom.xml | 4 ++-- zeppelin-web/pom.xml | 4 ++-- zeppelin-web/src/app/tabledata/package.json | 2 +- zeppelin-web/src/app/visualization/package.json | 2 +- zeppelin-zengine/pom.xml | 4 ++-- 39 files changed, 72 insertions(+), 72 deletions(-) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/163f6730/alluxio/pom.xml -- diff --git a/alluxio/pom.xml b/alluxio/pom.xml index b862aa6..bed29a8 100644 --- a/alluxio/pom.xml +++ b/alluxio/pom.xml @@ -22,14 +22,14 @@ zeppelin org.apache.zeppelin -0.7.2-SNAPSHOT +0.7.1 .. org.apache.zeppelin zeppelin-alluxio jar -0.7.2-SNAPSHOT +0.7.1 Zeppelin: Alluxio interpreter http://git-wip-us.apache.org/repos/asf/zeppelin/blob/163f6730/angular/pom.xml -- diff --git a/angular/pom.xml b/angular/pom.xml index 3ceb564..36ddc4d 100644 --- a/angular/pom.xml +++ b/angular/pom.xml @@ -22,14 +22,14 @@ zeppelin org.apache.zeppelin -0.7.2-SNAPSHOT +0.7.1 .. org.apache.zeppelin zeppelin-angular jar - 0.7.2-SNAPSHOT + 0.7.1 Zeppelin: Angular interpreter http://git-wip-us.apache.org/repos/asf/zeppelin/blob/163f6730/beam/pom.xml -- diff --git a/beam/pom.xml b/beam/pom.xml index f4ca076..943b92c 100644 --- a/beam/pom.xml +++ b
svn commit: r18885 - /dev/zeppelin/zeppelin-0.7.1-rc2/
Author: minalee Date: Fri Mar 24 02:31:02 2017 New Revision: 18885 Log: Upload zeppelin-0.7.1-rc2 Added: dev/zeppelin/zeppelin-0.7.1-rc2/ dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz (with props) dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz.asc dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz.md5 dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz.sha512 dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-netinst.tgz (with props) dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-netinst.tgz.asc dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-netinst.tgz.md5 dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-netinst.tgz.sha512 dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1.tgz (with props) dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1.tgz.asc dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1.tgz.md5 dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1.tgz.sha512 Added: dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz == Binary file - no diff available. Propchange: dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz -- svn:mime-type = application/octet-stream Added: dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz.asc == --- dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz.asc (added) +++ dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz.asc Fri Mar 24 02:31:02 2017 @@ -0,0 +1,11 @@ +-BEGIN PGP SIGNATURE- + +iQEzBAABCAAdFiEEoiUpCBwcv0n4DKCJVRP5wdxy3V8FAljUfIwACgkQVRP5wdxy +3V+vWwgAu9GiThUUALSjuxu6eoe63KKgniZJReBWju2XkEBBNmXGdrS4WkZ/nf3x +bvc3TEdg5KkIEdJMeZi8TrTUAU7KbBQ7piM/alvwjwsJ0Zfz4SAzIN5zsVjUAbIe +fwDxq51hvRcQfDvF8nVGNQLXjxNX9iH77eJOS1h0pyztcOlo0v15ZstrxiCNkCUT +cBfJBV/3HP9izuB2HxLOHTM6AeBoW9ThhJjETvNftUckS6O65bxPJdIEAuzXhsbZ +YM/VpNSUsVUHjp44Nh8iSU2VtTs0n4WviHIB3j3R2yiyANapmQYwvnkgSLKs29+U +Ek/Z7M6TfkXZq0LBH89TItCGehqNCw== +=lf4G +-END PGP SIGNATURE- Added: dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz.md5 == --- dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz.md5 (added) +++ dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz.md5 Fri Mar 24 02:31:02 2017 @@ -0,0 +1 @@ +zeppelin-0.7.1-bin-all.tgz: 7D 92 D9 F0 48 8A 53 CD 58 32 63 23 37 6C 97 69 Added: dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz.sha512 == --- dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz.sha512 (added) +++ dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-all.tgz.sha512 Fri Mar 24 02:31:02 2017 @@ -0,0 +1 @@ +f31214fc72debf360fcf8d0aed47bf6b432d0a9cbc97537214fe46d4c58ec2a113b715bf05bb33a3f0218444f6f6f6484192bd68ddece4f87f1c55b2cb7230f0 zeppelin-0.7.1-bin-all.tgz Added: dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-netinst.tgz == Binary file - no diff available. Propchange: dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-netinst.tgz -- svn:mime-type = application/octet-stream Added: dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-netinst.tgz.asc == --- dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-netinst.tgz.asc (added) +++ dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-netinst.tgz.asc Fri Mar 24 02:31:02 2017 @@ -0,0 +1,11 @@ +-BEGIN PGP SIGNATURE- + +iQEzBAABCAAdFiEEoiUpCBwcv0n4DKCJVRP5wdxy3V8FAljUfb4ACgkQVRP5wdxy +3V92/gf/Rf9RCOi5QkeQD/lsLnJ3gRt7KZT6UMXcQUj8pbk1RF9pbvrOKue5t31c +OEahZ+eAuJ9iWXhzjye/yC+5tm+wsCZuU5Aa+ioR32b/2wly9LuacsdyrLoLdqKY +7Ir6mWBaI6ZEuA22hJ666xgi0d5mMwmvkHk61Sw8RB8KtClAYtHc9zYtUM1Z/75t +uWagL0h6NYH2Jt6gXcHYybGIvKd4RNdAbehHDLoBTeKkbVvZDauhsmSpaNN5F3El +QF9A2yYuDdGJpX5Yn2v9uXgXupPLG/GQnT6/X/NROo0V2qfuOwyWivnAdGebE/H+ +0NAnUQFMN+ZNFACbWliPjgULDnrpQw== +=DvSe +-END PGP SIGNATURE- Added: dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-netinst.tgz.md5 == --- dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-netinst.tgz.md5 (added) +++ dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-netinst.tgz.md5 Fri Mar 24 02:31:02 2017 @@ -0,0 +1 @@ +zeppelin-0.7.1-bin-netinst.tgz: D1 B8 6B A7 9D 67 AB 49 BC 7C 35 3C 01 82 FB 98 Added: dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-netinst.tgz.sha512 == --- dev/zeppelin/zeppelin-0.7.1-rc2/zeppelin-0.7.1-bin-netinst.tgz.sha512 (added) +++ dev/z
zeppelin git commit: [ZEPPELIN-2243] Use uppercase for shortcut description
Repository: zeppelin
Updated Branches:
refs/heads/master 0aea2416d -> 5d9083ed3
[ZEPPELIN-2243] Use uppercase for shortcut description
### What is this PR for?
Use uppercase for keyboard shortcut description so that user can recognize
shortcuts easily.
it's hard to understand for some shortcuts since we used lowercases. For
example, `Ctrl+Option+l` (actually this `L`, not `I`)
I attached screenshots.
### What type of PR is it?
[Improvement]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2243](https://issues.apache.org/jira/browse/ZEPPELIN-2243)
### How should this be tested?
1. Open the paragraph shortcut panel.
2. Open the note shortcut dialog.
### Screenshots (if appropriate)
Before
https://cloud.githubusercontent.com/assets/4968473/23786191/fb3dafe8-05ae-11e7-8e1e-36b5f151070f.png";>
After
https://cloud.githubusercontent.com/assets/4968473/23786194/fe59b1e0-05ae-11e7-9741-371f8e3f77de.png";>
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
Author: 1ambda <1am...@gmail.com>
Closes #2119 from
1ambda/ZEPPELIN-2243/use-uppercase-for-keyboard-shortcut-description and
squashes the following commits:
9bd868a [1ambda] fix: Remove white spaces
6a163d6 [1ambda] fix: ParagraphActionsIT
5366743 [1ambda] fix: Use uppercase for shortcut desc
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/5d9083ed
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/5d9083ed
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/5d9083ed
Branch: refs/heads/master
Commit: 5d9083ed3aeef18b12c25dfcf23a41064b98fd8f
Parents: 0aea241
Author: 1ambda <1am...@gmail.com>
Authored: Thu Mar 16 05:00:20 2017 +0900
Committer: ahyoungryu
Committed: Fri Mar 24 12:31:14 2017 +0900
--
.../integration/ParagraphActionsIT.java | 8 ++--
.../notebook/paragraph/paragraph-control.html | 30 +++---
.../modal-shortcut/modal-shortcut.html | 42 ++--
3 files changed, 40 insertions(+), 40 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/5d9083ed/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
--
diff --git
a/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
b/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
index 0507767..1577eca 100644
---
a/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
+++
b/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
@@ -372,7 +372,7 @@ public class ParagraphActionsIT extends AbstractZeppelinIT {
driver.findElement(By.xpath(xpathToShowTitle)).getText(),
CoreMatchers.allOf(CoreMatchers.startsWith("Show title"),
CoreMatchers.containsString("Ctrl+"),
CoreMatchers.anyOf(CoreMatchers.containsString("Option"),
CoreMatchers.containsString("Alt")),
- CoreMatchers.containsString("+t")));
+ CoreMatchers.containsString("+T")));
clickAndWait(By.xpath(xpathToShowTitle));
collector.checkThat("After Show Title : The title field contains",
@@ -384,7 +384,7 @@ public class ParagraphActionsIT extends AbstractZeppelinIT {
driver.findElement(By.xpath(xpathToHideTitle)).getText(),
CoreMatchers.allOf(CoreMatchers.startsWith("Hide title"),
CoreMatchers.containsString("Ctrl+"),
CoreMatchers.anyOf(CoreMatchers.containsString("Option"),
CoreMatchers.containsString("Alt")),
- CoreMatchers.containsString("+t")));
+ CoreMatchers.containsString("+T")));
clickAndWait(By.xpath(xpathToHideTitle));
ZeppelinITUtils.turnOffImplicitWaits(driver);
@@ -438,7 +438,7 @@ public class ParagraphActionsIT extends AbstractZeppelinIT {
driver.findElement(By.xpath(xpathToShowLineNumberButton)).getText(),
CoreMatchers.allOf(CoreMatchers.startsWith("Show line numbers"),
CoreMatchers.containsString("Ctrl+"),
CoreMatchers.anyOf(CoreMatchers.containsString("Option"),
CoreMatchers.containsString("Alt")),
- CoreMatchers.containsString("+m")));
+ CoreMatchers.containsString("+M")));
clickAndWait(By.xpath(xpathToShowLineNumberButton));
@@ -451,7 +451,7 @@ public class ParagraphActionsIT extends AbstractZeppelinIT {
driver.findElement(By.xpath(xpathToHideLineNumberButton)).getText(),
CoreMatchers.allOf(CoreMatchers.startsWith("Hide line numbers"),
CoreMatchers.containsString("Ctrl+"),
CoreMatchers.anyOf(CoreMatchers.containsString("Optio
zeppelin git commit: [ZEPPELIN-2243] Use uppercase for shortcut description
Repository: zeppelin
Updated Branches:
refs/heads/branch-0.7 94474b5f3 -> b50340eca
[ZEPPELIN-2243] Use uppercase for shortcut description
### What is this PR for?
Use uppercase for keyboard shortcut description so that user can recognize
shortcuts easily.
it's hard to understand for some shortcuts since we used lowercases. For
example, `Ctrl+Option+l` (actually this `L`, not `I`)
I attached screenshots.
### What type of PR is it?
[Improvement]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2243](https://issues.apache.org/jira/browse/ZEPPELIN-2243)
### How should this be tested?
1. Open the paragraph shortcut panel.
2. Open the note shortcut dialog.
### Screenshots (if appropriate)
Before
https://cloud.githubusercontent.com/assets/4968473/23786191/fb3dafe8-05ae-11e7-8e1e-36b5f151070f.png";>
After
https://cloud.githubusercontent.com/assets/4968473/23786194/fe59b1e0-05ae-11e7-9741-371f8e3f77de.png";>
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
Author: 1ambda <1am...@gmail.com>
Closes #2119 from
1ambda/ZEPPELIN-2243/use-uppercase-for-keyboard-shortcut-description and
squashes the following commits:
9bd868a [1ambda] fix: Remove white spaces
6a163d6 [1ambda] fix: ParagraphActionsIT
5366743 [1ambda] fix: Use uppercase for shortcut desc
(cherry picked from commit 5d9083ed3aeef18b12c25dfcf23a41064b98fd8f)
Signed-off-by: ahyoungryu
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/b50340ec
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/b50340ec
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/b50340ec
Branch: refs/heads/branch-0.7
Commit: b50340eca5744e89e28f323ef6619279c960be13
Parents: 94474b5
Author: 1ambda <1am...@gmail.com>
Authored: Thu Mar 16 05:00:20 2017 +0900
Committer: ahyoungryu
Committed: Fri Mar 24 12:31:28 2017 +0900
--
.../integration/ParagraphActionsIT.java | 8 ++--
.../notebook/paragraph/paragraph-control.html | 30 +++---
.../modal-shortcut/modal-shortcut.html | 42 ++--
3 files changed, 40 insertions(+), 40 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/b50340ec/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
--
diff --git
a/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
b/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
index d5b4609..dac9028 100644
---
a/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
+++
b/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
@@ -373,7 +373,7 @@ public class ParagraphActionsIT extends AbstractZeppelinIT {
driver.findElement(By.xpath(xpathToShowTitle)).getText(),
CoreMatchers.allOf(CoreMatchers.startsWith("Show title"),
CoreMatchers.containsString("Ctrl+"),
CoreMatchers.anyOf(CoreMatchers.containsString("Option"),
CoreMatchers.containsString("Alt")),
- CoreMatchers.containsString("+t")));
+ CoreMatchers.containsString("+T")));
clickAndWait(By.xpath(xpathToShowTitle));
collector.checkThat("After Show Title : The title field contains",
@@ -385,7 +385,7 @@ public class ParagraphActionsIT extends AbstractZeppelinIT {
driver.findElement(By.xpath(xpathToHideTitle)).getText(),
CoreMatchers.allOf(CoreMatchers.startsWith("Hide title"),
CoreMatchers.containsString("Ctrl+"),
CoreMatchers.anyOf(CoreMatchers.containsString("Option"),
CoreMatchers.containsString("Alt")),
- CoreMatchers.containsString("+t")));
+ CoreMatchers.containsString("+T")));
clickAndWait(By.xpath(xpathToHideTitle));
ZeppelinITUtils.turnOffImplicitWaits(driver);
@@ -439,7 +439,7 @@ public class ParagraphActionsIT extends AbstractZeppelinIT {
driver.findElement(By.xpath(xpathToShowLineNumberButton)).getText(),
CoreMatchers.allOf(CoreMatchers.startsWith("Show line numbers"),
CoreMatchers.containsString("Ctrl+"),
CoreMatchers.anyOf(CoreMatchers.containsString("Option"),
CoreMatchers.containsString("Alt")),
- CoreMatchers.containsString("+m")));
+ CoreMatchers.containsString("+M")));
clickAndWait(By.xpath(xpathToShowLineNumberButton));
@@ -452,7 +452,7 @@ public class ParagraphActionsIT extends AbstractZeppelinIT {
driver.findElement(By.xpath(xpathToHideLineNumberButton)).getText(),
CoreMatchers.allOf(CoreMatchers.startsWith("Hide line numbers"),
C
zeppelin git commit: [ZEPPELIN-2267] Improve Helium Enable / Disable Dialogs
Repository: zeppelin
Updated Branches:
refs/heads/master 5d9083ed3 -> 3ac44b11e
[ZEPPELIN-2267] Improve Helium Enable / Disable Dialogs
### What is this PR for?
Improved Helium Enable / Disable Dialogs to
- include more detailed info for enable dialog
- include more concise info for disable dialog
- use dialog title as well just instead of message
- link to doc if `type === SPELL || type === VISUALIZATION`
- parse `description` and `license` as HTML
I attached screenshots for comparison.
### What type of PR is it?
[Improvement]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2267](https://issues.apache.org/jira/browse/ZEPPELIN-2267)
### How should this be tested?
1. Test with local, online helium packages.
2. In case of local package modify description and license text to test HTML
parsing like
```
"description": "The Ultimate Line Chart for Apache Zeppelin using https://www.amcharts.com\";>amcharts",
"license": "https://www.amcharts.com/licenses/javascript-charts-free-license\";>Amcharts
License"
```
### Screenshots (if appropriate)
Before: enable dialog
https://cloud.githubusercontent.com/assets/4968473/23984205/a45babf6-0a5b-11e7-934d-83d6ed31c5eb.png";>
After: enable dialog
https://cloud.githubusercontent.com/assets/4968473/23984234/c98335ca-0a5b-11e7-9b72-810fda629635.png";>
Before: disable dialog
https://cloud.githubusercontent.com/assets/4968473/23984232/c65ed642-0a5b-11e7-8f67-a4ce2c5378f8.png";>
After: disable dialog
https://cloud.githubusercontent.com/assets/4968473/23984226/bb0fcfd0-0a5b-11e7-9afb-2326c2f6b778.png";>
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
Author: 1ambda <1am...@gmail.com>
Closes #2144 from 1ambda/ZEPPELIN-2267/improve-helium-dialog and squashes the
following commits:
053abbe [1ambda] fix: Link current version doc
bc0ba52 [1ambda] fix: lint errors
7bb9614 [1ambda] feat: Improve helium disable dialog
cf9ee42 [1ambda] feat: Improve heloium enable dialog
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/3ac44b11
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/3ac44b11
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/3ac44b11
Branch: refs/heads/master
Commit: 3ac44b11e0d5f499d8f44936c96bfa70e231c24e
Parents: 5d9083e
Author: 1ambda <1am...@gmail.com>
Authored: Wed Mar 22 21:13:23 2017 +0900
Committer: ahyoungryu
Committed: Fri Mar 24 13:33:13 2017 +0900
--
.../src/app/helium/helium.controller.js | 60 +---
zeppelin-web/src/app/helium/helium.html | 4 +-
2 files changed, 41 insertions(+), 23 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/3ac44b11/zeppelin-web/src/app/helium/helium.controller.js
--
diff --git a/zeppelin-web/src/app/helium/helium.controller.js
b/zeppelin-web/src/app/helium/helium.controller.js
index 1130075..0565ec1 100644
--- a/zeppelin-web/src/app/helium/helium.controller.js
+++ b/zeppelin-web/src/app/helium/helium.controller.js
@@ -149,37 +149,55 @@ export default function HeliumCtrl($scope, $rootScope,
$sce,
return license;
}
- $scope.enable = function(name, artifact, type, groupId) {
+ const getHeliumTypeText = function(type) {
+if (type === HeliumType.VISUALIZATION) {
+ return `https://zeppelin.apache.org/docs/${$rootScope.zeppelinVersion}/development/writingzeppelinvisualization.html";>${type}`;
// eslint-disable-line max-len
+} else if (type === HeliumType.SPELL) {
+ return `https://zeppelin.apache.org/docs/${$rootScope.zeppelinVersion}/development/writingzeppelinspell.html";>${type}`;
// eslint-disable-line max-len
+} else {
+ return type;
+}
+ }
+
+ $scope.enable = function(name, artifact, type, groupId, description) {
var license = getLicense(name, artifact);
var mavenArtifactInfoToHTML = groupId +':'+ artifact.split('@')[0] + ':' +
artifact.split('@')[1];
var zeppelinVersion = $rootScope.zeppelinVersion;
var url = 'https://zeppelin.apache.org/docs/' + zeppelinVersion +
'/manual/interpreterinstallation.html';
-
+
var confirm = ''
-if (type === 'INTERPRETER') {
-confirm = BootstrapDialog.show({
- title: '',
- message: 'Below command will download maven artifact ' +
- '' +
+if (type === HeliumType.INTERPRETER) {
+ confirm = BootstrapDialog.show({
+title: '',
+message: 'Below command will download maven artifact ' +
+'' +
mavenArtifactInfoToHTML + '' +
- ' and all of its transitive dependencies into
interpreter/interpreter-name directory.' +
- '' +
- './bin/install-interpreter.s
zeppelin git commit: [ZEPPELIN-1720] Adding tests to verify behaviour of dynamic forms
Repository: zeppelin
Updated Branches:
refs/heads/branch-0.7 b50340eca -> 53e905786
[ZEPPELIN-1720] Adding tests to verify behaviour of dynamic forms
### What is this PR for?
Adding Selenium tests to ensure proper behaviour of dynamic forms.
### What type of PR is it?
Test
### Todos
N/A
### What is the Jira issue?
[ZEPPELIN-1720](https://issues.apache.org/jira/browse/ZEPPELIN-1720)
### How should this be tested?
1. Once should first get Firefox v. 41 as it is the latest version that works
with the current version of Selenium in Apache Zeppelin.
2. You can then run the tests with following command:
`TEST_SELENIUM="true" mvn package -DfailIfNoTests=false -pl
'zeppelin-interpreter,zeppelin-zengine,zeppelin-server'
-Dtest=ParagraphActionsIT
`
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Guillermo Cabrera
Closes #2141 from guicaro/ZEPPELIN-1720-AddingTestsForDynamicForms and squashes
the following commits:
a5bc7db [Guillermo Cabrera] Updated tests to work with new paragraph behaviour
3fa2033 [Guillermo Cabrera] Updated testMultipleDynamicFormsSameType based on
new behaviour of paragraphs
92102bd [Guillermo Cabrera] Updated testSingleDynamicFormSelectForm for "Run on
selection change" option
f194979 [Guillermo Cabrera] Fixing other issues on test case messages for
readability
f7e99ca [Guillermo Cabrera] Corrected grammar in a test case output message
bc1e7f9 [Guillermo Cabrera] Removed unused import, alignment and removed
unnecesary condition in test case
274b2c1 [Guillermo Cabrera] Added tests that cover behaviour of dynamic forms
eed42f0 [Guillermo Cabrera] Completed and verified corrct behaviour of
testSingleDynamicFormTextInput
7a4f121 [Guillermo Cabrera] Added method stubbs for new UI tests checking
correct behaviour of dynamic forms
(cherry picked from commit f76ac8807eaf3a0875d859e4ef896b770b4df01a)
Signed-off-by: ahyoungryu
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/53e90578
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/53e90578
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/53e90578
Branch: refs/heads/branch-0.7
Commit: 53e90578621574f466a58ad02a6577bca6335a5a
Parents: b50340e
Author: Guillermo Cabrera
Authored: Mon Mar 20 16:00:52 2017 +0300
Committer: ahyoungryu
Committed: Fri Mar 24 13:35:17 2017 +0900
--
.../integration/ParagraphActionsIT.java | 161 ++-
1 file changed, 160 insertions(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/53e90578/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
--
diff --git
a/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
b/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
index dac9028..e826e23 100644
---
a/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
+++
b/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
@@ -513,4 +513,163 @@ public class ParagraphActionsIT extends
AbstractZeppelinIT {
handleException("Exception in ParagraphActionsIT while
testEditOnDoubleClick ", e);
}
}
-}
+
+ @Test
+ public void testSingleDynamicFormTextInput() throws Exception {
+if (!endToEndTestEnabled()) {
+ return;
+}
+try {
+ createNewNote();
+
+ setTextOfParagraph(1, "%spark println(\"Hello \"+z.input(\"name\",
\"world\")) ");
+
+ runParagraph(1);
+ waitForParagraph(1, "FINISHED");
+ collector.checkThat("Output text is equal to value specified initially",
+ driver.findElement(By.xpath(getParagraphXPath(1) +
"//div[contains(@class, 'text plainTextContent')]")).getText(),
+ CoreMatchers.equalTo("Hello world"));
+
+ driver.findElement(By.xpath(getParagraphXPath(1) + "//input")).clear();
+ driver.findElement(By.xpath(getParagraphXPath(1) +
"//input")).sendKeys("Zeppelin");
+
+ collector.checkThat("After new data in text input form, output should
not be changed",
+ driver.findElement(By.xpath(getParagraphXPath(1) +
"//div[contains(@class, 'text plainTextContent')]")).getText(),
+ CoreMatchers.equalTo("Hello world"));
+
+ runParagraph(1);
+ waitForParagraph(1, "FINISHED");
+ collector.checkThat("Only after running the paragraph, we can see the
newly updated output",
+ driver.findElement(By.xpath(getParagraphXPath(1) +
"//div[contains(@class, 'text plainTextContent')]")).getText(),
+ CoreMatchers.equalTo
zeppelin git commit: [ZEPPELIN-1720] Adding tests to verify behaviour of dynamic forms
Repository: zeppelin
Updated Branches:
refs/heads/master 3ac44b11e -> f76ac8807
[ZEPPELIN-1720] Adding tests to verify behaviour of dynamic forms
### What is this PR for?
Adding Selenium tests to ensure proper behaviour of dynamic forms.
### What type of PR is it?
Test
### Todos
N/A
### What is the Jira issue?
[ZEPPELIN-1720](https://issues.apache.org/jira/browse/ZEPPELIN-1720)
### How should this be tested?
1. Once should first get Firefox v. 41 as it is the latest version that works
with the current version of Selenium in Apache Zeppelin.
2. You can then run the tests with following command:
`TEST_SELENIUM="true" mvn package -DfailIfNoTests=false -pl
'zeppelin-interpreter,zeppelin-zengine,zeppelin-server'
-Dtest=ParagraphActionsIT
`
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Guillermo Cabrera
Closes #2141 from guicaro/ZEPPELIN-1720-AddingTestsForDynamicForms and squashes
the following commits:
a5bc7db [Guillermo Cabrera] Updated tests to work with new paragraph behaviour
3fa2033 [Guillermo Cabrera] Updated testMultipleDynamicFormsSameType based on
new behaviour of paragraphs
92102bd [Guillermo Cabrera] Updated testSingleDynamicFormSelectForm for "Run on
selection change" option
f194979 [Guillermo Cabrera] Fixing other issues on test case messages for
readability
f7e99ca [Guillermo Cabrera] Corrected grammar in a test case output message
bc1e7f9 [Guillermo Cabrera] Removed unused import, alignment and removed
unnecesary condition in test case
274b2c1 [Guillermo Cabrera] Added tests that cover behaviour of dynamic forms
eed42f0 [Guillermo Cabrera] Completed and verified corrct behaviour of
testSingleDynamicFormTextInput
7a4f121 [Guillermo Cabrera] Added method stubbs for new UI tests checking
correct behaviour of dynamic forms
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/f76ac880
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/f76ac880
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/f76ac880
Branch: refs/heads/master
Commit: f76ac8807eaf3a0875d859e4ef896b770b4df01a
Parents: 3ac44b1
Author: Guillermo Cabrera
Authored: Mon Mar 20 16:00:52 2017 +0300
Committer: ahyoungryu
Committed: Fri Mar 24 13:35:00 2017 +0900
--
.../integration/ParagraphActionsIT.java | 161 ++-
1 file changed, 160 insertions(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/f76ac880/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
--
diff --git
a/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
b/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
index 1577eca..e06b602 100644
---
a/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
+++
b/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
@@ -512,4 +512,163 @@ public class ParagraphActionsIT extends
AbstractZeppelinIT {
handleException("Exception in ParagraphActionsIT while
testEditOnDoubleClick ", e);
}
}
-}
+
+ @Test
+ public void testSingleDynamicFormTextInput() throws Exception {
+if (!endToEndTestEnabled()) {
+ return;
+}
+try {
+ createNewNote();
+
+ setTextOfParagraph(1, "%spark println(\"Hello \"+z.input(\"name\",
\"world\")) ");
+
+ runParagraph(1);
+ waitForParagraph(1, "FINISHED");
+ collector.checkThat("Output text is equal to value specified initially",
+ driver.findElement(By.xpath(getParagraphXPath(1) +
"//div[contains(@class, 'text plainTextContent')]")).getText(),
+ CoreMatchers.equalTo("Hello world"));
+
+ driver.findElement(By.xpath(getParagraphXPath(1) + "//input")).clear();
+ driver.findElement(By.xpath(getParagraphXPath(1) +
"//input")).sendKeys("Zeppelin");
+
+ collector.checkThat("After new data in text input form, output should
not be changed",
+ driver.findElement(By.xpath(getParagraphXPath(1) +
"//div[contains(@class, 'text plainTextContent')]")).getText(),
+ CoreMatchers.equalTo("Hello world"));
+
+ runParagraph(1);
+ waitForParagraph(1, "FINISHED");
+ collector.checkThat("Only after running the paragraph, we can see the
newly updated output",
+ driver.findElement(By.xpath(getParagraphXPath(1) +
"//div[contains(@class, 'text plainTextContent')]")).getText(),
+ CoreMatchers.equalTo("Hello Zeppelin"));
+
+ deleteTestNotebook(driver);
+
+} catch (Exception e) {
+ handleExc
