[jira] [Resolved] (HADOOP-7725) fix test-patch so that Jenkins can accept patches to the hadoop-tools module.

2012-09-22 Thread Harsh J (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J resolved HADOOP-7725.
-

   Resolution: Duplicate
Fix Version/s: (was: 0.24.0)

The hadoop-tools and others are all covered via HADOOP-8308 now. Marking as 
dupe of that.

Reopen if am incorrect.

 fix test-patch so that Jenkins can accept patches to the hadoop-tools module.
 -

 Key: HADOOP-7725
 URL: https://issues.apache.org/jira/browse/HADOOP-7725
 Project: Hadoop Common
  Issue Type: Improvement
  Components: build
Affects Versions: 0.23.0, 0.24.0
Reporter: Alejandro Abdelnur

 Basically, test-patch.sh needs some tinkering to recognize 
 hadoop-tools-project along-side common/mapreduce/hdfs. It also needs changes 
 to compile and run tests in hadoop-tools_projects on patch submission.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Resolved] (HADOOP-7855) Improve DiskChecker javadocs

2012-09-22 Thread Harsh J (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-7855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J resolved HADOOP-7855.
-

   Resolution: Duplicate
Fix Version/s: (was: 0.24.0)

Dupe of HADOOP-7856 (Accidental dual-submit).

 Improve DiskChecker javadocs
 

 Key: HADOOP-7855
 URL: https://issues.apache.org/jira/browse/HADOOP-7855
 Project: Hadoop Common
  Issue Type: Bug
  Components: util
Reporter: Eli Collins
  Labels: noob

 The javadocs for DiskChecker#checkDir(File dir) trail off, look like they 
 weren't completed, should be. 
 While checkDir(File) uses java File to check if a dir actually is writable, 
 the version of checkDir that takes an FsPermission uses FsAction#implies 
 which doesn't actually check if a dir is writable (eg it passes on a 
 read-only file system). So switching from one version to the other can cause 
 unexpected bugs. Let's call this out explicitly in the javadocs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Resolved] (HADOOP-7884) test-patch seems to fail when a patch goes across projects (common/hdfs/mapreduce) or touches hadoop-assemblies/hadoop-dist.

2012-09-22 Thread Harsh J (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J resolved HADOOP-7884.
-

   Resolution: Not A Problem
Fix Version/s: (was: 0.24.0)

No longer a problem after HADOOP-8308.

 test-patch seems to fail when a patch goes across projects 
 (common/hdfs/mapreduce) or touches hadoop-assemblies/hadoop-dist.
 

 Key: HADOOP-7884
 URL: https://issues.apache.org/jira/browse/HADOOP-7884
 Project: Hadoop Common
  Issue Type: Bug
  Components: build
Affects Versions: 0.24.0
Reporter: Alejandro Abdelnur

 Take for example HDFS-2178, the patch applies cleanly, but test-patch fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Resolved] (HADOOP-7840) Cleanup unnecessary exceptions thrown and unnecessary casts

2012-09-22 Thread Harsh J (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J resolved HADOOP-7840.
-

Resolution: Invalid

If we remove those throws IOException bits out of the methods you've changed, 
won't we inadvertently affect DistributedFileSystem that does Override these 
methods and makes use of the throws specification? We'll be breaking API if am 
not wrong.

For example, I tried removing throws IOException from FileSystem and 
DistributedFileSystem immediately complained at the overriden method cause it 
broke compatibility.

I'm closing this as Invalid, at this point, but please reopen if I got 
something wrong.

 Cleanup unnecessary exceptions thrown and unnecessary casts
 ---

 Key: HADOOP-7840
 URL: https://issues.apache.org/jira/browse/HADOOP-7840
 Project: Hadoop Common
  Issue Type: Improvement
  Components: fs
Affects Versions: 0.24.0
Reporter: Hari Mankude
Assignee: Hari Mankude
Priority: Minor
 Attachments: hadoop-7840.trunk.patch


 Cleanup build warnings. It is the file in the hadoop-common subtree for 
 hdfs-2564.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira