[jira] [Created] (HADOOP-10659) Refactor AccessControlList to reuse utility functions and to improve performance

2014-06-03 Thread Benoy Antony (JIRA)
Benoy Antony created HADOOP-10659:
-

 Summary: Refactor AccessControlList to reuse utility functions and 
to improve performance
 Key: HADOOP-10659
 URL: https://issues.apache.org/jira/browse/HADOOP-10659
 Project: Hadoop Common
  Issue Type: Sub-task
Reporter: Benoy Antony
Assignee: Benoy Antony
Priority: Minor


Minor improvements can be done on _AccessControlList_.

Code Reusability:
_AccessControlList_ sanitizes the input list to remove duplicate entries, trim 
entries. _StringUtils.getTrimmedStringCollection_ can be used in this case.

Performance:
_AccessControlList_  uses TreeSet to maintain set of users and groups.
HashSet improves the performance slightly.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (HADOOP-10660) GraphiteSink should implement Closeable

2014-06-03 Thread Ted Yu (JIRA)
Ted Yu created HADOOP-10660:
---

 Summary: GraphiteSink should implement Closeable
 Key: HADOOP-10660
 URL: https://issues.apache.org/jira/browse/HADOOP-10660
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Ted Yu


GraphiteSink wraps OutputStreamWriter around socket's output stream.
Currently the socket is never closed.

GraphiteSink should implement Closeable such that MetricsSystem can close the 
socket when it is stopped.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (HADOOP-10661) Ineffective user/passsword check in FTPFileSystem#initialize()

2014-06-03 Thread Ted Yu (JIRA)
Ted Yu created HADOOP-10661:
---

 Summary: Ineffective user/passsword check in 
FTPFileSystem#initialize()
 Key: HADOOP-10661
 URL: https://issues.apache.org/jira/browse/HADOOP-10661
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Ted Yu
Priority: Minor


Here is related code:
{code}
  userAndPassword = (conf.get("fs.ftp.user." + host, null) + ":" + conf
  .get("fs.ftp.password." + host, null));
  if (userAndPassword == null) {
throw new IOException("Invalid user/passsword specified");
  }
{code}
The intention seems to be checking that username / password should not be null.
But due to the presence of colon, the above check is not effective.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (HADOOP-10662) NullPointerException in CryptoInputStream while wrapped stream is not ByteBufferReadable. Add tests using normal stream.

2014-06-03 Thread Yi Liu (JIRA)
Yi Liu created HADOOP-10662:
---

 Summary: NullPointerException in CryptoInputStream while wrapped 
stream is not ByteBufferReadable. Add tests using normal stream.
 Key: HADOOP-10662
 URL: https://issues.apache.org/jira/browse/HADOOP-10662
 Project: Hadoop Common
  Issue Type: Bug
  Components: security
Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
Reporter: Yi Liu
Assignee: Yi Liu
 Fix For: fs-encryption (HADOOP-10150 and HDFS-6134)


NullPointerException in CryptoInputStream while wrapped stream is not 
ByteBufferReadable. 
Add tests for crypto streams using normal stream which does not support the 
additional interfaces that the Hadoop FileSystem streams implement (Seekable, 
PositionedReadable, ByteBufferReadable, HasFileDescriptor, CanSetDropBehind, 
CanSetReadahead, HasEnhancedByteBufferAccess, Syncable, CanSetDropBehind).



--
This message was sent by Atlassian JIRA
(v6.2#6252)