[jira] [Created] (HADOOP-12731) Remove useless boxing/unboxing code (Hadoop Common)
Kousuke Saruta created HADOOP-12731: --- Summary: Remove useless boxing/unboxing code (Hadoop Common) Key: HADOOP-12731 URL: https://issues.apache.org/jira/browse/HADOOP-12731 Project: Hadoop Common Issue Type: Improvement Components: performance Affects Versions: 3.0.0 Reporter: Kousuke Saruta Assignee: Kousuke Saruta Priority: Minor There are lots of places where useless boxing/unboxing occur. To avoid performance issue, let's remove them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HADOOP-10792) Add FileSystem#closeIfNotReferred method
Kousuke Saruta created HADOOP-10792: --- Summary: Add FileSystem#closeIfNotReferred method Key: HADOOP-10792 URL: https://issues.apache.org/jira/browse/HADOOP-10792 Project: Hadoop Common Issue Type: Improvement Components: fs Reporter: Kousuke Saruta FileSystem#close closes FileSystem even if the same instance of FileSystem is referred by someone. For instance, a library using FileSystem calls FileSystem.get, and a program using the library calls FileSystem.get, both of instances of FileSystem is same. When the library and the program is implemented as different threads and one calls FileSystem.close, another fails most of operations of FileSystem. So, we need the method like cloesIfNotReferred, which closes FileSystem only if a instance of FileSystem is not referred by anyone. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (HADOOP-10582) TestFsShellCopy doesn't test which we expect
Kousuke Saruta created HADOOP-10582:
---
Summary: TestFsShellCopy doesn't test which we expect
Key: HADOOP-10582
URL: https://issues.apache.org/jira/browse/HADOOP-10582
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 3.0.0
Reporter: Kousuke Saruta
Priority: Minor
In TestFsShellCopy#prepTest, there is a following code.
{code}
final Path dstPath = new Path(path);
final Path childPath = new Path(dstPath, childPath);
...
// copy to non-existent subdir
prepPut(childPath, false, false);
checkPut(1, srcPath, dstPath, useWindowsPath);
{code}
The code expect to test the case when we put a file to non-exsistent directory.
But the code delete childPath and then copy to its parent directory (dstPath).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (HADOOP-10243) Typo: soft-limit for hard-limit in DFSClient
Kousuke Saruta created HADOOP-10243:
---
Summary: Typo: soft-limit for hard-limit in DFSClient
Key: HADOOP-10243
URL: https://issues.apache.org/jira/browse/HADOOP-10243
Project: Hadoop Common
Issue Type: Bug
Reporter: Kousuke Saruta
Priority: Trivial
In DFSClient#renewLease, there is a log message as follows.
{code}
LOG.warn(Failed to renew lease for + clientName + for
+ (elapsed/1000) + seconds (= soft-limit =
+ (HdfsConstants.LEASE_HARDLIMIT_PERIOD/1000) + seconds.)
{code}
This log message includes soft-limit but, considering the context, I think
it's typo for hard-limit.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Created] (HADOOP-10118) CommandFormat never parse --
Kousuke Saruta created HADOOP-10118:
---
Summary: CommandFormat never parse --
Key: HADOOP-10118
URL: https://issues.apache.org/jira/browse/HADOOP-10118
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 3.0.0
Reporter: Kousuke Saruta
We cannot use -- option to skip args following that.
CommandFormat#parse is implemented as follows.
{code}
public void parse(ListString args) {
...
} else if (arg.equals(--)) { // force end of option processing
args.remove(pos);
break;
}
...
{code}
But, FsShell is called through ToolRunner and ToolRunner use
GenericOptionParser. GenericOptionParser use GnuParser, which discard -- when
parsing args.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Created] (HADOOP-10113) There are some threads which will be dead silently when uncaught exception/error occured
Kousuke Saruta created HADOOP-10113: --- Summary: There are some threads which will be dead silently when uncaught exception/error occured Key: HADOOP-10113 URL: https://issues.apache.org/jira/browse/HADOOP-10113 Project: Hadoop Common Issue Type: Bug Affects Versions: 3.0.0 Reporter: Kousuke Saruta Fix For: 3.0.0 Related to HDFS-5500, I found there are some threads be dead silently when uncaught exception/error occured. For example, following threads are I mentioned. * refreshUsed in DU * reloader in ReloadingX509TrustManager * t in UserGroupInformation#spawnAutoRenewalThreadForUserCreds * errThread in Shell#runCommand * sinkThread in MetricsSinkAdapter * blockScannerThread in DataBlockScanner * emptier in NameNode#startTrashEmptier (when we use TrashPolicyDefault) There are some critical threads if we can't notice the dead (e.g DU). I think we should handle those exception/error, and monitor the liveness or log that. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (HADOOP-9772) Test for put/copyFromLocal using stdin as a source.
Kousuke Saruta created HADOOP-9772: -- Summary: Test for put/copyFromLocal using stdin as a source. Key: HADOOP-9772 URL: https://issues.apache.org/jira/browse/HADOOP-9772 Project: Hadoop Common Issue Type: Improvement Components: test Affects Versions: 3.0.0 Reporter: Kousuke Saruta Fix For: 3.0.0 There are no test for put/copyFromLocal using stdin as a source. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
