Ted Yu created HADOOP-11283:
-------------------------------

             Summary: Potentially unclosed SequenceFile.Writer in 
DistCpV1#setup()
                 Key: HADOOP-11283
                 URL: https://issues.apache.org/jira/browse/HADOOP-11283
             Project: Hadoop Common
          Issue Type: Bug
            Reporter: Ted Yu
            Priority: Minor


{code}
    SequenceFile.Writer src_writer = SequenceFile.createWriter(jobfs, jobConf,
        srcfilelist, LongWritable.class, FilePair.class,
        SequenceFile.CompressionType.NONE);

    Path dstfilelist = new Path(jobDirectory, "_distcp_dst_files");
    SequenceFile.Writer dst_writer = SequenceFile.createWriter(jobfs, jobConf,
        dstfilelist, Text.class, Text.class,
        SequenceFile.CompressionType.NONE);
{code}
If creation of dst_writer throws exception, src_writer would be left unclosed 
since there is no finally clause doing that for the above code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to