Aaron Fabbri created HADOOP-14096: ------------------------------------- Summary: s3guard: regression in dirListingUnion Key: HADOOP-14096 URL: https://issues.apache.org/jira/browse/HADOOP-14096 Project: Hadoop Common Issue Type: Sub-task Components: fs/s3 Affects Versions: HADOOP-13345 Reporter: Aaron Fabbri Priority: Critical
Just noticed HADOOP-14020 introduced a bug in S3Guard#dirListingUnion. The offending change is here: {noformat} - if (dirMeta.get(s.getPath()) == null) { - dirMeta.put(s); - } + changed = changed || dirMeta.put(s); + } + {noformat} hint: Logical OR is a short-circuit operator. Easy fix, but should probably come with a unit test for dirListingUnion(). -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org