Adam Antal created HADOOP-16510:
-----------------------------------

             Summary: [hadoop-common] Fix order of actual and expected 
expression in assert statements
                 Key: HADOOP-16510
                 URL: https://issues.apache.org/jira/browse/HADOOP-16510
             Project: Hadoop Common
          Issue Type: Sub-task
    Affects Versions: 3.2.0
            Reporter: Adam Antal


Fix order of actual and expected expression in assert statements which gives 
misleading message when test case fails. Attached file has some of the places 
where it is placed wrongly.
{code:java}
[ERROR] 
testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
  Time elapsed: 3.385 s  <<< FAILURE!
java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but 
was:<0>
{code}
For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be used 
for new test cases which avoids such mistakes.

This is a follow-up jira for the hadoop-common project.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

Reply via email to