[jira] [Commented] (HADOOP-9199) Cover package org.apache.hadoop.io with unit tests

2013-01-23 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561478#comment-13561478
 ] 

Hadoop QA commented on HADOOP-9199:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12566265/HADOOP-9199-trunk-c.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 16 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2083//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2083//console

This message is automatically generated.

> Cover package org.apache.hadoop.io with unit tests
> --
>
> Key: HADOOP-9199
> URL: https://issues.apache.org/jira/browse/HADOOP-9199
> Project: Hadoop Common
>  Issue Type: Test
>Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.6
>Reporter: Vadim Bondarev
> Attachments: HADOOP-9199-branch-0.23-a.patch, 
> HADOOP-9199-branch-0.23-b.patch, HADOOP-9199-branch-0.23-c.patch, 
> HADOOP-9199-branch-2-a.patch, HADOOP-9199-branch-2-b.patch, 
> HADOOP-9199-branch-2-c.patch, HADOOP-9199-trunk-a.patch, 
> HADOOP-9199-trunk-b.patch, HADOOP-9199-trunk-c.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HADOOP-9199) Cover package org.apache.hadoop.io with unit tests

2013-01-23 Thread Vadim Bondarev (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-9199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vadim Bondarev updated HADOOP-9199:
---

Attachment: HADOOP-9199-trunk-c.patch
HADOOP-9199-branch-2-c.patch
HADOOP-9199-branch-0.23-c.patch

> Cover package org.apache.hadoop.io with unit tests
> --
>
> Key: HADOOP-9199
> URL: https://issues.apache.org/jira/browse/HADOOP-9199
> Project: Hadoop Common
>  Issue Type: Test
>Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.6
>Reporter: Vadim Bondarev
> Attachments: HADOOP-9199-branch-0.23-a.patch, 
> HADOOP-9199-branch-0.23-b.patch, HADOOP-9199-branch-0.23-c.patch, 
> HADOOP-9199-branch-2-a.patch, HADOOP-9199-branch-2-b.patch, 
> HADOOP-9199-branch-2-c.patch, HADOOP-9199-trunk-a.patch, 
> HADOOP-9199-trunk-b.patch, HADOOP-9199-trunk-c.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9239) Move the general@ description to the end of lists in the mailing lists web page

2013-01-23 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561459#comment-13561459
 ] 

Hadoop QA commented on HADOOP-9239:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12566260/HADOOP-9239.patch
  against trunk revision .

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2082//console

This message is automatically generated.

> Move the general@ description to the end of lists in the mailing lists web 
> page
> ---
>
> Key: HADOOP-9239
> URL: https://issues.apache.org/jira/browse/HADOOP-9239
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Harsh J
>Priority: Minor
> Attachments: HADOOP-9239.patch
>
>
> We have users unnecessarily subscribing to and abusing the general@ list 
> mainly cause of its presence as the first option in the page 
> http://hadoop.apache.org/mailing_lists.html, and secondarily cause of its 
> name.
> This is to at least address the first one that is causing growing pain to its 
> subscribers. Lets move it to the bottom of the presented list of lists.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HADOOP-9239) Move the general@ description to the end of lists in the mailing lists web page

2013-01-23 Thread Harsh J (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-9239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J updated HADOOP-9239:


Attachment: HADOOP-9239.patch

> Move the general@ description to the end of lists in the mailing lists web 
> page
> ---
>
> Key: HADOOP-9239
> URL: https://issues.apache.org/jira/browse/HADOOP-9239
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Harsh J
>Priority: Minor
> Attachments: HADOOP-9239.patch
>
>
> We have users unnecessarily subscribing to and abusing the general@ list 
> mainly cause of its presence as the first option in the page 
> http://hadoop.apache.org/mailing_lists.html, and secondarily cause of its 
> name.
> This is to at least address the first one that is causing growing pain to its 
> subscribers. Lets move it to the bottom of the presented list of lists.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HADOOP-9239) Move the general@ description to the end of lists in the mailing lists web page

2013-01-23 Thread Harsh J (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-9239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J updated HADOOP-9239:


Status: Patch Available  (was: Open)

> Move the general@ description to the end of lists in the mailing lists web 
> page
> ---
>
> Key: HADOOP-9239
> URL: https://issues.apache.org/jira/browse/HADOOP-9239
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Harsh J
>Priority: Minor
> Attachments: HADOOP-9239.patch
>
>
> We have users unnecessarily subscribing to and abusing the general@ list 
> mainly cause of its presence as the first option in the page 
> http://hadoop.apache.org/mailing_lists.html, and secondarily cause of its 
> name.
> This is to at least address the first one that is causing growing pain to its 
> subscribers. Lets move it to the bottom of the presented list of lists.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HADOOP-9239) Move the general@ description to the end of lists in the mailing lists web page

2013-01-23 Thread Harsh J (JIRA)
Harsh J created HADOOP-9239:
---

 Summary: Move the general@ description to the end of lists in the 
mailing lists web page
 Key: HADOOP-9239
 URL: https://issues.apache.org/jira/browse/HADOOP-9239
 Project: Hadoop Common
  Issue Type: Improvement
  Components: documentation
Reporter: Harsh J
Priority: Minor


We have users unnecessarily subscribing to and abusing the general@ list mainly 
cause of its presence as the first option in the page 
http://hadoop.apache.org/mailing_lists.html, and secondarily cause of its name.

This is to at least address the first one that is causing growing pain to its 
subscribers. Lets move it to the bottom of the presented list of lists.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9150) Unnecessary DNS resolution attempts for logical URIs

2013-01-23 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561348#comment-13561348
 ] 

Hadoop QA commented on HADOOP-9150:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12566219/hadoop-9150.txt
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 6 new 
or modified test files.

  {color:red}-1 javac{color}.  The applied patch generated 2030 javac 
compiler warnings (more than the trunk's current 2022 warnings).

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

  org.apache.hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2081//testReport/
Javac warnings: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2081//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2081//console

This message is automatically generated.

> Unnecessary DNS resolution attempts for logical URIs
> 
>
> Key: HADOOP-9150
> URL: https://issues.apache.org/jira/browse/HADOOP-9150
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs/s3, ha, performance, viewfs
>Affects Versions: 3.0.0, 2.0.2-alpha
>Reporter: Todd Lipcon
>Assignee: Todd Lipcon
>Priority: Critical
> Attachments: hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, 
> hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, 
> hadoop-9150.txt, hadoop-9150.txt, log.txt, tracing-resolver.tgz
>
>
> In the FileSystem code, we accidentally try to DNS-resolve the logical name 
> before it is converted to an actual domain name. In some DNS setups, this can 
> cause a big slowdown - eg in one misconfigured cluster we saw a 2-3x drop in 
> terasort throughput, since every task wasted a lot of time waiting for slow 
> "not found" responses from DNS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HADOOP-9150) Unnecessary DNS resolution attempts for logical URIs

2013-01-23 Thread Todd Lipcon (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-9150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Todd Lipcon updated HADOOP-9150:


Attachment: hadoop-9150.txt

Had to modify TestFilterFileSystem so that it knows that FilterFileSystem 
doesn't need to override final methods.

> Unnecessary DNS resolution attempts for logical URIs
> 
>
> Key: HADOOP-9150
> URL: https://issues.apache.org/jira/browse/HADOOP-9150
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs/s3, ha, performance, viewfs
>Affects Versions: 3.0.0, 2.0.2-alpha
>Reporter: Todd Lipcon
>Assignee: Todd Lipcon
>Priority: Critical
> Attachments: hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, 
> hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, 
> hadoop-9150.txt, hadoop-9150.txt, log.txt, tracing-resolver.tgz
>
>
> In the FileSystem code, we accidentally try to DNS-resolve the logical name 
> before it is converted to an actual domain name. In some DNS setups, this can 
> cause a big slowdown - eg in one misconfigured cluster we saw a 2-3x drop in 
> terasort throughput, since every task wasted a lot of time waiting for slow 
> "not found" responses from DNS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9150) Unnecessary DNS resolution attempts for logical URIs

2013-01-23 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561162#comment-13561162
 ] 

Hadoop QA commented on HADOOP-9150:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12566181/hadoop-9150.txt
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 5 new 
or modified test files.

  {color:red}-1 javac{color}.  The applied patch generated 2030 javac 
compiler warnings (more than the trunk's current 2022 warnings).

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

  org.apache.hadoop.fs.TestFilterFileSystem
  
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2080//testReport/
Javac warnings: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2080//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2080//console

This message is automatically generated.

> Unnecessary DNS resolution attempts for logical URIs
> 
>
> Key: HADOOP-9150
> URL: https://issues.apache.org/jira/browse/HADOOP-9150
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs/s3, ha, performance, viewfs
>Affects Versions: 3.0.0, 2.0.2-alpha
>Reporter: Todd Lipcon
>Assignee: Todd Lipcon
>Priority: Critical
> Attachments: hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, 
> hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, 
> hadoop-9150.txt, log.txt, tracing-resolver.tgz
>
>
> In the FileSystem code, we accidentally try to DNS-resolve the logical name 
> before it is converted to an actual domain name. In some DNS setups, this can 
> cause a big slowdown - eg in one misconfigured cluster we saw a 2-3x drop in 
> terasort throughput, since every task wasted a lot of time waiting for slow 
> "not found" responses from DNS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HADOOP-9150) Unnecessary DNS resolution attempts for logical URIs

2013-01-23 Thread Todd Lipcon (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-9150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Todd Lipcon updated HADOOP-9150:


Attachment: hadoop-9150.txt

Attached patch makes {{getCanonicalUri()}} final as suggested by Suresh and 
Daryn above. I had to change a couple unit tests which were relying on 
overriding the protected method in order to expose it at public visibility.

I also changed the if condition checking for default port, but I didn't change 
the default behavior to return -1 instead of 0. It seemed like this could have 
more far-reaching but subtle impact, so figured I'd prefer to avoid the scope 
creep on this JIRA.

> Unnecessary DNS resolution attempts for logical URIs
> 
>
> Key: HADOOP-9150
> URL: https://issues.apache.org/jira/browse/HADOOP-9150
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs/s3, ha, performance, viewfs
>Affects Versions: 3.0.0, 2.0.2-alpha
>Reporter: Todd Lipcon
>Assignee: Todd Lipcon
>Priority: Critical
> Attachments: hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, 
> hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, 
> hadoop-9150.txt, log.txt, tracing-resolver.tgz
>
>
> In the FileSystem code, we accidentally try to DNS-resolve the logical name 
> before it is converted to an actual domain name. In some DNS setups, this can 
> cause a big slowdown - eg in one misconfigured cluster we saw a 2-3x drop in 
> terasort throughput, since every task wasted a lot of time waiting for slow 
> "not found" responses from DNS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HADOOP-8921) ant build.xml in branch-1 ignores -Dcompile.native

2013-01-23 Thread Chris Nauroth (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-8921:
--

Attachment: HADOOP-8921.5.patch

Thanks for providing this patch, [~gopalv].  I've found that in the current 
branch-1 codebase, I also get a failure on Mac due to the native compile of 
task controller.  I'm uploading HADOOP-8921.5.patch.  The only difference from 
the version 4 patch is that I have added the if native check to the 
task-controller target:

{code}
-  
+  
{code}


> ant build.xml in branch-1 ignores -Dcompile.native
> --
>
> Key: HADOOP-8921
> URL: https://issues.apache.org/jira/browse/HADOOP-8921
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.2.0
> Environment: Mac OS X 10.7.4
>Reporter: Gopal V
>Priority: Trivial
>  Labels: ant, autoconf, patch
> Attachments: HADOOP-8921.4.patch, HADOOP-8921.5.patch
>
>
> ant -Dcompile.native=false still runs autoconf and libtoolize
> According to ant 1.8 manual, any  conditions are checked only 
> after the dependencies are run through. The current if condition in code 
> fails to prevent the autoconf/libtool components from running.
> Fixing it by moving the if condition up into the "compile-native" target and 
> changing it to a param substitution instead of being evaluated as a condition.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HADOOP-8921) ant build.xml in branch-1 ignores -Dcompile.native

2013-01-23 Thread Chris Nauroth (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-8921:
--

Status: Open  (was: Patch Available)

> ant build.xml in branch-1 ignores -Dcompile.native
> --
>
> Key: HADOOP-8921
> URL: https://issues.apache.org/jira/browse/HADOOP-8921
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.2.0
> Environment: Mac OS X 10.7.4
>Reporter: Gopal V
>Priority: Trivial
>  Labels: ant, autoconf, patch
> Attachments: HADOOP-8921.4.patch
>
>
> ant -Dcompile.native=false still runs autoconf and libtoolize
> According to ant 1.8 manual, any  conditions are checked only 
> after the dependencies are run through. The current if condition in code 
> fails to prevent the autoconf/libtool components from running.
> Fixing it by moving the if condition up into the "compile-native" target and 
> changing it to a param substitution instead of being evaluated as a condition.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map

2013-01-23 Thread Surenkumar Nihalani (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560812#comment-13560812
 ] 

Surenkumar Nihalani commented on HADOOP-9154:
-

I see better maintainability in this refactoring. If you feel otherwise, that's 
ok too. 

Since both {{MapWritable}}s extend {{AbstractMapWritable}} the one line fix and 
the unit tests should suffice.

> SortedMapWritable#putAll() doesn't add key/value classes to the map
> ---
>
> Key: HADOOP-9154
> URL: https://issues.apache.org/jira/browse/HADOOP-9154
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: io
>Affects Versions: 2.0.2-alpha
>Reporter: Karthik Kambatla
>Assignee: Karthik Kambatla
> Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch, 
> hadoop-9154.patch, hadoop-9154.patch
>
>
> In the following code from {{SortedMapWritable}}, #putAll() doesn't add 
> key/value classes to the class-id maps.
> {code}
>   @Override
>   public Writable put(WritableComparable key, Writable value) {
> addToMap(key.getClass());
> addToMap(value.getClass());
> return instance.put(key, value);
>   }
>   @Override
>   public void putAll(Map t){
> for (Map.Entry e:
>   t.entrySet()) {
>   
>   instance.put(e.getKey(), e.getValue());
> }
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9150) Unnecessary DNS resolution attempts for logical URIs

2013-01-23 Thread Daryn Sharp (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560759#comment-13560759
 ] 

Daryn Sharp commented on HADOOP-9150:
-

I'm also kind of leaning towards a final on {{getCanonicalUri()}}.  If someone 
overrides it then there would be an inconsistency in calling 
{{getCanonicalUri()}} and {{getCanonicalUri(getUri())}}.

I think the comparison {{getDefaultPort() != 0}} should be {{getDefaultPort() > 
0}} since -1 signifies no port to URI.  I find it very odd that the default 
impl returns 0 instead of -1.  Perhaps that should be changed?  If so, maybe it 
should be {{getDefaultPort() != -1}}.

Very minor, but I'd consider renaming {{canonicalizeUri(URI)}} to 
{{getCanonicalUri(URI)}}.  If you disagree, that's ok.


> Unnecessary DNS resolution attempts for logical URIs
> 
>
> Key: HADOOP-9150
> URL: https://issues.apache.org/jira/browse/HADOOP-9150
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs/s3, ha, performance, viewfs
>Affects Versions: 3.0.0, 2.0.2-alpha
>Reporter: Todd Lipcon
>Assignee: Todd Lipcon
>Priority: Critical
> Attachments: hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, 
> hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, hadoop-9150.txt, log.txt, 
> tracing-resolver.tgz
>
>
> In the FileSystem code, we accidentally try to DNS-resolve the logical name 
> before it is converted to an actual domain name. In some DNS setups, this can 
> cause a big slowdown - eg in one misconfigured cluster we saw a 2-3x drop in 
> terasort throughput, since every task wasted a lot of time waiting for slow 
> "not found" responses from DNS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HADOOP-9238) FsShell -put from stdin auto-creates paths

2013-01-23 Thread Daryn Sharp (JIRA)
Daryn Sharp created HADOOP-9238:
---

 Summary: FsShell -put from stdin auto-creates paths
 Key: HADOOP-9238
 URL: https://issues.apache.org/jira/browse/HADOOP-9238
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: 2.0.0-alpha, 0.23.0, 3.0.0
Reporter: Daryn Sharp


FsShell put is no longer supposed to auto-create paths.  There's an 
inconsistency where a put from stdin will still auto-create paths.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9231) Parametrize staging URL for the uniformity of distributionManagement

2013-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560706#comment-13560706
 ] 

Hudson commented on HADOOP-9231:


Integrated in Hadoop-Mapreduce-trunk #1322 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1322/])
HADOOP-9231. Add missing CHANGES.txt (Revision 1437143)
HADOOP-9231. Parametrize staging URL for the uniformity of 
distributionManagement. Contributed by Konstantin Boudnik. (Revision 1437140)

 Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1437143
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1437140
Files : 
* /hadoop/common/trunk/pom.xml


> Parametrize staging URL for the uniformity of distributionManagement
> 
>
> Key: HADOOP-9231
> URL: https://issues.apache.org/jira/browse/HADOOP-9231
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.0.0, 2.0.3-alpha
>Reporter: Konstantin Boudnik
>Assignee: Konstantin Boudnik
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-9231.patch, HADOOP-9231.patch
>
>
> The build's {{distributionManagement}} section currently uses parametrization 
> for the snapshot repository. It is convenient and allows to override the 
> value from a developer's custom profile.
> The same isn't available for release artifacts to make the parametrization 
> symmetric for both types.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9231) Parametrize staging URL for the uniformity of distributionManagement

2013-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560658#comment-13560658
 ] 

Hudson commented on HADOOP-9231:


Integrated in Hadoop-Hdfs-trunk #1294 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1294/])
HADOOP-9231. Add missing CHANGES.txt (Revision 1437143)
HADOOP-9231. Parametrize staging URL for the uniformity of 
distributionManagement. Contributed by Konstantin Boudnik. (Revision 1437140)

 Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1437143
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1437140
Files : 
* /hadoop/common/trunk/pom.xml


> Parametrize staging URL for the uniformity of distributionManagement
> 
>
> Key: HADOOP-9231
> URL: https://issues.apache.org/jira/browse/HADOOP-9231
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.0.0, 2.0.3-alpha
>Reporter: Konstantin Boudnik
>Assignee: Konstantin Boudnik
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-9231.patch, HADOOP-9231.patch
>
>
> The build's {{distributionManagement}} section currently uses parametrization 
> for the snapshot repository. It is convenient and allows to override the 
> value from a developer's custom profile.
> The same isn't available for release artifacts to make the parametrization 
> symmetric for both types.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map

2013-01-23 Thread Tom White (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560600#comment-13560600
 ] 

Tom White commented on HADOOP-9154:
---

Sorry to come to this late, but I feel that we should just fix the bug and not 
perform such extensive refactoring here. This is stable code and we need to be 
sure that such a change doesn't break compatibility.

The following fix plus a unit test to show the problem should suffice, no?

{noformat}
diff --git 
a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SortedMapWritable.java
 b/hadoop-common-p
index eee744e..b533d94 100644
--- 
a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SortedMapWritable.java
+++ 
b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SortedMapWritable.java
@@ -141,7 +141,7 @@ public void putAll(Map t) {
 for (Map.Entry e:
   t.entrySet()) {
   
-  instance.put(e.getKey(), e.getValue());
+  put(e.getKey(), e.getValue());
 }
   }
{noformat}


> SortedMapWritable#putAll() doesn't add key/value classes to the map
> ---
>
> Key: HADOOP-9154
> URL: https://issues.apache.org/jira/browse/HADOOP-9154
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: io
>Affects Versions: 2.0.2-alpha
>Reporter: Karthik Kambatla
>Assignee: Karthik Kambatla
> Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch, 
> hadoop-9154.patch, hadoop-9154.patch
>
>
> In the following code from {{SortedMapWritable}}, #putAll() doesn't add 
> key/value classes to the class-id maps.
> {code}
>   @Override
>   public Writable put(WritableComparable key, Writable value) {
> addToMap(key.getClass());
> addToMap(value.getClass());
> return instance.put(key, value);
>   }
>   @Override
>   public void putAll(Map t){
> for (Map.Entry e:
>   t.entrySet()) {
>   
>   instance.put(e.getKey(), e.getValue());
> }
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9231) Parametrize staging URL for the uniformity of distributionManagement

2013-01-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560550#comment-13560550
 ] 

Hudson commented on HADOOP-9231:


Integrated in Hadoop-Yarn-trunk #105 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/105/])
HADOOP-9231. Add missing CHANGES.txt (Revision 1437143)
HADOOP-9231. Parametrize staging URL for the uniformity of 
distributionManagement. Contributed by Konstantin Boudnik. (Revision 1437140)

 Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1437143
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1437140
Files : 
* /hadoop/common/trunk/pom.xml


> Parametrize staging URL for the uniformity of distributionManagement
> 
>
> Key: HADOOP-9231
> URL: https://issues.apache.org/jira/browse/HADOOP-9231
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.0.0, 2.0.3-alpha
>Reporter: Konstantin Boudnik
>Assignee: Konstantin Boudnik
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-9231.patch, HADOOP-9231.patch
>
>
> The build's {{distributionManagement}} section currently uses parametrization 
> for the snapshot repository. It is convenient and allows to override the 
> value from a developer's custom profile.
> The same isn't available for release artifacts to make the parametrization 
> symmetric for both types.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira