[jira] [Commented] (HADOOP-10365) BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally block
[
https://issues.apache.org/jira/browse/HADOOP-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1424#comment-1424
]
Tsuyoshi OZAWA commented on HADOOP-10365:
-
[~yunsh] Sorry for iterative comments - how about using try-with-resources
since we only support JDK7+ now. Do you mind updating it?
http://docs.oracle.com/javase/7/docs/technotes/guides/language/try-with-resources.html
> BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally
> block
> --
>
> Key: HADOOP-10365
> URL: https://issues.apache.org/jira/browse/HADOOP-10365
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
>Reporter: Ted Yu
>Priority: Minor
> Attachments: HADOOP-10365.2.patch, HADOOP-10365.3.patch,
> HADOOP-10365.4.patch, HADOOP-10365.patch
>
>
> {code}
> BufferedOutputStream outputStream = new BufferedOutputStream(
> new FileOutputStream(outputFile));
> ...
> outputStream.flush();
> outputStream.close();
> {code}
> outputStream should be closed in finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11429) Findbugs warnings in hadoop extras
[ https://issues.apache.org/jira/browse/HADOOP-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255584#comment-14255584 ] Varun Saxena commented on HADOOP-11429: --- Thanks for the review and commit, [~wheat9]. > Findbugs warnings in hadoop extras > -- > > Key: HADOOP-11429 > URL: https://issues.apache.org/jira/browse/HADOOP-11429 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Varun Saxena >Assignee: Varun Saxena > Fix For: 2.7.0 > > Attachments: HADOOP-11429.001.patch, HADOOP-11429.patch, > newPatchFindbugsWarningshadoop-extras.html > > > 9 new findbugs warnings in hadoop-extras. Check the attached report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HADOOP-11441) Hadoop-azure: Change few methods and class scope to public
shashank created HADOOP-11441: - Summary: Hadoop-azure: Change few methods and class scope to public Key: HADOOP-11441 URL: https://issues.apache.org/jira/browse/HADOOP-11441 Project: Hadoop Common Issue Type: Improvement Components: tools Reporter: shashank Assignee: Chris Nauroth TestWindowsAzureTableSinkSetup class test cases have dependencies with hadoop-azure test classes, however few functions in hadoop azure test classes are having default access and are not visible outside package. AzureBlobStorageTestAccount.createTestAccount() AzureNativeFileSystemStore.getAccountKeyFromConfiguration() also visibility of AzureNativeFileSystemStore class needs to be changed as well -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11414) FileBasedIPList#readLines() can leak file descriptors
[
https://issues.apache.org/jira/browse/HADOOP-11414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255627#comment-14255627
]
Hudson commented on HADOOP-11414:
-
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #49 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/49/])
HADOOP-11414. FileBasedIPList#readLines() can leak file descriptors. (ozawa)
(ozawa: rev ecf1469fa51f9977f70652fac313d4a9ec1eb86f)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/FileBasedIPList.java
> FileBasedIPList#readLines() can leak file descriptors
> -
>
> Key: HADOOP-11414
> URL: https://issues.apache.org/jira/browse/HADOOP-11414
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.6.0
>Reporter: Ted Yu
>Assignee: Tsuyoshi OZAWA
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HADOOP-11414.1.patch, HADOOP-11414.2.patch,
> HADOOP-11414.3.patch, HADOOP-11414.4.patch
>
>
> {code}
> Reader fileReader = new InputStreamReader(
> new FileInputStream(file), Charsets.UTF_8);
> BufferedReader bufferedReader = new BufferedReader(fileReader);
> List lines = new ArrayList();
> String line = null;
> while ((line = bufferedReader.readLine()) != null) {
> lines.add(line);
> }
> bufferedReader.close();
> {code}
> Since bufferedReader.readLine() may throw IOE, so the close of bufferedReader
> should be enclosed within finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11429) Findbugs warnings in hadoop extras
[ https://issues.apache.org/jira/browse/HADOOP-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255628#comment-14255628 ] Hudson commented on HADOOP-11429: - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #49 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/49/]) HADOOP-11429. Findbugs warnings in hadoop extras. Contributed by Varun Saxena. (wheat9: rev 02b21b7131d9f1dba6d93fb3f87154e86b9825d6) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/Logalyzer.java * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistTool.java * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCpV1.java * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCh.java > Findbugs warnings in hadoop extras > -- > > Key: HADOOP-11429 > URL: https://issues.apache.org/jira/browse/HADOOP-11429 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Varun Saxena >Assignee: Varun Saxena > Fix For: 2.7.0 > > Attachments: HADOOP-11429.001.patch, HADOOP-11429.patch, > newPatchFindbugsWarningshadoop-extras.html > > > 9 new findbugs warnings in hadoop-extras. Check the attached report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11414) FileBasedIPList#readLines() can leak file descriptors
[
https://issues.apache.org/jira/browse/HADOOP-11414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255632#comment-14255632
]
Hudson commented on HADOOP-11414:
-
FAILURE: Integrated in Hadoop-Yarn-trunk #783 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/783/])
HADOOP-11414. FileBasedIPList#readLines() can leak file descriptors. (ozawa)
(ozawa: rev ecf1469fa51f9977f70652fac313d4a9ec1eb86f)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/FileBasedIPList.java
> FileBasedIPList#readLines() can leak file descriptors
> -
>
> Key: HADOOP-11414
> URL: https://issues.apache.org/jira/browse/HADOOP-11414
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.6.0
>Reporter: Ted Yu
>Assignee: Tsuyoshi OZAWA
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HADOOP-11414.1.patch, HADOOP-11414.2.patch,
> HADOOP-11414.3.patch, HADOOP-11414.4.patch
>
>
> {code}
> Reader fileReader = new InputStreamReader(
> new FileInputStream(file), Charsets.UTF_8);
> BufferedReader bufferedReader = new BufferedReader(fileReader);
> List lines = new ArrayList();
> String line = null;
> while ((line = bufferedReader.readLine()) != null) {
> lines.add(line);
> }
> bufferedReader.close();
> {code}
> Since bufferedReader.readLine() may throw IOE, so the close of bufferedReader
> should be enclosed within finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11429) Findbugs warnings in hadoop extras
[ https://issues.apache.org/jira/browse/HADOOP-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255633#comment-14255633 ] Hudson commented on HADOOP-11429: - FAILURE: Integrated in Hadoop-Yarn-trunk #783 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/783/]) HADOOP-11429. Findbugs warnings in hadoop extras. Contributed by Varun Saxena. (wheat9: rev 02b21b7131d9f1dba6d93fb3f87154e86b9825d6) * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCh.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/Logalyzer.java * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCpV1.java * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistTool.java > Findbugs warnings in hadoop extras > -- > > Key: HADOOP-11429 > URL: https://issues.apache.org/jira/browse/HADOOP-11429 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Varun Saxena >Assignee: Varun Saxena > Fix For: 2.7.0 > > Attachments: HADOOP-11429.001.patch, HADOOP-11429.patch, > newPatchFindbugsWarningshadoop-extras.html > > > 9 new findbugs warnings in hadoop-extras. Check the attached report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HADOOP-11442) hadoop-azure: Create test jar
shashank created HADOOP-11442: - Summary: hadoop-azure: Create test jar Key: HADOOP-11442 URL: https://issues.apache.org/jira/browse/HADOOP-11442 Project: Hadoop Common Issue Type: Improvement Components: tools Reporter: shashank Assignee: Chris Nauroth pom of hadoop-azure project to needs to be modified to create a test jar as well. This test jar is required to run test cases of Windowsazuretablesink -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11429) Findbugs warnings in hadoop extras
[ https://issues.apache.org/jira/browse/HADOOP-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255762#comment-14255762 ] Hudson commented on HADOOP-11429: - FAILURE: Integrated in Hadoop-Hdfs-trunk #1981 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1981/]) HADOOP-11429. Findbugs warnings in hadoop extras. Contributed by Varun Saxena. (wheat9: rev 02b21b7131d9f1dba6d93fb3f87154e86b9825d6) * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCpV1.java * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistTool.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCh.java * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/Logalyzer.java > Findbugs warnings in hadoop extras > -- > > Key: HADOOP-11429 > URL: https://issues.apache.org/jira/browse/HADOOP-11429 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Varun Saxena >Assignee: Varun Saxena > Fix For: 2.7.0 > > Attachments: HADOOP-11429.001.patch, HADOOP-11429.patch, > newPatchFindbugsWarningshadoop-extras.html > > > 9 new findbugs warnings in hadoop-extras. Check the attached report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11414) FileBasedIPList#readLines() can leak file descriptors
[
https://issues.apache.org/jira/browse/HADOOP-11414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255761#comment-14255761
]
Hudson commented on HADOOP-11414:
-
FAILURE: Integrated in Hadoop-Hdfs-trunk #1981 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1981/])
HADOOP-11414. FileBasedIPList#readLines() can leak file descriptors. (ozawa)
(ozawa: rev ecf1469fa51f9977f70652fac313d4a9ec1eb86f)
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/FileBasedIPList.java
* hadoop-common-project/hadoop-common/CHANGES.txt
> FileBasedIPList#readLines() can leak file descriptors
> -
>
> Key: HADOOP-11414
> URL: https://issues.apache.org/jira/browse/HADOOP-11414
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.6.0
>Reporter: Ted Yu
>Assignee: Tsuyoshi OZAWA
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HADOOP-11414.1.patch, HADOOP-11414.2.patch,
> HADOOP-11414.3.patch, HADOOP-11414.4.patch
>
>
> {code}
> Reader fileReader = new InputStreamReader(
> new FileInputStream(file), Charsets.UTF_8);
> BufferedReader bufferedReader = new BufferedReader(fileReader);
> List lines = new ArrayList();
> String line = null;
> while ((line = bufferedReader.readLine()) != null) {
> lines.add(line);
> }
> bufferedReader.close();
> {code}
> Since bufferedReader.readLine() may throw IOE, so the close of bufferedReader
> should be enclosed within finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11429) Findbugs warnings in hadoop extras
[ https://issues.apache.org/jira/browse/HADOOP-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255769#comment-14255769 ] Hudson commented on HADOOP-11429: - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #46 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/46/]) HADOOP-11429. Findbugs warnings in hadoop extras. Contributed by Varun Saxena. (wheat9: rev 02b21b7131d9f1dba6d93fb3f87154e86b9825d6) * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/Logalyzer.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistTool.java * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCpV1.java * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCh.java > Findbugs warnings in hadoop extras > -- > > Key: HADOOP-11429 > URL: https://issues.apache.org/jira/browse/HADOOP-11429 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Varun Saxena >Assignee: Varun Saxena > Fix For: 2.7.0 > > Attachments: HADOOP-11429.001.patch, HADOOP-11429.patch, > newPatchFindbugsWarningshadoop-extras.html > > > 9 new findbugs warnings in hadoop-extras. Check the attached report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11414) FileBasedIPList#readLines() can leak file descriptors
[
https://issues.apache.org/jira/browse/HADOOP-11414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255768#comment-14255768
]
Hudson commented on HADOOP-11414:
-
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #46 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/46/])
HADOOP-11414. FileBasedIPList#readLines() can leak file descriptors. (ozawa)
(ozawa: rev ecf1469fa51f9977f70652fac313d4a9ec1eb86f)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/FileBasedIPList.java
> FileBasedIPList#readLines() can leak file descriptors
> -
>
> Key: HADOOP-11414
> URL: https://issues.apache.org/jira/browse/HADOOP-11414
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.6.0
>Reporter: Ted Yu
>Assignee: Tsuyoshi OZAWA
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HADOOP-11414.1.patch, HADOOP-11414.2.patch,
> HADOOP-11414.3.patch, HADOOP-11414.4.patch
>
>
> {code}
> Reader fileReader = new InputStreamReader(
> new FileInputStream(file), Charsets.UTF_8);
> BufferedReader bufferedReader = new BufferedReader(fileReader);
> List lines = new ArrayList();
> String line = null;
> while ((line = bufferedReader.readLine()) != null) {
> lines.add(line);
> }
> bufferedReader.close();
> {code}
> Since bufferedReader.readLine() may throw IOE, so the close of bufferedReader
> should be enclosed within finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11414) FileBasedIPList#readLines() can leak file descriptors
[
https://issues.apache.org/jira/browse/HADOOP-11414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255806#comment-14255806
]
Hudson commented on HADOOP-11414:
-
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #50 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/50/])
HADOOP-11414. FileBasedIPList#readLines() can leak file descriptors. (ozawa)
(ozawa: rev ecf1469fa51f9977f70652fac313d4a9ec1eb86f)
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/FileBasedIPList.java
* hadoop-common-project/hadoop-common/CHANGES.txt
> FileBasedIPList#readLines() can leak file descriptors
> -
>
> Key: HADOOP-11414
> URL: https://issues.apache.org/jira/browse/HADOOP-11414
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.6.0
>Reporter: Ted Yu
>Assignee: Tsuyoshi OZAWA
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HADOOP-11414.1.patch, HADOOP-11414.2.patch,
> HADOOP-11414.3.patch, HADOOP-11414.4.patch
>
>
> {code}
> Reader fileReader = new InputStreamReader(
> new FileInputStream(file), Charsets.UTF_8);
> BufferedReader bufferedReader = new BufferedReader(fileReader);
> List lines = new ArrayList();
> String line = null;
> while ((line = bufferedReader.readLine()) != null) {
> lines.add(line);
> }
> bufferedReader.close();
> {code}
> Since bufferedReader.readLine() may throw IOE, so the close of bufferedReader
> should be enclosed within finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11429) Findbugs warnings in hadoop extras
[ https://issues.apache.org/jira/browse/HADOOP-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255807#comment-14255807 ] Hudson commented on HADOOP-11429: - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #50 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/50/]) HADOOP-11429. Findbugs warnings in hadoop extras. Contributed by Varun Saxena. (wheat9: rev 02b21b7131d9f1dba6d93fb3f87154e86b9825d6) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCh.java * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/Logalyzer.java * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistTool.java * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCpV1.java > Findbugs warnings in hadoop extras > -- > > Key: HADOOP-11429 > URL: https://issues.apache.org/jira/browse/HADOOP-11429 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Varun Saxena >Assignee: Varun Saxena > Fix For: 2.7.0 > > Attachments: HADOOP-11429.001.patch, HADOOP-11429.patch, > newPatchFindbugsWarningshadoop-extras.html > > > 9 new findbugs warnings in hadoop-extras. Check the attached report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11414) FileBasedIPList#readLines() can leak file descriptors
[
https://issues.apache.org/jira/browse/HADOOP-11414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255836#comment-14255836
]
Hudson commented on HADOOP-11414:
-
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2000 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2000/])
HADOOP-11414. FileBasedIPList#readLines() can leak file descriptors. (ozawa)
(ozawa: rev ecf1469fa51f9977f70652fac313d4a9ec1eb86f)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/FileBasedIPList.java
> FileBasedIPList#readLines() can leak file descriptors
> -
>
> Key: HADOOP-11414
> URL: https://issues.apache.org/jira/browse/HADOOP-11414
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.6.0
>Reporter: Ted Yu
>Assignee: Tsuyoshi OZAWA
>Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HADOOP-11414.1.patch, HADOOP-11414.2.patch,
> HADOOP-11414.3.patch, HADOOP-11414.4.patch
>
>
> {code}
> Reader fileReader = new InputStreamReader(
> new FileInputStream(file), Charsets.UTF_8);
> BufferedReader bufferedReader = new BufferedReader(fileReader);
> List lines = new ArrayList();
> String line = null;
> while ((line = bufferedReader.readLine()) != null) {
> lines.add(line);
> }
> bufferedReader.close();
> {code}
> Since bufferedReader.readLine() may throw IOE, so the close of bufferedReader
> should be enclosed within finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11429) Findbugs warnings in hadoop extras
[ https://issues.apache.org/jira/browse/HADOOP-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255837#comment-14255837 ] Hudson commented on HADOOP-11429: - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2000 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2000/]) HADOOP-11429. Findbugs warnings in hadoop extras. Contributed by Varun Saxena. (wheat9: rev 02b21b7131d9f1dba6d93fb3f87154e86b9825d6) * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCh.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistTool.java * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/DistCpV1.java * hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/Logalyzer.java > Findbugs warnings in hadoop extras > -- > > Key: HADOOP-11429 > URL: https://issues.apache.org/jira/browse/HADOOP-11429 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Varun Saxena >Assignee: Varun Saxena > Fix For: 2.7.0 > > Attachments: HADOOP-11429.001.patch, HADOOP-11429.patch, > newPatchFindbugsWarningshadoop-extras.html > > > 9 new findbugs warnings in hadoop-extras. Check the attached report -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11402) Negative user-to-group cache entries are never cleared for never-again-accessed users
[ https://issues.apache.org/jira/browse/HADOOP-11402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255852#comment-14255852 ] Benoy Antony commented on HADOOP-11402: --- [~varun_saxena], Can we use Guava cache(https://code.google.com/p/guava-libraries/wiki/CachesExplained) for negative cache ? Most of the added functionality is already encapsulated in Guava cache. > Negative user-to-group cache entries are never cleared for > never-again-accessed users > - > > Key: HADOOP-11402 > URL: https://issues.apache.org/jira/browse/HADOOP-11402 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Colin Patrick McCabe >Assignee: Varun Saxena >Priority: Minor > Attachments: HADOOP-11402.001.patch > > > Negative user-to-group cache entries are never cleared for > never-again-accessed users. We should have a background thread that runs > very infrequently and removes these expired entries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-11399) Java Configuration file and .xml files should be automatically cross-compared
[ https://issues.apache.org/jira/browse/HADOOP-11399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Chiang updated HADOOP-11399: Attachment: HADOOP-11399.003.patch Add findbugs exclusion > Java Configuration file and .xml files should be automatically cross-compared > - > > Key: HADOOP-11399 > URL: https://issues.apache.org/jira/browse/HADOOP-11399 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 2.4.1 >Reporter: Ray Chiang >Assignee: Ray Chiang >Priority: Minor > Labels: supportability > Attachments: HADOOP-11399.001.patch, HADOOP-11399.002.patch, > HADOOP-11399.003.patch, YARN-2284-04.patch, YARN-2284-05.patch, > YARN-2284-06.patch, YARN-2284-07.patch, YARN-2284-08.patch, > YARN-2284-09.patch, YARN2284-01.patch, YARN2284-02.patch, YARN2284-03.patch > > > Update common in order to allow automatic comparison of Java Configuration > classes and xxx-default.xml files within a unit test. Changes here will be > used in downstream JIRAs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HADOOP-11380) Restore Rack Awareness documentation
[ https://issues.apache.org/jira/browse/HADOOP-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer reassigned HADOOP-11380: - Assignee: Allen Wittenauer > Restore Rack Awareness documentation > > > Key: HADOOP-11380 > URL: https://issues.apache.org/jira/browse/HADOOP-11380 > Project: Hadoop Common > Issue Type: Bug >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 3.0.0 > > Attachments: HADOOP-11380.patch > > > As part of HADOOP-8427, large, extremely useful sections of the Rack > Awareness documentation that was added in HADOOP-6616 was wiped out. We > should restore it as a separate document. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11400) GraphiteSink does not reconnect to Graphite after 'broken pipe'
[ https://issues.apache.org/jira/browse/HADOOP-11400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256069#comment-14256069 ] Ravi Prakash commented on HADOOP-11400: --- Hi Kamil! https://wiki.apache.org/hadoop/HowToContribute Just follow the same code formatting and create a patch file to upload onto this JIRA. > GraphiteSink does not reconnect to Graphite after 'broken pipe' > --- > > Key: HADOOP-11400 > URL: https://issues.apache.org/jira/browse/HADOOP-11400 > Project: Hadoop Common > Issue Type: Bug > Components: metrics >Affects Versions: 2.6.0, 2.5.1 >Reporter: Kamil Gorlo > > I see that after network error GraphiteSink does not reconnects to Graphite > server and in effect metrics are not sent. > Here is stacktrace I see (this is from nodemanager): > 2014-12-11 16:39:21,655 ERROR > org.apache.hadoop.metrics2.impl.MetricsSinkAdapter: Got sink exception, retry > in 4806ms > org.apache.hadoop.metrics2.MetricsException: Error flushing metrics > at > org.apache.hadoop.metrics2.sink.GraphiteSinkFixed.flush(GraphiteSinkFixed.java:120) > at > org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:184) > at > org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:43) > at > org.apache.hadoop.metrics2.impl.SinkQueue.consumeAll(SinkQueue.java:87) > at > org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.publishMetricsFromQueue(MetricsSinkAdapter.java:129) > at > org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1.run(MetricsSinkAdapter.java:88) > Caused by: java.net.SocketException: Broken pipe > at java.net.SocketOutputStream.socketWrite0(Native Method) > at > java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:113) > at java.net.SocketOutputStream.write(SocketOutputStream.java:159) > at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221) > at sun.nio.cs.StreamEncoder.implFlushBuffer(StreamEncoder.java:291) > at sun.nio.cs.StreamEncoder.implFlush(StreamEncoder.java:295) > at sun.nio.cs.StreamEncoder.flush(StreamEncoder.java:141) > at java.io.OutputStreamWriter.flush(OutputStreamWriter.java:229) > at > org.apache.hadoop.metrics2.sink.GraphiteSinkFixed.flush(GraphiteSinkFixed.java:118) > ... 5 more > 2014-12-11 16:39:26,463 ERROR > org.apache.hadoop.metrics2.impl.MetricsSinkAdapter: Got sink exception and > over retry limit, suppressing further error messages > org.apache.hadoop.metrics2.MetricsException: Error flushing metrics > at > org.apache.hadoop.metrics2.sink.GraphiteSinkFixed.flush(GraphiteSinkFixed.java:120) > at > org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:184) > at > org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:43) > at > org.apache.hadoop.metrics2.impl.SinkQueue.consumeAll(SinkQueue.java:87) > at > org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.publishMetricsFromQueue(MetricsSinkAdapter.java:129) > at > org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1.run(MetricsSinkAdapter.java:88) > Caused by: java.net.SocketException: Broken pipe > at java.net.SocketOutputStream.socketWrite0(Native Method) > at > java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:113) > at java.net.SocketOutputStream.write(SocketOutputStream.java:159) > at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221) > at sun.nio.cs.StreamEncoder.implFlushBuffer(StreamEncoder.java:291) > at sun.nio.cs.StreamEncoder.implFlush(StreamEncoder.java:295) > at sun.nio.cs.StreamEncoder.flush(StreamEncoder.java:141) > at java.io.OutputStreamWriter.flush(OutputStreamWriter.java:229) > at > org.apache.hadoop.metrics2.sink.GraphiteSinkFixed.flush(GraphiteSinkFixed.java:118) > ... 5 more > GraphiteSinkFixed.java is simply GraphiteSink.java from Hadoop 2.6.0 (with > fixed https://issues.apache.org/jira/browse/HADOOP-11182) because I cannot > simply upgrade Hadoop (I am using CDH5). > I see that GraphiteSink is using OutputStreamWriter which is created only in > init method (which is probably called only once per application runtime) and > there is no reconnection logic. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-11295) RPC Server Reader thread can't shutdown if RPCCallQueue is full
[
https://issues.apache.org/jira/browse/HADOOP-11295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gera Shegalov updated HADOOP-11295:
---
Attachment: HADOOP-11295-4.patch
[~mingma], I took the liberty to incorporate my nit comments myself while you
are on a break. Let me know whether it looks good to you when get a chance.
It would also be good if some other committer takes a look as well.
> RPC Server Reader thread can't shutdown if RPCCallQueue is full
> ---
>
> Key: HADOOP-11295
> URL: https://issues.apache.org/jira/browse/HADOOP-11295
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Ming Ma
>Assignee: Ming Ma
> Attachments: HADOOP-11295-2.patch, HADOOP-11295-3.patch,
> HADOOP-11295-4.patch, HADOOP-11295.patch
>
>
> If RPC server is asked to stop when RPCCallQueue is full, {{reader.join()}}
> will just wait there. That is because
> 1. The reader thread is blocked on {{callQueue.put(call);}}.
> 2. When RPC server is asked to stop, it will interrupt all handler threads
> and thus no threads will drain the callQueue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (HADOOP-11010) Post-9902 "Umbrella" JIRA
[ https://issues.apache.org/jira/browse/HADOOP-11010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Smith reassigned HADOOP-11010: --- Assignee: John Smith (was: Allen Wittenauer) > Post-9902 "Umbrella" JIRA > - > > Key: HADOOP-11010 > URL: https://issues.apache.org/jira/browse/HADOOP-11010 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Allen Wittenauer >Assignee: John Smith > > Umbrella JIRA to keep track of bug fixes and enhancements, now that the major > portion of the shell script rewrite has been committed. Some of these are > the result of 9902, others are just projects that I missed that should really > be done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-11010) Post-9902 "Umbrella" JIRA
[ https://issues.apache.org/jira/browse/HADOOP-11010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Smith updated HADOOP-11010: Attachment: HADOOP-10788-04.patch Fix [~aw]'s bugs. ^_^; > Post-9902 "Umbrella" JIRA > - > > Key: HADOOP-11010 > URL: https://issues.apache.org/jira/browse/HADOOP-11010 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Allen Wittenauer >Assignee: John Smith > Attachments: HADOOP-10788-04.patch > > > Umbrella JIRA to keep track of bug fixes and enhancements, now that the major > portion of the shell script rewrite has been committed. Some of these are > the result of 9902, others are just projects that I missed that should really > be done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11010) Post-9902 "Umbrella" JIRA
[ https://issues.apache.org/jira/browse/HADOOP-11010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256115#comment-14256115 ] John Smith commented on HADOOP-11010: - Oh! Wrong jira! > Post-9902 "Umbrella" JIRA > - > > Key: HADOOP-11010 > URL: https://issues.apache.org/jira/browse/HADOOP-11010 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Allen Wittenauer >Assignee: John Smith > Attachments: HADOOP-10788-04.patch > > > Umbrella JIRA to keep track of bug fixes and enhancements, now that the major > portion of the shell script rewrite has been committed. Some of these are > the result of 9902, others are just projects that I missed that should really > be done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-10788) Rewrite kms to use new shell framework
[ https://issues.apache.org/jira/browse/HADOOP-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Smith updated HADOOP-10788: Attachment: HADOOP-10788-04.patch Fix [~aw]'s bugs. ^_^; > Rewrite kms to use new shell framework > -- > > Key: HADOOP-10788 > URL: https://issues.apache.org/jira/browse/HADOOP-10788 > Project: Hadoop Common > Issue Type: Improvement > Components: scripts >Affects Versions: 3.0.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Labels: scripts > Attachments: HADOOP-10788-01.patch, HADOOP-10788-02.patch, > HADOOP-10788-03.patch, HADOOP-10788-04.patch, HADOOP-10788.patch > > > kms was not rewritten to use the new shell framework. It should be reworked > to take advantage of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HADOOP-10788) Rewrite kms to use new shell framework
[ https://issues.apache.org/jira/browse/HADOOP-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Smith reassigned HADOOP-10788: --- Assignee: John Smith (was: Allen Wittenauer) > Rewrite kms to use new shell framework > -- > > Key: HADOOP-10788 > URL: https://issues.apache.org/jira/browse/HADOOP-10788 > Project: Hadoop Common > Issue Type: Improvement > Components: scripts >Affects Versions: 3.0.0 >Reporter: Allen Wittenauer >Assignee: John Smith > Labels: scripts > Attachments: HADOOP-10788-01.patch, HADOOP-10788-02.patch, > HADOOP-10788-03.patch, HADOOP-10788-04.patch, HADOOP-10788.patch > > > kms was not rewritten to use the new shell framework. It should be reworked > to take advantage of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-11010) Post-9902 "Umbrella" JIRA
[ https://issues.apache.org/jira/browse/HADOOP-11010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Smith updated HADOOP-11010: Assignee: Allen Wittenauer (was: John Smith) > Post-9902 "Umbrella" JIRA > - > > Key: HADOOP-11010 > URL: https://issues.apache.org/jira/browse/HADOOP-11010 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Attachments: HADOOP-10788-04.patch > > > Umbrella JIRA to keep track of bug fixes and enhancements, now that the major > portion of the shell script rewrite has been committed. Some of these are > the result of 9902, others are just projects that I missed that should really > be done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11399) Java Configuration file and .xml files should be automatically cross-compared
[
https://issues.apache.org/jira/browse/HADOOP-11399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256131#comment-14256131
]
Hadoop QA commented on HADOOP-11399:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12688702/HADOOP-11399.003.patch
against trunk revision a696fbb.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5330//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5330//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5330//console
This message is automatically generated.
> Java Configuration file and .xml files should be automatically cross-compared
> -
>
> Key: HADOOP-11399
> URL: https://issues.apache.org/jira/browse/HADOOP-11399
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.4.1
>Reporter: Ray Chiang
>Assignee: Ray Chiang
>Priority: Minor
> Labels: supportability
> Attachments: HADOOP-11399.001.patch, HADOOP-11399.002.patch,
> HADOOP-11399.003.patch, YARN-2284-04.patch, YARN-2284-05.patch,
> YARN-2284-06.patch, YARN-2284-07.patch, YARN-2284-08.patch,
> YARN-2284-09.patch, YARN2284-01.patch, YARN2284-02.patch, YARN2284-03.patch
>
>
> Update common in order to allow automatic comparison of Java Configuration
> classes and xxx-default.xml files within a unit test. Changes here will be
> used in downstream JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11399) Java Configuration file and .xml files should be automatically cross-compared
[ https://issues.apache.org/jira/browse/HADOOP-11399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256137#comment-14256137 ] Ray Chiang commented on HADOOP-11399: - RE: findbugs. Configuration findbugs is masked properly. Remaining 3 are unrelated. > Java Configuration file and .xml files should be automatically cross-compared > - > > Key: HADOOP-11399 > URL: https://issues.apache.org/jira/browse/HADOOP-11399 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 2.4.1 >Reporter: Ray Chiang >Assignee: Ray Chiang >Priority: Minor > Labels: supportability > Attachments: HADOOP-11399.001.patch, HADOOP-11399.002.patch, > HADOOP-11399.003.patch, YARN-2284-04.patch, YARN-2284-05.patch, > YARN-2284-06.patch, YARN-2284-07.patch, YARN-2284-08.patch, > YARN-2284-09.patch, YARN2284-01.patch, YARN2284-02.patch, YARN2284-03.patch > > > Update common in order to allow automatic comparison of Java Configuration > classes and xxx-default.xml files within a unit test. Changes here will be > used in downstream JIRAs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11295) RPC Server Reader thread can't shutdown if RPCCallQueue is full
[
https://issues.apache.org/jira/browse/HADOOP-11295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256161#comment-14256161
]
Hadoop QA commented on HADOOP-11295:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12688707/HADOOP-11295-4.patch
against trunk revision a696fbb.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverControllerStress
org.apache.hadoop.ipc.TestRPC
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5331//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5331//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5331//console
This message is automatically generated.
> RPC Server Reader thread can't shutdown if RPCCallQueue is full
> ---
>
> Key: HADOOP-11295
> URL: https://issues.apache.org/jira/browse/HADOOP-11295
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Ming Ma
>Assignee: Ming Ma
> Attachments: HADOOP-11295-2.patch, HADOOP-11295-3.patch,
> HADOOP-11295-4.patch, HADOOP-11295.patch
>
>
> If RPC server is asked to stop when RPCCallQueue is full, {{reader.join()}}
> will just wait there. That is because
> 1. The reader thread is blocked on {{callQueue.put(call);}}.
> 2. When RPC server is asked to stop, it will interrupt all handler threads
> and thus no threads will drain the callQueue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11402) Negative user-to-group cache entries are never cleared for never-again-accessed users
[ https://issues.apache.org/jira/browse/HADOOP-11402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255852#comment-14255852 ] Benoy Antony edited comment on HADOOP-11402 at 12/22/14 8:33 PM: - [~varun_saxena], Can we use Guava cache(https://code.google.com/p/guava-libraries/wiki/CachesExplained) for negative cache ? Most of the added functionality is already encapsulated in Guava cache. You could also explore the possibility of using the existing Guava cache for +ve caching for negative caching also. was (Author: benoyantony): [~varun_saxena], Can we use Guava cache(https://code.google.com/p/guava-libraries/wiki/CachesExplained) for negative cache ? Most of the added functionality is already encapsulated in Guava cache. > Negative user-to-group cache entries are never cleared for > never-again-accessed users > - > > Key: HADOOP-11402 > URL: https://issues.apache.org/jira/browse/HADOOP-11402 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Colin Patrick McCabe >Assignee: Varun Saxena >Priority: Minor > Attachments: HADOOP-11402.001.patch > > > Negative user-to-group cache entries are never cleared for > never-again-accessed users. We should have a background thread that runs > very infrequently and removes these expired entries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-10788) Rewrite kms to use new shell framework
[
https://issues.apache.org/jira/browse/HADOOP-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256184#comment-14256184
]
Hadoop QA commented on HADOOP-10788:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12688709/HADOOP-10788-04.patch
against trunk revision a696fbb.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5332//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5332//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5332//console
This message is automatically generated.
> Rewrite kms to use new shell framework
> --
>
> Key: HADOOP-10788
> URL: https://issues.apache.org/jira/browse/HADOOP-10788
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
>Affects Versions: 3.0.0
>Reporter: Allen Wittenauer
>Assignee: John Smith
> Labels: scripts
> Attachments: HADOOP-10788-01.patch, HADOOP-10788-02.patch,
> HADOOP-10788-03.patch, HADOOP-10788-04.patch, HADOOP-10788.patch
>
>
> kms was not rewritten to use the new shell framework. It should be reworked
> to take advantage of it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HADOOP-11442) hadoop-azure: Create test jar
[ https://issues.apache.org/jira/browse/HADOOP-11442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated HADOOP-11442: --- Assignee: (was: Chris Nauroth) > hadoop-azure: Create test jar > - > > Key: HADOOP-11442 > URL: https://issues.apache.org/jira/browse/HADOOP-11442 > Project: Hadoop Common > Issue Type: Improvement > Components: tools >Reporter: shashank > > pom of hadoop-azure project to needs to be modified to create a test jar as > well. This test jar is required to run test cases of Windowsazuretablesink -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-11442) hadoop-azure: Create test jar
[ https://issues.apache.org/jira/browse/HADOOP-11442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated HADOOP-11442: --- Assignee: shashank > hadoop-azure: Create test jar > - > > Key: HADOOP-11442 > URL: https://issues.apache.org/jira/browse/HADOOP-11442 > Project: Hadoop Common > Issue Type: Improvement > Components: tools >Reporter: shashank >Assignee: shashank > > pom of hadoop-azure project to needs to be modified to create a test jar as > well. This test jar is required to run test cases of Windowsazuretablesink -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-11441) Hadoop-azure: Change few methods and class scope to public
[ https://issues.apache.org/jira/browse/HADOOP-11441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated HADOOP-11441: --- Assignee: shashank (was: Chris Nauroth) > Hadoop-azure: Change few methods and class scope to public > -- > > Key: HADOOP-11441 > URL: https://issues.apache.org/jira/browse/HADOOP-11441 > Project: Hadoop Common > Issue Type: Improvement > Components: tools >Reporter: shashank >Assignee: shashank > > TestWindowsAzureTableSinkSetup class test cases have dependencies with > hadoop-azure test classes, however few functions in hadoop azure test classes > are having default access and are not visible outside package. > AzureBlobStorageTestAccount.createTestAccount() > AzureNativeFileSystemStore.getAccountKeyFromConfiguration() > also visibility of AzureNativeFileSystemStore class needs to be changed as > well -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HADOOP-11443) hadoop.auth cookie has invalid Expires if used with non-US default Locale
Gregory Chanan created HADOOP-11443:
---
Summary: hadoop.auth cookie has invalid Expires if used with
non-US default Locale
Key: HADOOP-11443
URL: https://issues.apache.org/jira/browse/HADOOP-11443
Project: Hadoop Common
Issue Type: Bug
Components: security
Affects Versions: 2.5.0
Reporter: Gregory Chanan
Assignee: Gregory Chanan
The netscape cookie spec (http://curl.haxx.se/rfc/cookie_spec.html) does not
specify the language of the EXPIRES attribute:
{code}
The date string is formatted as:
Wdy, DD-Mon- HH:MM:SS GMT
This is based on RFC 822, RFC 850, RFC 1036, and RFC 1123, with the variations
that the only legal time zone is GMT and the separators between the elements of
the date must be dashes.
{code}
But RFC 822, lists the months as:
{code}
month = "Jan" / "Feb" / "Mar" / "Apr"
/ "May" / "Jun" / "Jul" / "Aug"
/ "Sep" / "Oct" / "Nov" / "Dec"
{code}
and some clients (i.e. httpclient) do not recognize Expires in other languages,
so it's best to just use US English (which is the only Locale guaranteed to be
supported by the jvm, see
http://www.oracle.com/technetwork/articles/javase/locale-140624.html).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HADOOP-11443) hadoop.auth cookie has invalid Expires if used with non-US default Locale
[
https://issues.apache.org/jira/browse/HADOOP-11443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gregory Chanan updated HADOOP-11443:
Attachment: HADOOP-11443.patch
Here's a patch that generates the date using the US locale and a test that sets
a different locale and verifies the cookie still works with httpclient.
> hadoop.auth cookie has invalid Expires if used with non-US default Locale
> -
>
> Key: HADOOP-11443
> URL: https://issues.apache.org/jira/browse/HADOOP-11443
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
>Affects Versions: 2.5.0
>Reporter: Gregory Chanan
>Assignee: Gregory Chanan
> Attachments: HADOOP-11443.patch
>
>
> The netscape cookie spec (http://curl.haxx.se/rfc/cookie_spec.html) does not
> specify the language of the EXPIRES attribute:
> {code}
> The date string is formatted as:
> Wdy, DD-Mon- HH:MM:SS GMT
> This is based on RFC 822, RFC 850, RFC 1036, and RFC 1123, with the
> variations that the only legal time zone is GMT and the separators between
> the elements of the date must be dashes.
> {code}
> But RFC 822, lists the months as:
> {code}
> month = "Jan" / "Feb" / "Mar" / "Apr"
> / "May" / "Jun" / "Jul" / "Aug"
> / "Sep" / "Oct" / "Nov" / "Dec"
> {code}
> and some clients (i.e. httpclient) do not recognize Expires in other
> languages, so it's best to just use US English (which is the only Locale
> guaranteed to be supported by the jvm, see
> http://www.oracle.com/technetwork/articles/javase/locale-140624.html).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (HADOOP-11443) hadoop.auth cookie has invalid Expires if used with non-US default Locale
[
https://issues.apache.org/jira/browse/HADOOP-11443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai resolved HADOOP-11443.
-
Resolution: Duplicate
Since we have moved to Java 7, we can use the {{Cookie}} class form Java 7
instead of hacking it here and there.
> hadoop.auth cookie has invalid Expires if used with non-US default Locale
> -
>
> Key: HADOOP-11443
> URL: https://issues.apache.org/jira/browse/HADOOP-11443
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
>Affects Versions: 2.5.0
>Reporter: Gregory Chanan
>Assignee: Gregory Chanan
> Attachments: HADOOP-11443.patch
>
>
> The netscape cookie spec (http://curl.haxx.se/rfc/cookie_spec.html) does not
> specify the language of the EXPIRES attribute:
> {code}
> The date string is formatted as:
> Wdy, DD-Mon- HH:MM:SS GMT
> This is based on RFC 822, RFC 850, RFC 1036, and RFC 1123, with the
> variations that the only legal time zone is GMT and the separators between
> the elements of the date must be dashes.
> {code}
> But RFC 822, lists the months as:
> {code}
> month = "Jan" / "Feb" / "Mar" / "Apr"
> / "May" / "Jun" / "Jul" / "Aug"
> / "Sep" / "Oct" / "Nov" / "Dec"
> {code}
> and some clients (i.e. httpclient) do not recognize Expires in other
> languages, so it's best to just use US English (which is the only Locale
> guaranteed to be supported by the jvm, see
> http://www.oracle.com/technetwork/articles/javase/locale-140624.html).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HADOOP-11295) RPC Server Reader thread can't shutdown if RPCCallQueue is full
[
https://issues.apache.org/jira/browse/HADOOP-11295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gera Shegalov updated HADOOP-11295:
---
Attachment: HADOOP-11295-5.patch
relaxed ConnectException to IOException as the expected exception.
> RPC Server Reader thread can't shutdown if RPCCallQueue is full
> ---
>
> Key: HADOOP-11295
> URL: https://issues.apache.org/jira/browse/HADOOP-11295
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Ming Ma
>Assignee: Ming Ma
> Attachments: HADOOP-11295-2.patch, HADOOP-11295-3.patch,
> HADOOP-11295-4.patch, HADOOP-11295-5.patch, HADOOP-11295.patch
>
>
> If RPC server is asked to stop when RPCCallQueue is full, {{reader.join()}}
> will just wait there. That is because
> 1. The reader thread is blocked on {{callQueue.put(call);}}.
> 2. When RPC server is asked to stop, it will interrupt all handler threads
> and thus no threads will drain the callQueue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11295) RPC Server Reader thread can't shutdown if RPCCallQueue is full
[
https://issues.apache.org/jira/browse/HADOOP-11295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256649#comment-14256649
]
Hadoop QA commented on HADOOP-11295:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12688791/HADOOP-11295-5.patch
against trunk revision fdf042d.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverControllerStress
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5333//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5333//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5333//console
This message is automatically generated.
> RPC Server Reader thread can't shutdown if RPCCallQueue is full
> ---
>
> Key: HADOOP-11295
> URL: https://issues.apache.org/jira/browse/HADOOP-11295
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Ming Ma
>Assignee: Ming Ma
> Attachments: HADOOP-11295-2.patch, HADOOP-11295-3.patch,
> HADOOP-11295-4.patch, HADOOP-11295-5.patch, HADOOP-11295.patch
>
>
> If RPC server is asked to stop when RPCCallQueue is full, {{reader.join()}}
> will just wait there. That is because
> 1. The reader thread is blocked on {{callQueue.put(call);}}.
> 2. When RPC server is asked to stop, it will interrupt all handler threads
> and thus no threads will drain the callQueue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11423) [Umbrella] Support Java 10 in Hadoop
[ https://issues.apache.org/jira/browse/HADOOP-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256657#comment-14256657 ] Andrew Purtell commented on HADOOP-11423: - Is this snark? > [Umbrella] Support Java 10 in Hadoop > > > Key: HADOOP-11423 > URL: https://issues.apache.org/jira/browse/HADOOP-11423 > Project: Hadoop Common > Issue Type: New Feature >Reporter: sneaky > > Java 10 is coming quickly to various clusters. Making sure Hadoop seamlessly > works with Java 10 is important for the Apache community. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
