[jira] [Assigned] (HADOOP-12284) UserGroupInformation doAs can throw misleading exception

2015-09-29 Thread Steve Loughran (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran reassigned HADOOP-12284:
---

Assignee: Steve Loughran  (was: Aaron Dossett)

> UserGroupInformation doAs can throw misleading exception
> 
>
> Key: HADOOP-12284
> URL: https://issues.apache.org/jira/browse/HADOOP-12284
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: security
>Reporter: Aaron Dossett
>Assignee: Steve Loughran
>Priority: Trivial
> Attachments: HADOOP-12284-002.patch, HADOOP-12284-003.patch, 
> HADOOP-12284-004.patch, HADOOP-12284.example, HADOOP-12284.patch
>
>
> If doAs() catches a PrivilegedActionException it extracts the underlying 
> cause through getCause and then re-throws an exception based on the class of 
> the Cause.  If getCause returns null, this is how it gets re-thrown:
> else {
> throw new UndeclaredThrowableException(cause);
>   }
> If cause == null that seems misleading. I have seen actual instances where 
> cause is null, so this isn't just a theoretical concern.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12284) UserGroupInformation doAs can throw misleading exception

2015-09-29 Thread Steve Loughran (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HADOOP-12284:

Assignee: Aaron Dossett  (was: Steve Loughran)
  Status: Patch Available  (was: In Progress)

> UserGroupInformation doAs can throw misleading exception
> 
>
> Key: HADOOP-12284
> URL: https://issues.apache.org/jira/browse/HADOOP-12284
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: security
>Reporter: Aaron Dossett
>Assignee: Aaron Dossett
>Priority: Trivial
> Attachments: HADOOP-12284-002.patch, HADOOP-12284-003.patch, 
> HADOOP-12284-004.patch, HADOOP-12284.example, HADOOP-12284.patch
>
>
> If doAs() catches a PrivilegedActionException it extracts the underlying 
> cause through getCause and then re-throws an exception based on the class of 
> the Cause.  If getCause returns null, this is how it gets re-thrown:
> else {
> throw new UndeclaredThrowableException(cause);
>   }
> If cause == null that seems misleading. I have seen actual instances where 
> cause is null, so this isn't just a theoretical concern.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12284) UserGroupInformation doAs can throw misleading exception

2015-09-29 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934785#comment-14934785
 ] 

Steve Loughran commented on HADOOP-12284:
-

yes, that's what I was thinking of. Submitted the patch (I think you have to 
not have it tagged as in progress for the submission; I had to assign it to 
myself briefly). 

I think checkstyle will fail on line length; otherwise I'm happy with it

> UserGroupInformation doAs can throw misleading exception
> 
>
> Key: HADOOP-12284
> URL: https://issues.apache.org/jira/browse/HADOOP-12284
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: security
>Reporter: Aaron Dossett
>Assignee: Aaron Dossett
>Priority: Trivial
> Attachments: HADOOP-12284-002.patch, HADOOP-12284-003.patch, 
> HADOOP-12284-004.patch, HADOOP-12284.example, HADOOP-12284.patch
>
>
> If doAs() catches a PrivilegedActionException it extracts the underlying 
> cause through getCause and then re-throws an exception based on the class of 
> the Cause.  If getCause returns null, this is how it gets re-thrown:
> else {
> throw new UndeclaredThrowableException(cause);
>   }
> If cause == null that seems misleading. I have seen actual instances where 
> cause is null, so this isn't just a theoretical concern.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12284) UserGroupInformation doAs can throw misleading exception

2015-09-29 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934830#comment-14934830
 ] 

Hadoop QA commented on HADOOP-12284:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  17m 30s | Pre-patch trunk has 1 extant 
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |   8m  5s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |  10m 23s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 24s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   1m  8s | The applied patch generated  1 
new checkstyle issues (total was 108, now 109). |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 27s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 53s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |   7m 58s | Tests passed in 
hadoop-common. |
| | |  49m 24s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12764077/HADOOP-12284-004.patch 
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 151fca5 |
| Pre-patch Findbugs warnings | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7730/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
 |
| checkstyle |  
https://builds.apache.org/job/PreCommit-HADOOP-Build/7730/artifact/patchprocess/diffcheckstylehadoop-common.txt
 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7730/artifact/patchprocess/testrun_hadoop-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7730/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7730/console |


This message was automatically generated.

> UserGroupInformation doAs can throw misleading exception
> 
>
> Key: HADOOP-12284
> URL: https://issues.apache.org/jira/browse/HADOOP-12284
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: security
>Reporter: Aaron Dossett
>Assignee: Aaron Dossett
>Priority: Trivial
> Attachments: HADOOP-12284-002.patch, HADOOP-12284-003.patch, 
> HADOOP-12284-004.patch, HADOOP-12284.example, HADOOP-12284.patch
>
>
> If doAs() catches a PrivilegedActionException it extracts the underlying 
> cause through getCause and then re-throws an exception based on the class of 
> the Cause.  If getCause returns null, this is how it gets re-thrown:
> else {
> throw new UndeclaredThrowableException(cause);
>   }
> If cause == null that seems misleading. I have seen actual instances where 
> cause is null, so this isn't just a theoretical concern.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-8437) getLocalPathForWrite is not throwing any expection for invalid paths

2015-09-29 Thread Brahma Reddy Battula (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brahma Reddy Battula updated HADOOP-8437:
-
Attachment: HADOOP-8437-004.patch

> getLocalPathForWrite is not throwing any expection for invalid paths
> 
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs
>Affects Versions: 2.0.0-alpha, 2.6.0, 3.0.0
>Reporter: Brahma Reddy Battula
>Assignee: Brahma Reddy Battula
>  Labels: BB2015-05-TBR
> Attachments: HADOOP-8437-003.patch, HADOOP-8437-004.patch, 
> HADOOP-8437.patch, HADOOP-8437_1.patch, HADOOP-8437_2.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread Colin Patrick McCabe (JIRA)
Colin Patrick McCabe created HADOOP-12447:
-

 Summary: Clean up some htrace integration issues
 Key: HADOOP-12447
 URL: https://issues.apache.org/jira/browse/HADOOP-12447
 Project: Hadoop Common
  Issue Type: Bug
  Components: tracing
Affects Versions: 2.8.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe


Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-8437) getLocalPathForWrite is not throwing any expection for invalid paths

2015-09-29 Thread Brahma Reddy Battula (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934854#comment-14934854
 ] 

Brahma Reddy Battula commented on HADOOP-8437:
--

[~zxu] thanks for taking a look into this issue.. Updated patch based on your 
comments..Kindly Review..

> getLocalPathForWrite is not throwing any expection for invalid paths
> 
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs
>Affects Versions: 2.0.0-alpha, 2.6.0, 3.0.0
>Reporter: Brahma Reddy Battula
>Assignee: Brahma Reddy Battula
>  Labels: BB2015-05-TBR
> Attachments: HADOOP-8437-003.patch, HADOOP-8437-004.patch, 
> HADOOP-8437.patch, HADOOP-8437_1.patch, HADOOP-8437_2.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-8437) getLocalPathForWrite is not throwing any expection for invalid paths

2015-09-29 Thread Brahma Reddy Battula (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brahma Reddy Battula updated HADOOP-8437:
-
Labels:   (was: BB2015-05-TBR)
Status: Patch Available  (was: Open)

> getLocalPathForWrite is not throwing any expection for invalid paths
> 
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs
>Affects Versions: 2.6.0, 2.0.0-alpha, 3.0.0
>Reporter: Brahma Reddy Battula
>Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437-003.patch, HADOOP-8437-004.patch, 
> HADOOP-8437.patch, HADOOP-8437_1.patch, HADOOP-8437_2.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread Colin Patrick McCabe (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934864#comment-14934864
 ] 

Colin Patrick McCabe commented on HADOOP-12447:
---

{{hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md}}: update 
the documentation to remove references to the obsolete {{dfs.htrace}} 
configuration keys and the deprecated no-argument {{Tracer#Builder}} 
constructor.  Update the configuration keys described here to be their modern 
equivalents.

{{HdfsClientConfigKeys.java}}, {{DFSConfigKeys.java}}, {{hdfs-default.xml}}: 
remove references to the unused obsolete configuration key 
{{dfs.client.htrace.sampler.classes}}

{{NameNodeRpcServer.java}}: we should set the Tracer for the 
{{serviceRpcServer}} (the RPC server which DNs talk to) as well as the for 
{{clientRpcServer}}.  Due to a typo, only one of them was getting set.

{{NamenodeFsck.java}}: we should construct a {{Tracer}} using the configuration 
prefix {{namenode.fsck.htrace}} so that tracing can be enabled specifically for 
fsck.

{{TestBlockTokenWithDFS.java}}, {{TestDataNodeVolumeFailure.java}}: set the 
Tracer object when constructing a {{BlockReader}}.  It isn't strictly 
necessary, but it is awkward to have {{tracer}} be a null pointer, and it will 
be helpful if these tests need to be extended in the future.  (Note: may need 
to be done on JspHelper in older branches)

> Clean up some htrace integration issues
> ---
>
> Key: HADOOP-12447
> URL: https://issues.apache.org/jira/browse/HADOOP-12447
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: tracing
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>
> Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread Colin Patrick McCabe (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colin Patrick McCabe updated HADOOP-12447:
--
Attachment: HADOOP-12447.002.patch

> Clean up some htrace integration issues
> ---
>
> Key: HADOOP-12447
> URL: https://issues.apache.org/jira/browse/HADOOP-12447
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: tracing
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HADOOP-12447.002.patch
>
>
> Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread Colin Patrick McCabe (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colin Patrick McCabe updated HADOOP-12447:
--
Status: Patch Available  (was: Open)

> Clean up some htrace integration issues
> ---
>
> Key: HADOOP-12447
> URL: https://issues.apache.org/jira/browse/HADOOP-12447
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: tracing
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HADOOP-12447.002.patch
>
>
> Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-8437) getLocalPathForWrite is not throwing any expection for invalid paths

2015-09-29 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934924#comment-14934924
 ] 

Hadoop QA commented on HADOOP-8437:
---

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  17m 17s | Pre-patch trunk has 1 extant 
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 1 new or modified test files. |
| {color:green}+1{color} | javac |   7m 53s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |  10m  9s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 24s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   1m  5s | The applied patch generated  1 
new checkstyle issues (total was 23, now 24). |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 3  line(s) that 
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 27s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 53s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |   7m 47s | Tests passed in 
hadoop-common. |
| | |  48m 31s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12764209/HADOOP-8437-004.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / d6fa34e |
| Pre-patch Findbugs warnings | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7731/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
 |
| checkstyle |  
https://builds.apache.org/job/PreCommit-HADOOP-Build/7731/artifact/patchprocess/diffcheckstylehadoop-common.txt
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7731/artifact/patchprocess/whitespace.txt
 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7731/artifact/patchprocess/testrun_hadoop-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7731/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7731/console |


This message was automatically generated.

> getLocalPathForWrite is not throwing any expection for invalid paths
> 
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs
>Affects Versions: 2.0.0-alpha, 2.6.0, 3.0.0
>Reporter: Brahma Reddy Battula
>Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437-003.patch, HADOOP-8437-004.patch, 
> HADOOP-8437.patch, HADOOP-8437_1.patch, HADOOP-8437_2.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-8437) getLocalPathForWrite is not throwing any expection for invalid paths

2015-09-29 Thread Brahma Reddy Battula (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brahma Reddy Battula updated HADOOP-8437:
-
Attachment: HADOOP-8437-005.patch

Uploaded patch for  checkstyle and whitespace errors fix..

> getLocalPathForWrite is not throwing any expection for invalid paths
> 
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs
>Affects Versions: 2.0.0-alpha, 2.6.0, 3.0.0
>Reporter: Brahma Reddy Battula
>Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437-003.patch, HADOOP-8437-004.patch, 
> HADOOP-8437-005.patch, HADOOP-8437.patch, HADOOP-8437_1.patch, 
> HADOOP-8437_2.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-8437) getLocalPathForWrite is not throwing any expection for invalid paths

2015-09-29 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935019#comment-14935019
 ] 

Hadoop QA commented on HADOOP-8437:
---

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  17m 30s | Pre-patch trunk has 1 extant 
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 1 new or modified test files. |
| {color:green}+1{color} | javac |   7m 58s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |  10m  8s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m 10s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 27s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 51s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests |   6m 58s | Tests failed in 
hadoop-common. |
| | |  48m  1s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.security.ssl.TestReloadingX509TrustManager |
| Timed out tests | org.apache.hadoop.ha.TestZKFailoverController |
|   | org.apache.hadoop.ha.TestZKFailoverControllerStress |
|   | org.apache.hadoop.metrics2.lib.TestMutableMetrics |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12764221/HADOOP-8437-005.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / d6fa34e |
| Pre-patch Findbugs warnings | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7733/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7733/artifact/patchprocess/testrun_hadoop-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7733/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7733/console |


This message was automatically generated.

> getLocalPathForWrite is not throwing any expection for invalid paths
> 
>
> Key: HADOOP-8437
> URL: https://issues.apache.org/jira/browse/HADOOP-8437
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs
>Affects Versions: 2.0.0-alpha, 2.6.0, 3.0.0
>Reporter: Brahma Reddy Battula
>Assignee: Brahma Reddy Battula
> Attachments: HADOOP-8437-003.patch, HADOOP-8437-004.patch, 
> HADOOP-8437-005.patch, HADOOP-8437.patch, HADOOP-8437_1.patch, 
> HADOOP-8437_2.patch
>
>
> call dirAllocator.getLocalPathForWrite ( "/InvalidPath", conf );
> Here it will not thrown any exception but earlier version it used throw.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935080#comment-14935080
 ] 

stack commented on HADOOP-12447:


+1 from me. Cleans up doc so it refers to 4.0.1 htrace API.  Fixes configs 
removing no longer referenced keys.

> Clean up some htrace integration issues
> ---
>
> Key: HADOOP-12447
> URL: https://issues.apache.org/jira/browse/HADOOP-12447
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: tracing
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HADOOP-12447.002.patch
>
>
> Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935131#comment-14935131
 ] 

Hadoop QA commented on HADOOP-12447:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  22m 49s | Findbugs (version 3.0.0) 
appears to be broken on trunk. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 3 new or modified test files. |
| {color:green}+1{color} | javac |   7m 54s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |  10m 13s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 26s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | site |   3m  6s | Site still builds. |
| {color:green}+1{color} | checkstyle |   3m 12s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with 
eclipse:eclipse. |
| {color:red}-1{color} | findbugs |   6m 24s | The patch appears to introduce 1 
new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests |   6m 18s | Tests failed in 
hadoop-common. |
| {color:red}-1{color} | hdfs tests | 173m 12s | Tests failed in hadoop-hdfs. |
| {color:green}+1{color} | hdfs tests |   0m 38s | Tests passed in 
hadoop-hdfs-client. |
| | | 236m 25s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
| Failed unit tests | hadoop.metrics2.sink.TestFileSink |
|   | hadoop.hdfs.server.namenode.TestFSNamesystem |
|   | hadoop.hdfs.server.datanode.TestDirectoryScanner |
|   | hadoop.hdfs.server.namenode.ha.TestHAAppend |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12764212/HADOOP-12447.002.patch 
|
| Optional Tests | site javadoc javac unit findbugs checkstyle |
| git revision | trunk / d6fa34e |
| Pre-patch Findbugs warnings | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
 |
| Findbugs warnings | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/testrun_hadoop-common.txt
 |
| hadoop-hdfs test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/testrun_hadoop-hdfs.txt
 |
| hadoop-hdfs-client test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/console |


This message was automatically generated.

> Clean up some htrace integration issues
> ---
>
> Key: HADOOP-12447
> URL: https://issues.apache.org/jira/browse/HADOOP-12447
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: tracing
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HADOOP-12447.002.patch
>
>
> Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-10775) Shell operations to fail with meaningful errors on windows if winutils.exe not found

2015-09-29 Thread Steve Loughran (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HADOOP-10775:

Status: Open  (was: Patch Available)

> Shell operations to fail with meaningful errors on windows if winutils.exe 
> not found
> 
>
> Key: HADOOP-10775
> URL: https://issues.apache.org/jira/browse/HADOOP-10775
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: util
>Affects Versions: 2.7.1, trunk-win
> Environment: windows
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-10775-002.patch, HADOOP-10775-003.patch, 
> HADOOP-10775.patch
>
>
> If {{winutils.exe}} can't be found {{HADOOP_HOME}} wrong/unset or other 
> causes, then an error is logged -but when any of the {{Shell}} operations are 
> used, an NPE is raised rather than something meaningful.
> The error message at setup time should be preserved and then raised before 
> any attempt to invoke a winutils-driven process made



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12436) GlobPattern regex library has performance issues with wildcard characters

2015-09-29 Thread Daniel Templeton (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935157#comment-14935157
 ] 

Daniel Templeton commented on HADOOP-12436:
---

The tests passed, so that's a good sign.  Have you tried spinning up a cluster 
with the patch and banging on it a bit?

> GlobPattern regex library has performance issues with wildcard characters
> -
>
> Key: HADOOP-12436
> URL: https://issues.apache.org/jira/browse/HADOOP-12436
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: fs
>Affects Versions: 2.2.0, 2.7.1
>Reporter: Matthew Paduano
>Assignee: Matthew Paduano
> Attachments: HADOOP-12436.01.patch
>
>
> java.util.regex classes have performance problems with certain wildcard 
> patterns.  Namely, consecutive * characters in a file name (not properly 
> escaped as literals) will cause commands such as "hadoop fs -ls 
> file**name" to consume 100% CPU and probably never return in a reasonable 
> time (time scales with number of *'s). 
> Here is an example:
> {noformat}
> hadoop fs -touchz 
> /user/mattp/job_1429571161900_4222-1430338332599-tda%2D%2D\\\+\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\+\\\+\\\+...%270%27%28Stage-1430338580443-39-2000-SUCCEEDED-production%2Dhigh-1430338340360.jhist
> hadoop fs -ls 
> /user/mattp/job_1429571161900_4222-1430338332599-tda%2D%2D+**+++...%270%27%28Stage-1430338580443-39-2000-SUCCEEDED-production%2Dhigh-1430338340360.jhist
> {noformat}
> causes:
> {noformat}
> PIDCOMMAND  %CPU   TIME  
> 14526  java 100.0  01:18.85 
> {noformat}
> Not every string of *'s causes this, but the above filename reproduces this 
> reliably.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Colin Patrick McCabe (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colin Patrick McCabe updated HADOOP-12448:
--
Status: Patch Available  (was: Open)

> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HADOOP-12448.001.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Moved] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Colin Patrick McCabe (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colin Patrick McCabe moved HDFS-9177 to HADOOP-12448:
-

Affects Version/s: (was: 2.8.0)
   2.8.0
 Target Version/s: 2.8.0  (was: 2.8.0)
  Key: HADOOP-12448  (was: HDFS-9177)
  Project: Hadoop Common  (was: Hadoop HDFS)

> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Colin Patrick McCabe (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colin Patrick McCabe updated HADOOP-12448:
--
Attachment: HADOOP-12448.001.patch

> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HADOOP-12448.001.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12449) TestDNS and TestNetUtils failing if no network

2015-09-29 Thread Steve Loughran (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HADOOP-12449:

Attachment: HADOOP-12449-001.patch

fixes for tests. For the {{TestNetUtils}} one, the args for expectEquals were 
swapped with expected ahead of actual, and diagnostics text included for all 
assertions. Then the test was changed to skip on DNS.

{{TestDNS}} handles a new way for things to fail.

> TestDNS and TestNetUtils failing if no network
> --
>
> Key: HADOOP-12449
> URL: https://issues.apache.org/jira/browse/HADOOP-12449
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 3.0.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-12449-001.patch
>
>
> On a laptop with wifi enabled but unbonded, test cases in {{TestDNS}} and 
> {{TestNetUtils}} fail due to DNS problems. They need to skip in this situation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12449) TestDNS and TestNetUtils failing if no network

2015-09-29 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935388#comment-14935388
 ] 

Steve Loughran commented on HADOOP-12449:
-

original test failures

{noformat}
---
Running org.apache.hadoop.net.TestDNS
Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 15.556 sec <<< 
FAILURE! - in org.apache.hadoop.net.TestDNS
testRDNS(org.apache.hadoop.net.TestDNS)  Time elapsed: 15.049 sec  <<< ERROR!
javax.naming.CommunicationException: DNS error
at java.net.PlainDatagramSocketImpl.peekData(Native Method)
at java.net.DatagramSocket.receive(DatagramSocket.java:791)
at com.sun.jndi.dns.DnsClient.doUdpQuery(DnsClient.java:416)
at com.sun.jndi.dns.DnsClient.query(DnsClient.java:210)
at com.sun.jndi.dns.Resolver.query(Resolver.java:81)
at com.sun.jndi.dns.DnsContext.c_getAttributes(DnsContext.java:430)
at 
com.sun.jndi.toolkit.ctx.ComponentDirContext.p_getAttributes(ComponentDirContext.java:231)
at 
com.sun.jndi.toolkit.ctx.PartialCompositeDirContext.getAttributes(PartialCompositeDirContext.java:139)
at 
com.sun.jndi.toolkit.url.GenericURLDirContext.getAttributes(GenericURLDirContext.java:103)
at 
javax.naming.directory.InitialDirContext.getAttributes(InitialDirContext.java:142)
at org.apache.hadoop.net.DNS.reverseDns(DNS.java:84)
at org.apache.hadoop.net.TestDNS.testRDNS(TestDNS.java:139)



---
Running org.apache.hadoop.net.TestNetUtils
Tests run: 40, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.998 sec <<< 
FAILURE! - in org.apache.hadoop.net.TestNetUtils
testNormalizeHostName(org.apache.hadoop.net.TestNetUtils)  Time elapsed: 0.018 
sec  <<< FAILURE!
java.lang.AssertionError: Element 2 equal original [127.0.0.1, localhost, 
1.kanyezone.appspot.com, UnknownHost123] normalized [127.0.0.1, 127.0.0.1, 
1.kanyezone.appspot.com, UnknownHost123]
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at 
org.apache.hadoop.net.TestNetUtils.testNormalizeHostName(TestNetUtils.java:632)
{noformat}

> TestDNS and TestNetUtils failing if no network
> --
>
> Key: HADOOP-12449
> URL: https://issues.apache.org/jira/browse/HADOOP-12449
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 3.0.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-12449-001.patch
>
>
> On a laptop with wifi enabled but unbonded, test cases in {{TestDNS}} and 
> {{TestNetUtils}} fail due to DNS problems. They need to skip in this situation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12449) TestDNS and TestNetUtils failing if no network

2015-09-29 Thread Steve Loughran (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HADOOP-12449:

Status: Patch Available  (was: Open)

> TestDNS and TestNetUtils failing if no network
> --
>
> Key: HADOOP-12449
> URL: https://issues.apache.org/jira/browse/HADOOP-12449
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 3.0.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-12449-001.patch
>
>
> On a laptop with wifi enabled but unbonded, test cases in {{TestDNS}} and 
> {{TestNetUtils}} fail due to DNS problems. They need to skip in this situation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-10775) Shell operations to fail with meaningful errors on windows if winutils.exe not found

2015-09-29 Thread Steve Loughran (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HADOOP-10775:

Attachment: HADOOP-10775-004.patch

An iteration with

# cleanup of the tests: no need to skip symlink tests on windows
# small code review and some cleanup of Shell itself (-> SLF4J; why was the 
{{AtomicBoolean}} {{completed}} marked as {{volatile?}}
# review of tests and switch to the exception raising {{getWinUtilsPathXXX()}} 
calls.
# Improve {{NativeLibraryChecker}} to include text on windows as to why it 
couldn't be found (and don't look when not on windows)
# if you try to get the path when not on windows, an exception gets raised.
# explicit calls to probe for the path existing, and to ask for it as a 
{{File}} class.

> Shell operations to fail with meaningful errors on windows if winutils.exe 
> not found
> 
>
> Key: HADOOP-10775
> URL: https://issues.apache.org/jira/browse/HADOOP-10775
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: util
>Affects Versions: trunk-win, 2.7.1
> Environment: windows
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-10775-002.patch, HADOOP-10775-003.patch, 
> HADOOP-10775-004.patch, HADOOP-10775.patch
>
>
> If {{winutils.exe}} can't be found {{HADOOP_HOME}} wrong/unset or other 
> causes, then an error is logged -but when any of the {{Shell}} operations are 
> used, an NPE is raised rather than something meaningful.
> The error message at setup time should be preserved and then raised before 
> any attempt to invoke a winutils-driven process made



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-10775) Shell operations to fail with meaningful errors on windows if winutils.exe not found

2015-09-29 Thread Steve Loughran (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HADOOP-10775:

Status: Patch Available  (was: Open)

> Shell operations to fail with meaningful errors on windows if winutils.exe 
> not found
> 
>
> Key: HADOOP-10775
> URL: https://issues.apache.org/jira/browse/HADOOP-10775
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: util
>Affects Versions: 2.7.1, trunk-win
> Environment: windows
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-10775-002.patch, HADOOP-10775-003.patch, 
> HADOOP-10775-004.patch, HADOOP-10775.patch
>
>
> If {{winutils.exe}} can't be found {{HADOOP_HOME}} wrong/unset or other 
> causes, then an error is logged -but when any of the {{Shell}} operations are 
> used, an NPE is raised rather than something meaningful.
> The error message at setup time should be preserved and then raised before 
> any attempt to invoke a winutils-driven process made



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11003) org.apache.hadoop.util.Shell should not take a dependency on binaries being deployed when used as a library

2015-09-29 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935412#comment-14935412
 ] 

Steve Loughran commented on HADOOP-11003:
-

What about having a special log category just for "no native libs"; Shell & 
NativeCodeLoader could share it?

> org.apache.hadoop.util.Shell should not take a dependency on binaries being 
> deployed when used as a library
> ---
>
> Key: HADOOP-11003
> URL: https://issues.apache.org/jira/browse/HADOOP-11003
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: util
> Environment: Windows
>Reporter: Remus Rusanu
>
> HIVE-7845 shows how an exception is being thrown when 
> org.apache.hadoop.util.Shell is being used as a library, not as part of a 
> deployed Hadoop environment.
> {code}
> 13:20:00 [ERROR pool-2-thread-4 Shell.getWinUtilsPath] Failed to locate the 
> winutils binary in the hadoop binary path
> java.io.IOException: Could not locate executable null\bin\winutils.exe in the 
> Hadoop binaries.
>at 
> org.apache.hadoop.util.Shell.getQualifiedBinPath(Shell.java:324)
>at org.apache.hadoop.util.Shell.getWinUtilsPath(Shell.java:339)
>at org.apache.hadoop.util.Shell.(Shell.java:332)
>at 
> org.apache.hadoop.hive.conf.HiveConf$ConfVars.findHadoopBinary(HiveConf.java:918)
>at 
> org.apache.hadoop.hive.conf.HiveConf$ConfVars.(HiveConf.java:228)
> {code}
> There are similar native dependencies (eg. NativeIO and hadoop.dll) that 
> handle lack of binaries with fallback to non-native code paths.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread Colin Patrick McCabe (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colin Patrick McCabe updated HADOOP-12447:
--
   Resolution: Fixed
Fix Version/s: 2.8.0
   Status: Resolved  (was: Patch Available)

> Clean up some htrace integration issues
> ---
>
> Key: HADOOP-12447
> URL: https://issues.apache.org/jira/browse/HADOOP-12447
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: tracing
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12447.002.patch
>
>
> Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread Colin Patrick McCabe (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935414#comment-14935414
 ] 

Colin Patrick McCabe commented on HADOOP-12447:
---

Test issues are not related.  Findbugs output is empty.  Committed to 2.8.  
Thanks, [~stack].

> Clean up some htrace integration issues
> ---
>
> Key: HADOOP-12447
> URL: https://issues.apache.org/jira/browse/HADOOP-12447
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: tracing
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12447.002.patch
>
>
> Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HADOOP-12449) TestDNS and TestNetUtils failing if no network

2015-09-29 Thread Steve Loughran (JIRA)
Steve Loughran created HADOOP-12449:
---

 Summary: TestDNS and TestNetUtils failing if no network
 Key: HADOOP-12449
 URL: https://issues.apache.org/jira/browse/HADOOP-12449
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Steve Loughran
Assignee: Steve Loughran
Priority: Minor


On a laptop with wifi enabled but unbonded, test cases in {{TestDNS}} and 
{{TestNetUtils}} fail due to DNS problems. They need to skip in this situation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935456#comment-14935456
 ] 

Hudson commented on HADOOP-12447:
-

FAILURE: Integrated in Hadoop-trunk-Commit #8541 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/8541/])
HADOOP-12447. Clean up some htrace integration issues (cmccabe) (cmccabe: rev 
850d679acb935a6a6b0e6cb6f69d998e99395468)
* hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
* hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
* 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
Add HADOOP-12447 to CHANGES.txt (cmccabe: rev 
a2efb945e31700ae9a5afecf9f24294cff39a14f)
* hadoop-common-project/hadoop-common/CHANGES.txt


> Clean up some htrace integration issues
> ---
>
> Key: HADOOP-12447
> URL: https://issues.apache.org/jira/browse/HADOOP-12447
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: tracing
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12447.002.patch
>
>
> Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12449) TestDNS and TestNetUtils failing if no network

2015-09-29 Thread Arpit Agarwal (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935459#comment-14935459
 ] 

Arpit Agarwal commented on HADOOP-12449:


+1 pending Jenkins.

Verified it fixes the failure with wifi disconnected.

> TestDNS and TestNetUtils failing if no network
> --
>
> Key: HADOOP-12449
> URL: https://issues.apache.org/jira/browse/HADOOP-12449
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 3.0.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-12449-001.patch
>
>
> On a laptop with wifi enabled but unbonded, test cases in {{TestDNS}} and 
> {{TestNetUtils}} fail due to DNS problems. They need to skip in this situation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935485#comment-14935485
 ] 

Hadoop QA commented on HADOOP-12448:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |   7m  9s | Pre-patch trunk has 1 extant 
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 1 new or modified test files. |
| {color:green}+1{color} | javac |   7m 47s | There were no new javac warning 
messages. |
| {color:green}+1{color} | release audit |   0m 20s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m  8s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 28s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 52s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |   6m 45s | Tests passed in 
hadoop-common. |
| | |  27m  6s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12764264/HADOOP-12448.001.patch 
|
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / a2efb94 |
| Pre-patch Findbugs warnings | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7734/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7734/artifact/patchprocess/testrun_hadoop-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7734/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7734/console |


This message was automatically generated.

> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HADOOP-12448.001.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Chris Nauroth (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-12448:
---
Attachment: HADOOP-12448.002.patch

This is a good idea.  It's probably helpful for stable parallel test execution. 
 (HADOOP-11984).

However, -1 for patch v001.  This would fail on Windows.  The path strings 
constructed for the files would not be valid URI syntax due to the drive spec.  
There is a point in the tests where the path strings are converted back to a 
{{URI}}, and this causes an exception to be thrown.

I took the liberty of making a small tweak and verifying that it passes on Mac 
and Windows.  I'm attaching it as v002.

Thanks, [~cmccabe]!  Maybe another committer can review and +1, since I have 
sullied myself by touching the patch?  :-)

> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HADOOP-12448.001.patch, HADOOP-12448.002.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Chris Nauroth (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-12448:
---
Component/s: test

> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HADOOP-12448.001.patch, HADOOP-12448.002.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12441) Fix kill command behavior under some Linux distributions.

2015-09-29 Thread Wangda Tan (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935508#comment-14935508
 ] 

Wangda Tan commented on HADOOP-12441:
-

Ran failed tests with patch locally, all passed.

> Fix kill command behavior under some Linux distributions.
> -
>
> Key: HADOOP-12441
> URL: https://issues.apache.org/jira/browse/HADOOP-12441
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Wangda Tan
>Assignee: Wangda Tan
>Priority: Critical
> Attachments: HADOOP-12441.1.patch, HADOOP-12441.2.patch, 
> HADOOP-12441.4.patch
>
>
> After HADOOP-12317, kill command's execution will be failure under Ubuntu12. 
> After NM restarts, it cannot get if a process is alive or not via pid of 
> containers, and it cannot kill process correctly when RM/AM tells NM to kill 
> a container.
> Logs from NM (customized logs):
> {code}
> 2015-09-25 21:58:59,348 INFO  nodemanager.DefaultContainerExecutor 
> (DefaultContainerExecutor.java:containerIsAlive(431)) -  == 
> check alive cmd:[[Ljava.lang.String;@496e442d]
> 2015-09-25 21:58:59,349 INFO  nodemanager.NMAuditLogger 
> (NMAuditLogger.java:logSuccess(89)) - USER=hrt_qa   IP=10.0.1.14
> OPERATION=Stop Container RequestTARGET=ContainerManageImpl  
> RESULT=SUCCESS  APPID=application_1443218269460_0001
> CONTAINERID=container_1443218269460_0001_01_01
> 2015-09-25 21:58:59,363 INFO  nodemanager.DefaultContainerExecutor 
> (DefaultContainerExecutor.java:containerIsAlive(438)) -  
> ===
> ExitCodeException exitCode=1: ERROR: garbage process ID "--".
> Usage:
>   kill pid ...  Send SIGTERM to every process listed.
>   kill signal pid ...   Send a signal to every process listed.
>   kill -s signal pid ...Send a signal to every process listed.
>   kill -l   List all signal names.
>   kill -L   List all signal names in a nice table.
>   kill -l signalConvert between signal numbers and names.
> at org.apache.hadoop.util.Shell.runCommand(Shell.java:550)
> at org.apache.hadoop.util.Shell.run(Shell.java:461)
> at 
> org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:727)
> at 
> org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor.containerIsAlive(DefaultContainerExecutor.java:432)
> at 
> org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor.signalContainer(DefaultContainerExecutor.java:401)
> at 
> org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch.cleanupContainer(ContainerLaunch.java:419)
> at 
> org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainersLauncher.handle(ContainersLauncher.java:139)
> at 
> org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainersLauncher.handle(ContainersLauncher.java:55)
> at 
> org.apache.hadoop.yarn.event.AsyncDispatcher.dispatch(AsyncDispatcher.java:175)
> at 
> org.apache.hadoop.yarn.event.AsyncDispatcher$1.run(AsyncDispatcher.java:108)
> at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12449) TestDNS and TestNetUtils failing if no network

2015-09-29 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935513#comment-14935513
 ] 

Hadoop QA commented on HADOOP-12449:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |   7m 28s | Pre-patch trunk has 1 extant 
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 2 new or modified test files. |
| {color:green}+1{color} | javac |   8m  2s | There were no new javac warning 
messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m  6s | There were no new checkstyle 
issues. |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 1  line(s) that 
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 30s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 35s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 51s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |   8m  1s | Tests passed in 
hadoop-common. |
| | |  29m  3s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12764268/HADOOP-12449-001.patch 
|
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / 80d33b5 |
| Pre-patch Findbugs warnings | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7736/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7736/artifact/patchprocess/whitespace.txt
 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7736/artifact/patchprocess/testrun_hadoop-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7736/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7736/console |


This message was automatically generated.

> TestDNS and TestNetUtils failing if no network
> --
>
> Key: HADOOP-12449
> URL: https://issues.apache.org/jira/browse/HADOOP-12449
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 3.0.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-12449-001.patch
>
>
> On a laptop with wifi enabled but unbonded, test cases in {{TestDNS}} and 
> {{TestNetUtils}} fail due to DNS problems. They need to skip in this situation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935511#comment-14935511
 ] 

Hudson commented on HADOOP-12447:
-

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #460 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/460/])
HADOOP-12447. Clean up some htrace integration issues (cmccabe) (cmccabe: rev 
850d679acb935a6a6b0e6cb6f69d998e99395468)
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
* 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
* hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
Add HADOOP-12447 to CHANGES.txt (cmccabe: rev 
a2efb945e31700ae9a5afecf9f24294cff39a14f)
* hadoop-common-project/hadoop-common/CHANGES.txt


> Clean up some htrace integration issues
> ---
>
> Key: HADOOP-12447
> URL: https://issues.apache.org/jira/browse/HADOOP-12447
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: tracing
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12447.002.patch
>
>
> Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HADOOP-12450) UserGroupInformation should not log at WARN level if no groups are found

2015-09-29 Thread Elliott Clark (JIRA)
Elliott Clark created HADOOP-12450:
--

 Summary: UserGroupInformation should not log at WARN level if no 
groups are found
 Key: HADOOP-12450
 URL: https://issues.apache.org/jira/browse/HADOOP-12450
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Elliott Clark
Assignee: Elliott Clark


HBase tries to get the groups of a user on every request. That user may or may 
not exist on the box running Hadoop/HBase.

If that user doesn't exist currently Hadoop will log at the WARN level 
everytime. This leads to gigs of log spam and serious GC issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12450) UserGroupInformation should not log at WARN level if no groups are found

2015-09-29 Thread Elliott Clark (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HADOOP-12450:
---
Attachment: HADOOP-12450-v1.patch

> UserGroupInformation should not log at WARN level if no groups are found
> 
>
> Key: HADOOP-12450
> URL: https://issues.apache.org/jira/browse/HADOOP-12450
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Attachments: HADOOP-12450-v1.patch
>
>
> HBase tries to get the groups of a user on every request. That user may or 
> may not exist on the box running Hadoop/HBase.
> If that user doesn't exist currently Hadoop will log at the WARN level 
> everytime. This leads to gigs of log spam and serious GC issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12450) UserGroupInformation should not log at WARN level if no groups are found

2015-09-29 Thread Elliott Clark (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HADOOP-12450:
---
Status: Patch Available  (was: Open)

> UserGroupInformation should not log at WARN level if no groups are found
> 
>
> Key: HADOOP-12450
> URL: https://issues.apache.org/jira/browse/HADOOP-12450
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Attachments: HADOOP-12450-v1.patch
>
>
> HBase tries to get the groups of a user on every request. That user may or 
> may not exist on the box running Hadoop/HBase.
> If that user doesn't exist currently Hadoop will log at the WARN level 
> everytime. This leads to gigs of log spam and serious GC issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935565#comment-14935565
 ] 

Hadoop QA commented on HADOOP-12448:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |   7m 27s | Pre-patch trunk has 1 extant 
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 1 new or modified test files. |
| {color:green}+1{color} | javac |   7m 58s | There were no new javac warning 
messages. |
| {color:green}+1{color} | release audit |   0m 20s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m  7s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 28s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 53s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests |   6m 10s | Tests failed in 
hadoop-common. |
| | |  27m  2s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.metrics2.sink.TestFileSink |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12764281/HADOOP-12448.002.patch 
|
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / 80d33b5 |
| Pre-patch Findbugs warnings | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7737/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7737/artifact/patchprocess/testrun_hadoop-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7737/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7737/console |


This message was automatically generated.

> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HADOOP-12448.001.patch, HADOOP-12448.002.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10775) Shell operations to fail with meaningful errors on windows if winutils.exe not found

2015-09-29 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935585#comment-14935585
 ] 

Hadoop QA commented on HADOOP-10775:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  22m 20s | Pre-patch trunk has 1 extant 
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 7 new or modified test files. |
| {color:red}-1{color} | javac |   8m 46s | The applied patch generated  8  
additional warning messages. |
| {color:red}-1{color} | javadoc |  11m  8s | The applied patch generated  1  
additional warning messages. |
| {color:green}+1{color} | release audit |   0m 26s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   2m  8s | The applied patch generated  
13 new checkstyle issues (total was 194, now 199). |
| {color:red}-1{color} | whitespace |   0m  9s | The patch has 4  line(s) that 
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 38s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   5m 29s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |   7m 13s | Tests passed in 
hadoop-common. |
| {color:green}+1{color} | yarn tests |   2m  2s | Tests passed in 
hadoop-yarn-common. |
| {color:green}+1{color} | yarn tests |   8m 28s | Tests passed in 
hadoop-yarn-server-nodemanager. |
| | |  70m 59s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12764270/HADOOP-10775-004.patch 
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 80d33b5 |
| Pre-patch Findbugs warnings | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7735/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
 |
| javac | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7735/artifact/patchprocess/diffJavacWarnings.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7735/artifact/patchprocess/diffJavadocWarnings.txt
 |
| checkstyle |  
https://builds.apache.org/job/PreCommit-HADOOP-Build/7735/artifact/patchprocess/diffcheckstylehadoop-common.txt
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7735/artifact/patchprocess/whitespace.txt
 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7735/artifact/patchprocess/testrun_hadoop-common.txt
 |
| hadoop-yarn-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7735/artifact/patchprocess/testrun_hadoop-yarn-common.txt
 |
| hadoop-yarn-server-nodemanager test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7735/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7735/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7735/console |


This message was automatically generated.

> Shell operations to fail with meaningful errors on windows if winutils.exe 
> not found
> 
>
> Key: HADOOP-10775
> URL: https://issues.apache.org/jira/browse/HADOOP-10775
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: util
>Affects Versions: trunk-win, 2.7.1
> Environment: windows
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-10775-002.patch, HADOOP-10775-003.patch, 
> HADOOP-10775-004.patch, HADOOP-10775.patch
>
>
> If {{winutils.exe}} can't be found {{HADOOP_HOME}} wrong/unset or other 
> causes, then an error is logged -but when any of the {{Shell}} operations are 
> used, an NPE is raised rather than something meaningful.
> The error message at setup time should be preserved and then raised before 
> any attempt to invoke a winutils-driven process made



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12450) UserGroupInformation should not log at WARN level if no groups are found

2015-09-29 Thread Steve Loughran (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HADOOP-12450:

   Priority: Minor  (was: Major)
Component/s: security
 Issue Type: Improvement  (was: Bug)

> UserGroupInformation should not log at WARN level if no groups are found
> 
>
> Key: HADOOP-12450
> URL: https://issues.apache.org/jira/browse/HADOOP-12450
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: security
>Reporter: Elliott Clark
>Assignee: Elliott Clark
>Priority: Minor
> Attachments: HADOOP-12450-v1.patch
>
>
> HBase tries to get the groups of a user on every request. That user may or 
> may not exist on the box running Hadoop/HBase.
> If that user doesn't exist currently Hadoop will log at the WARN level 
> everytime. This leads to gigs of log spam and serious GC issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12450) UserGroupInformation should not log at WARN level if no groups are found

2015-09-29 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935600#comment-14935600
 ] 

Steve Loughran commented on HADOOP-12450:
-

# it should really be at debug; trace doesn't get used in the hadoop code.
# Given it's also swallowing the exception (which may be a sign of something 
fundamental), maybe the logging should also include the nested exception. 

What do others think?

> UserGroupInformation should not log at WARN level if no groups are found
> 
>
> Key: HADOOP-12450
> URL: https://issues.apache.org/jira/browse/HADOOP-12450
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Attachments: HADOOP-12450-v1.patch
>
>
> HBase tries to get the groups of a user on every request. That user may or 
> may not exist on the box running Hadoop/HBase.
> If that user doesn't exist currently Hadoop will log at the WARN level 
> everytime. This leads to gigs of log spam and serious GC issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10775) Shell operations to fail with meaningful errors on windows if winutils.exe not found

2015-09-29 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935603#comment-14935603
 ] 

Steve Loughran commented on HADOOP-10775:
-

Checkstyle
{code}
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:52:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:59:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:64:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:69:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:269:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:377:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:465:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:468:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:471:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:527:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:541:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:566:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:571:
 First sentence should end with a period.
{code}

And javac, which is from the new  deprecation warnings
{code}
https://builds.apache.org/job/PreCommit-HADOOP-Build/7735/artifact/patchprocess/diffJavacWarnings.txt
{code}

will fix

> Shell operations to fail with meaningful errors on windows if winutils.exe 
> not found
> 
>
> Key: HADOOP-10775
> URL: https://issues.apache.org/jira/browse/HADOOP-10775
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: util
>Affects Versions: trunk-win, 2.7.1
> Environment: windows
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-10775-002.patch, HADOOP-10775-003.patch, 
> HADOOP-10775-004.patch, HADOOP-10775.patch
>
>
> If {{winutils.exe}} can't be found {{HADOOP_HOME}} wrong/unset or other 
> causes, then an error is logged -but when any of the {{Shell}} operations are 
> used, an NPE is raised rather than something meaningful.
> The error message at setup time should be preserved and then raised before 
> any attempt to invoke a winutils-driven process made



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12230) hadoop-project declares duplicate, conflicting curator dependencies

2015-09-29 Thread Rakesh R (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R updated HADOOP-12230:
--
Attachment: HADOOP-12230-00.patch

> hadoop-project declares duplicate, conflicting curator dependencies
> ---
>
> Key: HADOOP-12230
> URL: https://issues.apache.org/jira/browse/HADOOP-12230
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: build
>Affects Versions: 2.7.1
>Reporter: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-12230-00.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> HADOOP-11492 bumped up the curator version in trunk & branch-2, but it looks 
> like there were a couple of extra curator dependencies in branch-2 that 
> didn't get updated, and are still down as 2.6.0
> This isn't that serious, maven will have picked the latest one, but its still 
> messy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12230) hadoop-project declares duplicate, conflicting curator dependencies

2015-09-29 Thread Rakesh R (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935617#comment-14935617
 ] 

Rakesh R commented on HADOOP-12230:
---

Hi [~ste...@apache.org], I could see two occurrences in {{hadoop-project}} and 
I'm attaching a patch based on branch-2.7. Kindly review, Thanks!

> hadoop-project declares duplicate, conflicting curator dependencies
> ---
>
> Key: HADOOP-12230
> URL: https://issues.apache.org/jira/browse/HADOOP-12230
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: build
>Affects Versions: 2.7.1
>Reporter: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-12230-00.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> HADOOP-11492 bumped up the curator version in trunk & branch-2, but it looks 
> like there were a couple of extra curator dependencies in branch-2 that 
> didn't get updated, and are still down as 2.6.0
> This isn't that serious, maven will have picked the latest one, but its still 
> messy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935631#comment-14935631
 ] 

Hudson commented on HADOOP-12447:
-

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #468 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/468/])
HADOOP-12447. Clean up some htrace integration issues (cmccabe) (cmccabe: rev 
850d679acb935a6a6b0e6cb6f69d998e99395468)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
* hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
* 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
Add HADOOP-12447 to CHANGES.txt (cmccabe: rev 
a2efb945e31700ae9a5afecf9f24294cff39a14f)
* hadoop-common-project/hadoop-common/CHANGES.txt


> Clean up some htrace integration issues
> ---
>
> Key: HADOOP-12447
> URL: https://issues.apache.org/jira/browse/HADOOP-12447
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: tracing
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12447.002.patch
>
>
> Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12450) UserGroupInformation should not log at WARN level if no groups are found

2015-09-29 Thread Elliott Clark (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HADOOP-12450:
---
Attachment: HADOOP-12450-v2.patch

Patch with log at debug.

> UserGroupInformation should not log at WARN level if no groups are found
> 
>
> Key: HADOOP-12450
> URL: https://issues.apache.org/jira/browse/HADOOP-12450
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: security
>Reporter: Elliott Clark
>Assignee: Elliott Clark
>Priority: Minor
> Attachments: HADOOP-12450-v1.patch, HADOOP-12450-v2.patch
>
>
> HBase tries to get the groups of a user on every request. That user may or 
> may not exist on the box running Hadoop/HBase.
> If that user doesn't exist currently Hadoop will log at the WARN level 
> everytime. This leads to gigs of log spam and serious GC issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12101) Add automatic search of default Configuration variables to TestConfigurationFieldsBase

2015-09-29 Thread Ray Chiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935646#comment-14935646
 ] 

Ray Chiang commented on HADOOP-12101:
-

RE: Pre-patch findbugs

Not in related code

RE: Failed unit test

Unrelated test and test doesn't fail in my tree




> Add automatic search of default Configuration variables to 
> TestConfigurationFieldsBase
> --
>
> Key: HADOOP-12101
> URL: https://issues.apache.org/jira/browse/HADOOP-12101
> Project: Hadoop Common
>  Issue Type: Test
>  Components: test
>Affects Versions: 2.7.0
>Reporter: Ray Chiang
>Assignee: Ray Chiang
>  Labels: supportability
> Attachments: HADOOP-12101.001.patch, HADOOP-12101.002.patch, 
> HADOOP-12101.003.patch
>
>
> Add functionality given a Configuration variable FOO, to at least check the 
> xml file value against DEFAULT_FOO.
> Without waivers and a mapping for exceptions, this can probably never be a 
> test method that generates actual errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935649#comment-14935649
 ] 

Hudson commented on HADOOP-12447:
-

FAILURE: Integrated in Hadoop-Yarn-trunk #1199 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/1199/])
HADOOP-12447. Clean up some htrace integration issues (cmccabe) (cmccabe: rev 
850d679acb935a6a6b0e6cb6f69d998e99395468)
* hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
* hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
* 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
Add HADOOP-12447 to CHANGES.txt (cmccabe: rev 
a2efb945e31700ae9a5afecf9f24294cff39a14f)
* hadoop-common-project/hadoop-common/CHANGES.txt


> Clean up some htrace integration issues
> ---
>
> Key: HADOOP-12447
> URL: https://issues.apache.org/jira/browse/HADOOP-12447
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: tracing
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12447.002.patch
>
>
> Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12450) UserGroupInformation should not log at WARN level if no groups are found

2015-09-29 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935663#comment-14935663
 ] 

Hadoop QA commented on HADOOP-12450:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  19m 18s | Pre-patch trunk has 1 extant 
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |   9m  2s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |  11m 56s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 25s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m 16s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 37s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   2m  3s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |   7m 59s | Tests passed in 
hadoop-common. |
| | |  54m 17s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12764284/HADOOP-12450-v1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 80d33b5 |
| Pre-patch Findbugs warnings | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7738/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7738/artifact/patchprocess/testrun_hadoop-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7738/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7738/console |


This message was automatically generated.

> UserGroupInformation should not log at WARN level if no groups are found
> 
>
> Key: HADOOP-12450
> URL: https://issues.apache.org/jira/browse/HADOOP-12450
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: security
>Reporter: Elliott Clark
>Assignee: Elliott Clark
>Priority: Minor
> Attachments: HADOOP-12450-v1.patch, HADOOP-12450-v2.patch
>
>
> HBase tries to get the groups of a user on every request. That user may or 
> may not exist on the box running Hadoop/HBase.
> If that user doesn't exist currently Hadoop will log at the WARN level 
> everytime. This leads to gigs of log spam and serious GC issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12450) UserGroupInformation should not log at WARN level if no groups are found

2015-09-29 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935725#comment-14935725
 ] 

Hadoop QA commented on HADOOP-12450:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  17m 38s | Pre-patch trunk has 1 extant 
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |   8m  1s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |  10m 19s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 24s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m  5s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 28s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 34s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 56s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests |   6m 36s | Tests failed in 
hadoop-common. |
| | |  48m  4s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.fs.sftp.TestSFTPFileSystem |
|   | hadoop.net.TestDNS |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12764300/HADOOP-12450-v2.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 80d33b5 |
| Pre-patch Findbugs warnings | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7739/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7739/artifact/patchprocess/testrun_hadoop-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7739/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7739/console |


This message was automatically generated.

> UserGroupInformation should not log at WARN level if no groups are found
> 
>
> Key: HADOOP-12450
> URL: https://issues.apache.org/jira/browse/HADOOP-12450
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: security
>Reporter: Elliott Clark
>Assignee: Elliott Clark
>Priority: Minor
> Attachments: HADOOP-12450-v1.patch, HADOOP-12450-v2.patch
>
>
> HBase tries to get the groups of a user on every request. That user may or 
> may not exist on the box running Hadoop/HBase.
> If that user doesn't exist currently Hadoop will log at the WARN level 
> everytime. This leads to gigs of log spam and serious GC issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935727#comment-14935727
 ] 

Hudson commented on HADOOP-12447:
-

FAILURE: Integrated in Hadoop-Mapreduce-trunk #2403 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2403/])
HADOOP-12447. Clean up some htrace integration issues (cmccabe) (cmccabe: rev 
850d679acb935a6a6b0e6cb6f69d998e99395468)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
* hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
Add HADOOP-12447 to CHANGES.txt (cmccabe: rev 
a2efb945e31700ae9a5afecf9f24294cff39a14f)
* hadoop-common-project/hadoop-common/CHANGES.txt


> Clean up some htrace integration issues
> ---
>
> Key: HADOOP-12447
> URL: https://issues.apache.org/jira/browse/HADOOP-12447
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: tracing
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12447.002.patch
>
>
> Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935833#comment-14935833
 ] 

Hudson commented on HADOOP-12447:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk #2375 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2375/])
HADOOP-12447. Clean up some htrace integration issues (cmccabe) (cmccabe: rev 
850d679acb935a6a6b0e6cb6f69d998e99395468)
* hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
* hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
* 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
Add HADOOP-12447 to CHANGES.txt (cmccabe: rev 
a2efb945e31700ae9a5afecf9f24294cff39a14f)
* hadoop-common-project/hadoop-common/CHANGES.txt


> Clean up some htrace integration issues
> ---
>
> Key: HADOOP-12447
> URL: https://issues.apache.org/jira/browse/HADOOP-12447
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: tracing
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12447.002.patch
>
>
> Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-10709) Reuse Filters across web apps

2015-09-29 Thread Benoy Antony (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benoy Antony updated HADOOP-10709:
--
Attachment: HADOOP-10679-003.patch

Attaching the rebased patch 

> Reuse Filters across web apps
> -
>
> Key: HADOOP-10709
> URL: https://issues.apache.org/jira/browse/HADOOP-10709
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: security
>Reporter: Benoy Antony
>Assignee: Benoy Antony
> Attachments: HADOOP-10679-003.patch, HADOOP-10709-002.patch, 
> HADOOP-10709.patch, configForFilterReuse.xml
>
>
> Currently, we need to define separate authentication filters for webhdfs and 
> general webui. This also involves defining parameters for those filters.
> It will be better if one could reuse filters for web apps if desired. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-10709) Reuse Filters across web apps

2015-09-29 Thread Benoy Antony (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benoy Antony updated HADOOP-10709:
--
Status: Patch Available  (was: Open)

> Reuse Filters across web apps
> -
>
> Key: HADOOP-10709
> URL: https://issues.apache.org/jira/browse/HADOOP-10709
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: security
>Reporter: Benoy Antony
>Assignee: Benoy Antony
> Attachments: HADOOP-10679-003.patch, HADOOP-10709-002.patch, 
> HADOOP-10709.patch, configForFilterReuse.xml
>
>
> Currently, we need to define separate authentication filters for webhdfs and 
> general webui. This also involves defining parameters for those filters.
> It will be better if one could reuse filters for web apps if desired. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12447) Clean up some htrace integration issues

2015-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935929#comment-14935929
 ] 

Hudson commented on HADOOP-12447:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #435 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/435/])
HADOOP-12447. Clean up some htrace integration issues (cmccabe) (cmccabe: rev 
850d679acb935a6a6b0e6cb6f69d998e99395468)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
* hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
* hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
Add HADOOP-12447 to CHANGES.txt (cmccabe: rev 
a2efb945e31700ae9a5afecf9f24294cff39a14f)
* hadoop-common-project/hadoop-common/CHANGES.txt


> Clean up some htrace integration issues
> ---
>
> Key: HADOOP-12447
> URL: https://issues.apache.org/jira/browse/HADOOP-12447
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: tracing
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12447.002.patch
>
>
> Clean up some htrace integration issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12445) TestNativeAzureFileSystemOperationsMocked fails in trunk

2015-09-29 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936004#comment-14936004
 ] 

Ted Yu commented on HADOOP-12445:
-

[~cnauroth]:
Mind taking a look at the patch ?

> TestNativeAzureFileSystemOperationsMocked fails in trunk
> 
>
> Key: HADOOP-12445
> URL: https://issues.apache.org/jira/browse/HADOOP-12445
> Project: Hadoop Common
>  Issue Type: Test
>  Components: azure, test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: hadoop-12445-v1.patch, hadoop-12445-v2.patch
>
>
> When working on HDFS-6264, QA bot reported the following:
> {code}
> testGlobStatusFilterWithMultiplePathWildcardsAndNonTrivialFilter(org.apache.hadoop.fs.azure.TestNativeAzureFileSystemOperationsMocked)
>   Time elapsed: 0.02 sec  <<< ERROR!
> java.lang.NullPointerException: null
>   at org.apache.hadoop.fs.Globber.glob(Globber.java:145)
>   at org.apache.hadoop.fs.FileSystem.globStatus(FileSystem.java:1688)
>   at 
> org.apache.hadoop.fs.FSMainOperationsBaseTest.testGlobStatusFilterWithMultiplePathWildcardsAndNonTrivialFilter(FSMainOp
> {code}
> On hadoop trunk branch, the above can be reproduced without any patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10709) Reuse Filters across web apps

2015-09-29 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936094#comment-14936094
 ] 

Hadoop QA commented on HADOOP-10709:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  23m 50s | Pre-patch trunk has 1 extant 
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 4 new or modified test files. |
| {color:green}+1{color} | javac |   8m  5s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |  10m 22s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 27s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | site |   3m 20s | Site still builds. |
| {color:red}-1{color} | checkstyle |   1m 29s | The applied patch generated  
80 new checkstyle issues (total was 326, now 381). |
| {color:red}-1{color} | whitespace |   0m  3s | The patch has 19  line(s) that 
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 40s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   3m 18s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests |   7m 13s | Tests failed in 
hadoop-common. |
| {color:red}-1{color} | yarn tests |  60m  9s | Tests failed in 
hadoop-yarn-server-resourcemanager. |
| | | 120m 48s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.ipc.TestRPCWaitForProxy |
|   | hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart |
|   | hadoop.yarn.server.resourcemanager.TestRMAdminService |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12764321/HADOOP-10679-003.patch 
|
| Optional Tests | javadoc javac unit findbugs checkstyle site |
| git revision | trunk / 80d33b5 |
| Pre-patch Findbugs warnings | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7740/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
 |
| checkstyle |  
https://builds.apache.org/job/PreCommit-HADOOP-Build/7740/artifact/patchprocess/diffcheckstylehadoop-common.txt
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7740/artifact/patchprocess/whitespace.txt
 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7740/artifact/patchprocess/testrun_hadoop-common.txt
 |
| hadoop-yarn-server-resourcemanager test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7740/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7740/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/7740/console |


This message was automatically generated.

> Reuse Filters across web apps
> -
>
> Key: HADOOP-10709
> URL: https://issues.apache.org/jira/browse/HADOOP-10709
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: security
>Reporter: Benoy Antony
>Assignee: Benoy Antony
> Attachments: HADOOP-10679-003.patch, HADOOP-10709-002.patch, 
> HADOOP-10709.patch, configForFilterReuse.xml
>
>
> Currently, we need to define separate authentication filters for webhdfs and 
> general webui. This also involves defining parameters for those filters.
> It will be better if one could reuse filters for web apps if desired. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HADOOP-12451) One should be able to set HADOOP_HOME outside as well

2015-09-29 Thread Karthik Kambatla (JIRA)
Karthik Kambatla created HADOOP-12451:
-

 Summary: One should be able to set HADOOP_HOME outside as well
 Key: HADOOP-12451
 URL: https://issues.apache.org/jira/browse/HADOOP-12451
 Project: Hadoop Common
  Issue Type: Bug
  Components: conf
Affects Versions: 2.7.1
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Blocker


HADOOP-11464 reinstates cygwin support. In the process, it sets HADOOP_HOME 
explicitly in hadoop-config.sh without checking if it has already been set. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12451) One should be able to set HADOOP_HOME outside as well

2015-09-29 Thread Karthik Kambatla (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karthik Kambatla updated HADOOP-12451:
--
Attachment: HADOOP-12451-branch-2.1.patch

Simple patch that adds a check to see if HADOOP_HOME has already been set, 
similar to how HADOOP_HDFS_HOME is handled. 

[~cnauroth] - can you please review the patch since you know the latest details 
on how to ensure it runs with cygwin? 

> One should be able to set HADOOP_HOME outside as well
> -
>
> Key: HADOOP-12451
> URL: https://issues.apache.org/jira/browse/HADOOP-12451
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: conf
>Affects Versions: 2.7.1
>Reporter: Karthik Kambatla
>Assignee: Karthik Kambatla
>Priority: Blocker
> Attachments: HADOOP-12451-branch-2.1.patch
>
>
> HADOOP-11464 reinstates cygwin support. In the process, it sets HADOOP_HOME 
> explicitly in hadoop-config.sh without checking if it has already been set. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Yi Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936280#comment-14936280
 ] 

Yi Liu commented on HADOOP-12448:
-

+1, thanks [~cmccabe] and [~cnauroth], will commit it shortly.

> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HADOOP-12448.001.patch, HADOOP-12448.002.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Yi Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yi Liu updated HADOOP-12448:

   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 2.8.0
   Status: Resolved  (was: Patch Available)

Committed to trunk and branch-2.

> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12448.001.patch, HADOOP-12448.002.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936305#comment-14936305
 ] 

Hudson commented on HADOOP-12448:
-

FAILURE: Integrated in Hadoop-trunk-Commit #8546 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/8546/])
HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test 
directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 
06abc57a90bb2ac86121cc803a60dab82609da88)
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java


> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12448.001.patch, HADOOP-12448.002.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-10709) Reuse Filters across web apps

2015-09-29 Thread Benoy Antony (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benoy Antony updated HADOOP-10709:
--
Attachment: HADOOP-10709-003.patch

Attaching the right patch

> Reuse Filters across web apps
> -
>
> Key: HADOOP-10709
> URL: https://issues.apache.org/jira/browse/HADOOP-10709
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: security
>Reporter: Benoy Antony
>Assignee: Benoy Antony
> Attachments: HADOOP-10679-003.patch, HADOOP-10709-002.patch, 
> HADOOP-10709-003.patch, HADOOP-10709.patch, configForFilterReuse.xml
>
>
> Currently, we need to define separate authentication filters for webhdfs and 
> general webui. This also involves defining parameters for those filters.
> It will be better if one could reuse filters for web apps if desired. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Chris Nauroth (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936340#comment-14936340
 ] 

Chris Nauroth commented on HADOOP-12448:


[~hitliuyi] and [~cmccabe], thank you!

> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12448.001.patch, HADOOP-12448.002.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936364#comment-14936364
 ] 

Hudson commented on HADOOP-12448:
-

FAILURE: Integrated in Hadoop-Yarn-trunk #1202 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/1202/])
HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test 
directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 
06abc57a90bb2ac86121cc803a60dab82609da88)
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java


> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12448.001.patch, HADOOP-12448.002.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936371#comment-14936371
 ] 

Hudson commented on HADOOP-12448:
-

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #463 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/463/])
HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test 
directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 
06abc57a90bb2ac86121cc803a60dab82609da88)
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java


> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12448.001.patch, HADOOP-12448.002.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936377#comment-14936377
 ] 

Hudson commented on HADOOP-12448:
-

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #471 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/471/])
HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test 
directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 
06abc57a90bb2ac86121cc803a60dab82609da88)
* 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java
* hadoop-common-project/hadoop-common/CHANGES.txt


> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12448.001.patch, HADOOP-12448.002.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936401#comment-14936401
 ] 

Hudson commented on HADOOP-12448:
-

FAILURE: Integrated in Hadoop-Mapreduce-trunk #2406 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2406/])
HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test 
directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 
06abc57a90bb2ac86121cc803a60dab82609da88)
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java


> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12448.001.patch, HADOOP-12448.002.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-10709) Reuse Filters across web apps

2015-09-29 Thread Benoy Antony (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benoy Antony updated HADOOP-10709:
--
Attachment: (was: HADOOP-10679-003.patch)

> Reuse Filters across web apps
> -
>
> Key: HADOOP-10709
> URL: https://issues.apache.org/jira/browse/HADOOP-10709
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: security
>Reporter: Benoy Antony
>Assignee: Benoy Antony
> Attachments: HADOOP-10709-002.patch, HADOOP-10709-003.patch, 
> HADOOP-10709.patch, configForFilterReuse.xml
>
>
> Currently, we need to define separate authentication filters for webhdfs and 
> general webui. This also involves defining parameters for those filters.
> It will be better if one could reuse filters for web apps if desired. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-12448) TestTextCommand: use mkdirs rather than mkdir to create test directory

2015-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936451#comment-14936451
 ] 

Hudson commented on HADOOP-12448:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #438 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/438/])
HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test 
directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 
06abc57a90bb2ac86121cc803a60dab82609da88)
* 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java
* hadoop-common-project/hadoop-common/CHANGES.txt


> TestTextCommand: use mkdirs rather than mkdir to create test directory
> --
>
> Key: HADOOP-12448
> URL: https://issues.apache.org/jira/browse/HADOOP-12448
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.8.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 2.8.0
>
> Attachments: HADOOP-12448.001.patch, HADOOP-12448.002.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)