[GitHub] [hadoop] snvijaya commented on a change in pull request #1701: Hadoop 16687: Fix testcase added for HADOOP-16138 for namespace enabled account
snvijaya commented on a change in pull request #1701: Hadoop 16687: Fix
testcase added for HADOOP-16138 for namespace enabled account
URL: https://github.com/apache/hadoop/pull/1701#discussion_r347220822
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCLI.java
##
@@ -57,8 +55,14 @@ public void testMkdirRootNonExistentContainer() throws
Exception {
String nonExistentContainer = "nonexistent-" + UUID.randomUUID();
+// Disable creation of new filesystem
+final AbfsConfiguration conf = getConfiguration();
+conf.setBoolean(AZURE_CREATE_REMOTE_FILESYSTEM_DURING_INITIALIZATION,
+false);
+
int result = fsShell.run(new String[] { "-mkdir",
-ABFS_SCHEME + "://" + nonExistentContainer + "@" + account + "/" });
+ABFS_SCHEME + "://" + nonExistentContainer + "@" + account +
+"/testDirOnRoot" });
Review comment:
Reverted the path back to container root.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16717) Remove GenericsUtil isLog4jLogger
[
https://issues.apache.org/jira/browse/HADOOP-16717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976318#comment-16976318
]
Hadoop QA commented on HADOOP-16717:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m
8s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m
9s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
14m 45s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
40s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
18s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 15m
37s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 40s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch
generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 43s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 56s{color}
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
42s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}102m 6s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.util.TestGenericsUtil |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 Image:yetus/hadoop:104ccca9169 |
| JIRA Issue | HADOOP-16717 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12986073/HADOOP-16717.001.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml findbugs checkstyle |
| uname | Linux 504bcdefaa0f 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1
05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 96c4520 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_222 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/16673/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
|
| unit
[GitHub] [hadoop] snvijaya commented on a change in pull request #1701: Hadoop 16687: Fix testcase added for HADOOP-16138 for namespace enabled account
snvijaya commented on a change in pull request #1701: Hadoop 16687: Fix
testcase added for HADOOP-16138 for namespace enabled account
URL: https://github.com/apache/hadoop/pull/1701#discussion_r347218495
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCLI.java
##
@@ -57,8 +55,14 @@ public void testMkdirRootNonExistentContainer() throws
Exception {
String nonExistentContainer = "nonexistent-" + UUID.randomUUID();
+// Disable creation of new filesystem
+final AbfsConfiguration conf = getConfiguration();
+conf.setBoolean(AZURE_CREATE_REMOTE_FILESYSTEM_DURING_INITIALIZATION,
+false);
Review comment:
Updated the rawConfiguration as suggested.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16717) Remove GenericsUtil isLog4jLogger
[
https://issues.apache.org/jira/browse/HADOOP-16717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976288#comment-16976288
]
Akira Ajisaka commented on HADOOP-16717:
Thanks [~risyomei] for the patch.
* Full class name including its package is required for the argument of
Class.forName().
* You don't have to remove the dependency from pom.xml for now. The removal
itself is discussed in HADOOP-16716.
> Remove GenericsUtil isLog4jLogger
> -
>
> Key: HADOOP-16717
> URL: https://issues.apache.org/jira/browse/HADOOP-16717
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.2
>Reporter: David Mollitor
>Assignee: Xieming Li
>Priority: Major
> Attachments: HADOOP-16717.001.patch
>
>
> Remove this method:
> {code:java}
> /**
>* Determine whether the log of clazz is Log4j implementation.
>* @param clazz a class to be determined
>* @return true if the log of clazz is Log4j implementation.
>*/
> public static boolean isLog4jLogger(Class clazz) {
> if (clazz == null) {
> return false;
> }
> Logger log = LoggerFactory.getLogger(clazz);
> return log instanceof Log4jLoggerAdapter;
> }
> {code}
> This creates a dependency on Log4jLoggerAdapter (slf4j-log4j12) which means
> that any project which depends on hadoop-commons needs to carry this
> dependency as well. Such a simple use case and such a heavy dependency. The
> commons library should not depend on any specific implementation of SLF4J
> binding
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-16717) Remove GenericsUtil isLog4jLogger
[
https://issues.apache.org/jira/browse/HADOOP-16717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xieming Li updated HADOOP-16717:
Attachment: HADOOP-16717.001.patch
Status: Patch Available (was: Open)
[~ste...@apache.org]Thank you for your suggestion. I have changed the function
by using reflection to remove dependency to slf4j-log4j12.
> Remove GenericsUtil isLog4jLogger
> -
>
> Key: HADOOP-16717
> URL: https://issues.apache.org/jira/browse/HADOOP-16717
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.2
>Reporter: David Mollitor
>Assignee: Xieming Li
>Priority: Major
> Attachments: HADOOP-16717.001.patch
>
>
> Remove this method:
> {code:java}
> /**
>* Determine whether the log of clazz is Log4j implementation.
>* @param clazz a class to be determined
>* @return true if the log of clazz is Log4j implementation.
>*/
> public static boolean isLog4jLogger(Class clazz) {
> if (clazz == null) {
> return false;
> }
> Logger log = LoggerFactory.getLogger(clazz);
> return log instanceof Log4jLoggerAdapter;
> }
> {code}
> This creates a dependency on Log4jLoggerAdapter (slf4j-log4j12) which means
> that any project which depends on hadoop-commons needs to carry this
> dependency as well. Such a simple use case and such a heavy dependency. The
> commons library should not depend on any specific implementation of SLF4J
> binding
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-16714) Hadoop website does not mention 2.8.5 release
[ https://issues.apache.org/jira/browse/HADOOP-16714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-16714: --- Status: Patch Available (was: Open) > Hadoop website does not mention 2.8.5 release > - > > Key: HADOOP-16714 > URL: https://issues.apache.org/jira/browse/HADOOP-16714 > Project: Hadoop Common > Issue Type: Task > Components: website >Affects Versions: 2.8.5 >Reporter: Wei-Chiu Chuang >Assignee: Akira Ajisaka >Priority: Major > > I'm not seeing the 2.8.5 release mentioned in the new website > https://hadoop.apache.org/releases.html, nor is it mentioned in the old > website https://hadoop.apache.org/old/releases.html > The 2.8.5 doc: https://hadoop.apache.org/docs/r2.8.5/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16716) slf4j-log4j12 Should Not Be Included as Dependency
[ https://issues.apache.org/jira/browse/HADOOP-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976250#comment-16976250 ] Akira Ajisaka commented on HADOOP-16716: bq. slf4j-log4j12 bridge Sorry I meant slf4j-log4j12 binding. > slf4j-log4j12 Should Not Be Included as Dependency > -- > > Key: HADOOP-16716 > URL: https://issues.apache.org/jira/browse/HADOOP-16716 > Project: Hadoop Common > Issue Type: Improvement > Components: common >Affects Versions: 3.2 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Major > > The project should be using 'slf4j-api' to log to the SLF4J framwork, but the > end-project, the project that includes hadoop-commons should be specifying > the specific binding to use. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Assigned] (HADOOP-16714) Hadoop website does not mention 2.8.5 release
[ https://issues.apache.org/jira/browse/HADOOP-16714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka reassigned HADOOP-16714: -- Assignee: Akira Ajisaka > Hadoop website does not mention 2.8.5 release > - > > Key: HADOOP-16714 > URL: https://issues.apache.org/jira/browse/HADOOP-16714 > Project: Hadoop Common > Issue Type: Task > Components: website >Affects Versions: 2.8.5 >Reporter: Wei-Chiu Chuang >Assignee: Akira Ajisaka >Priority: Major > > I'm not seeing the 2.8.5 release mentioned in the new website > https://hadoop.apache.org/releases.html, nor is it mentioned in the old > website https://hadoop.apache.org/old/releases.html > The 2.8.5 doc: https://hadoop.apache.org/docs/r2.8.5/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16654) Delete hadoop-ozone and hadoop-hdds subprojects from apache trunk
[ https://issues.apache.org/jira/browse/HADOOP-16654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976232#comment-16976232 ] Akira Ajisaka commented on HADOOP-16654: Thank you [~Sandeep Nemuri], [~aengineer], [~elek], and [~dineshchitlangia]! > Delete hadoop-ozone and hadoop-hdds subprojects from apache trunk > - > > Key: HADOOP-16654 > URL: https://issues.apache.org/jira/browse/HADOOP-16654 > Project: Hadoop Common > Issue Type: Task >Reporter: Marton Elek >Assignee: Sandeep Nemuri >Priority: Major > Fix For: 3.3.0 > > > As described in the HDDS-2287 ozone/hdds sources are moving to the > apache/hadoop-ozone git repository. > All the remaining ozone/hdds files can be removed from trunk (including hdds > profile in main pom.xml) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16716) slf4j-log4j12 Should Not Be Included as Dependency
[
https://issues.apache.org/jira/browse/HADOOP-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976227#comment-16976227
]
David Mollitor commented on HADOOP-16716:
-
Just to clarify, so we are all on the same page here:
Bridge = Takes code base written for a particular logging framework (Log4J for
example; log4j-over-slf4j) and makes it SLF4J compatible
Binding = Allows logging framework to plug into a code base written to work
with the SLF4J framework (slf4j-log4j12)
I'm talking about slf4j-log4j12 which is a binding. For the 'common' project,
I highly recommend making it {{test}} scope so that there is no dependence on
it for project that include hadoop-common in their list of dependencies.
Anything that includes commons should decide what logging framework to use, not
inherit it from this project.
> slf4j-log4j12 Should Not Be Included as Dependency
> --
>
> Key: HADOOP-16716
> URL: https://issues.apache.org/jira/browse/HADOOP-16716
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
>Affects Versions: 3.2
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
>
> The project should be using 'slf4j-api' to log to the SLF4J framwork, but the
> end-project, the project that includes hadoop-commons should be specifying
> the specific binding to use.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-16714) Hadoop website does not mention 2.8.5 release
[ https://issues.apache.org/jira/browse/HADOOP-16714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-16714: --- Target Version/s: asf-site > Hadoop website does not mention 2.8.5 release > - > > Key: HADOOP-16714 > URL: https://issues.apache.org/jira/browse/HADOOP-16714 > Project: Hadoop Common > Issue Type: Task > Components: website >Affects Versions: 2.8.5 >Reporter: Wei-Chiu Chuang >Priority: Major > > I'm not seeing the 2.8.5 release mentioned in the new website > https://hadoop.apache.org/releases.html, nor is it mentioned in the old > website https://hadoop.apache.org/old/releases.html > The 2.8.5 doc: https://hadoop.apache.org/docs/r2.8.5/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16716) slf4j-log4j12 Should Not Be Included as Dependency
[ https://issues.apache.org/jira/browse/HADOOP-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976220#comment-16976220 ] Akira Ajisaka commented on HADOOP-16716: Log4J1 is EoL and we need to upgrade from Log4j1 to Log4j2, and then we have to remove slf4j-log4j12 bridge from common (HADOOP-16206). Therefore I think we must break compatibility in some future releases. Probably 3.4 or 3.5? > slf4j-log4j12 Should Not Be Included as Dependency > -- > > Key: HADOOP-16716 > URL: https://issues.apache.org/jira/browse/HADOOP-16716 > Project: Hadoop Common > Issue Type: Improvement > Components: common >Affects Versions: 3.2 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Major > > The project should be using 'slf4j-api' to log to the SLF4J framwork, but the > end-project, the project that includes hadoop-commons should be specifying > the specific binding to use. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16685) FileSystem#listStatusIterator does not check if given path exists
[
https://issues.apache.org/jira/browse/HADOOP-16685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976211#comment-16976211
]
Hadoop QA commented on HADOOP-16685:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m
59s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 19m
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
16m 30s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
26s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m
29s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
24s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 19m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 19m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
14m 18s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m
56s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
46s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}118m 15s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1695 |
| JIRA Issue | HADOOP-16685 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux fc09c2961707 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1
05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 96c4520 |
| Default Java | 1.8.0_222 |
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/3/testReport/ |
| Max. process+thread count | 1363 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/3/console |
| versions | git=2.7.4
[GitHub] [hadoop] hadoop-yetus commented on issue #1695: HADOOP-16685: FileSystem#listStatusIterator does not check if given path exists
hadoop-yetus commented on issue #1695: HADOOP-16685: FileSystem#listStatusIterator does not check if given path exists URL: https://github.com/apache/hadoop/pull/1695#issuecomment-554807516 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 74 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1319 | trunk passed | | +1 | compile | 1191 | trunk passed | | +1 | checkstyle | 48 | trunk passed | | +1 | mvnsite | 82 | trunk passed | | +1 | shadedclient | 990 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 86 | trunk passed | | 0 | spotbugs | 149 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 144 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 55 | the patch passed | | +1 | compile | 1176 | the patch passed | | +1 | javac | 1176 | the patch passed | | +1 | checkstyle | 49 | the patch passed | | +1 | mvnsite | 83 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 858 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 83 | the patch passed | | +1 | findbugs | 139 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 596 | hadoop-common in the patch passed. | | +1 | asflicense | 46 | The patch does not generate ASF License warnings. | | | | 7095 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1695 | | JIRA Issue | HADOOP-16685 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux fc09c2961707 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 96c4520 | | Default Java | 1.8.0_222 | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/3/testReport/ | | Max. process+thread count | 1363 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/3/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] sahilTakiar commented on a change in pull request #1695: HADOOP-16685: FileSystem#listStatusIterator does not check if given path exists
sahilTakiar commented on a change in pull request #1695: HADOOP-16685:
FileSystem#listStatusIterator does not check if given path exists
URL: https://github.com/apache/hadoop/pull/1695#discussion_r347164840
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractGetFileStatusTest.java
##
@@ -279,6 +279,20 @@ public void testListFilesNoDir() throws Throwable {
}
}
+ @Test
+ public void testListStatusIteratorNoDir() throws Throwable {
+describe("test the listStatusIterator calls on a path which is not " +
+"present");
+Path path = path("missing");
+try {
+ RemoteIterator iterator
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16712) Config ha.failover-controller.active-standby-elector.zk.op.retries is not in core-default.xml
[ https://issues.apache.org/jira/browse/HADOOP-16712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976133#comment-16976133 ] Ayush Saxena commented on HADOOP-16712: --- Thanx [~risyomei] for the patch. v001 LGTM +1 > Config ha.failover-controller.active-standby-elector.zk.op.retries is not in > core-default.xml > - > > Key: HADOOP-16712 > URL: https://issues.apache.org/jira/browse/HADOOP-16712 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Wei-Chiu Chuang >Assignee: Xieming Li >Priority: Trivial > Attachments: HADOOP-16712.001.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1530: HDFS-14869 Copy renamed files which are not excluded anymore by filter
steveloughran commented on issue #1530: HDFS-14869 Copy renamed files which are not excluded anymore by filter URL: https://github.com/apache/hadoop/pull/1530#issuecomment-554775529 LGTM, we just need yetus to see it. can you do a rebase + force push to see if that works? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran closed pull request #1210: HADOOP-16477. S3 delegation token tests fail if fs.s3a.encryption.key set
steveloughran closed pull request #1210: HADOOP-16477. S3 delegation token tests fail if fs.s3a.encryption.key set URL: https://github.com/apache/hadoop/pull/1210 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #1695: HADOOP-16685: FileSystem#listStatusIterator does not check if given path exists
steveloughran commented on a change in pull request #1695: HADOOP-16685:
FileSystem#listStatusIterator does not check if given path exists
URL: https://github.com/apache/hadoop/pull/1695#discussion_r347152581
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractGetFileStatusTest.java
##
@@ -279,6 +279,20 @@ public void testListFilesNoDir() throws Throwable {
}
}
+ @Test
+ public void testListStatusIteratorNoDir() throws Throwable {
+describe("test the listStatusIterator calls on a path which is not " +
+"present");
+Path path = path("missing");
+try {
+ RemoteIterator iterator
Review comment:
use `LambdaTestUtils.intercept()`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1695: HADOOP-16685: FileSystem#listStatusIterator does not check if given path exists
hadoop-yetus removed a comment on issue #1695: HADOOP-16685: FileSystem#listStatusIterator does not check if given path exists URL: https://github.com/apache/hadoop/pull/1695#issuecomment-550034685 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 74 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1258 | trunk passed | | +1 | compile | 1065 | trunk passed | | +1 | checkstyle | 47 | trunk passed | | +1 | mvnsite | 81 | trunk passed | | +1 | shadedclient | 955 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 87 | trunk passed | | 0 | spotbugs | 128 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 126 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 50 | the patch passed | | +1 | compile | 1026 | the patch passed | | +1 | javac | 1026 | the patch passed | | -0 | checkstyle | 45 | hadoop-common-project/hadoop-common: The patch generated 1 new + 75 unchanged - 0 fixed = 76 total (was 75) | | +1 | mvnsite | 80 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 816 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 85 | the patch passed | | +1 | findbugs | 135 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 555 | hadoop-common in the patch failed. | | +1 | asflicense | 45 | The patch does not generate ASF License warnings. | | | | 6606 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.conf.TestCommonConfigurationFields | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1695 | | JIRA Issue | HADOOP-16685 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 63c4967f93b8 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / bfb8f28 | | Default Java | 1.8.0_222 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/1/testReport/ | | Max. process+thread count | 1346 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1695/1/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient.
steveloughran commented on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient. URL: https://github.com/apache/hadoop/pull/1145#issuecomment-554774875 @bgaborg you got a chance to look @this? It's not complicated This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient.
hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient. URL: https://github.com/apache/hadoop/pull/1145#issuecomment-523892882 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | -1 | mvninstall | 20 | root in trunk failed. | | -1 | compile | 5 | hadoop-aws in trunk failed. | | -0 | checkstyle | 4 | The patch fails to run checkstyle in hadoop-aws | | -1 | mvnsite | 6 | hadoop-aws in trunk failed. | | +1 | shadedclient | 18 | branch has no errors when building and testing our client artifacts. | | -1 | javadoc | 6 | hadoop-aws in trunk failed. | | 0 | spotbugs | 32 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 6 | hadoop-aws in trunk failed. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 5 | hadoop-aws in the patch failed. | | -1 | compile | 6 | hadoop-aws in the patch failed. | | -1 | javac | 6 | hadoop-aws in the patch failed. | | -0 | checkstyle | 26 | hadoop-tools/hadoop-aws: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | +1 | mvnsite | 29 | the patch passed | | -1 | whitespace | 0 | The patch has 162 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -1 | whitespace | 2 | The patch 3000 line(s) with tabs. | | +1 | shadedclient | 775 | patch has no errors when building and testing our client artifacts. | | -1 | javadoc | 21 | hadoop-tools_hadoop-aws generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | findbugs | 58 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 72 | hadoop-aws in the patch passed. | | -1 | asflicense | 26 | The patch generated 6 ASF License warnings. | | | | 1217 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1145 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 29d43fcb5ae2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 69ddb36 | | Default Java | 1.8.0_222 | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out/branch-compile-hadoop-tools_hadoop-aws.txt | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1145/out/maven-branch-checkstyle-hadoop-tools_hadoop-aws.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out/branch-mvnsite-hadoop-tools_hadoop-aws.txt | | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out/branch-javadoc-hadoop-tools_hadoop-aws.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out/branch-findbugs-hadoop-tools_hadoop-aws.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out/patch-mvninstall-hadoop-tools_hadoop-aws.txt | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out/patch-compile-hadoop-tools_hadoop-aws.txt | | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out/patch-compile-hadoop-tools_hadoop-aws.txt | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt | | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out/whitespace-eol.txt | | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out/whitespace-tabs.txt | | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-aws.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/testReport/ | | asflicense | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/8/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 399
[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient.
hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient. URL: https://github.com/apache/hadoop/pull/1145#issuecomment-527274171 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 71 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1162 | trunk passed | | +1 | compile | 30 | trunk passed | | +1 | checkstyle | 22 | trunk passed | | +1 | mvnsite | 35 | trunk passed | | +1 | shadedclient | 795 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 26 | trunk passed | | 0 | spotbugs | 55 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 54 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 33 | the patch passed | | +1 | compile | 26 | the patch passed | | +1 | javac | 26 | the patch passed | | +1 | checkstyle | 17 | the patch passed | | +1 | mvnsite | 31 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 841 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 23 | the patch passed | | +1 | findbugs | 59 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 80 | hadoop-aws in the patch passed. | | +1 | asflicense | 28 | The patch does not generate ASF License warnings. | | | | 3413 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1145 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 4464ef2bfc36 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 915cbc9 | | Default Java | 1.8.0_222 | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/10/testReport/ | | Max. process+thread count | 338 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/10/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient.
hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient. URL: https://github.com/apache/hadoop/pull/1145#issuecomment-523036444 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 108 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1259 | trunk passed | | +1 | compile | 37 | trunk passed | | +1 | checkstyle | 27 | trunk passed | | +1 | mvnsite | 41 | trunk passed | | +1 | shadedclient | 809 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 24 | trunk passed | | 0 | spotbugs | 59 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 58 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 39 | the patch passed | | +1 | compile | 31 | the patch passed | | +1 | javac | 31 | the patch passed | | +1 | checkstyle | 23 | the patch passed | | +1 | mvnsite | 35 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 847 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 28 | the patch passed | | +1 | findbugs | 73 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 90 | hadoop-aws in the patch passed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 3648 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1145 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 5adc0a21fe19 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 094d736 | | Default Java | 1.8.0_222 | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/7/testReport/ | | Max. process+thread count | 306 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/7/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient.
hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient. URL: https://github.com/apache/hadoop/pull/1145#issuecomment-525233091 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 47 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1129 | trunk passed | | +1 | compile | 34 | trunk passed | | +1 | checkstyle | 24 | trunk passed | | +1 | mvnsite | 37 | trunk passed | | +1 | shadedclient | 753 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 27 | trunk passed | | 0 | spotbugs | 58 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 56 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 37 | the patch passed | | +1 | compile | 28 | the patch passed | | +1 | javac | 28 | the patch passed | | +1 | checkstyle | 17 | the patch passed | | +1 | mvnsite | 33 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 794 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 24 | the patch passed | | +1 | findbugs | 65 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 80 | hadoop-aws in the patch passed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 3298 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1145 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 1e33b71904c3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 3329257 | | Default Java | 1.8.0_222 | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/9/testReport/ | | Max. process+thread count | 460 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/9/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient.
hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient. URL: https://github.com/apache/hadoop/pull/1145#issuecomment-519470650 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1097 | trunk passed | | +1 | compile | 28 | trunk passed | | +1 | checkstyle | 18 | trunk passed | | +1 | mvnsite | 30 | trunk passed | | +1 | shadedclient | 685 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 23 | trunk passed | | 0 | spotbugs | 52 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 49 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 36 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 21 | the patch passed | | +1 | mvnsite | 29 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 708 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 59 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 275 | hadoop-aws in the patch passed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 3245 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1145 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 68e17ec10846 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 397a563 | | Default Java | 1.8.0_212 | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/5/testReport/ | | Max. process+thread count | 450 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/5/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient.
hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient. URL: https://github.com/apache/hadoop/pull/1145#issuecomment-519341925 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 101 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1341 | trunk passed | | +1 | compile | 37 | trunk passed | | +1 | checkstyle | 23 | trunk passed | | +1 | mvnsite | 36 | trunk passed | | +1 | shadedclient | 802 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 29 | trunk passed | | 0 | spotbugs | 68 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 65 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 38 | the patch passed | | +1 | compile | 31 | the patch passed | | +1 | javac | 31 | the patch passed | | +1 | checkstyle | 20 | the patch passed | | +1 | mvnsite | 36 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 828 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 27 | the patch passed | | +1 | findbugs | 70 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 297 | hadoop-aws in the patch passed. | | +1 | asflicense | 28 | The patch does not generate ASF License warnings. | | | | 3892 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1145 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 6da008908e28 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 70b4617 | | Default Java | 1.8.0_222 | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/4/testReport/ | | Max. process+thread count | 324 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/4/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient.
hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient. URL: https://github.com/apache/hadoop/pull/1145#issuecomment-522075026 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 78 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1219 | trunk passed | | +1 | compile | 29 | trunk passed | | +1 | checkstyle | 22 | trunk passed | | +1 | mvnsite | 34 | trunk passed | | +1 | shadedclient | 810 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 23 | trunk passed | | 0 | spotbugs | 55 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 53 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 32 | the patch passed | | +1 | compile | 29 | the patch passed | | +1 | javac | 29 | the patch passed | | +1 | checkstyle | 20 | the patch passed | | +1 | mvnsite | 31 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 843 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 22 | the patch passed | | +1 | findbugs | 63 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 85 | hadoop-aws in the patch passed. | | +1 | asflicense | 27 | The patch does not generate ASF License warnings. | | | | 3493 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1145 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 8da6aa1c1c7c 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 9a1d8cf | | Default Java | 1.8.0_222 | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/6/testReport/ | | Max. process+thread count | 339 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/6/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient.
hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient. URL: https://github.com/apache/hadoop/pull/1145#issuecomment-517501067 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1093 | trunk passed | | +1 | compile | 44 | trunk passed | | +1 | checkstyle | 26 | trunk passed | | +1 | mvnsite | 43 | trunk passed | | +1 | shadedclient | 707 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 23 | trunk passed | | 0 | spotbugs | 56 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 53 | hadoop-tools/hadoop-aws in trunk has 1 extant findbugs warnings. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 32 | the patch passed | | +1 | compile | 27 | the patch passed | | +1 | javac | 27 | the patch passed | | +1 | checkstyle | 17 | the patch passed | | +1 | mvnsite | 32 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 690 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 61 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 281 | hadoop-aws in the patch passed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 3277 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1145 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux d0d06532d880 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / d086d05 | | Default Java | 1.8.0_212 | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/3/artifact/out/branch-findbugs-hadoop-tools_hadoop-aws-warnings.html | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/3/testReport/ | | Max. process+thread count | 412 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/3/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient.
hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient. URL: https://github.com/apache/hadoop/pull/1145#issuecomment-515420733 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1088 | trunk passed | | +1 | compile | 29 | trunk passed | | +1 | checkstyle | 21 | trunk passed | | +1 | mvnsite | 37 | trunk passed | | +1 | shadedclient | 685 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 27 | trunk passed | | 0 | spotbugs | 72 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 69 | hadoop-tools/hadoop-aws in trunk has 1 extant findbugs warnings. | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 36 | the patch passed | | +1 | compile | 34 | the patch passed | | +1 | javac | 34 | the patch passed | | +1 | checkstyle | 20 | the patch passed | | +1 | mvnsite | 39 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 706 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 18 | the patch passed | | +1 | findbugs | 59 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 274 | hadoop-aws in the patch passed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 3280 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1145 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux addd4a7c6ef8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / aebac6d | | Default Java | 1.8.0_212 | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/2/artifact/out/branch-findbugs-hadoop-tools_hadoop-aws-warnings.html | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/2/testReport/ | | Max. process+thread count | 447 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/2/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient.
hadoop-yetus removed a comment on issue #1145: HADOOP-16450. ITestS3ACommitterFactory to not use useInconsistentClient. URL: https://github.com/apache/hadoop/pull/1145#issuecomment-514235666 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 157 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1483 | trunk passed | | +1 | compile | 48 | trunk passed | | +1 | checkstyle | 33 | trunk passed | | +1 | mvnsite | 49 | trunk passed | | +1 | shadedclient | 959 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 29 | trunk passed | | 0 | spotbugs | 63 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 61 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 34 | the patch passed | | +1 | compile | 32 | the patch passed | | +1 | javac | 32 | the patch passed | | +1 | checkstyle | 18 | the patch passed | | +1 | mvnsite | 34 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 872 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 27 | the patch passed | | +1 | findbugs | 69 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 299 | hadoop-aws in the patch passed. | | +1 | asflicense | 28 | The patch does not generate ASF License warnings. | | | | 4314 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1145 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 72758b09b1d4 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / eb36b09 | | Default Java | 1.8.0_212 | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/1/testReport/ | | Max. process+thread count | 304 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1145/1/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1714: HADOOP-16484. S3A to warn or fail if S3Guard is disabled - addendum: silent for S3GuardTool
steveloughran commented on issue #1714: HADOOP-16484. S3A to warn or fail if S3Guard is disabled - addendum: silent for S3GuardTool URL: https://github.com/apache/hadoop/pull/1714#issuecomment-554774548 LGTM. if we are being extra paranoid we would disable the per bucket setting as well. But I will take the view if people are tuning in those options on a bucket by bucket basis then they can fend for themselves. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1702: HDFS-14788 Use dynamic regex filter to ignore copy of source files in…
steveloughran commented on issue #1702: HDFS-14788 Use dynamic regex filter to ignore copy of source files in… URL: https://github.com/apache/hadoop/pull/1702#issuecomment-554774312 code LGTM. Now you just need to get checkstyle happy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre…
steveloughran commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre… URL: https://github.com/apache/hadoop/pull/1527#issuecomment-554773789 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #1711: HADOOP-16455. ABFS: Implement FileSystem.access() method.
steveloughran commented on a change in pull request #1711: HADOOP-16455. ABFS: Implement FileSystem.access() method. URL: https://github.com/apache/hadoop/pull/1711#discussion_r347151616 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCheckAccess.java ## @@ -32,9 +28,14 @@ import org.apache.hadoop.fs.permission.AclEntryType; import org.apache.hadoop.fs.permission.FsAction; import org.apache.hadoop.security.AccessControlException; + import org.junit.Assume; import org.junit.Test; +import java.io.FileNotFoundException; Review comment: please restore to where they were. java.* should be the first import. Please: import conflict is one of the key source of false-positive backport problems. Patches MUST NOT move imports around without good reason. This is not one of them. * If your IDE is set up to rearrange things: disable. * if your IDE has an "optimize imports" button -don't press it. * consider reviewing submitted PRs to look for spurious IDE-initiated changes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #1711: HADOOP-16455. ABFS: Implement FileSystem.access() method.
steveloughran commented on a change in pull request #1711: HADOOP-16455. ABFS:
Implement FileSystem.access() method.
URL: https://github.com/apache/hadoop/pull/1711#discussion_r347151667
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCheckAccess.java
##
@@ -243,29 +250,41 @@ public void testFsActionALL() throws Exception {
isCheckAccessEnabled);
Path testFilePath = setupTestDirectoryAndUserAccess("/test8.txt",
FsAction.ALL);
-assertTrue(isAccessible(testFilePath, FsAction.EXECUTE));
-assertTrue(isAccessible(testFilePath, FsAction.WRITE));
-assertTrue(isAccessible(testFilePath, FsAction.WRITE_EXECUTE));
-assertTrue(isAccessible(testFilePath, FsAction.READ));
-assertTrue(isAccessible(testFilePath, FsAction.READ_EXECUTE));
-assertTrue(isAccessible(testFilePath, FsAction.READ_WRITE));
-assertTrue(isAccessible(testFilePath, FsAction.ALL));
+assertAccessible(testFilePath, FsAction.EXECUTE);
+assertAccessible(testFilePath, FsAction.WRITE);
+assertAccessible(testFilePath, FsAction.WRITE_EXECUTE);
+assertAccessible(testFilePath, FsAction.READ);
+assertAccessible(testFilePath, FsAction.READ_EXECUTE);
+assertAccessible(testFilePath, FsAction.READ_WRITE);
+assertAccessible(testFilePath, FsAction.ALL);
+ }
+
+ private void assertAccessible(Path testFilePath, FsAction fsAction)
Review comment:
this is good -thanks for doing this. if you ever find yourself duplicating
code in tests, it's usually a sign to add your own assertions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16710) testing_azure.md documentation is misleading
[
https://issues.apache.org/jira/browse/HADOOP-16710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976091#comment-16976091
]
Hudson commented on HADOOP-16710:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17650 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/17650/])
HADOOP-16710. Testing_azure.md documentation is misleading. (stevel: rev
96c4520f89c5d0c8f7b79e52156ae4dfa5e7a189)
* (edit) hadoop-tools/hadoop-azure/src/site/markdown/testing_azure.md
> testing_azure.md documentation is misleading
>
>
> Key: HADOOP-16710
> URL: https://issues.apache.org/jira/browse/HADOOP-16710
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/azure, test
>Affects Versions: 3.2.0
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>Priority: Major
> Fix For: 3.2.2
>
> Attachments: HADOOP-16710.001.patch
>
>
> testing_azure.md states that "-Dparallel-tests" will run all the integration
> tests in parallel.
> But in fact using -Dparallel-tests without any value actually skips the
> integration tests and runs only the unit tests.
> The reason is that to activate a profile which is able to run ITs in parallel
> requires parallel-tests property to have a value (abfs, wasb or 'both').
> sequential-tests profile defines !parallel-tests as value which means that
> the property should not even be mentioned.
> Please check the output of help:active-profiles command:
>
> {code:java}
> cd hadoop-tools/hadoop-azure
> andrasbokor$ mvn help:active-profiles -Dparallel-tests=abfs
> - parallel-tests-abfs (source: org.apache.hadoop:hadoop-azure:3.3.0-SNAPSHOT)
> - os.mac (source: org.apache.hadoop:hadoop-project:3.3.0-SNAPSHOT)
> - hbase1 (source: org.apache.hadoop:hadoop-project:3.3.0-SNAPSHOT) {code}
> {code:java}
> andrasbokor$ mvn help:active-profiles -Dparallel-tests
> - os.mac (source: org.apache.hadoop:hadoop-project:3.3.0-SNAPSHOT)
> - hbase1 (source: org.apache.hadoop:hadoop-project:3.3.0-SNAPSHOT)
> {code}
> {code:java}
> mvn help:active-profiles
> - sequential-tests (source: org.apache.hadoop:hadoop-azure:3.3.0-SNAPSHOT)
> - os.mac (source: org.apache.hadoop:hadoop-project:3.3.0-SNAPSHOT)
> - hbase1 (source: org.apache.hadoop:hadoop-project:3.3.0-SNAPSHOT){code}
> The help:active-profiles shows that -Dparallel-tests does not add any IT
> related profiles and results in skipping all the integration tests during
> verify phrase.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16716) slf4j-log4j12 Should Not Be Included as Dependency
[ https://issues.apache.org/jira/browse/HADOOP-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976089#comment-16976089 ] David Mollitor commented on HADOOP-16716: - [~ste...@apache.org] Thank you for the feedback. I understand what you're saying about the ability to exclude the dependency. In fact, what lead me to create this JIRA is that I noticed it was being explicitly excluded in a project I was working on. I was thinking to myself "why would this 'common' library ship a binding?" and "how would anyone know to manually exclude this?" and "why does every project need to know to do this?" I would wager that including this dependency ends up adding multiple bindings to the classpath for upstream projects and causes a lot of warnings and confusion. The entire point of SLF4J is that the bindings are pluggable. I think it's much cleaner to have the upstream projects produce a warning that no logger exists. This forces the user to make a decision about which logging framework they want to use, if by some chance they don't already have a logger included. If this was for the HDFS NameNode, HDFS DataNode, YARN services, etc. I get it. That is appropriate to include a logging framework. But it's not so clear to me that a utility package called 'commons' would automatically introduce a logging framework. > slf4j-log4j12 Should Not Be Included as Dependency > -- > > Key: HADOOP-16716 > URL: https://issues.apache.org/jira/browse/HADOOP-16716 > Project: Hadoop Common > Issue Type: Improvement > Components: common >Affects Versions: 3.2 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Major > > The project should be using 'slf4j-api' to log to the SLF4J framwork, but the > end-project, the project that includes hadoop-commons should be specifying > the specific binding to use. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-16716) slf4j-log4j12 Should Not Be Included as Dependency
[ https://issues.apache.org/jira/browse/HADOOP-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HADOOP-16716: Affects Version/s: 3.2 > slf4j-log4j12 Should Not Be Included as Dependency > -- > > Key: HADOOP-16716 > URL: https://issues.apache.org/jira/browse/HADOOP-16716 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.2 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Major > > The project should be using 'slf4j-api' to log to the SLF4J framwork, but the > end-project, the project that includes hadoop-commons should be specifying > the specific binding to use. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-16716) slf4j-log4j12 Should Not Be Included as Dependency
[ https://issues.apache.org/jira/browse/HADOOP-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HADOOP-16716: Component/s: common > slf4j-log4j12 Should Not Be Included as Dependency > -- > > Key: HADOOP-16716 > URL: https://issues.apache.org/jira/browse/HADOOP-16716 > Project: Hadoop Common > Issue Type: Improvement > Components: common >Affects Versions: 3.2 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Major > > The project should be using 'slf4j-api' to log to the SLF4J framwork, but the > end-project, the project that includes hadoop-commons should be specifying > the specific binding to use. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-16710) testing_azure.md documentation is misleading
[
https://issues.apache.org/jira/browse/HADOOP-16710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-16710:
Fix Version/s: 3.2.2
Resolution: Fixed
Status: Resolved (was: Patch Available)
+1 -committed, thanks
> testing_azure.md documentation is misleading
>
>
> Key: HADOOP-16710
> URL: https://issues.apache.org/jira/browse/HADOOP-16710
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/azure, test
>Affects Versions: 3.2.0
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>Priority: Major
> Fix For: 3.2.2
>
> Attachments: HADOOP-16710.001.patch
>
>
> testing_azure.md states that "-Dparallel-tests" will run all the integration
> tests in parallel.
> But in fact using -Dparallel-tests without any value actually skips the
> integration tests and runs only the unit tests.
> The reason is that to activate a profile which is able to run ITs in parallel
> requires parallel-tests property to have a value (abfs, wasb or 'both').
> sequential-tests profile defines !parallel-tests as value which means that
> the property should not even be mentioned.
> Please check the output of help:active-profiles command:
>
> {code:java}
> cd hadoop-tools/hadoop-azure
> andrasbokor$ mvn help:active-profiles -Dparallel-tests=abfs
> - parallel-tests-abfs (source: org.apache.hadoop:hadoop-azure:3.3.0-SNAPSHOT)
> - os.mac (source: org.apache.hadoop:hadoop-project:3.3.0-SNAPSHOT)
> - hbase1 (source: org.apache.hadoop:hadoop-project:3.3.0-SNAPSHOT) {code}
> {code:java}
> andrasbokor$ mvn help:active-profiles -Dparallel-tests
> - os.mac (source: org.apache.hadoop:hadoop-project:3.3.0-SNAPSHOT)
> - hbase1 (source: org.apache.hadoop:hadoop-project:3.3.0-SNAPSHOT)
> {code}
> {code:java}
> mvn help:active-profiles
> - sequential-tests (source: org.apache.hadoop:hadoop-azure:3.3.0-SNAPSHOT)
> - os.mac (source: org.apache.hadoop:hadoop-project:3.3.0-SNAPSHOT)
> - hbase1 (source: org.apache.hadoop:hadoop-project:3.3.0-SNAPSHOT){code}
> The help:active-profiles shows that -Dparallel-tests does not add any IT
> related profiles and results in skipping all the integration tests during
> verify phrase.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16711) With S3Guard + authmode, consider skipping "verifyBuckets" check in S3A fs init()
[ https://issues.apache.org/jira/browse/HADOOP-16711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976082#comment-16976082 ] Steve Loughran commented on HADOOP-16711: - Please justify. * If you believe it is because you don't need to check with things being there until you actually do some form of file IO, that is quite an interesting change. it means errors about non-existent buckets will only surface when you open a nonzero byte file to read, or try to write something. I'm curious whether we would sensibly translate whatever error comes back into a one about the bucket rather than the file. * If it is because S3Guard + DDB itself checks for the bucket location -that only happens if you don't specify region. But it will be nice to consider how we could combine the two checks. But remember you can have a different implementations of S3Guard; the local one does not talk AWS at all. * Be aware - the AWS S3 SDK apparently does some calls too, so that it can determine which endpoints to use for v4 signing. I believe that is a recent change in the SDKs -as Sidd Seth about it. If you're worried about start-up latency you are better off having an application create the S3 client asynchronously. That would hide all the overhead of DNS lookups, DDB init, S3 probes in both ours and the AWS libraries. See ORC-570 + please tag with version, components etc. > With S3Guard + authmode, consider skipping "verifyBuckets" check in S3A fs > init() > - > > Key: HADOOP-16711 > URL: https://issues.apache.org/jira/browse/HADOOP-16711 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 >Reporter: Rajesh Balamohan >Priority: Minor > Labels: performance > Attachments: HADOOP-16711.prelim.1.patch > > > When authoritative mode is enabled with s3guard, it would be good to skip > verifyBuckets call during S3A filesystem init(). This would save call to S3 > during init method. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16716) slf4j-log4j12 Should Not Be Included as Dependency
[ https://issues.apache.org/jira/browse/HADOOP-16716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976072#comment-16976072 ] Steve Loughran commented on HADOOP-16716: - There is a risk of this change will have traumatic consequences for every single application which uses the code and expects there to be logger on it. That includes all the other modules and their tests but downstream things too. Certainly, it will break my downstream applications which have had enough problems with guava updates already. If people don't want Log4J on the CP, they are free to exclude the relevant dependencies. And I hope the shaded client doesn't export these. Therefore I am in favour of leaving things as they are. please tag with versions, components etc. > slf4j-log4j12 Should Not Be Included as Dependency > -- > > Key: HADOOP-16716 > URL: https://issues.apache.org/jira/browse/HADOOP-16716 > Project: Hadoop Common > Issue Type: Improvement >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Major > > The project should be using 'slf4j-api' to log to the SLF4J framwork, but the > end-project, the project that includes hadoop-commons should be specifying > the specific binding to use. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16717) Remove GenericsUtil isLog4jLogger
[
https://issues.apache.org/jira/browse/HADOOP-16717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976069#comment-16976069
]
Steve Loughran commented on HADOOP-16717:
-
You should be able to switch to reflection here
> Remove GenericsUtil isLog4jLogger
> -
>
> Key: HADOOP-16717
> URL: https://issues.apache.org/jira/browse/HADOOP-16717
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.2
>Reporter: David Mollitor
>Assignee: Xieming Li
>Priority: Major
>
> Remove this method:
> {code:java}
> /**
>* Determine whether the log of clazz is Log4j implementation.
>* @param clazz a class to be determined
>* @return true if the log of clazz is Log4j implementation.
>*/
> public static boolean isLog4jLogger(Class clazz) {
> if (clazz == null) {
> return false;
> }
> Logger log = LoggerFactory.getLogger(clazz);
> return log instanceof Log4jLoggerAdapter;
> }
> {code}
> This creates a dependency on Log4jLoggerAdapter (slf4j-log4j12) which means
> that any project which depends on hadoop-commons needs to carry this
> dependency as well. Such a simple use case and such a heavy dependency. The
> commons library should not depend on any specific implementation of SLF4J
> binding
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Assigned] (HADOOP-16717) Remove GenericsUtil isLog4jLogger
[
https://issues.apache.org/jira/browse/HADOOP-16717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xieming Li reassigned HADOOP-16717:
---
Assignee: Xieming Li
> Remove GenericsUtil isLog4jLogger
> -
>
> Key: HADOOP-16717
> URL: https://issues.apache.org/jira/browse/HADOOP-16717
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.2
>Reporter: David Mollitor
>Assignee: Xieming Li
>Priority: Major
>
> Remove this method:
> {code:java}
> /**
>* Determine whether the log of clazz is Log4j implementation.
>* @param clazz a class to be determined
>* @return true if the log of clazz is Log4j implementation.
>*/
> public static boolean isLog4jLogger(Class clazz) {
> if (clazz == null) {
> return false;
> }
> Logger log = LoggerFactory.getLogger(clazz);
> return log instanceof Log4jLoggerAdapter;
> }
> {code}
> This creates a dependency on Log4jLoggerAdapter (slf4j-log4j12) which means
> that any project which depends on hadoop-commons needs to carry this
> dependency as well. Such a simple use case and such a heavy dependency. The
> commons library should not depend on any specific implementation of SLF4J
> binding
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
