[GitHub] [hadoop] GauthamBanasandra commented on pull request #4085: HDFS-16470.Change some frequent method lock type in ReplicaMap.
GauthamBanasandra commented on pull request #4085: URL: https://github.com/apache/hadoop/pull/4085#issuecomment-1073174347 @MingXiangLi It seems like you've mentioned the wrong JIRA in the title. Could you please fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Created] (HADOOP-18165) hadoop-yarn-ui has a number of insecure dependencies
PJ Fanning created HADOOP-18165: --- Summary: hadoop-yarn-ui has a number of insecure dependencies Key: HADOOP-18165 URL: https://issues.apache.org/jira/browse/HADOOP-18165 Project: Hadoop Common Issue Type: Bug Reporter: PJ Fanning Many of these are rates as critical or high risk vulnerabilities. This list is the tip of the iceberg. Examples found by dependabot * https://github.com/advisories/GHSA-35jh-r3h4-6jhm (lodash-es) * https://github.com/advisories/GHSA-p6mc-m468-83gw (lodash) * https://github.com/advisories/GHSA-pc58-wgmc-hfjr (mout) * https://github.com/advisories/GHSA-4rq4-32rv-6wp6 (shelljs) * https://github.com/advisories/GHSA-5955-9wpr-37jh (tar) may need to upgrade ember to allow these items above to be updated * https://github.com/advisories/GHSA-765h-qjxv-5f44 (handlebars) * https://github.com/advisories/GHSA-xfhh-g9f5-x4m4 (socket.io-parser) * https://github.com/advisories/GHSA-72mh-269x-7mh5 (xmlhttprequest-ssl) * https://github.com/advisories/GHSA-g78m-2chm-r7qv (websocket-extensions) -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4085: HDFS-16470.Change some frequent method lock type in ReplicaMap.
hadoop-yetus commented on pull request #4085:
URL: https://github.com/apache/hadoop/pull/4085#issuecomment-1073060257
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 12m 0s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 28s | | trunk passed |
| +1 :green_heart: | compile | 1m 27s | | trunk passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 1m 22s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 1s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 31s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 4s | | trunk passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 37s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 18s | | trunk passed |
| +1 :green_heart: | shadedclient | 22m 46s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 18s | | the patch passed |
| +1 :green_heart: | compile | 1m 18s | | the patch passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 1m 18s | | the patch passed |
| +1 :green_heart: | compile | 1m 13s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 1m 13s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 51s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 21s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 52s | | the patch passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 29s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 18s | | the patch passed |
| +1 :green_heart: | shadedclient | 22m 54s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 231m 24s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4085/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 46s | | The patch does not
generate ASF License warnings. |
| | | 344m 5s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | hadoop.hdfs.TestRollingUpgrade |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4085/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4085 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 34f8ee31fa21 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 75c2505bf0161dc9df5fb252db017d002ed05200 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4085/1/testReport/ |
| Max. process+thread count | 3013 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4085/1/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was
[jira] [Work logged] (HADOOP-13386) Upgrade Avro to 1.8.x or later
[ https://issues.apache.org/jira/browse/HADOOP-13386?focusedWorklogId=744636=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744636 ] ASF GitHub Bot logged work on HADOOP-13386: --- Author: ASF GitHub Bot Created on: 19/Mar/22 14:28 Start Date: 19/Mar/22 14:28 Worklog Time Spent: 10m Work Description: pjfanning commented on pull request #3990: URL: https://github.com/apache/hadoop/pull/3990#issuecomment-1073019803 @aajisaka would you be able to review this PR when you get a chance? I made one small change to an Avro based test to get it to pass. There are also timeout issues with the tests in TestRouterDistCpProcedure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 744636) Time Spent: 3.5h (was: 3h 20m) > Upgrade Avro to 1.8.x or later > -- > > Key: HADOOP-13386 > URL: https://issues.apache.org/jira/browse/HADOOP-13386 > Project: Hadoop Common > Issue Type: Sub-task > Components: build >Reporter: Ben McCann >Priority: Major > Labels: pull-request-available > Time Spent: 3.5h > Remaining Estimate: 0h > > Avro 1.8.x makes generated classes serializable which makes them much easier > to use with Spark. It would be great to upgrade Avro to 1.8.x -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] pjfanning commented on pull request #3990: [HADOOP-13386] upgrade to avro 1.9.2
pjfanning commented on pull request #3990: URL: https://github.com/apache/hadoop/pull/3990#issuecomment-1073019803 @aajisaka would you be able to review this PR when you get a chance? I made one small change to an Avro based test to get it to pass. There are also timeout issues with the tests in TestRouterDistCpProcedure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-13386) Upgrade Avro to 1.8.x or later
[
https://issues.apache.org/jira/browse/HADOOP-13386?focusedWorklogId=744630=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744630
]
ASF GitHub Bot logged work on HADOOP-13386:
---
Author: ASF GitHub Bot
Created on: 19/Mar/22 14:12
Start Date: 19/Mar/22 14:12
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3990:
URL: https://github.com/apache/hadoop/pull/3990#issuecomment-1073017380
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 22m 57s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | shelldocs | 0m 1s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 13m 28s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 26m 55s | | trunk passed |
| +1 :green_heart: | compile | 24m 46s | | trunk passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 21m 2s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 3m 50s | | trunk passed |
| +1 :green_heart: | mvnsite | 27m 6s | | trunk passed |
| +1 :green_heart: | javadoc | 8m 25s | | trunk passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 8m 19s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +0 :ok: | spotbugs | 0m 18s | | branch/hadoop-project no spotbugs
output file (spotbugsXml.xml) |
| +1 :green_heart: | shadedclient | 57m 42s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 29m 38s | | the patch passed |
| +1 :green_heart: | compile | 23m 59s | | the patch passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| -1 :x: | javac | 23m 59s |
[/results-compile-javac-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3990/14/artifact/out/results-compile-javac-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt)
| root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 1 new + 1805 unchanged - 2
fixed = 1806 total (was 1807) |
| +1 :green_heart: | compile | 21m 0s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | javac | 21m 0s |
[/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3990/14/artifact/out/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 1683
unchanged - 2 fixed = 1684 total (was 1685) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 3m 54s | | the patch passed |
| +1 :green_heart: | mvnsite | 25m 40s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | xml | 0m 10s | | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 8m 42s | | the patch passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 8m 21s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +0 :ok: | spotbugs | 0m 17s | | hadoop-project has no data from
spotbugs |
| -1 :x: | spotbugs | 35m 30s |
[/new-spotbugs-root.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3990/14/artifact/out/new-spotbugs-root.html)
| root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | shadedclient | 58m 14s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 1005m 47s |
[/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3990/14/artifact/out/patch-unit-root.txt)
| root in the patch
[GitHub] [hadoop] hadoop-yetus commented on pull request #3990: [HADOOP-13386] upgrade to avro 1.9.2
hadoop-yetus commented on pull request #3990:
URL: https://github.com/apache/hadoop/pull/3990#issuecomment-1073017380
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 22m 57s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | shelldocs | 0m 1s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 13m 28s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 26m 55s | | trunk passed |
| +1 :green_heart: | compile | 24m 46s | | trunk passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 21m 2s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 3m 50s | | trunk passed |
| +1 :green_heart: | mvnsite | 27m 6s | | trunk passed |
| +1 :green_heart: | javadoc | 8m 25s | | trunk passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 8m 19s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +0 :ok: | spotbugs | 0m 18s | | branch/hadoop-project no spotbugs
output file (spotbugsXml.xml) |
| +1 :green_heart: | shadedclient | 57m 42s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 29m 38s | | the patch passed |
| +1 :green_heart: | compile | 23m 59s | | the patch passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| -1 :x: | javac | 23m 59s |
[/results-compile-javac-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3990/14/artifact/out/results-compile-javac-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt)
| root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 generated 1 new + 1805 unchanged - 2
fixed = 1806 total (was 1807) |
| +1 :green_heart: | compile | 21m 0s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | javac | 21m 0s |
[/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3990/14/artifact/out/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 1683
unchanged - 2 fixed = 1684 total (was 1685) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 3m 54s | | the patch passed |
| +1 :green_heart: | mvnsite | 25m 40s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | xml | 0m 10s | | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 8m 42s | | the patch passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 8m 21s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +0 :ok: | spotbugs | 0m 17s | | hadoop-project has no data from
spotbugs |
| -1 :x: | spotbugs | 35m 30s |
[/new-spotbugs-root.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3990/14/artifact/out/new-spotbugs-root.html)
| root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | shadedclient | 58m 14s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 1005m 47s |
[/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3990/14/artifact/out/patch-unit-root.txt)
| root in the patch passed. |
| +1 :green_heart: | asflicense | 1m 32s | | The patch does not
generate ASF License warnings. |
| | | 1431m 2s | | |
| Reason | Tests |
|---:|:--|
| SpotBugs | module:root |
| | A known null value is checked to see if it is an instance of
org.apache.avro.util.Utf8 in
org.apache.hadoop.mapreduce.jobhistory.JobSubmitted.customDecode(ResolvingDecoder)
At
[GitHub] [hadoop] MingXiangLi opened a new pull request #4085: HDFS-16470.Change some frequent method lock type in ReplicaMap.
MingXiangLi opened a new pull request #4085: URL: https://github.com/apache/hadoop/pull/4085 In [HDFS-16429](https://issues.apache.org/jira/browse/HDFS-16429) we make LightWeightResizableGSet to be thread safe, and In [HDFS-15382](https://issues.apache.org/jira/browse/HDFS-15382) we have split lock to block pool grain locks.After these improvement, we can change some method to acquire read lock replace to acquire write lock. The lock now in ReplicaMap is protect replicaInfo message.But now it have been protect by lock in LightWeightResizableGSet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on a change in pull request #4081: HDFS-13248: Namenode needs to use the actual client IP when going through RBF proxy.
ayushtkn commented on a change in pull request #4081:
URL: https://github.com/apache/hadoop/pull/4081#discussion_r830458682
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeRpcServer.java
##
@@ -59,5 +70,87 @@ public void testNamenodeRpcBindAny() throws IOException {
conf.unset(DFS_NAMENODE_RPC_BIND_HOST_KEY);
}
}
+
+ /**
+ * Get the preferred DataNode location for the first block of the
+ * given file.
+ * @param fs The file system to use
+ * @param p The path to use
+ * @return the preferred host to get the data
+ */
+ private static String getPreferredLocation(DistributedFileSystem fs,
+ Path p) throws IOException{
+// Use getLocatedBlocks because it is the basis for HDFS open,
+// but provides visibility into which host will be used.
+LocatedBlocks blocks = fs.getClient()
+.getLocatedBlocks(p.toUri().getPath(), 0);
+return blocks.get(0).getLocations()[0].getHostName();
+ }
+
+ /**
+ * A test to make sure that if an authorized user adds "clientIp:" to their
+ * caller context, it will be used to make locality decisions on the NN.
+ */
+ @Test
+ public void testNamenodeRpcClientIpProxy() throws IOException {
+// Because of the randomness of the NN assigning DN, we run multiple
+// trials. 1/3^20=3e-10, so that should be good enough.
+final int ITERATIONS_TO_USE = 20;
Review comment:
variable name fetches checkstyle warning
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4081/5/artifact/out/results-checkstyle-root.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18088) Replace log4j 1.x with reload4j
[
https://issues.apache.org/jira/browse/HADOOP-18088?focusedWorklogId=744606=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744606
]
ASF GitHub Bot logged work on HADOOP-18088:
---
Author: ASF GitHub Bot
Created on: 19/Mar/22 08:19
Start Date: 19/Mar/22 08:19
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #4084:
URL: https://github.com/apache/hadoop/pull/4084#issuecomment-1072967518
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 11m 40s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ branch-3.2 Compile Tests _ |
| +0 :ok: | mvndep | 3m 19s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 26m 18s | | branch-3.2 passed |
| +1 :green_heart: | compile | 15m 33s | | branch-3.2 passed |
| +1 :green_heart: | checkstyle | 2m 40s | | branch-3.2 passed |
| +1 :green_heart: | mvnsite | 16m 0s | | branch-3.2 passed |
| +1 :green_heart: | javadoc | 5m 53s | | branch-3.2 passed |
| +0 :ok: | spotbugs | 0m 16s | | branch/hadoop-project no spotbugs
output file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 20s | |
branch/hadoop-client-modules/hadoop-client no spotbugs output file
(spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 19s | |
branch/hadoop-client-modules/hadoop-client-check-invariants no spotbugs output
file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 20s | |
branch/hadoop-client-modules/hadoop-client-check-test-invariants no spotbugs
output file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 19s | |
branch/hadoop-client-modules/hadoop-client-integration-tests no spotbugs output
file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 21s | |
branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file
(spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 19s | |
branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file
(spotbugsXml.xml) |
| +1 :green_heart: | shadedclient | 15m 22s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 44m 44s | | the patch passed |
| +1 :green_heart: | compile | 15m 3s | | the patch passed |
| +1 :green_heart: | javac | 15m 3s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 2m 41s | | the patch passed |
| +1 :green_heart: | mvnsite | 13m 33s | | the patch passed |
| +1 :green_heart: | xml | 0m 32s | | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 5m 49s | | the patch passed |
| +0 :ok: | spotbugs | 0m 15s | | hadoop-project has no data from
spotbugs |
| +0 :ok: | spotbugs | 0m 18s | | hadoop-client-modules/hadoop-client
has no data from spotbugs |
| +0 :ok: | spotbugs | 0m 17s | |
hadoop-client-modules/hadoop-client-runtime has no data from spotbugs |
| +0 :ok: | spotbugs | 0m 18s | |
hadoop-client-modules/hadoop-client-check-invariants has no data from spotbugs
|
| +0 :ok: | spotbugs | 0m 18s | |
hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs |
| +0 :ok: | spotbugs | 0m 17s | |
hadoop-client-modules/hadoop-client-check-test-invariants has no data from
spotbugs |
| +0 :ok: | spotbugs | 0m 18s | |
hadoop-client-modules/hadoop-client-integration-tests has no data from spotbugs
|
| +1 :green_heart: | shadedclient | 40m 1s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 651m 35s |
[/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4084/2/artifact/out/patch-unit-root.txt)
| root in the patch passed. |
| -1 :x: | asflicense | 1m 5s |
[/results-asflicense.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4084/2/artifact/out/results-asflicense.txt)
| The patch generated 1 ASF License warnings. |
| | | 963m 26s | | |
| Reason | Tests |
|---:|:--|
| Failed junit
[GitHub] [hadoop] hadoop-yetus commented on pull request #4084: HADOOP-18088. Replace log4j 1.x with reload4j.
hadoop-yetus commented on pull request #4084:
URL: https://github.com/apache/hadoop/pull/4084#issuecomment-1072967518
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 11m 40s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ branch-3.2 Compile Tests _ |
| +0 :ok: | mvndep | 3m 19s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 26m 18s | | branch-3.2 passed |
| +1 :green_heart: | compile | 15m 33s | | branch-3.2 passed |
| +1 :green_heart: | checkstyle | 2m 40s | | branch-3.2 passed |
| +1 :green_heart: | mvnsite | 16m 0s | | branch-3.2 passed |
| +1 :green_heart: | javadoc | 5m 53s | | branch-3.2 passed |
| +0 :ok: | spotbugs | 0m 16s | | branch/hadoop-project no spotbugs
output file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 20s | |
branch/hadoop-client-modules/hadoop-client no spotbugs output file
(spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 19s | |
branch/hadoop-client-modules/hadoop-client-check-invariants no spotbugs output
file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 20s | |
branch/hadoop-client-modules/hadoop-client-check-test-invariants no spotbugs
output file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 19s | |
branch/hadoop-client-modules/hadoop-client-integration-tests no spotbugs output
file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 21s | |
branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file
(spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 19s | |
branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file
(spotbugsXml.xml) |
| +1 :green_heart: | shadedclient | 15m 22s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 44m 44s | | the patch passed |
| +1 :green_heart: | compile | 15m 3s | | the patch passed |
| +1 :green_heart: | javac | 15m 3s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 2m 41s | | the patch passed |
| +1 :green_heart: | mvnsite | 13m 33s | | the patch passed |
| +1 :green_heart: | xml | 0m 32s | | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 5m 49s | | the patch passed |
| +0 :ok: | spotbugs | 0m 15s | | hadoop-project has no data from
spotbugs |
| +0 :ok: | spotbugs | 0m 18s | | hadoop-client-modules/hadoop-client
has no data from spotbugs |
| +0 :ok: | spotbugs | 0m 17s | |
hadoop-client-modules/hadoop-client-runtime has no data from spotbugs |
| +0 :ok: | spotbugs | 0m 18s | |
hadoop-client-modules/hadoop-client-check-invariants has no data from spotbugs
|
| +0 :ok: | spotbugs | 0m 18s | |
hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs |
| +0 :ok: | spotbugs | 0m 17s | |
hadoop-client-modules/hadoop-client-check-test-invariants has no data from
spotbugs |
| +0 :ok: | spotbugs | 0m 18s | |
hadoop-client-modules/hadoop-client-integration-tests has no data from spotbugs
|
| +1 :green_heart: | shadedclient | 40m 1s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 651m 35s |
[/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4084/2/artifact/out/patch-unit-root.txt)
| root in the patch passed. |
| -1 :x: | asflicense | 1m 5s |
[/results-asflicense.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4084/2/artifact/out/results-asflicense.txt)
| The patch generated 1 ASF License warnings. |
| | | 963m 26s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | hadoop.mapred.uploader.TestFrameworkUploader |
| |
hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2 |
| | hadoop.security.TestRaceWhenRelogin |
| | hadoop.hdfs.TestDatanodeRegistration |
| | hadoop.hdfs.server.datanode.TestBPOfferService |
| | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer |
| | hadoop.hdfs.TestRollingUpgrade |
| Subsystem |
[GitHub] [hadoop] tomscut commented on a change in pull request #4082: HDFS-16507. Avoid purging edit log which is in progress
tomscut commented on a change in pull request #4082:
URL: https://github.com/apache/hadoop/pull/4082#discussion_r830454966
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
##
@@ -1509,13 +1509,18 @@ synchronized void abortCurrentLogSegment() {
* effect.
*/
@Override
- public synchronized void purgeLogsOlderThan(final long minTxIdToKeep) {
+ public synchronized void purgeLogsOlderThan(long minTxIdToKeep) {
// Should not purge logs unless they are open for write.
// This prevents the SBN from purging logs on shared storage, for example.
if (!isOpenForWrite()) {
return;
}
-
+
+// Reset purgeLogsFrom to avoid purging edit log which is in progress.
+if (isSegmentOpen()) {
+ minTxIdToKeep = minTxIdToKeep > curSegmentTxId ? curSegmentTxId :
minTxIdToKeep;
Review comment:
> Just below this we have:
>
> ```java
> assert curSegmentTxId == HdfsServerConstants.INVALID_TXID || // on
format this is no-op
> minTxIdToKeep <= curSegmentTxId :
> "cannot purge logs older than txid " + minTxIdToKeep +
> " when current segment starts at " + curSegmentTxId;
> ```
>
> We assert that `minTxIdToKeep <= curSegmentTxId`. So in the situation you
described where `minTxIdToKeep > curSegmentTxId`, shouldn't the assert fail?
Thank you @xkrogen very much for your reply.
We did add assertion. But in the production, assertions are usually disabled
and do not actually take effect. I think we should add strict logic to avoid
problems. What do you think of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on a change in pull request #4082: HDFS-16507. Avoid purging edit log which is in progress
tomscut commented on a change in pull request #4082:
URL: https://github.com/apache/hadoop/pull/4082#discussion_r830454966
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
##
@@ -1509,13 +1509,18 @@ synchronized void abortCurrentLogSegment() {
* effect.
*/
@Override
- public synchronized void purgeLogsOlderThan(final long minTxIdToKeep) {
+ public synchronized void purgeLogsOlderThan(long minTxIdToKeep) {
// Should not purge logs unless they are open for write.
// This prevents the SBN from purging logs on shared storage, for example.
if (!isOpenForWrite()) {
return;
}
-
+
+// Reset purgeLogsFrom to avoid purging edit log which is in progress.
+if (isSegmentOpen()) {
+ minTxIdToKeep = minTxIdToKeep > curSegmentTxId ? curSegmentTxId :
minTxIdToKeep;
Review comment:
> Just below this we have:
>
> ```java
> assert curSegmentTxId == HdfsServerConstants.INVALID_TXID || // on
format this is no-op
> minTxIdToKeep <= curSegmentTxId :
> "cannot purge logs older than txid " + minTxIdToKeep +
> " when current segment starts at " + curSegmentTxId;
> ```
>
> We assert that `minTxIdToKeep <= curSegmentTxId`. So in the situation you
described where `minTxIdToKeep > curSegmentTxId`, shouldn't the assert fail?
Thank you @xkrogen very much for your reply.
We did add assertion. But in the production, assertions are usually
prohibited and do not actually take effect. I think we should add strict logic
to avoid problems. What do you think of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18088) Replace log4j 1.x with reload4j
[
https://issues.apache.org/jira/browse/HADOOP-18088?focusedWorklogId=744602=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744602
]
ASF GitHub Bot logged work on HADOOP-18088:
---
Author: ASF GitHub Bot
Created on: 19/Mar/22 07:30
Start Date: 19/Mar/22 07:30
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #4084:
URL: https://github.com/apache/hadoop/pull/4084#issuecomment-1072960849
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 11m 32s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ branch-3.2 Compile Tests _ |
| +0 :ok: | mvndep | 3m 23s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 26m 8s | | branch-3.2 passed |
| +1 :green_heart: | compile | 15m 40s | | branch-3.2 passed |
| +1 :green_heart: | checkstyle | 2m 41s | | branch-3.2 passed |
| +1 :green_heart: | mvnsite | 19m 9s | | branch-3.2 passed |
| +1 :green_heart: | javadoc | 15m 52s | | branch-3.2 passed |
| +0 :ok: | spotbugs | 0m 25s | | branch/hadoop-project no spotbugs
output file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 26s | |
branch/hadoop-client-modules/hadoop-client no spotbugs output file
(spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 24s | |
branch/hadoop-client-modules/hadoop-client-check-invariants no spotbugs output
file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 25s | |
branch/hadoop-client-modules/hadoop-client-check-test-invariants no spotbugs
output file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 24s | |
branch/hadoop-client-modules/hadoop-client-integration-tests no spotbugs output
file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 25s | |
branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file
(spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 25s | |
branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file
(spotbugsXml.xml) |
| +1 :green_heart: | shadedclient | 15m 55s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 22m 31s | | the patch passed |
| +1 :green_heart: | compile | 15m 6s | | the patch passed |
| +1 :green_heart: | javac | 15m 6s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 2m 40s | | the patch passed |
| +1 :green_heart: | mvnsite | 19m 2s | | the patch passed |
| +1 :green_heart: | xml | 0m 33s | | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 15m 42s | | the patch passed |
| +0 :ok: | spotbugs | 0m 25s | | hadoop-project has no data from
spotbugs |
| +0 :ok: | spotbugs | 0m 28s | | hadoop-client-modules/hadoop-client
has no data from spotbugs |
| +0 :ok: | spotbugs | 0m 27s | |
hadoop-client-modules/hadoop-client-runtime has no data from spotbugs |
| +0 :ok: | spotbugs | 0m 27s | |
hadoop-client-modules/hadoop-client-check-invariants has no data from spotbugs
|
| +0 :ok: | spotbugs | 0m 27s | |
hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs |
| +0 :ok: | spotbugs | 0m 27s | |
hadoop-client-modules/hadoop-client-check-test-invariants has no data from
spotbugs |
| +0 :ok: | spotbugs | 0m 26s | |
hadoop-client-modules/hadoop-client-integration-tests has no data from spotbugs
|
| +1 :green_heart: | shadedclient | 14m 40s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 0m 24s | | hadoop-project in the patch
passed. |
| +1 :green_heart: | unit | 0m 37s | | hadoop-minikdc in the patch
passed. |
| +1 :green_heart: | unit | 3m 18s | | hadoop-auth in the patch
passed. |
| +1 :green_heart: | unit | 0m 27s | | hadoop-auth-examples in the
patch passed. |
| +1 :green_heart: | unit | 16m 1s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 0m 45s | | hadoop-nfs in the patch
[GitHub] [hadoop] hadoop-yetus commented on pull request #4084: HADOOP-18088. Replace log4j 1.x with reload4j.
hadoop-yetus commented on pull request #4084:
URL: https://github.com/apache/hadoop/pull/4084#issuecomment-1072960849
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 11m 32s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ branch-3.2 Compile Tests _ |
| +0 :ok: | mvndep | 3m 23s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 26m 8s | | branch-3.2 passed |
| +1 :green_heart: | compile | 15m 40s | | branch-3.2 passed |
| +1 :green_heart: | checkstyle | 2m 41s | | branch-3.2 passed |
| +1 :green_heart: | mvnsite | 19m 9s | | branch-3.2 passed |
| +1 :green_heart: | javadoc | 15m 52s | | branch-3.2 passed |
| +0 :ok: | spotbugs | 0m 25s | | branch/hadoop-project no spotbugs
output file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 26s | |
branch/hadoop-client-modules/hadoop-client no spotbugs output file
(spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 24s | |
branch/hadoop-client-modules/hadoop-client-check-invariants no spotbugs output
file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 25s | |
branch/hadoop-client-modules/hadoop-client-check-test-invariants no spotbugs
output file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 24s | |
branch/hadoop-client-modules/hadoop-client-integration-tests no spotbugs output
file (spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 25s | |
branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file
(spotbugsXml.xml) |
| +0 :ok: | spotbugs | 0m 25s | |
branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file
(spotbugsXml.xml) |
| +1 :green_heart: | shadedclient | 15m 55s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 22m 31s | | the patch passed |
| +1 :green_heart: | compile | 15m 6s | | the patch passed |
| +1 :green_heart: | javac | 15m 6s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 2m 40s | | the patch passed |
| +1 :green_heart: | mvnsite | 19m 2s | | the patch passed |
| +1 :green_heart: | xml | 0m 33s | | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 15m 42s | | the patch passed |
| +0 :ok: | spotbugs | 0m 25s | | hadoop-project has no data from
spotbugs |
| +0 :ok: | spotbugs | 0m 28s | | hadoop-client-modules/hadoop-client
has no data from spotbugs |
| +0 :ok: | spotbugs | 0m 27s | |
hadoop-client-modules/hadoop-client-runtime has no data from spotbugs |
| +0 :ok: | spotbugs | 0m 27s | |
hadoop-client-modules/hadoop-client-check-invariants has no data from spotbugs
|
| +0 :ok: | spotbugs | 0m 27s | |
hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs |
| +0 :ok: | spotbugs | 0m 27s | |
hadoop-client-modules/hadoop-client-check-test-invariants has no data from
spotbugs |
| +0 :ok: | spotbugs | 0m 26s | |
hadoop-client-modules/hadoop-client-integration-tests has no data from spotbugs
|
| +1 :green_heart: | shadedclient | 14m 40s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 0m 24s | | hadoop-project in the patch
passed. |
| +1 :green_heart: | unit | 0m 37s | | hadoop-minikdc in the patch
passed. |
| +1 :green_heart: | unit | 3m 18s | | hadoop-auth in the patch
passed. |
| +1 :green_heart: | unit | 0m 27s | | hadoop-auth-examples in the
patch passed. |
| +1 :green_heart: | unit | 16m 1s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 0m 45s | | hadoop-nfs in the patch passed.
|
| +1 :green_heart: | unit | 3m 40s | | hadoop-kms in the patch passed.
|
| +1 :green_heart: | unit | 2m 3s | | hadoop-hdfs-client in the patch
passed. |
| -1 :x: | unit | 217m 38s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4084/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the
[GitHub] [hadoop] hadoop-yetus commented on pull request #4081: HDFS-13248: Namenode needs to use the actual client IP when going through RBF proxy.
hadoop-yetus commented on pull request #4081:
URL: https://github.com/apache/hadoop/pull/4081#issuecomment-1072960641
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 58s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | markdownlint | 0m 0s | | markdownlint was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 12m 41s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 27m 20s | | trunk passed |
| +1 :green_heart: | compile | 29m 29s | | trunk passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 25m 2s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 3m 58s | | trunk passed |
| +1 :green_heart: | mvnsite | 4m 36s | | trunk passed |
| +1 :green_heart: | javadoc | 3m 8s | | trunk passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 4m 37s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 8m 16s | | trunk passed |
| +1 :green_heart: | shadedclient | 24m 44s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 56s | | the patch passed |
| +1 :green_heart: | compile | 26m 20s | | the patch passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 26m 20s | | the patch passed |
| +1 :green_heart: | compile | 25m 24s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 25m 24s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 4m 22s |
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4081/5/artifact/out/results-checkstyle-root.txt)
| root: The patch generated 1 new + 415 unchanged - 0 fixed = 416 total (was
415) |
| +1 :green_heart: | mvnsite | 4m 45s | | the patch passed |
| +1 :green_heart: | xml | 0m 2s | | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 3m 38s | | the patch passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 5m 8s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 9m 3s | | the patch passed |
| +1 :green_heart: | shadedclient | 28m 8s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 19m 14s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 379m 59s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | unit | 40m 9s | | hadoop-hdfs-rbf in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 8s | | The patch does not
generate ASF License warnings. |
| | | 698m 0s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4081/5/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4081 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint xml |
| uname | Linux dcc4433df778 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29
06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 322cffe88d96c96f1ea52c1514af4b5795506d91 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4081/5/testReport/ |
| Max. process+thread count | 2495 (vs. ulimit of 5500) |
| modules | C:
[GitHub] [hadoop] hadoop-yetus commented on pull request #4081: HDFS-13248: Namenode needs to use the actual client IP when going through RBF proxy.
hadoop-yetus commented on pull request #4081:
URL: https://github.com/apache/hadoop/pull/4081#issuecomment-1072958998
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 19m 4s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | markdownlint | 0m 1s | | markdownlint was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 12m 51s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 28m 35s | | trunk passed |
| +1 :green_heart: | compile | 28m 51s | | trunk passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 24m 42s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 4m 20s | | trunk passed |
| +1 :green_heart: | mvnsite | 4m 46s | | trunk passed |
| +1 :green_heart: | javadoc | 3m 34s | | trunk passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 4m 44s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 8m 41s | | trunk passed |
| +1 :green_heart: | shadedclient | 27m 26s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 25s | | the patch passed |
| +1 :green_heart: | compile | 26m 56s | | the patch passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 26m 56s | | the patch passed |
| +1 :green_heart: | compile | 22m 42s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 22m 42s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 3m 52s |
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4081/6/artifact/out/results-checkstyle-root.txt)
| root: The patch generated 1 new + 415 unchanged - 0 fixed = 416 total (was
415) |
| +1 :green_heart: | mvnsite | 4m 2s | | the patch passed |
| +1 :green_heart: | xml | 0m 1s | | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 3m 23s | | the patch passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 4m 32s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 8m 11s | | the patch passed |
| +1 :green_heart: | shadedclient | 24m 50s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 17m 47s | | hadoop-common in the patch
passed. |
| -1 :x: | unit | 338m 52s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4081/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| -1 :x: | unit | 38m 48s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4081/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt)
| hadoop-hdfs-rbf in the patch passed. |
| +1 :green_heart: | asflicense | 1m 11s | | The patch does not
generate ASF License warnings. |
| | | 669m 13s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | hadoop.hdfs.server.mover.TestMover |
| | hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4081/6/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4081 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint xml |
| uname | Linux 8608bf267e21 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18
11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision
