date:20230405

[GitHub] [hadoop] melissayou closed pull request #5534: [HDFS-16971]add read metrics for remote reads in FileSystem Statistics

2023-04-05 Thread via GitHub



melissayou closed pull request #5534: [HDFS-16971]add read metrics for remote 
reads in FileSystem Statistics
URL: https://github.com/apache/hadoop/pull/5534


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] melissayou commented on pull request #5534: [HDFS-16971]add read metrics for remote reads in FileSystem Statistics

2023-04-05 Thread via GitHub



melissayou commented on PR #5534:
URL: https://github.com/apache/hadoop/pull/5534#issuecomment-1498562755

   Closing in favor of https://github.com/apache/hadoop/pull/5536


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] slfan1989 commented on pull request #5525: YARN-11377. [Federation] Support addToClusterNodeLabels、removeFromClusterNodeLabels、replaceLabelsOnNode API's for Federation.

2023-04-05 Thread via GitHub



slfan1989 commented on PR #5525:
URL: https://github.com/apache/hadoop/pull/5525#issuecomment-1498528683

   > There are a few checkstyle issues left.
   
   @goiri Thank you very much for your help to review the code! I will modify 
the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] hadoop-yetus commented on pull request #5536: [HDFS-16971]add read metrics for remote reads in FileSystem Statistics #5534

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5536:
URL: https://github.com/apache/hadoop/pull/5536#issuecomment-1498471027

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 49s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  71m 38s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  31m  6s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  30m 18s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  compile  |  23m  2s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  checkstyle  |   4m 13s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 53s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m 56s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 26s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 36s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  26m 28s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 26s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 14s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  29m 17s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javac  |  29m 17s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  24m  2s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  javac  |  24m  2s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   4m  5s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   2m 54s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 56s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 24s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 50s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  25m 55s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  18m 41s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   2m 31s |  |  hadoop-hdfs-client in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 52s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 319m 55s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5536/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5536 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 17f938c87f17 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / e2564fcd67b98ac411414b78282bfd0aefa99706 |
   | Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
 /usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5536/3/testReport/ |
   | Max. process+thread count | 1375 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common 
hadoop-hdfs-project/hadoop-hdfs-client U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5536/3/console |
   | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.

[GitHub] [hadoop] hadoop-yetus commented on pull request #5536: [HDFS-16971]add read metrics for remote reads in FileSystem Statistics #5534

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5536:
URL: https://github.com/apache/hadoop/pull/5536#issuecomment-1498463690

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 53s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  82m 59s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  29m 23s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  28m 20s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  compile  |  25m 32s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  checkstyle  |  12m 32s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 54s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m  7s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 28s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 44s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  26m 12s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 42s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 51s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  29m 10s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javac  |  29m 10s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  26m  7s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  javac  |  26m  7s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   4m  7s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   3m  1s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 53s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 25s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   6m  6s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  26m 12s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  18m 50s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   2m 36s |  |  hadoop-hdfs-client in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 54s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 341m 23s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5536/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5536 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 917fedd73546 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 7313169073a6bda7d7568ef5cf38bcda22181d08 |
   | Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
 /usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5536/2/testReport/ |
   | Max. process+thread count | 2035 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common 
hadoop-hdfs-project/hadoop-hdfs-client U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5536/2/console |
   | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.

[GitHub] [hadoop] simbadzina commented on pull request #5469: HDFS-16943. RBF: Implements MySQL based StateStoreDriver.

2023-04-05 Thread via GitHub



simbadzina commented on PR #5469:
URL: https://github.com/apache/hadoop/pull/5469#issuecomment-1498413388

   Thank you for the reviews @virajjasani @goiri .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2023-04-05 Thread via GitHub



slfan1989 commented on code in PR #4963:
URL: https://github.com/apache/hadoop/pull/4963#discussion_r115945


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateStoreService.java:
##
@@ -283,154 +290,251 @@ public void checkVersion() throws Exception {
   @Override
   public GetSubClusterPolicyConfigurationResponse getPolicyConfiguration(
   GetSubClusterPolicyConfigurationRequest request) throws YarnException {
-return stateStoreClient.getPolicyConfiguration(request);
+FederationClientMethod 
clientMethod =
+new FederationClientMethod<>("getPolicyConfiguration",
+GetSubClusterPolicyConfigurationRequest.class, request,
+GetSubClusterPolicyConfigurationResponse.class, stateStoreClient, 
clock);
+return clientMethod.invoke();
   }
 
   @Override
   public SetSubClusterPolicyConfigurationResponse setPolicyConfiguration(
   SetSubClusterPolicyConfigurationRequest request) throws YarnException {
-return stateStoreClient.setPolicyConfiguration(request);
+FederationClientMethod 
clientMethod =
+new FederationClientMethod<>("setPolicyConfiguration",
+SetSubClusterPolicyConfigurationRequest.class, request,
+SetSubClusterPolicyConfigurationResponse.class, stateStoreClient, 
clock);
+return clientMethod.invoke();
   }
 
   @Override
   public GetSubClusterPoliciesConfigurationsResponse getPoliciesConfigurations(
   GetSubClusterPoliciesConfigurationsRequest request) throws YarnException 
{
-return stateStoreClient.getPoliciesConfigurations(request);
+FederationClientMethod 
clientMethod =
+new FederationClientMethod<>("getPoliciesConfigurations",
+GetSubClusterPoliciesConfigurationsRequest.class, request,
+GetSubClusterPoliciesConfigurationsResponse.class, stateStoreClient, 
clock);
+return clientMethod.invoke();
   }
 
   @Override
-  public SubClusterRegisterResponse registerSubCluster(
-  SubClusterRegisterRequest registerSubClusterRequest)
+  public SubClusterRegisterResponse 
registerSubCluster(SubClusterRegisterRequest request)
   throws YarnException {
-return stateStoreClient.registerSubCluster(registerSubClusterRequest);
+FederationClientMethod clientMethod =
+new FederationClientMethod<>("registerSubCluster",
+SubClusterRegisterRequest.class, request,
+SubClusterRegisterResponse.class, stateStoreClient, clock);
+return clientMethod.invoke();
   }
 
   @Override
-  public SubClusterDeregisterResponse deregisterSubCluster(
-  SubClusterDeregisterRequest subClusterDeregisterRequest)
+  public SubClusterDeregisterResponse 
deregisterSubCluster(SubClusterDeregisterRequest request)
   throws YarnException {
-return stateStoreClient.deregisterSubCluster(subClusterDeregisterRequest);
+FederationClientMethod clientMethod =
+new FederationClientMethod<>("deregisterSubCluster",
+SubClusterDeregisterRequest.class, request,
+SubClusterDeregisterResponse.class, stateStoreClient, clock);
+return clientMethod.invoke();
   }
 
   @Override
-  public SubClusterHeartbeatResponse subClusterHeartbeat(
-  SubClusterHeartbeatRequest subClusterHeartbeatRequest)
+  public SubClusterHeartbeatResponse 
subClusterHeartbeat(SubClusterHeartbeatRequest request)
   throws YarnException {
-return stateStoreClient.subClusterHeartbeat(subClusterHeartbeatRequest);
+FederationClientMethod clientMethod =
+new FederationClientMethod<>("subClusterHeartbeat",
+SubClusterHeartbeatRequest.class, request,
+SubClusterHeartbeatResponse.class, stateStoreClient, clock);
+return clientMethod.invoke();
   }
 
   @Override
-  public GetSubClusterInfoResponse getSubCluster(
-  GetSubClusterInfoRequest subClusterRequest) throws YarnException {
-return stateStoreClient.getSubCluster(subClusterRequest);
+  public GetSubClusterInfoResponse getSubCluster(GetSubClusterInfoRequest 
request)
+  throws YarnException {
+FederationClientMethod clientMethod =
+new FederationClientMethod<>("getSubCluster",
+GetSubClusterInfoRequest.class, request,
+GetSubClusterInfoResponse.class, stateStoreClient, clock);
+return clientMethod.invoke();
   }
 
   @Override
-  public GetSubClustersInfoResponse getSubClusters(
-  GetSubClustersInfoRequest subClustersRequest) throws YarnException {
-return stateStoreClient.getSubClusters(subClustersRequest);
+  public GetSubClustersInfoResponse getSubClusters(GetSubClustersInfoRequest 
request)
+  throws YarnException {
+FederationClientMethod clientMethod =
+new FederationClientMethod<>("getSubClusters",
+GetSubClustersInfoRequest.class, request,
+GetSubClustersInfoResponse.class, stateStoreClient, clock);
+return clientMethod.invoke();
   }
 
   @Override
   pub

[GitHub] [hadoop] slfan1989 commented on pull request #5518: YARN-11436. [Federation] MemoryFederationStateStore Support Version.

2023-04-05 Thread via GitHub



slfan1989 commented on PR #5518:
URL: https://github.com/apache/hadoop/pull/5518#issuecomment-1498403620

   @goiri Thank you very much for your help in reviewing the code!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] goiri merged pull request #5469: HDFS-16943. RBF: Implements MySQL based StateStoreDriver.

2023-04-05 Thread via GitHub



goiri merged PR #5469:
URL: https://github.com/apache/hadoop/pull/5469


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-16206) Migrate from Log4j1 to Log4j2

2023-04-05 Thread Viraj Jasani (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709132#comment-17709132
 ] 

Viraj Jasani commented on HADOOP-16206:
---

A gentle reminder for the review of adding hadoop-logging module on 
[https://github.com/apache/hadoop/pull/5503]

Thanks

> Migrate from Log4j1 to Log4j2
> -
>
> Key: HADOOP-16206
> URL: https://issues.apache.org/jira/browse/HADOOP-16206
> Project: Hadoop Common
>  Issue Type: Task
>Affects Versions: 3.3.0
>Reporter: Akira Ajisaka
>Assignee: Viraj Jasani
>Priority: Major
> Attachments: HADOOP-16206-wip.001.patch
>
>
> This sub-task is to remove log4j1 dependency and add log4j2 dependency.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-16206) Migrate from Log4j1 to Log4j2

2023-04-05 Thread Viraj Jasani (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709131#comment-17709131
 ] 

Viraj Jasani commented on HADOOP-16206:
---

The explanation for breaking Java 11 compilation support is provided on 
HADOOP-12956.

> Migrate from Log4j1 to Log4j2
> -
>
> Key: HADOOP-16206
> URL: https://issues.apache.org/jira/browse/HADOOP-16206
> Project: Hadoop Common
>  Issue Type: Task
>Affects Versions: 3.3.0
>Reporter: Akira Ajisaka
>Assignee: Viraj Jasani
>Priority: Major
> Attachments: HADOOP-16206-wip.001.patch
>
>
> This sub-task is to remove log4j1 dependency and add log4j2 dependency.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] hadoop-yetus commented on pull request #5536: [HDFS-16971]add read metrics for remote reads in FileSystem Statistics #5534

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5536:
URL: https://github.com/apache/hadoop/pull/5536#issuecomment-1498240339

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 52s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  16m  2s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  29m 50s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  27m 21s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  compile  |  24m 53s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  checkstyle  |   4m  7s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 49s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m 56s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 26s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 31s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  25m 16s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 51s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  24m 38s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javac  |  24m 38s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  21m 41s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  javac  |  21m 41s |  |  the patch passed  |
   | -1 :x: |  blanks  |   0m  0s | 
[/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5536/1/artifact/out/blanks-eol.txt)
 |  The patch has 5 line(s) that end in blanks. Use git apply --whitespace=fix 
<>. Refer https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  checkstyle  |   3m 50s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   2m 43s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 48s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 28s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 37s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  25m 51s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  18m 15s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   2m 34s |  |  hadoop-hdfs-client in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 53s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 252m 21s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5536/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5536 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux ac9a29230171 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / ef018d4e277af047977579b162133663c67120a1 |
   | Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
 /usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5536/1/testReport/ |
   | Max. process+thread count | 2409 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common 
hadoop-hdfs-project/hadoop-hdfs-client U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5536/1/

[GitHub] [hadoop] virajjasani commented on pull request #5469: HDFS-16943. RBF: Implements MySQL based StateStoreDriver.

2023-04-05 Thread via GitHub



virajjasani commented on PR #5469:
URL: https://github.com/apache/hadoop/pull/5469#issuecomment-1498188706

   Sorry I did +1 but it was only comment. The changes look good for 3.4.0. 
Thank you @goiri @simbadzina !!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] hadoop-yetus commented on pull request #5534: [HDFS-16971]add read metrics for remote reads in FileSystem Statistics

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5534:
URL: https://github.com/apache/hadoop/pull/5534#issuecomment-1498186760

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 57s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  16m 11s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  30m 23s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  29m 51s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  compile  |  25m  3s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  checkstyle  |   4m 26s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m  1s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m  4s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 31s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 47s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  26m  3s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 25s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 54s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  26m 38s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javac  |  26m 38s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  23m  7s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  javac  |  23m  7s |  |  the patch passed  |
   | -1 :x: |  blanks  |   0m  0s | 
[/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5534/2/artifact/out/blanks-eol.txt)
 |  The patch has 5 line(s) that end in blanks. Use git apply --whitespace=fix 
<>. Refer https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  checkstyle  |   3m 52s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   2m 42s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 49s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 26s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 37s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  25m 13s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  18m 14s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   2m 31s |  |  hadoop-hdfs-client in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 53s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 260m 14s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5534/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5534 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 43ad5cdb9f37 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / ef018d4e277af047977579b162133663c67120a1 |
   | Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
 /usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5534/2/testReport/ |
   | Max. process+thread count | 1303 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common 
hadoop-hdfs-project/hadoop-hdfs-client U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5534/2/

[GitHub] [hadoop] goiri commented on pull request #5469: HDFS-16943. RBF: Implements MySQL based StateStoreDriver.

2023-04-05 Thread via GitHub



goiri commented on PR #5469:
URL: https://github.com/apache/hadoop/pull/5469#issuecomment-1498163495

   @virajjasani do you mind approving?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] goiri merged pull request #5533: HDFS-16973. RBF: MountTableResolver cache size lookup should take read lock

2023-04-05 Thread via GitHub



goiri merged PR #5533:
URL: https://github.com/apache/hadoop/pull/5533


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] hadoop-yetus commented on pull request #5519: MAPREDUCE-7435. Manifest Committer OOM on abfs

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#issuecomment-1498081085

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 51s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 10 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  16m 33s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 48s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  25m 10s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  compile  |  22m 15s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  checkstyle  |   4m  4s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 33s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m 28s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 54s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | -1 :x: |  spotbugs  |   1m 39s | 
[/branch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5519/5/artifact/out/branch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html)
 |  
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core 
in trunk has 1 extant spotbugs warnings.  |
   | +1 :green_heart: |  shadedclient  |  25m  5s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 30s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 25s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  29m  2s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javac  |  29m  2s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  24m  2s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  javac  |  24m  2s |  |  the patch passed  |
   | -1 :x: |  blanks  |   0m  0s | 
[/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5519/5/artifact/out/blanks-eol.txt)
 |  The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix 
<>. Refer https://git-scm.com/docs/git-apply  |
   | -0 :warning: |  checkstyle  |   4m  1s | 
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5519/5/artifact/out/results-checkstyle-root.txt)
 |  root: The patch generated 7 new + 33 unchanged - 0 fixed = 40 total (was 
33)  |
   | +1 :green_heart: |  mvnsite  |   3m 34s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m 11s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 49s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | -1 :x: |  spotbugs  |   1m 47s | 
[/new-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5519/5/artifact/out/new-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html)
 |  
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core 
generated 4 new + 1 unchanged - 0 fixed = 5 total (was 1)  |
   | +1 :green_heart: |  shadedclient  |  25m 13s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  19m 35s |  |  hadoop-common in the patch 
passed.  |
   | -1 :x: |  unit  |   8m 41s | 
[/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5519/5/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt)
 |  hadoop-mapreduce-client-core in the patch passed.  |
   | +1 :green_heart: |  unit  |   2m 25s |  |  hadoop-azure in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 53s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 270

[GitHub] [hadoop] hadoop-yetus commented on pull request #5533: HDFS-16973. RBF: MountTableResolver cache size lookup should take read lock

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5533:
URL: https://github.com/apache/hadoop/pull/5533#issuecomment-1498042537

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 48s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  42m 11s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   0m 42s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  compile  |   0m 38s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  checkstyle  |   0m 30s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 42s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   0m 49s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   0m 57s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   1m 36s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  23m 49s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 34s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 39s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javac  |   0m 39s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 31s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  javac  |   0m 31s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 17s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   0m 34s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 33s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   0m 49s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   1m 29s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  24m 50s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  25m 36s |  |  hadoop-hdfs-rbf in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 35s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 131m  2s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5533/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5533 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 8d0be9a72ca1 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 9f2328050a64be17324a9947a90eab37c8fb80af |
   | Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
 /usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5533/2/testReport/ |
   | Max. process+thread count | 2128 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: 
hadoop-hdfs-project/hadoop-hdfs-rbf |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5533/2/console |
   | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about

[GitHub] [hadoop] umamaheswararao commented on pull request #5532: HDFS-16972. Delete a snapshot may deleteCurrentFile.

2023-04-05 Thread via GitHub



umamaheswararao commented on PR #5532:
URL: https://github.com/apache/hadoop/pull/5532#issuecomment-1498000753

   When I was debugging, here the call trace:
   cleanFile:128, FileWithSnapshotFeature 
(org.apache.hadoop.hdfs.server.namenode.snapshot)
   cleanSubtree:755, INodeFile (org.apache.hadoop.hdfs.server.namenode)
   destroyDstSubtree:409, DirectoryWithSnapshotFeature 
(org.apache.hadoop.hdfs.server.namenode.snapshot)
   destroyDstSubtree:405, DirectoryWithSnapshotFeature 
(org.apache.hadoop.hdfs.server.namenode.snapshot)
   destroyDstSubtree:405, DirectoryWithSnapshotFeature 
(org.apache.hadoop.hdfs.server.namenode.snapshot)
   destroyDstSubtree:435, DirectoryWithSnapshotFeature 
(org.apache.hadoop.hdfs.server.namenode.snapshot)
   destroyDstSubtree:435, DirectoryWithSnapshotFeature 
(org.apache.hadoop.hdfs.server.namenode.snapshot)
   destroyAndCollectBlocks:847, INodeReference$DstReference 
(org.apache.hadoop.hdfs.server.namenode)
   cleanDirectory:762, DirectoryWithSnapshotFeature 
(org.apache.hadoop.hdfs.server.namenode.snapshot)
   cleanSubtree:848, INodeDirectory (org.apache.hadoop.hdfs.server.namenode)
   cleanSubtree:314, INodeReference (org.apache.hadoop.hdfs.server.namenode)
   cleanSubtree:659, INodeReference$WithName 
(org.apache.hadoop.hdfs.server.namenode)
   cleanSubtreeRecursively:819, INodeDirectory 
(org.apache.hadoop.hdfs.server.namenode)
   cleanDirectory:734, DirectoryWithSnapshotFeature 
(org.apache.hadoop.hdfs.server.namenode.snapshot)
   cleanSubtree:848, INodeDirectory (org.apache.hadoop.hdfs.server.namenode)
   cleanSubtreeRecursively:819, INodeDirectory 
(org.apache.hadoop.hdfs.server.namenode)
   cleanDirectory:734, DirectoryWithSnapshotFeature 
(org.apache.hadoop.hdfs.server.namenode.snapshot)
   cleanSubtree:848, INodeDirectory (org.apache.hadoop.hdfs.server.namenode)
   cleanSubtreeRecursively:819, INodeDirectory 
(org.apache.hadoop.hdfs.server.namenode)
   cleanDirectory:734, DirectoryWithSnapshotFeature 
(org.apache.hadoop.hdfs.server.namenode.snapshot)
   cleanSubtree:848, INodeDirectory (org.apache.hadoop.hdfs.server.namenode)
   cleanSubtreeRecursively:819, INodeDirectory 
(org.apache.hadoop.hdfs.server.namenode)
   cleanSubtree:866, INodeDirectory (org.apache.hadoop.hdfs.server.namenode)
   cleanSubtreeRecursively:819, INodeDirectory 
(org.apache.hadoop.hdfs.server.namenode)
   cleanSubtree:866, INodeDirectory (org.apache.hadoop.hdfs.server.namenode)
   cleanSubtreeRecursively:819, INodeDirectory 
(org.apache.hadoop.hdfs.server.namenode)
   cleanSubtree:866, INodeDirectory (org.apache.hadoop.hdfs.server.namenode)
   cleanSubtreeRecursively:819, INodeDirectory 
(org.apache.hadoop.hdfs.server.namenode)
   cleanDirectory:734, DirectoryWithSnapshotFeature 
(org.apache.hadoop.hdfs.server.namenode.snapshot)
   cleanSubtree:848, INodeDirectory (org.apache.hadoop.hdfs.server.namenode)
   removeSnapshot:266, DirectorySnapshottableFeature 
(org.apache.hadoop.hdfs.server.namenode.snapshot)
   removeSnapshot:298, INodeDirectory (org.apache.hadoop.hdfs.server.namenode)
   deleteSnapshot:541, SnapshotManager 
(org.apache.hadoop.hdfs.server.namenode.snapshot)
   deleteSnapshot:280, FSDirSnapshotOp (org.apache.hadoop.hdfs.server.namenode)
   deleteSnapshot:264, FSDirSnapshotOp (org.apache.hadoop.hdfs.server.namenode)
   deleteSnapshot:7012, FSNamesystem (org.apache.hadoop.hdfs.server.namenode)
   testValidation1:80, TestFsImageValidation 
(org.apache.hadoop.hdfs.server.namenode)
   invoke0:-1, NativeMethodAccessorImpl (sun.reflect)
   invoke:62, NativeMethodAccessorImpl (sun.reflect)
   invoke:43, DelegatingMethodAccessorImpl (sun.reflect)
   invoke:498, Method (java.lang.reflect)
   runReflectiveCall:50, FrameworkMethod$1 (org.junit.runners.model)
   run:12, ReflectiveCallable (org.junit.internal.runners.model)
   invokeExplosively:47, FrameworkMethod (org.junit.runners.model)
   evaluate:17, InvokeMethod (org.junit.internal.runners.statements)
   runLeaf:325, ParentRunner (org.junit.runners)
   runChild:78, BlockJUnit4ClassRunner (org.junit.runners)
   runChild:57, BlockJUnit4ClassRunner (org.junit.runners)
   run:290, ParentRunner$3 (org.junit.runners)
   schedule:71, ParentRunner$1 (org.junit.runners)
   runChildren:288, ParentRunner (org.junit.runners)
   access$000:58, ParentRunner (org.junit.runners)
   evaluate:268, ParentRunner$2 (org.junit.runners)
   run:363, ParentRunner (org.junit.runners)
   run:137, JUnitCore (org.junit.runner)
   startRunnerWithArgs:69, JUnit4IdeaTestRunner (com.intellij.junit4)
   execute:38, IdeaTestRunner$Repeater$1 (com.intellij.rt.junit)
   repeat:11, TestsRepeater (com.intellij.rt.execution.junit)
   startRunnerWithArgs:35, IdeaTestRunner$Repeater (com.intellij.rt.junit)
   prepareStreamsAndStart:232, JUnitStarter (com.intellij.rt.junit)
   main:55, JUnitStarter (com.intellij.rt.junit)
   
   This is the place this patch is trying to fix the issue. My other question 
is, when call reaches here, the snapshot id is CURRENT_STATE_ID, which

[GitHub] [hadoop] melissayou opened a new pull request, #5536: [HDFS-16971]add read metrics for remote reads in FileSystem Statistics #5534

2023-04-05 Thread via GitHub



melissayou opened a new pull request, #5536:
URL: https://github.com/apache/hadoop/pull/5536

   
   
   ### Description of PR
   In Filesystem.java, currently it only collects bytes read not the 
corresponding timing of reads.
   In particular, we're interested in time spent on remote reads(not local 
reads). Adding timing info will help us understand it better and further 
analyze how locality of DN behaves.
   
   ### How was this patch tested?
   Ran hadoop-common and hadoop-hdsf related unit tests locally with and 
without the change.
   
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5533: HDFS-16973. RBF: MountTableResolver cache size lookup should take read lock

2023-04-05 Thread via GitHub



virajjasani commented on code in PR #5533:
URL: https://github.com/apache/hadoop/pull/5533#discussion_r1158834780


##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/resolver/TestMountTableResolver.java:
##
@@ -552,6 +552,10 @@ public void testMountTableScalability() throws IOException 
{
 
 assertEquals(10, mountTable.getMountPoints("/").size());
 assertEquals(10, mountTable.getMounts("/").size());
+for (int i = 0; i < 20; i++) {

Review Comment:
   Done, thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] goiri commented on pull request #5525: YARN-11377. [Federation] Support addToClusterNodeLabels、removeFromClusterNodeLabels、replaceLabelsOnNode API's for Federation.

2023-04-05 Thread via GitHub



goiri commented on PR #5525:
URL: https://github.com/apache/hadoop/pull/5525#issuecomment-1497880674

   There are a few checkstyle issues left.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] goiri commented on a diff in pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2023-04-05 Thread via GitHub



goiri commented on code in PR #4963:
URL: https://github.com/apache/hadoop/pull/4963#discussion_r1158826171


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateStoreService.java:
##
@@ -283,154 +290,251 @@ public void checkVersion() throws Exception {
   @Override
   public GetSubClusterPolicyConfigurationResponse getPolicyConfiguration(
   GetSubClusterPolicyConfigurationRequest request) throws YarnException {
-return stateStoreClient.getPolicyConfiguration(request);
+FederationClientMethod 
clientMethod =
+new FederationClientMethod<>("getPolicyConfiguration",
+GetSubClusterPolicyConfigurationRequest.class, request,
+GetSubClusterPolicyConfigurationResponse.class, stateStoreClient, 
clock);
+return clientMethod.invoke();
   }
 
   @Override
   public SetSubClusterPolicyConfigurationResponse setPolicyConfiguration(
   SetSubClusterPolicyConfigurationRequest request) throws YarnException {
-return stateStoreClient.setPolicyConfiguration(request);
+FederationClientMethod 
clientMethod =
+new FederationClientMethod<>("setPolicyConfiguration",
+SetSubClusterPolicyConfigurationRequest.class, request,
+SetSubClusterPolicyConfigurationResponse.class, stateStoreClient, 
clock);
+return clientMethod.invoke();
   }
 
   @Override
   public GetSubClusterPoliciesConfigurationsResponse getPoliciesConfigurations(
   GetSubClusterPoliciesConfigurationsRequest request) throws YarnException 
{
-return stateStoreClient.getPoliciesConfigurations(request);
+FederationClientMethod 
clientMethod =
+new FederationClientMethod<>("getPoliciesConfigurations",
+GetSubClusterPoliciesConfigurationsRequest.class, request,
+GetSubClusterPoliciesConfigurationsResponse.class, stateStoreClient, 
clock);
+return clientMethod.invoke();
   }
 
   @Override
-  public SubClusterRegisterResponse registerSubCluster(
-  SubClusterRegisterRequest registerSubClusterRequest)
+  public SubClusterRegisterResponse 
registerSubCluster(SubClusterRegisterRequest request)
   throws YarnException {
-return stateStoreClient.registerSubCluster(registerSubClusterRequest);
+FederationClientMethod clientMethod =
+new FederationClientMethod<>("registerSubCluster",
+SubClusterRegisterRequest.class, request,
+SubClusterRegisterResponse.class, stateStoreClient, clock);
+return clientMethod.invoke();
   }
 
   @Override
-  public SubClusterDeregisterResponse deregisterSubCluster(
-  SubClusterDeregisterRequest subClusterDeregisterRequest)
+  public SubClusterDeregisterResponse 
deregisterSubCluster(SubClusterDeregisterRequest request)
   throws YarnException {
-return stateStoreClient.deregisterSubCluster(subClusterDeregisterRequest);
+FederationClientMethod clientMethod =
+new FederationClientMethod<>("deregisterSubCluster",
+SubClusterDeregisterRequest.class, request,
+SubClusterDeregisterResponse.class, stateStoreClient, clock);
+return clientMethod.invoke();
   }
 
   @Override
-  public SubClusterHeartbeatResponse subClusterHeartbeat(
-  SubClusterHeartbeatRequest subClusterHeartbeatRequest)
+  public SubClusterHeartbeatResponse 
subClusterHeartbeat(SubClusterHeartbeatRequest request)
   throws YarnException {
-return stateStoreClient.subClusterHeartbeat(subClusterHeartbeatRequest);
+FederationClientMethod clientMethod =
+new FederationClientMethod<>("subClusterHeartbeat",
+SubClusterHeartbeatRequest.class, request,
+SubClusterHeartbeatResponse.class, stateStoreClient, clock);
+return clientMethod.invoke();
   }
 
   @Override
-  public GetSubClusterInfoResponse getSubCluster(
-  GetSubClusterInfoRequest subClusterRequest) throws YarnException {
-return stateStoreClient.getSubCluster(subClusterRequest);
+  public GetSubClusterInfoResponse getSubCluster(GetSubClusterInfoRequest 
request)
+  throws YarnException {
+FederationClientMethod clientMethod =
+new FederationClientMethod<>("getSubCluster",
+GetSubClusterInfoRequest.class, request,
+GetSubClusterInfoResponse.class, stateStoreClient, clock);
+return clientMethod.invoke();
   }
 
   @Override
-  public GetSubClustersInfoResponse getSubClusters(
-  GetSubClustersInfoRequest subClustersRequest) throws YarnException {
-return stateStoreClient.getSubClusters(subClustersRequest);
+  public GetSubClustersInfoResponse getSubClusters(GetSubClustersInfoRequest 
request)
+  throws YarnException {
+FederationClientMethod clientMethod =
+new FederationClientMethod<>("getSubClusters",
+GetSubClustersInfoRequest.class, request,
+GetSubClustersInfoResponse.class, stateStoreClient, clock);
+return clientMethod.invoke();
   }
 
   @Override
   public

[GitHub] [hadoop] goiri merged pull request #5518: YARN-11436. [Federation] MemoryFederationStateStore Support Version.

2023-04-05 Thread via GitHub



goiri merged PR #5518:
URL: https://github.com/apache/hadoop/pull/5518


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] goiri commented on pull request #5363: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

2023-04-05 Thread via GitHub



goiri commented on PR #5363:
URL: https://github.com/apache/hadoop/pull/5363#issuecomment-1497869230

   > @goiri Thank you very much for your help in reviewing the code! The javac 
compilation error is because we have changed the proto file. This part of the 
warning seems unavoidable.
   > 
   > DeregisterSubClustersProto
   > 
   > ```
   > message DeregisterSubClustersProto {
   >   optional string subClusterId = 1;
   >   optional string deregisterState = 2;
   >   optional string lastHeartBeatTime = 3;
   >   optional string information = 4;
   >   optional string subClusterState = 5;
   > }
   > ```
   > 
   > ```
   > 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/target/generated-sources/java/org/apache/hadoop/yarn/proto/YarnServerResourceManagerServiceProtos.java:18867:102:[deprecation]
 PARSER in DeregisterSubClustersProto has been deprecated
   > ```
   
   No way we can get a clean build then?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] goiri commented on a diff in pull request #5533: HDFS-16973. RBF: MountTableResolver cache size lookup should take read lock

2023-04-05 Thread via GitHub



goiri commented on code in PR #5533:
URL: https://github.com/apache/hadoop/pull/5533#discussion_r1158812807


##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/resolver/TestMountTableResolver.java:
##
@@ -552,6 +552,10 @@ public void testMountTableScalability() throws IOException 
{
 
 assertEquals(10, mountTable.getMountPoints("/").size());
 assertEquals(10, mountTable.getMounts("/").size());
+for (int i = 0; i < 20; i++) {

Review Comment:
   Add a comment saying this is for testing concurrency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] hadoop-yetus commented on pull request #5515: YARN-11037. Add configurable logic to split resource request to the least loaded SC.

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5515:
URL: https://github.com/apache/hadoop/pull/5515#issuecomment-1497826334

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 37s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  1s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 3 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  16m 25s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  25m 40s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   9m 46s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  compile  |   8m 32s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  checkstyle  |   1m 49s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   4m  0s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 42s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   3m 22s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   7m 17s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  21m 34s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 28s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 29s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   9m  7s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javac  |   9m  7s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   8m 23s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  javac  |   8m 23s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 37s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5515/6/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 14 new + 164 unchanged 
- 0 fixed = 178 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   3m 39s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m 12s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   3m  7s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   7m 33s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  21m 32s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  |   1m 12s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5515/6/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt)
 |  hadoop-yarn-api in the patch passed.  |
   | +1 :green_heart: |  unit  |   5m 39s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   3m 34s |  |  hadoop-yarn-server-common in 
the patch passed.  |
   | +1 :green_heart: |  unit  |  24m  8s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 55s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 202m 20s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.yarn.conf.TestYarnConfigurationFields |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5515/6/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5515 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint |
   | uname | Linux e6cef840f597 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5127: YARN-11239. Optimize FederationClientInterceptor audit log.

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5127:
URL: https://github.com/apache/hadoop/pull/5127#issuecomment-1497683693

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 54s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  39m 33s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   0m 35s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  compile  |   0m 32s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  checkstyle  |   0m 32s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 37s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   0m 39s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   0m 28s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   1m  6s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  20m 18s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 26s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 26s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javac  |   0m 26s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 24s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  javac  |   0m 24s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 17s |  |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router: 
The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)  |
   | +1 :green_heart: |  mvnsite  |   0m 27s |  |  the patch passed  |
   | -1 :x: |  javadoc  |   0m 22s | 
[/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5127/11/artifact/out/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt)
 |  
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 1 new + 1 
unchanged - 0 fixed = 2 total (was 1)  |
   | -1 :x: |  javadoc  |   0m 20s | 
[/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5127/11/artifact/out/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt)
 |  
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
 with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 generated 1 new 
+ 1 unchanged - 0 fixed = 2 total (was 1)  |
   | +1 :green_heart: |  spotbugs  |   0m 55s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  20m  0s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 32s |  |  hadoop-yarn-server-router in 
the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 37s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  91m 47s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5127/11/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5127 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedc

[jira] [Commented] (HADOOP-18690) Fix for Javac Error of Unchecked Cast

2023-04-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708951#comment-17708951
 ] 

ASF GitHub Bot commented on HADOOP-18690:
-

hadoop-yetus commented on PR #5535:
URL: https://github.com/apache/hadoop/pull/5535#issuecomment-1497669996

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 42s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ branch-3.3.4 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  37m 52s |  |  branch-3.3.4 passed  |
   | +1 :green_heart: |  compile  |   0m 37s |  |  branch-3.3.4 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 30s |  |  branch-3.3.4 passed  |
   | +1 :green_heart: |  mvnsite  |   0m 40s |  |  branch-3.3.4 passed  |
   | +1 :green_heart: |  javadoc  |   0m 35s |  |  branch-3.3.4 passed  |
   | +1 :green_heart: |  spotbugs  |   1m 17s |  |  branch-3.3.4 passed  |
   | +1 :green_heart: |  shadedclient  |  24m 49s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 33s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 28s |  |  the patch passed  |
   | -1 :x: |  javac  |   0m 28s | 
[/results-compile-javac-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5535/1/artifact/out/results-compile-javac-hadoop-tools_hadoop-azure.txt)
 |  hadoop-tools_hadoop-azure generated 1 new + 18 unchanged - 1 fixed = 19 
total (was 19)  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 18s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   0m 30s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 22s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   1m  8s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  23m 47s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 56s |  |  hadoop-azure in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 38s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  98m 17s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5535/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5535 |
   | JIRA Issue | HADOOP-18690 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell |
   | uname | Linux b642ee76a61f 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | branch-3.3.4 / 1ddc91166340f95fb670ec312a019f24475ac850 |
   | Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~18.04.1-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5535/1/testReport/ |
   | Max. process+thread count | 540 (vs. ulimit of 5500) |
   | modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5535/1/console |
   | versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Fix for Javac Error of Unchecked Cast
> -
>
> Key: HADOOP-18690
> URL: https://issues.apache.org/jira/browse/HADOOP-18690
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Components: fs/azure
>Reporter: Anuj Modi
>Assignee: Anuj Modi
>Priority: Blocker
>  Labels: pull-request-available
>
> This task is to fix javac unchecked cast error on yetus build.
> Yetus checks on PR are failing at javac step with the error:
> *"hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/security/TokenUtils.java

[GitHub] [hadoop] hadoop-yetus commented on pull request #5535: HADOOP-18690: Fix for Javac Error of Unchecked Cast

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5535:
URL: https://github.com/apache/hadoop/pull/5535#issuecomment-1497669996

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 42s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ branch-3.3.4 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  37m 52s |  |  branch-3.3.4 passed  |
   | +1 :green_heart: |  compile  |   0m 37s |  |  branch-3.3.4 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 30s |  |  branch-3.3.4 passed  |
   | +1 :green_heart: |  mvnsite  |   0m 40s |  |  branch-3.3.4 passed  |
   | +1 :green_heart: |  javadoc  |   0m 35s |  |  branch-3.3.4 passed  |
   | +1 :green_heart: |  spotbugs  |   1m 17s |  |  branch-3.3.4 passed  |
   | +1 :green_heart: |  shadedclient  |  24m 49s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 33s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 28s |  |  the patch passed  |
   | -1 :x: |  javac  |   0m 28s | 
[/results-compile-javac-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5535/1/artifact/out/results-compile-javac-hadoop-tools_hadoop-azure.txt)
 |  hadoop-tools_hadoop-azure generated 1 new + 18 unchanged - 1 fixed = 19 
total (was 19)  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 18s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   0m 30s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 22s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   1m  8s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  23m 47s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 56s |  |  hadoop-azure in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 38s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  98m 17s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5535/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5535 |
   | JIRA Issue | HADOOP-18690 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell |
   | uname | Linux b642ee76a61f 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | branch-3.3.4 / 1ddc91166340f95fb670ec312a019f24475ac850 |
   | Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~18.04.1-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5535/1/testReport/ |
   | Max. process+thread count | 540 (vs. ulimit of 5500) |
   | modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5535/1/console |
   | versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Resolved] (HADOOP-18684) S3A filesystem to support binding to other URI schemes

2023-04-05 Thread Steve Loughran (Jira)



 [ 
https://issues.apache.org/jira/browse/HADOOP-18684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran resolved HADOOP-18684.
-
Fix Version/s: 3.4.0
   3.3.9
 Assignee: Harshit Gupta
   Resolution: Fixed

> S3A filesystem to support binding to other URI schemes
> --
>
> Key: HADOOP-18684
> URL: https://issues.apache.org/jira/browse/HADOOP-18684
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 3.3.5
>Reporter: Harshit Gupta
>Assignee: Harshit Gupta
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.4.0, 3.3.9
>
>
> Allow s3a filesystem to be bindable to other filesystem schemas, especially 
> s3://
> * FileContext API has hard coded use of "s3a"
> * S3AFileSystem.getScheme() needs to pick up the scheme of the URI passed to 
> initialize()
> * plus tests



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-18684) S3A filesystem to support binding to other URI schemes

2023-04-05 Thread Steve Loughran (Jira)



 [ 
https://issues.apache.org/jira/browse/HADOOP-18684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HADOOP-18684:

Summary: S3A filesystem to support binding to other URI schemes  (was: S3A 
filesystem to support binding to to other URI schemes)

> S3A filesystem to support binding to other URI schemes
> --
>
> Key: HADOOP-18684
> URL: https://issues.apache.org/jira/browse/HADOOP-18684
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 3.3.5
>Reporter: Harshit Gupta
>Priority: Major
>  Labels: pull-request-available
>
> Allow s3a filesystem to be bindable to other filesystem schemas, especially 
> s3://
> * FileContext API has hard coded use of "s3a"
> * S3AFileSystem.getScheme() needs to pick up the scheme of the URI passed to 
> initialize()
> * plus tests



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18684) S3A filesystem to support binding to other URI schemes

2023-04-05 Thread Steve Loughran (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708924#comment-17708924
 ] 

Steve Loughran commented on HADOOP-18684:
-

aah, i committed this with a typo in the title "to to"

I don't really think its enough to do revert and reapply though -what do others 
say?

> S3A filesystem to support binding to other URI schemes
> --
>
> Key: HADOOP-18684
> URL: https://issues.apache.org/jira/browse/HADOOP-18684
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 3.3.5
>Reporter: Harshit Gupta
>Priority: Major
>  Labels: pull-request-available
>
> Allow s3a filesystem to be bindable to other filesystem schemas, especially 
> s3://
> * FileContext API has hard coded use of "s3a"
> * S3AFileSystem.getScheme() needs to pick up the scheme of the URI passed to 
> initialize()
> * plus tests



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-18012) ABFS: Enable config controlled ETag check for Rename idempotency

2023-04-05 Thread Steve Loughran (Jira)



 [ 
https://issues.apache.org/jira/browse/HADOOP-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HADOOP-18012:

Fix Version/s: 3.3.9

> ABFS: Enable config controlled ETag check for Rename idempotency
> 
>
> Key: HADOOP-18012
> URL: https://issues.apache.org/jira/browse/HADOOP-18012
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Components: fs/azure
>Affects Versions: 3.3.2
>Reporter: Sneha Vijayarajan
>Assignee: Sree Bhattacharyya
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.3.9
>
>
> To support recovery of comms failure during rename, the abfs client fetches 
> the etag of the source file, and when recovering from a failure uses this tag 
> to determine whether the rename succeeded *before the failure happened*
> # This works for files, but not directories
> # this adds the overhead of a HEAD request before each rename.
> # the option can be disabled by setting "fs.azure.enable.rename.resilience" 
> to false
> Note: the manifest committer collects etags during task commitklkl and 
> supplies them to the abfs client for the rename, which avoids the need for a 
> HEAD call. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Resolved] (HADOOP-18647) x-ms-client-request-id to have some way that identifies retry of an API.

2023-04-05 Thread Steve Loughran (Jira)



 [ 
https://issues.apache.org/jira/browse/HADOOP-18647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran resolved HADOOP-18647.
-
Resolution: Fixed

> x-ms-client-request-id to have some way that identifies retry of an API.
> 
>
> Key: HADOOP-18647
> URL: https://issues.apache.org/jira/browse/HADOOP-18647
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Components: fs/azure
>Affects Versions: 3.3.5
>Reporter: Pranav Saxena
>Assignee: Pranav Saxena
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.4.0, 3.3.9
>
>
> In case primaryRequestId in x-ms-client-request-id is empty-string, the 
> retry's primaryRequestId has to contain last part of clientRequestId UUID.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] hadoop-yetus commented on pull request #5517: HDFS-16952. Support getLinkTarget API in WebHDFS

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5517:
URL: https://github.com/apache/hadoop/pull/5517#issuecomment-1497531305

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 37s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  markdownlint  |   0m  1s |  |  markdownlint was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  16m 47s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  26m 18s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m  2s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  compile  |   5m 44s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  checkstyle  |   1m 19s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 17s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m 30s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   3m 16s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   7m 11s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  20m 36s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  20m 56s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 28s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 41s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 53s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javac  |   5m 53s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 39s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  javac  |   5m 39s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   1m  5s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   2m 48s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m  1s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   2m 53s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   7m 10s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  20m 30s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 27s |  |  hadoop-hdfs-client in the patch 
passed.  |
   | -1 :x: |  unit  | 206m 50s | 
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/13/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
 |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  unit  |  20m 47s |  |  hadoop-hdfs-rbf in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 50s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 378m 32s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hdfs.server.datanode.TestDirectoryScanner |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5517/13/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5517 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint 
|
   | uname | Linux eebdf0fa9bc8 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 28f64dcc66de58b69be73e38da71cf696e1a9d86 |
   | Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+

[jira] [Updated] (HADOOP-18690) Fix for Javac Error of Unchecked Cast

2023-04-05 Thread Anuj Modi (Jira)



 [ 
https://issues.apache.org/jira/browse/HADOOP-18690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuj Modi updated HADOOP-18690:
---
Fix Version/s: (was: 3.3.0)
   (was: 3.3.5)

> Fix for Javac Error of Unchecked Cast
> -
>
> Key: HADOOP-18690
> URL: https://issues.apache.org/jira/browse/HADOOP-18690
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Components: fs/azure
>Reporter: Anuj Modi
>Assignee: Anuj Modi
>Priority: Blocker
>  Labels: pull-request-available
>
> This task is to fix javac unchecked cast error on yetus build.
> Yetus checks on PR are failing at javac step with the error:
> *"hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/security/TokenUtils.java:43:53:[unchecked]
>  unchecked cast"*
> This is blocking other PRs in the branches 3.3.3, 3.3.4, 3.3.2
> This task will fix this error/warning and unblock other PRs.
> Blocked PRs:
> 1. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.2 by anujmodi2021 · Pull Request #5529 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5529]
> 2. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.3 by anujmodi2021 · Pull Request #5530 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5530]
> 3. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.4 by anujmodi2021 · Pull Request #5531 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5531]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-18690) Fix for Javac Error of Unchecked Cast

2023-04-05 Thread Anuj Modi (Jira)



 [ 
https://issues.apache.org/jira/browse/HADOOP-18690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuj Modi updated HADOOP-18690:
---
Target Version/s: 3.3.4  (was: 3.3.2, 3.3.3, 3.3.4)

> Fix for Javac Error of Unchecked Cast
> -
>
> Key: HADOOP-18690
> URL: https://issues.apache.org/jira/browse/HADOOP-18690
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Components: fs/azure
>Reporter: Anuj Modi
>Assignee: Anuj Modi
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 3.3.0, 3.3.5
>
>
> This task is to fix javac unchecked cast error on yetus build.
> Yetus checks on PR are failing at javac step with the error:
> *"hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/security/TokenUtils.java:43:53:[unchecked]
>  unchecked cast"*
> This is blocking other PRs in the branches 3.3.3, 3.3.4, 3.3.2
> This task will fix this error/warning and unblock other PRs.
> Blocked PRs:
> 1. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.2 by anujmodi2021 · Pull Request #5529 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5529]
> 2. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.3 by anujmodi2021 · Pull Request #5530 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5530]
> 3. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.4 by anujmodi2021 · Pull Request #5531 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5531]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18690) Fix for Javac Error of Unchecked Cast

2023-04-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708913#comment-17708913
 ] 

ASF GitHub Bot commented on HADOOP-18690:
-

anujmodi2021 commented on code in PR #5535:
URL: https://github.com/apache/hadoop/pull/5535#discussion_r1158539279


##
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/security/TokenUtils.java:
##
@@ -40,10 +39,10 @@ private TokenUtils() {
   public static Token toDelegationToken(
   final Map inputMap) throws IOException {
 final Map m = (Map) inputMap.get(Token.class.getSimpleName());
-return (Token) toToken(m);
+return toToken(m);
   }
 
-  public static Token toToken(final Map m)
+  public static Token toToken(final Map m)

Review Comment:
   The only possible return type from this function (apart from null) is 
`"Token".` Therefore it seems safe to 
deterministically define the return type instead of generic return type here. 
This will solve the Unchecked Cast Error.





> Fix for Javac Error of Unchecked Cast
> -
>
> Key: HADOOP-18690
> URL: https://issues.apache.org/jira/browse/HADOOP-18690
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Components: fs/azure
>Reporter: Anuj Modi
>Assignee: Anuj Modi
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 3.3.0, 3.3.5
>
>
> This task is to fix javac unchecked cast error on yetus build.
> Yetus checks on PR are failing at javac step with the error:
> *"hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/security/TokenUtils.java:43:53:[unchecked]
>  unchecked cast"*
> This is blocking other PRs in the branches 3.3.3, 3.3.4, 3.3.2
> This task will fix this error/warning and unblock other PRs.
> Blocked PRs:
> 1. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.2 by anujmodi2021 · Pull Request #5529 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5529]
> 2. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.3 by anujmodi2021 · Pull Request #5530 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5530]
> 3. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.4 by anujmodi2021 · Pull Request #5531 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5531]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] anujmodi2021 commented on a diff in pull request #5535: HADOOP-18690: Fix for Javac Error of Unchecked Cast

2023-04-05 Thread via GitHub



anujmodi2021 commented on code in PR #5535:
URL: https://github.com/apache/hadoop/pull/5535#discussion_r1158539279


##
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/security/TokenUtils.java:
##
@@ -40,10 +39,10 @@ private TokenUtils() {
   public static Token toDelegationToken(
   final Map inputMap) throws IOException {
 final Map m = (Map) inputMap.get(Token.class.getSimpleName());
-return (Token) toToken(m);
+return toToken(m);
   }
 
-  public static Token toToken(final Map m)
+  public static Token toToken(final Map m)

Review Comment:
   The only possible return type from this function (apart from null) is 
`"Token".` Therefore it seems safe to 
deterministically define the return type instead of generic return type here. 
This will solve the Unchecked Cast Error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18690) Fix for Javac Error of Unchecked Cast

2023-04-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708912#comment-17708912
 ] 

ASF GitHub Bot commented on HADOOP-18690:
-

anujmodi2021 commented on code in PR #5535:
URL: https://github.com/apache/hadoop/pull/5535#discussion_r1158539279


##
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/security/TokenUtils.java:
##
@@ -40,10 +39,10 @@ private TokenUtils() {
   public static Token toDelegationToken(
   final Map inputMap) throws IOException {
 final Map m = (Map) inputMap.get(Token.class.getSimpleName());
-return (Token) toToken(m);
+return toToken(m);
   }
 
-  public static Token toToken(final Map m)
+  public static Token toToken(final Map m)

Review Comment:
   The only possible return type from this function (apart from null) is 
Token. Therefore it seems safe to deterministically 
define the return type instead of generic return type here. This will solve the 
Unchecked Cast Error.





> Fix for Javac Error of Unchecked Cast
> -
>
> Key: HADOOP-18690
> URL: https://issues.apache.org/jira/browse/HADOOP-18690
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Components: fs/azure
>Reporter: Anuj Modi
>Assignee: Anuj Modi
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 3.3.0, 3.3.5
>
>
> This task is to fix javac unchecked cast error on yetus build.
> Yetus checks on PR are failing at javac step with the error:
> *"hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/security/TokenUtils.java:43:53:[unchecked]
>  unchecked cast"*
> This is blocking other PRs in the branches 3.3.3, 3.3.4, 3.3.2
> This task will fix this error/warning and unblock other PRs.
> Blocked PRs:
> 1. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.2 by anujmodi2021 · Pull Request #5529 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5529]
> 2. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.3 by anujmodi2021 · Pull Request #5530 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5530]
> 3. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.4 by anujmodi2021 · Pull Request #5531 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5531]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] anujmodi2021 commented on a diff in pull request #5535: HADOOP-18690: Fix for Javac Error of Unchecked Cast

2023-04-05 Thread via GitHub



anujmodi2021 commented on code in PR #5535:
URL: https://github.com/apache/hadoop/pull/5535#discussion_r1158539279


##
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/security/TokenUtils.java:
##
@@ -40,10 +39,10 @@ private TokenUtils() {
   public static Token toDelegationToken(
   final Map inputMap) throws IOException {
 final Map m = (Map) inputMap.get(Token.class.getSimpleName());
-return (Token) toToken(m);
+return toToken(m);
   }
 
-  public static Token toToken(final Map m)
+  public static Token toToken(final Map m)

Review Comment:
   The only possible return type from this function (apart from null) is 
Token. Therefore it seems safe to deterministically 
define the return type instead of generic return type here. This will solve the 
Unchecked Cast Error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] slfan1989 commented on pull request #5363: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

2023-04-05 Thread via GitHub



slfan1989 commented on PR #5363:
URL: https://github.com/apache/hadoop/pull/5363#issuecomment-1497506725

   @goiri Thank you very much for your help in reviewing the code! The javac 
compilation error is because we have changed the proto file. It seems that 
there is no way to avoid this part of the warning. 
   
   DeregisterSubClustersProto
   
   ```
   message DeregisterSubClustersProto {
 optional string subClusterId = 1;
 optional string deregisterState = 2;
 optional string lastHeartBeatTime = 3;
 optional string information = 4;
 optional string subClusterState = 5;
   }
   ```
   
   ```
   
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/target/generated-sources/java/org/apache/hadoop/yarn/proto/YarnServerResourceManagerServiceProtos.java:18867:102:[deprecation]
 PARSER in DeregisterSubClustersProto has been deprecated
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18690) Fix for Javac Error of Unchecked Cast

2023-04-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708908#comment-17708908
 ] 

ASF GitHub Bot commented on HADOOP-18690:
-

anujmodi2021 opened a new pull request, #5535:
URL: https://github.com/apache/hadoop/pull/5535

   ### Description of PR
   This PR fixes the Unchecked Cast Error/Warning thrown at javac step of yetus 
checks on PR.
   Jira ticket: https://issues.apache.org/jira/browse/HADOOP-18690 
   
   Fix is to deterministically type cast the return type of the function.
   Since there is only one return type possible for the function, there is no 
need to type cast it.




> Fix for Javac Error of Unchecked Cast
> -
>
> Key: HADOOP-18690
> URL: https://issues.apache.org/jira/browse/HADOOP-18690
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Components: fs/azure
>Reporter: Anuj Modi
>Assignee: Anuj Modi
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 3.3.0, 3.3.5
>
>
> This task is to fix javac unchecked cast error on yetus build.
> Yetus checks on PR are failing at javac step with the error:
> *"hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/security/TokenUtils.java:43:53:[unchecked]
>  unchecked cast"*
> This is blocking other PRs in the branches 3.3.3, 3.3.4, 3.3.2
> This task will fix this error/warning and unblock other PRs.
> Blocked PRs:
> 1. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.2 by anujmodi2021 · Pull Request #5529 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5529]
> 2. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.3 by anujmodi2021 · Pull Request #5530 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5530]
> 3. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.4 by anujmodi2021 · Pull Request #5531 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5531]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] anujmodi2021 opened a new pull request, #5535: HADOOP-18690: Fix for Javac Error of Unchecked Cast

2023-04-05 Thread via GitHub



anujmodi2021 opened a new pull request, #5535:
URL: https://github.com/apache/hadoop/pull/5535

   ### Description of PR
   This PR fixes the Unchecked Cast Error/Warning thrown at javac step of yetus 
checks on PR.
   Jira ticket: https://issues.apache.org/jira/browse/HADOOP-18690 
   
   Fix is to deterministically type cast the return type of the function.
   Since there is only one return type possible for the function, there is no 
need to type cast it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-18690) Fix for Javac Error of Unchecked Cast

2023-04-05 Thread Anuj Modi (Jira)



 [ 
https://issues.apache.org/jira/browse/HADOOP-18690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuj Modi updated HADOOP-18690:
---
Description: 
This task is to fix javac unchecked cast error on yetus build.

Yetus checks on PR are failing at javac step with the error:
*"hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/security/TokenUtils.java:43:53:[unchecked]
 unchecked cast"*

This is blocking other PRs in the branches 3.3.3, 3.3.4, 3.3.2
This task will fix this error/warning and unblock other PRs.

Blocked PRs:
1. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
abfs stream closed in 3.3.2 by anujmodi2021 · Pull Request #5529 · 
apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5529]
2. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
abfs stream closed in 3.3.3 by anujmodi2021 · Pull Request #5530 · 
apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5530]
3. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
abfs stream closed in 3.3.4 by anujmodi2021 · Pull Request #5531 · 
apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5531]

  was:
This task is to cherry pick the fixes to all the branches where the data 
corruption fix has gone in.

This is similar to [HADOOP-18546] disable purging list of in progress reads in 
abfs stream closed - ASF JIRA (apache.org) for other release brnaches

More details on the task and issue: [HADOOP-18521] ABFS ReadBufferManager 
buffer sharing across concurrent HTTP requests - ASF JIRA (apache.org)


> Fix for Javac Error of Unchecked Cast
> -
>
> Key: HADOOP-18690
> URL: https://issues.apache.org/jira/browse/HADOOP-18690
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Components: fs/azure
>Reporter: Anuj Modi
>Assignee: Anuj Modi
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 3.3.0, 3.3.5
>
>
> This task is to fix javac unchecked cast error on yetus build.
> Yetus checks on PR are failing at javac step with the error:
> *"hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/security/TokenUtils.java:43:53:[unchecked]
>  unchecked cast"*
> This is blocking other PRs in the branches 3.3.3, 3.3.4, 3.3.2
> This task will fix this error/warning and unblock other PRs.
> Blocked PRs:
> 1. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.2 by anujmodi2021 · Pull Request #5529 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5529]
> 2. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.3 by anujmodi2021 · Pull Request #5530 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5530]
> 3. [Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in 
> abfs stream closed in 3.3.4 by anujmodi2021 · Pull Request #5531 · 
> apache/hadoop (github.com)|https://github.com/apache/hadoop/pull/5531]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] slfan1989 commented on pull request #5515: YARN-11037. Add configurable logic to split resource request to the least loaded SC.

2023-04-05 Thread via GitHub



slfan1989 commented on PR #5515:
URL: https://github.com/apache/hadoop/pull/5515#issuecomment-1497495223

   @goiri Can you help review this pr? Thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] slfan1989 commented on pull request #5525: YARN-11377. [Federation] Support addToClusterNodeLabels、removeFromClusterNodeLabels、replaceLabelsOnNode API's for Federation.

2023-04-05 Thread via GitHub



slfan1989 commented on PR #5525:
URL: https://github.com/apache/hadoop/pull/5525#issuecomment-1497494779

   @goiri Can you help review this pr? Thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-18690) Fix for Javac Error of Unchecked Cast

2023-04-05 Thread Anuj Modi (Jira)



 [ 
https://issues.apache.org/jira/browse/HADOOP-18690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anuj Modi updated HADOOP-18690:
---
Summary: Fix for Javac Error of Unchecked Cast  (was: Cherry-Picking 
Commits to Disable purging list of in progress reads in abfs inputstream close)

> Fix for Javac Error of Unchecked Cast
> -
>
> Key: HADOOP-18690
> URL: https://issues.apache.org/jira/browse/HADOOP-18690
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Components: fs/azure
>Reporter: Anuj Modi
>Assignee: Anuj Modi
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 3.3.0, 3.3.5
>
>
> This task is to cherry pick the fixes to all the branches where the data 
> corruption fix has gone in.
> This is similar to [HADOOP-18546] disable purging list of in progress reads 
> in abfs stream closed - ASF JIRA (apache.org) for other release brnaches
> More details on the task and issue: [HADOOP-18521] ABFS ReadBufferManager 
> buffer sharing across concurrent HTTP requests - ASF JIRA (apache.org)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] slfan1989 commented on pull request #5518: YARN-11436. [Federation] MemoryFederationStateStore Support Version.

2023-04-05 Thread via GitHub



slfan1989 commented on PR #5518:
URL: https://github.com/apache/hadoop/pull/5518#issuecomment-1497479093

   @goiri Can you help to merge this pr into the trunk branch? Thank you very 
much! I will continue to follow up YARN-11438. [Federation] 
ZookeeperFederationStateStore Support Version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] slfan1989 commented on pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2023-04-05 Thread via GitHub



slfan1989 commented on PR #4963:
URL: https://github.com/apache/hadoop/pull/4963#issuecomment-1497475124

   @goiri Can you help review this PR again? Thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18684) S3A filesystem to support binding to to other URI schemes

2023-04-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708830#comment-17708830
 ] 

ASF GitHub Bot commented on HADOOP-18684:
-

steveloughran merged PR #5521:
URL: https://github.com/apache/hadoop/pull/5521




> S3A filesystem to support binding to to other URI schemes
> -
>
> Key: HADOOP-18684
> URL: https://issues.apache.org/jira/browse/HADOOP-18684
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 3.3.5
>Reporter: Harshit Gupta
>Priority: Major
>  Labels: pull-request-available
>
> Allow s3a filesystem to be bindable to other filesystem schemas, especially 
> s3://
> * FileContext API has hard coded use of "s3a"
> * S3AFileSystem.getScheme() needs to pick up the scheme of the URI passed to 
> initialize()
> * plus tests



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] steveloughran merged pull request #5521: HADOOP-18684. S3A filesystem to support binding to to other URI schemes

2023-04-05 Thread via GitHub



steveloughran merged PR #5521:
URL: https://github.com/apache/hadoop/pull/5521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-18684) S3A filesystem to support binding to to other URI schemes

2023-04-05 Thread Steve Loughran (Jira)



 [ 
https://issues.apache.org/jira/browse/HADOOP-18684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HADOOP-18684:

Description: 
Allow s3a filesystem to be bindable to other filesystem schemas, especially 
s3://

* FileContext API has hard coded use of "s3a"
* S3AFileSystem.getScheme() needs to pick up the scheme of the URI passed to 
initialize()
* plus tests

  was:Certain codepaths use the FileContext API's to perform FS based 
operations such as yarn log aggregations. While trying to reuse the S3A 
connector for GCS based workloads the yarn log aggregation was not happening. 
Upon further investigation it was observed that FileContext API have hardcoded 
URI scheme checks that need to disabled/updated to make S3A compatible with non 
AWS stores.


> S3A filesystem to support binding to to other URI schemes
> -
>
> Key: HADOOP-18684
> URL: https://issues.apache.org/jira/browse/HADOOP-18684
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 3.3.5
>Reporter: Harshit Gupta
>Priority: Major
>  Labels: pull-request-available
>
> Allow s3a filesystem to be bindable to other filesystem schemas, especially 
> s3://
> * FileContext API has hard coded use of "s3a"
> * S3AFileSystem.getScheme() needs to pick up the scheme of the URI passed to 
> initialize()
> * plus tests



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-18684) S3A filesystem to support binding to to other URI schemes

2023-04-05 Thread Steve Loughran (Jira)



 [ 
https://issues.apache.org/jira/browse/HADOOP-18684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HADOOP-18684:

Summary: S3A filesystem to support binding to to other URI schemes  (was: 
Fix S3A filesystem such that the scheme matches the URI scheme)

> S3A filesystem to support binding to to other URI schemes
> -
>
> Key: HADOOP-18684
> URL: https://issues.apache.org/jira/browse/HADOOP-18684
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 3.3.5
>Reporter: Harshit Gupta
>Priority: Major
>  Labels: pull-request-available
>
> Certain codepaths use the FileContext API's to perform FS based operations 
> such as yarn log aggregations. While trying to reuse the S3A connector for 
> GCS based workloads the yarn log aggregation was not happening. Upon further 
> investigation it was observed that FileContext API have hardcoded URI scheme 
> checks that need to disabled/updated to make S3A compatible with non AWS 
> stores.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] hadoop-yetus commented on pull request #5515: YARN-11037. Add configurable logic to split resource request to the least loaded SC.

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5515:
URL: https://github.com/apache/hadoop/pull/5515#issuecomment-1497343823

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 47s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 3 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  15m 27s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  29m 11s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  10m 53s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  compile  |   8m 48s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  checkstyle  |   1m 49s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 33s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m 17s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   2m  1s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 17s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  24m 16s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 46s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   9m 50s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javac  |   9m 50s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   8m 48s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  javac  |   8m 48s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 40s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5515/5/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 15 new + 164 unchanged 
- 0 fixed = 179 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   2m 21s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m  2s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 50s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 32s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  24m  4s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  |   1m  4s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5515/5/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt)
 |  hadoop-yarn-api in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m 15s |  |  hadoop-yarn-server-common in 
the patch passed.  |
   | +1 :green_heart: |  unit  |  23m 34s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 48s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 192m 49s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.yarn.conf.TestYarnConfigurationFields |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5515/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5515 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 6a0d991a0935 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 457b93f490bd89775e42185a6f6bed84a6c948e2 |
   | Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   | Multi-JDK versions |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5515: YARN-11037. Add configurable logic to split resource request to the least loaded SC.

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5515:
URL: https://github.com/apache/hadoop/pull/5515#issuecomment-1497331680

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 35s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 3 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  16m  1s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  25m 55s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   9m 38s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  compile  |   8m 33s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  checkstyle  |   1m 40s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 49s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m 40s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   2m 28s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 30s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  21m 18s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 27s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 52s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   9m  7s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javac  |   9m  7s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   8m 28s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  javac  |   8m 28s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 37s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5515/4/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 15 new + 164 unchanged 
- 0 fixed = 179 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   2m 43s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m 21s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   2m 13s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 36s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  21m 32s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  |   1m 13s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5515/4/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt)
 |  hadoop-yarn-api in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m 24s |  |  hadoop-yarn-server-common in 
the patch passed.  |
   | +1 :green_heart: |  unit  |  24m  3s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 57s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 185m 40s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.yarn.conf.TestYarnConfigurationFields |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5515/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5515 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 38fc4cbfacfd 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 6fa49f681bdb7a8b3e4b2314b3750565977c4aef |
   | Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   | Multi-JDK versions |

[jira] [Commented] (HADOOP-18546) disable purging list of in progress reads in abfs stream closed

2023-04-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708799#comment-17708799
 ] 

ASF GitHub Bot commented on HADOOP-18546:
-

hadoop-yetus commented on PR #5529:
URL: https://github.com/apache/hadoop/pull/5529#issuecomment-1497257343

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m  5s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 5 new or modified test files.  |
    _ branch-3.3.2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   4m 43s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  34m 58s |  |  branch-3.3.2 passed  |
   | +1 :green_heart: |  compile  |  18m 22s |  |  branch-3.3.2 passed  |
   | +1 :green_heart: |  checkstyle  |   3m  1s |  |  branch-3.3.2 passed  |
   | +1 :green_heart: |  mvnsite  |   2m 16s |  |  branch-3.3.2 passed  |
   | +1 :green_heart: |  javadoc  |   2m 11s |  |  branch-3.3.2 passed  |
   | +1 :green_heart: |  spotbugs  |   3m 45s |  |  branch-3.3.2 passed  |
   | +1 :green_heart: |  shadedclient  |  27m  2s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 26s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 43s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  22m 22s |  |  the patch passed  |
   | -1 :x: |  javac  |  22m 22s | 
[/results-compile-javac-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5529/3/artifact/out/results-compile-javac-root.txt)
 |  root generated 1 new + 1970 unchanged - 1 fixed = 1971 total (was 1971)  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 53s | 
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5529/3/artifact/out/results-checkstyle-root.txt)
 |  root: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)  |
   | +1 :green_heart: |  mvnsite  |   2m 18s |  |  the patch passed  |
   | +1 :green_heart: |  xml  |   0m  1s |  |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  javadoc  |   2m 13s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   3m 53s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  25m 58s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  17m  0s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   2m 17s |  |  hadoop-azure in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 51s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 181m 56s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5529/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5529 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient codespell xml spotbugs checkstyle |
   | uname | Linux 81e6acfcb679 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | branch-3.3.2 / bdc6fac17b0c9ab2509193e43f650eecb7632956 |
   | Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~18.04.1-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5529/3/testReport/ |
   | Max. process+thread count | 3132 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure 
U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5529/3/console |
   | versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> disable purging list of in progress reads in abfs stream closed
> ---
>
> Key: HADOOP-18546
> URL: https://issues.apache.org/jira/browse/HADOOP-18546
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Compone

[GitHub] [hadoop] hadoop-yetus commented on pull request #5529: Backport HADOOP-18546: ABFS: Disable purging list of in progress reads in abfs stream closed in 3.3.2

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5529:
URL: https://github.com/apache/hadoop/pull/5529#issuecomment-1497257343

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m  5s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 5 new or modified test files.  |
    _ branch-3.3.2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   4m 43s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  34m 58s |  |  branch-3.3.2 passed  |
   | +1 :green_heart: |  compile  |  18m 22s |  |  branch-3.3.2 passed  |
   | +1 :green_heart: |  checkstyle  |   3m  1s |  |  branch-3.3.2 passed  |
   | +1 :green_heart: |  mvnsite  |   2m 16s |  |  branch-3.3.2 passed  |
   | +1 :green_heart: |  javadoc  |   2m 11s |  |  branch-3.3.2 passed  |
   | +1 :green_heart: |  spotbugs  |   3m 45s |  |  branch-3.3.2 passed  |
   | +1 :green_heart: |  shadedclient  |  27m  2s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 26s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 43s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  22m 22s |  |  the patch passed  |
   | -1 :x: |  javac  |  22m 22s | 
[/results-compile-javac-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5529/3/artifact/out/results-compile-javac-root.txt)
 |  root generated 1 new + 1970 unchanged - 1 fixed = 1971 total (was 1971)  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 53s | 
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5529/3/artifact/out/results-checkstyle-root.txt)
 |  root: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)  |
   | +1 :green_heart: |  mvnsite  |   2m 18s |  |  the patch passed  |
   | +1 :green_heart: |  xml  |   0m  1s |  |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  javadoc  |   2m 13s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   3m 53s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  25m 58s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  17m  0s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   2m 17s |  |  hadoop-azure in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 51s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 181m 56s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5529/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5529 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient codespell xml spotbugs checkstyle |
   | uname | Linux 81e6acfcb679 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | branch-3.3.2 / bdc6fac17b0c9ab2509193e43f650eecb7632956 |
   | Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~18.04.1-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5529/3/testReport/ |
   | Max. process+thread count | 3132 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure 
U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5529/3/console |
   | versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] hadoop-yetus commented on pull request #5363: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5363:
URL: https://github.com/apache/hadoop/pull/5363#issuecomment-1497177118

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 48s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  buf  |   0m  1s |  |  buf was not available.  |
   | +0 :ok: |  buf  |   0m  1s |  |  buf was not available.  |
   | +0 :ok: |  xmllint  |   0m  1s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 4 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  16m 23s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 55s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  10m 32s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  compile  |   8m 53s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  checkstyle  |   1m 46s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   5m 51s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   5m 10s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   4m 43s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |  11m  4s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  23m 31s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  23m 51s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m  7s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   9m 50s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  cc  |   9m 50s |  |  the patch passed  |
   | -1 :x: |  javac  |   9m 50s | 
[/results-compile-javac-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5363/16/artifact/out/results-compile-javac-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt)
 |  
hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 1 new + 730 
unchanged - 0 fixed = 731 total (was 730)  |
   | +1 :green_heart: |  compile  |   8m 48s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  cc  |   8m 48s |  |  the patch passed  |
   | -1 :x: |  javac  |   8m 48s | 
[/results-compile-javac-hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5363/16/artifact/out/results-compile-javac-hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt)
 |  
hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
 with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 generated 2 new 
+ 643 unchanged - 4 fixed = 645 total (was 647)  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   1m 36s |  |  
hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 230 unchanged - 1 
fixed = 230 total (was 231)  |
   | +1 :green_heart: |  mvnsite  |   5m 28s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   4m 39s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   4m 20s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |  11m 57s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  23m 37s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m  4s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 21s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   3m 14s |  |  hadoop-yarn-se

[GitHub] [hadoop] hadoop-yetus commented on pull request #5515: YARN-11037. Add configurable logic to split resource request to the least loaded SC.

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5515:
URL: https://github.com/apache/hadoop/pull/5515#issuecomment-1497079020

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 37s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 3 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  16m 30s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  26m 25s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   9m 45s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  compile  |   8m 36s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  checkstyle  |   1m 48s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 57s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m 41s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   2m 30s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 35s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  21m 11s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 28s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 49s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   9m  9s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javac  |   9m  9s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   8m 28s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  javac  |   8m 28s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 38s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5515/3/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 32 new + 164 unchanged 
- 0 fixed = 196 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   2m 43s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m 16s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   2m 14s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 34s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  24m 41s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  |   1m 14s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5515/3/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt)
 |  hadoop-yarn-api in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m 25s |  |  hadoop-yarn-server-common in 
the patch passed.  |
   | +1 :green_heart: |  unit  |  24m 18s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 56s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 190m 36s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.yarn.conf.TestYarnConfigurationFields |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5515/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5515 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 67fe57ead63b 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 39b123417fd2683cdc9240c57e81b52e23e67ec7 |
   | Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   | Multi-JDK versions |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5525: YARN-11377. [Federation] Support addToClusterNodeLabels、removeFromClusterNodeLabels、replaceLabelsOnNode API's for Federation.

2023-04-05 Thread via GitHub



hadoop-yetus commented on PR #5525:
URL: https://github.com/apache/hadoop/pull/5525#issuecomment-1497047713

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 49s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  buf  |   0m  1s |  |  buf was not available.  |
   | +0 :ok: |  buf  |   0m  1s |  |  buf was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  16m 34s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  25m 56s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   9m 38s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  compile  |   8m 30s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  checkstyle  |   1m 47s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 49s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m 39s |  |  trunk passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   2m 29s |  |  trunk passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 10s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  20m 49s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 28s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 42s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   8m 59s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  cc  |   8m 59s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   8m 59s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   8m 24s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  cc  |   8m 24s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   8m 24s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 36s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5525/2/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 18 unchanged - 
0 fixed = 26 total (was 18)  |
   | +1 :green_heart: |  mvnsite  |   2m 32s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m 22s |  |  the patch passed with JDK 
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1  |
   | +1 :green_heart: |  javadoc  |   2m 12s |  |  the patch passed with JDK 
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09  |
   | +1 :green_heart: |  spotbugs  |   5m 21s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  20m 39s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 12s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 42s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m 44s |  |  hadoop-yarn-server-router in 
the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 55s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 163m 45s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5525/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5525 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint 
bufcompat |
   | uname | Linux 9834f12e798b 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 64f750d4bfa92801e6fc4b4c1a00c4efe7b18690 |
   | Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-pos

62 matches

Mail list logo