[jira] [Updated] (HADOOP-17295) Move dedicated pre-logging statements into existing logging guards
[ https://issues.apache.org/jira/browse/HADOOP-17295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chen Zhi updated HADOOP-17295: -- Description: I find some cases where some pre-processing statements dedicated to logging calls are not guarded by existing logging guards. Most of them are easy to fix. And the performance and maintainability of these logging calls can be improved to some extend. So I create a PR to fix them. These issues are detected by a static analysis tool wrote by myself. This tool can extract all the dedicated statements for each debug-logging calls (i.e., the results of these statements are only used by debug-logging calls). Because I realize that debug logs will incur overhead in production, such as string concatenation and method calls in the parameters of logging calls as well as pre-processing statements. And I want to perform a systematic evaluation for the overhead of debugging logging calls in production. was: I find some cases where some pre-processing statements dedicated to logging calls are not guarded by existing logging guards. Most of them are easy to fix. And I create a PR to fix them. These issues are detected by a static analysis tool wrote by myself. This tool can extract all the dedicated statements for each debug-logging calls (i.e., the results of these statements are only used by debug-logging calls). Because I realize that debug logs will incur overhead in production, such as string concatenation and method calls in the parameters of logging calls as well as pre-processing statements. And I want to perform a systematic evaluation for the overhead of debugging logging calls in production. > Move dedicated pre-logging statements into existing logging guards > -- > > Key: HADOOP-17295 > URL: https://issues.apache.org/jira/browse/HADOOP-17295 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Chen Zhi >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > I find some cases where some pre-processing statements dedicated to logging > calls are not guarded by existing logging guards. Most of them are easy to > fix. And the performance and maintainability of these logging calls can be > improved to some extend. So I create a PR to fix them. > These issues are detected by a static analysis tool wrote by myself. This > tool can extract all the dedicated statements for each debug-logging calls > (i.e., the results of these statements are only used by debug-logging calls). > Because I realize that debug logs will incur overhead in production, such as > string concatenation and method calls in the parameters of logging calls as > well as pre-processing statements. And I want to perform a systematic > evaluation for the overhead of debugging logging calls in production. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17295) Move dedicated pre-logging statements into existing logging guards
[ https://issues.apache.org/jira/browse/HADOOP-17295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chen Zhi updated HADOOP-17295: -- Description: I find some cases where some pre-processing statements dedicated to logging calls are not guarded by existing logging guards. Most of them are easy to fix. And I create a PR to fix them. These issues are detected by a static analysis tool wrote by myself. This tool can extract all the dedicated statements for each debug-logging calls (i.e., the results of these statements are only used by debug-logging calls). Because I realize that debug logs will incur overhead in production, such as string concatenation and method calls in the parameters of logging calls as well as pre-processing statements. And I want to perform a systematic evaluation for the overhead of debugging logging calls in production. was: I find some cases where some pre-processing statements dedicated to logging calls are not guarded by existing logging guards. Most of them are easy to fix. And I create a PR to fix them. These issues are detected by a static analysis tool wrote by myself. This tool can extract all the dedicated statements for each debug-logging calls (i.e., the results of these statements are only used by debug-logging calls). Because I realize that debug logs will incur overhead in production, such as string concatenation and method calls in the parameters of logging calls. And I want to perform a systematic evaluation for the overhead of debugging logging calls in production. > Move dedicated pre-logging statements into existing logging guards > -- > > Key: HADOOP-17295 > URL: https://issues.apache.org/jira/browse/HADOOP-17295 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Chen Zhi >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > I find some cases where some pre-processing statements dedicated to logging > calls are not guarded by existing logging guards. Most of them are easy to > fix. And I create a PR to fix them. > These issues are detected by a static analysis tool wrote by myself. This > tool can extract all the dedicated statements for each debug-logging calls > (i.e., the results of these statements are only used by debug-logging calls). > Because I realize that debug logs will incur overhead in production, such as > string concatenation and method calls in the parameters of logging calls as > well as pre-processing statements. And I want to perform a systematic > evaluation for the overhead of debugging logging calls in production. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Created] (HADOOP-17295) Move dedicated pre-logging statements into existing logging guards
Chen Zhi created HADOOP-17295: - Summary: Move dedicated pre-logging statements into existing logging guards Key: HADOOP-17295 URL: https://issues.apache.org/jira/browse/HADOOP-17295 Project: Hadoop Common Issue Type: Improvement Reporter: Chen Zhi I find some cases where some pre-processing statements dedicated to logging calls are not guarded by existing logging guards. Most of them are easy to fix. And I create a PR to fix them. These issues are detected by a static analysis tool wrote by myself. This tool can extract all the dedicated statements for each debug-logging calls (i.e., the results of these statements are only used by debug-logging calls). Because I realize that debug logs will incur overhead in production, such as string concatenation and method calls in the parameters of logging calls. And I want to perform a systematic evaluation for the overhead of debugging logging calls in production. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-16162) Remove unused Job Summary Appender configurations from log4j.properties
[ https://issues.apache.org/jira/browse/HADOOP-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chen Zhi updated HADOOP-16162: -- Labels: CI pull-request-available (was: CI) > Remove unused Job Summary Appender configurations from log4j.properties > --- > > Key: HADOOP-16162 > URL: https://issues.apache.org/jira/browse/HADOOP-16162 > Project: Hadoop Common > Issue Type: Improvement > Components: conf >Affects Versions: 2.0.3-alpha >Reporter: Chen Zhi >Priority: Major > Labels: CI, pull-request-available > Attachments: HADOOP-16162.1.patch > > > The Job Summary Appender (JSA) is introduced in > [MAPREDUCE-740|https://issues.apache.org/jira/browse/MAPREDUCE-740] to > provide the summary information of the job's runtime. And this appender is > only referenced by the logger defined in > org.apache.hadoop.mapred.JobInProgress$JobSummary. However, this class has > been removed in > [MAPREDUCE-4266|https://issues.apache.org/jira/browse/MAPREDUCE-4266] > together with other M/R1 files. This appender is no longer used and I guess > we can remove it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-16162) Remove unused Job Summary Appender configurations from log4j.properties
[ https://issues.apache.org/jira/browse/HADOOP-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chen Zhi updated HADOOP-16162: -- Attachment: HADOOP-16162.1.patch > Remove unused Job Summary Appender configurations from log4j.properties > --- > > Key: HADOOP-16162 > URL: https://issues.apache.org/jira/browse/HADOOP-16162 > Project: Hadoop Common > Issue Type: Improvement > Components: conf >Affects Versions: 2.0.3-alpha >Reporter: Chen Zhi >Priority: Major > Labels: CI > Attachments: HADOOP-16162.1.patch > > > The Job Summary Appender (JSA) is introduced in > [MAPREDUCE-740|https://issues.apache.org/jira/browse/MAPREDUCE-740] to > provide the summary information of the job's runtime. And this appender is > only referenced by the logger defined in > org.apache.hadoop.mapred.JobInProgress$JobSummary. However, this class has > been removed in > [MAPREDUCE-4266|https://issues.apache.org/jira/browse/MAPREDUCE-4266] > together with other M/R1 files. This appender is no longer used and I guess > we can remove it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-16162) Remove unused Job Summary Appender configurations from log4j.properties
[ https://issues.apache.org/jira/browse/HADOOP-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chen Zhi updated HADOOP-16162: -- Attachment: (was: diff) > Remove unused Job Summary Appender configurations from log4j.properties > --- > > Key: HADOOP-16162 > URL: https://issues.apache.org/jira/browse/HADOOP-16162 > Project: Hadoop Common > Issue Type: Improvement > Components: conf >Affects Versions: 2.0.3-alpha >Reporter: Chen Zhi >Priority: Major > Labels: CI > Attachments: HADOOP-16162.1.patch > > > The Job Summary Appender (JSA) is introduced in > [MAPREDUCE-740|https://issues.apache.org/jira/browse/MAPREDUCE-740] to > provide the summary information of the job's runtime. And this appender is > only referenced by the logger defined in > org.apache.hadoop.mapred.JobInProgress$JobSummary. However, this class has > been removed in > [MAPREDUCE-4266|https://issues.apache.org/jira/browse/MAPREDUCE-4266] > together with other M/R1 files. This appender is no longer used and I guess > we can remove it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Created] (HADOOP-16162) Remove unused Job Summary Appender configurations from log4j.properties
Chen Zhi created HADOOP-16162: - Summary: Remove unused Job Summary Appender configurations from log4j.properties Key: HADOOP-16162 URL: https://issues.apache.org/jira/browse/HADOOP-16162 Project: Hadoop Common Issue Type: Improvement Components: conf Affects Versions: 2.0.3-alpha Reporter: Chen Zhi Attachments: diff The Job Summary Appender (JSA) is introduced in [MAPREDUCE-740|https://issues.apache.org/jira/browse/MAPREDUCE-740] to provide the summary information of the job's runtime. And this appender is only referenced by the logger defined in org.apache.hadoop.mapred.JobInProgress$JobSummary. However, this class has been removed in [MAPREDUCE-4266|https://issues.apache.org/jira/browse/MAPREDUCE-4266] together with other M/R1 files. This appender is no longer used and I guess we can remove it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
