[GitHub] [hadoop] ashutoshcipher commented on pull request #4229: HADOOP-18069. okhttp@2.7.5 to 4.9.3
ashutoshcipher commented on PR #4229: URL: https://github.com/apache/hadoop/pull/4229#issuecomment-1126600263 @aajisaka - Thanks for re-run. It seems to be completed. Can you please review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on pull request #4229: HADOOP-18069. okhttp@2.7.5 to 4.9.3
ashutoshcipher commented on PR #4229: URL: https://github.com/apache/hadoop/pull/4229#issuecomment-1117265531 > > spotbugs still thinks there is a problem. what is it that it is warning about? > > I already used try-with-resources for OkHttpClient and added request checks as well. The warning is about NPE case. > > Reading the source code, `responseBody.body()` is always non-null. However, spotbugs thinks `responseBody.body()` may be null and it warns "need null check". I think it is because Spotbugs failed to analyze the okhttp classes from Kotlin. > > I think we can simply ignore the warnings. @ashutoshcipher would you add some entries to ignore the spotbugs warning in `hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml`? Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on pull request #4229: HADOOP-18069. okhttp@2.7.5 to 4.9.3
ashutoshcipher commented on PR #4229: URL: https://github.com/apache/hadoop/pull/4229#issuecomment-1110235192 > commented. > > * checkstyle needs to be happy, along with javac. > * spotbugs still thinks there is a problem. what is it that it is warning about? > > i'm worried about adding kotlin everywhere. looking at the mvnrepo declarations it is (a) not optional and (b) about 1.5MB including transitive dependencies. so nothing much. my main concern is what pain does it cause downstream. we've had to tag this as an incompatible change just to add in the release notes about where it is used/needed - Checkstyle would be happy with my last commit. - Javac - 1. `hadoop-hdfs-project/hadoop-hdfs client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java:109:36:[deprecation] create(MediaType,String) in RequestBody has been deprecated `- Handled this in latest commit. 2. `hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/RequestHedgingProxyProvider.java:229:76:[unchecked] unchecked cast` -I believe this is not due this change, can see the same cast warning in my local on trunk as well. May be we can create a separate JIRA to handle this. - spotbugs still thinks there is a problem. what is it that it is warning about? I already used try-with-resources for OkHttpClient and added request checks as well. The warning is about NPE case. - I agree with your view on Kotlin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
