[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5568: HDFS-16653.Add error message for maxEvictableMmapedSize related Precondition check suite.

[via GitHub]

ayushtkn commented on code in PR #5568:
URL: https://github.com/apache/hadoop/pull/5568#discussion_r1192839897


##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java:
##
@@ -379,13 +380,18 @@ public static ShortCircuitCache fromConf(ShortCircuitConf 
conf) {
   public ShortCircuitCache(int maxTotalSize, long 
maxNonMmappedEvictableLifespanMs,
   int maxEvictableMmapedSize, long maxEvictableMmapedLifespanMs,
   long mmapRetryTimeoutMs, long staleThresholdMs, int shmInterruptCheckMs) 
{
-Preconditions.checkArgument(maxTotalSize >= 0);
+Preconditions.checkArgument(maxTotalSize >= 0,
+  "Invalid argument: maxTotalSize must be greater than zero.");

Review Comment:
   No need to put Invalid Argument:, It will throw IllegalArgumentException, 
that is indicative. just keep the message post Invalid argument: in all the 
Preconditions. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5568: HDFS-16653.Add error message for maxEvictableMmapedSize related Precondition check suite.

[via GitHub]

ayushtkn commented on code in PR #5568:
URL: https://github.com/apache/hadoop/pull/5568#discussion_r1171494224


##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java:
##
@@ -383,7 +384,9 @@ public ShortCircuitCache(int maxTotalSize, long 
maxNonMmappedEvictableLifespanMs
 this.maxTotalSize = maxTotalSize;
 Preconditions.checkArgument(maxNonMmappedEvictableLifespanMs >= 0);
 this.maxNonMmappedEvictableLifespanMs = maxNonMmappedEvictableLifespanMs;
-Preconditions.checkArgument(maxEvictableMmapedSize >= 0);
+Preconditions.checkArgument(maxEvictableMmapedSize >= 0,
+  "Invalid argument: " + HdfsClientConfigKeys.Mmap.CACHE_SIZE_KEY +
+  " must be greater than zero.");
 this.maxEvictableMmapedSize = maxEvictableMmapedSize;
 Preconditions.checkArgument(maxEvictableMmapedLifespanMs >= 0);

Review Comment:
   Do the same for other ``PreConditions`` as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org