[GitHub] [hadoop] ayushtkn commented on pull request #6102: MAPREDUCE-7453. Container logs are missing when yarn.app.container.log.filesize is set to default value 0.
ayushtkn commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741796859 Yahh, then we should revert only… Can you update this PR with the revert commit? We can get a test run & merge this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #6102: MAPREDUCE-7453. Container logs are missing when yarn.app.container.log.filesize is set to default value 0.
ayushtkn commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741778787 If I got you right, we are sorted with CRLA. For this ``` For CLA, I will replace with org.apache.log4j.FileAppender. But there will be no way to limit the size for FileAppender. And I think there is no need to limit the size for CLA. ``` Was this possible before that Hadoop patch, if yes may be we can let CRLA stuff as is & revert the CLA and get back the ``ContainerLogAppender`` If there was a way to limit previously, we should allow that now as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #6102: MAPREDUCE-7453. Container logs are missing when yarn.app.container.log.filesize is set to default value 0.
ayushtkn commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741714717 It is there since long & maintained, those changes are breaking the existing tests as well since long I believe, so lets revert that & fix the existing problems. if it is required, folks will figure out a way maintaining compat & redo. Changing defaults are incompatible change & we have a way without breaking compat, so it is a No from my side to change the defaults -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #6102: MAPREDUCE-7453. Container logs are missing when yarn.app.container.log.filesize is set to default value 0.
ayushtkn commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741637747 This fix was fixing those tests, so when we reverted that, they started failing again. for the fix, @zhengchenyu I think we should update the PR reverting the source fix and maintain old behaviour and compat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #6102: MAPREDUCE-7453. Container logs are missing when yarn.app.container.log.filesize is set to default value 0.
ayushtkn commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741258883 Another observation, the day this PR was reverted, some tests which were broken since eternity broke again. https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/1355/ & with this PR in they were passing: https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/1354/testReport/junit/org.apache.hadoop.mapreduce.v2/TestMRJobs/testThreadDumpOnTaskTimeout/ So, some way this fixes those tests, that we should anyway fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #6102: MAPREDUCE-7453. Container logs are missing when yarn.app.container.log.filesize is set to default value 0.
ayushtkn commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741254621 Thanx @zhengchenyu exploring a bit more. you removed this line ``` 0 disables the cap. ``` Now how does this change restores that behaviour? You did set a cap, now if I don't want to have any capping, how will I achieve that? And with this change in, still there would be behavioural differences? The problem & reasoning does makes sense to me, though not the fix if there ain't any option but only this, then ok but I am more inclined towards reverting the cause though... jfyi. @jojochuang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
