[GitHub] [hadoop] cwensel commented on pull request #2599: HADOOP-17337. NetworkBinding has a runtime dependency on shaded httpclient
cwensel commented on pull request #2599: URL: https://github.com/apache/hadoop/pull/2599#issuecomment-756300986 I fully understand the situation. And appreciate the time and effort put into this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] cwensel commented on pull request #2599: HADOOP-17337. NetworkBinding has a runtime dependency on shaded httpclient
cwensel commented on pull request #2599: URL: https://github.com/apache/hadoop/pull/2599#issuecomment-756248615 this is an unfortunate tradeoff. I'll gladly opt for improved runtime performance vs improved build and deployment performance. is it not possible, if not reasonable, to have both by adding a new class that couples to the unshaded class in tandem to the current proposed class that couples to the shaded? this seems like a reasonable tax on the choice to use a shaded library and coupling to its internals. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] cwensel commented on pull request #2599: HADOOP-17337. NetworkBinding has a runtime dependency on shaded httpclient
cwensel commented on pull request #2599: URL: https://github.com/apache/hadoop/pull/2599#issuecomment-755469136 @steveloughran without actually running it, - what would the fallback behavior be if the shaded artifact isn't found leaving the default SSL factory? - should the unshaded factory class be loaded and configured if available? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
