[GitHub] [hadoop] functioner commented on pull request #2727: HADOOP-17552. Change ipc.client.rpc-timeout.ms from 0 to 120000 by default to avoid potential hang

2021-03-05 Thread GitBox 


functioner commented on pull request #2727:
URL: https://github.com/apache/hadoop/pull/2727#issuecomment-791591405


   Are we ready to merge? @ferhui @iwasakims 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] functioner commented on pull request #2727: HADOOP-17552. Change ipc.client.rpc-timeout.ms from 0 to 120000 by default to avoid potential hang

2021-03-04 Thread GitBox 


functioner commented on pull request #2727:
URL: https://github.com/apache/hadoop/pull/2727#issuecomment-79227


   > @functioner As @iwasakims said, you can add
   > `conf.setInt(CommonConfigurationKeys.IPC_CLIENT_RPC_TIMEOUT_KEY, 0);`
   > before
   > ` assertEquals(Client.getTimeout(config), -1);`
   
   It seems it doesn't work. The obtained timeout is still 12. Any idea?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] functioner commented on pull request #2727: HADOOP-17552. Change ipc.client.rpc-timeout.ms from 0 to 120000 by default to avoid potential hang

2021-03-03 Thread GitBox 


functioner commented on pull request #2727:
URL: https://github.com/apache/hadoop/pull/2727#issuecomment-789587539


   > @functioner According to CI results, TestIPC#testClientGetTimeout fails. 
It is related, please check.
   
   It fails at line 1459:
   
https://github.com/apache/hadoop/blob/b4985c1ef277bcf51eec981385c56218ac41f09e/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java#L1456-L1460
   
   `Client.getTimeout` is:
   
https://github.com/apache/hadoop/blob/b4985c1ef277bcf51eec981385c56218ac41f09e/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java#L237-L258
   
   Before we change the default rpcTimeout:
   rpcTimeout is 0, so it won't return at line 251.
   `CommonConfigurationKeys.IPC_CLIENT_PING_DEFAULT` is true, so it won't 
return at line 255 either.
   Finally, it returns -1 at line 257, and passes the test case.
   
   After we change the default rpcTimeout=12:
   It returns at line 251, it fails because 12 is not -1.
   
   Conclusion:
   This test is essentially checking the default value of rpcTimeout.
   Since we modified this value, we should also modify this test as 
`assertThat(Client.getTimeout(config)).isEqualTo(12)`.
   What do you think? @ferhui @iwasakims 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org