goiri commented on code in PR #4960:
URL: https://github.com/apache/hadoop/pull/4960#discussion_r985272139
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java:
##
@@ -128,8 +128,15 @@ protected Boolean hasAccess(RMApp app, HttpServletRequest
hsr) {
}
return true;
}
-
-
+ private long appInfoFunc;
+ public String printData(long appInfoFunc) {
+this.appInfoFunc=appInfoFunc;
+if (appInfoFunc == -1) {
+ return "N/A";
+} else {
+ return String.valueOf(appInfoFunc);
Review Comment:
No need for else, just return.
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java:
##
@@ -128,8 +128,15 @@ protected Boolean hasAccess(RMApp app, HttpServletRequest
hsr) {
}
return true;
}
-
-
+ private long appInfoFunc;
+ public String printData(long appInfoFunc) {
Review Comment:
the name of printData() is a little too general.
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java:
##
@@ -128,8 +128,15 @@ protected Boolean hasAccess(RMApp app, HttpServletRequest
hsr) {
}
return true;
}
-
-
+ private long appInfoFunc;
+ public String printData(long appInfoFunc) {
+this.appInfoFunc=appInfoFunc;
Review Comment:
Why are we saving this? We are not using it later. Were you trying to cache
here?
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java:
##
@@ -128,8 +128,15 @@ protected Boolean hasAccess(RMApp app, HttpServletRequest
hsr) {
}
return true;
}
-
-
+ private long appInfoFunc;
+ public String printData(long appInfoFunc) {
+this.appInfoFunc=appInfoFunc;
+if (appInfoFunc == -1) {
+ return "N/A";
+} else {
+ return String.valueOf(appInfoFunc);
+}
+ }
Review Comment:
Breakline after and before the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
