[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1496: HADOOP-16560. [YARN] use protobuf-maven-plugin to generat…
hadoop-yetus commented on a change in pull request #1496: HADOOP-16560. [YARN] use protobuf-maven-plugin to generat… URL: https://github.com/apache/hadoop/pull/1496#discussion_r327132225 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml ## @@ -118,45 +118,22 @@ -org.apache.hadoop -hadoop-maven-plugins - +org.xolstice.maven.plugins + protobuf-maven-plugin + Review comment: whitespace:tabs in line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1496: HADOOP-16560. [YARN] use protobuf-maven-plugin to generat…
hadoop-yetus commented on a change in pull request #1496: HADOOP-16560. [YARN] use protobuf-maven-plugin to generat… URL: https://github.com/apache/hadoop/pull/1496#discussion_r327132236 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml ## @@ -118,45 +118,22 @@ -org.apache.hadoop -hadoop-maven-plugins - +org.xolstice.maven.plugins + protobuf-maven-plugin + -compile-protoc - - protoc - - - ${protobuf.version} - ${protoc.path} - - ${basedir}/../../../hadoop-common-project/hadoop-common/src/main/proto -${basedir}/src/main/proto -${basedir}/src/main/proto/server - - -${basedir}/src/main/proto - - yarn_protos.proto - yarn_service_protos.proto - applicationmaster_protocol.proto - applicationclient_protocol.proto - containermanagement_protocol.proto - server/yarn_server_resourcemanager_service_protos.proto - server/resourcemanager_administration_protocol.proto - application_history_client.proto - server/application_history_server.proto - client_SCM_protocol.proto - server/SCM_Admin_protocol.proto - yarn_csi_adaptor.proto - YarnCsiAdaptor.proto - - +src-compile-protoc + Review comment: whitespace:tabs in line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1496: HADOOP-16560. [YARN] use protobuf-maven-plugin to generat…
hadoop-yetus commented on a change in pull request #1496: HADOOP-16560. [YARN] use protobuf-maven-plugin to generat… URL: https://github.com/apache/hadoop/pull/1496#discussion_r327132249 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/pom.xml ## @@ -154,28 +154,21 @@ -org.apache.hadoop -hadoop-maven-plugins +org.xolstice.maven.plugins +protobuf-maven-plugin -compile-protoc - - protoc - - - ${protobuf.version} - ${protoc.path} - -${basedir}/src/test/proto - ${basedir}/../../../hadoop-common-project/hadoop-common/src/main/proto -${basedir}/../hadoop-yarn-api/src/main/proto - - -${basedir}/src/test/proto - - test_amrm_token.proto - - +src-test-compile-protoc + Review comment: whitespace:tabs in line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1496: HADOOP-16560. [YARN] use protobuf-maven-plugin to generat…
hadoop-yetus commented on a change in pull request #1496: HADOOP-16560. [YARN] use protobuf-maven-plugin to generat… URL: https://github.com/apache/hadoop/pull/1496#discussion_r327132267 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml ## @@ -205,30 +205,27 @@ -org.apache.hadoop -hadoop-maven-plugins +org.xolstice.maven.plugins +protobuf-maven-plugin -compile-protoc - - protoc - - - ${protobuf.version} - ${protoc.path} - - ${basedir}/../../../../hadoop-common-project/hadoop-common/src/main/proto -${basedir}/../../hadoop-yarn-api/src/main/proto - ${basedir}/../../hadoop-yarn-common/src/main/proto - ${basedir}/../hadoop-yarn-server-common/src/main/proto -${basedir}/src/main/proto - - -${basedir}/src/main/proto - - yarn_server_timelineserver_recovery.proto - - +src-compile-protoc + Review comment: whitespace:tabs in line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1496: HADOOP-16560. [YARN] use protobuf-maven-plugin to generat…
hadoop-yetus commented on a change in pull request #1496: HADOOP-16560. [YARN] use protobuf-maven-plugin to generat… URL: https://github.com/apache/hadoop/pull/1496#discussion_r327132210 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml ## @@ -118,45 +118,22 @@ -org.apache.hadoop -hadoop-maven-plugins - +org.xolstice.maven.plugins + protobuf-maven-plugin Review comment: whitespace:tabs in line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org