[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #549: HDDS-1213. Support plain text S3 MPU initialization request

2019-03-04 Thread GitBox
hadoop-yetus commented on a change in pull request #549: HDDS-1213. Support 
plain text S3 MPU initialization request
URL: https://github.com/apache/hadoop/pull/549#discussion_r262147191
 
 

 ##
 File path: hadoop-ozone/dist/src/main/smoketest/s3/MultipartUpload.robot
 ##
 @@ -172,8 +164,7 @@ Test list parts
 
 #upload parts
${system} = Evaluateplatform.system()platform
-   Run Keyword if  '${system}' == 'Darwin'  Create Random file for mac
-   Run Keyword if  '${system}' == 'Linux'   Create Random file for 
linux
+   Run Keyword Create Random file  5
 
 Review comment:
   whitespace:tabs in line
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #549: HDDS-1213. Support plain text S3 MPU initialization request

2019-03-04 Thread GitBox
hadoop-yetus commented on a change in pull request #549: HDDS-1213. Support 
plain text S3 MPU initialization request
URL: https://github.com/apache/hadoop/pull/549#discussion_r262147227
 
 

 ##
 File path: hadoop-ozone/dist/src/main/smoketest/s3/MultipartUpload.robot
 ##
 @@ -75,8 +71,7 @@ Test Multipart Upload Complete
 
 #upload parts
${system} = Evaluateplatform.system()platform
-   Run Keyword if  '${system}' == 'Darwin'  Create Random file for mac
-   Run Keyword if  '${system}' == 'Linux'   Create Random file for 
linux
+   Run Keyword Create Random file  5
 
 Review comment:
   whitespace:tabs in line
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #549: HDDS-1213. Support plain text S3 MPU initialization request

2019-03-04 Thread GitBox
hadoop-yetus commented on a change in pull request #549: HDDS-1213. Support 
plain text S3 MPU initialization request
URL: https://github.com/apache/hadoop/pull/549#discussion_r262147210
 
 

 ##
 File path: hadoop-ozone/dist/src/main/smoketest/s3/MultipartUpload.robot
 ##
 @@ -55,13 +53,11 @@ Test Multipart Upload
 # multipart upload, uploading each part as 5MB file, exception is for last part
 
${system} = Evaluateplatform.system()platform
-   Run Keyword if  '${system}' == 'Darwin'  Create Random file for mac
-   Run Keyword if  '${system}' == 'Linux'   Create Random file for 
linux
+   Run Keyword Create Random file  5
 
 Review comment:
   whitespace:tabs in line
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #549: HDDS-1213. Support plain text S3 MPU initialization request

2019-03-04 Thread GitBox
hadoop-yetus commented on a change in pull request #549: HDDS-1213. Support 
plain text S3 MPU initialization request
URL: https://github.com/apache/hadoop/pull/549#discussion_r262147199
 
 

 ##
 File path: hadoop-ozone/dist/src/main/smoketest/s3/MultipartUpload.robot
 ##
 @@ -205,3 +196,10 @@ Test list parts
 
 #finally abort it
   ${result} = Execute AWSS3APICli and checkrc
abort-multipart-upload --bucket ${BUCKET} --key multipartKey5 --upload-id 
${uploadID}0
+
+Test Multipart Upload with the simplified aws s3 cp API
+   Create Random file  22
 
 Review comment:
   whitespace:tabs in line
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #549: HDDS-1213. Support plain text S3 MPU initialization request

2019-03-04 Thread GitBox
hadoop-yetus commented on a change in pull request #549: HDDS-1213. Support 
plain text S3 MPU initialization request
URL: https://github.com/apache/hadoop/pull/549#discussion_r262147219
 
 

 ##
 File path: hadoop-ozone/dist/src/main/smoketest/s3/MultipartUpload.robot
 ##
 @@ -55,13 +53,11 @@ Test Multipart Upload
 # multipart upload, uploading each part as 5MB file, exception is for last part
 
${system} = Evaluateplatform.system()platform
-   Run Keyword if  '${system}' == 'Darwin'  Create Random file for mac
-   Run Keyword if  '${system}' == 'Linux'   Create Random file for 
linux
+   Run Keyword Create Random file  5
${result} = Execute AWSS3APICli upload-part --bucket 
${BUCKET} --key multipartKey --part-number 1 --body /tmp/part1 --upload-id 
${nextUploadID}
Should contain  ${result}ETag
 # override part
-   Run Keyword if  '${system}' == 'Darwin'Create Random file for 
mac
-   Run Keyword if  '${system}' == 'Linux' Create Random file for 
linux
+   Run Keyword Create Random file  5
 
 Review comment:
   whitespace:tabs in line
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org