[GitHub] [hadoop] haiyang1987 commented on pull request #6024: HDFS-17177. ErasureCodingWork reconstruct ignore the block length is Long.MAX_VALUE

2023-09-11 Thread via GitHub 


haiyang1987 commented on PR #6024:
URL: https://github.com/apache/hadoop/pull/6024#issuecomment-1713670352

   Thanks @ZanderXu @zhangshuyan0 help me review and merge it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] haiyang1987 commented on pull request #6024: HDFS-17177. ErasureCodingWork reconstruct ignore the block length is Long.MAX_VALUE

2023-09-07 Thread via GitHub 


haiyang1987 commented on PR #6024:
URL: https://github.com/apache/hadoop/pull/6024#issuecomment-1710003005

   Thanks @ZanderXu @zhangshuyan0 help me review.
   
   yeah, use `getBlock().isDeleted()` can better intuitively indicate that the 
current block has been deleted,
   In the current code, `ReplicationWork#chooseTargets `and` 
DatanodeManager#handleHeartbeat` maybe can be changed to 
`getBlock().isDeleted()`,  what do you think about?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org