[GitHub] [hadoop] iwasakims commented on pull request #2581: YARN-10553. Refactor TestDistributedShell
iwasakims commented on pull request #2581: URL: https://github.com/apache/hadoop/pull/2581#issuecomment-756551454 > It seems that there was an old bug and not introduced by my changes. It is easily surfaced by just running `mvn test` now as a result of the class splitting. This should be fixed here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] iwasakims commented on pull request #2581: YARN-10553. Refactor TestDistributedShell
iwasakims commented on pull request #2581: URL: https://github.com/apache/hadoop/pull/2581#issuecomment-756537729 Running `mvn test -Dtest=TestDSTimelineV20` alone worked as you said. TestDSTimelineV15 seems to affect the configuration of TestDSTimelineV20. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] iwasakims commented on pull request #2581: YARN-10553. Refactor TestDistributedShell
iwasakims commented on pull request #2581: URL: https://github.com/apache/hadoop/pull/2581#issuecomment-756536297 My stack trace indicates that TestDSTimelineV20 is configured to use HDFS but there is no running MiniDFSCluster. YARN daemons are failed to start due to this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] iwasakims commented on pull request #2581: YARN-10553. Refactor TestDistributedShell
iwasakims commented on pull request #2581: URL: https://github.com/apache/hadoop/pull/2581#issuecomment-756522630 The latest commit seemed to introduce errors. ``` $ mvn test -Dtest='TestDS*' ... [ERROR] Errors: [ERROR] TestDSTimelineV20>DistributedShellBaseTest.setup:159->DistributedShellBaseTest.setupInternal:476 » YarnRuntime [ERROR] TestDSTimelineV20>DistributedShellBaseTest.setup:159->DistributedShellBaseTest.setupInternal:476 » YarnRuntime [ERROR] TestDSTimelineV20>DistributedShellBaseTest.setup:159->DistributedShellBaseTest.setupInternal:476 » YarnRuntime [ERROR] TestDSTimelineV20>DistributedShellBaseTest.setup:159->DistributedShellBaseTest.setupInternal:476 » YarnRuntime [ERROR] TestDSTimelineV20>DistributedShellBaseTest.setup:159->DistributedShellBaseTest.setupInternal:476 » YarnRuntime [ERROR] TestDSTimelineV20>DistributedShellBaseTest.setup:159->DistributedShellBaseTest.setupInternal:476 » YarnRuntime [INFO] [ERROR] Tests run: 40, Failures: 0, Errors: 6, Skipped: 0 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] iwasakims commented on pull request #2581: YARN-10553. Refactor TestDistributedShell
iwasakims commented on pull request #2581: URL: https://github.com/apache/hadoop/pull/2581#issuecomment-755926955 > * The implementation has lots of code redundancy. > * It is inefficient in the setup and tearing down. The large percentage of time execution is exhausted by starting cluster and stopping the services. I think there is a gap between the PR and the above description of [YARN-10553](https://issues.apache.org/jira/browse/YARN-10553). Just splitting the TestDistributedShell does not reduce code nor minicluster ramp-up time. It would be nice to update the JIRA description reflecting what is addressed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] iwasakims commented on pull request #2581: YARN-10553. Refactor TestDistributedShell
iwasakims commented on pull request #2581: URL: https://github.com/apache/hadoop/pull/2581#issuecomment-755926211 Thank for working on this, @amahussein. LGTM overall pending some nits. While it is too late here, it is hard to follow which part of the TestDistributedShell is modified if splitting the class and refactoring are mixed up in a single commit. Doing one thing in one PR makes reviewing and cherry-picking easier. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] iwasakims commented on pull request #2581: YARN-10553. Refactor TestDistributedShell
iwasakims commented on pull request #2581: URL: https://github.com/apache/hadoop/pull/2581#issuecomment-755846099 Is the fix of o.a.h.tools.dynamometer.Cliet related to TestDistributedShell? It should be addressed in another JIRA if not. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
