[GitHub] [hadoop] iwasakims commented on pull request #2727: HADOOP-17552. Change ipc.client.rpc-timeout.ms from 0 to 120000 by default to avoid potential hang
iwasakims commented on pull request #2727: URL: https://github.com/apache/hadoop/pull/2727#issuecomment-789658781 @functioner The `TestIPC#testClientGetTimeout` tests deprecated `Client#getTimeout` which was used before `ipc.client.rpc-timeout.ms` and `Client#getRpcTimeout` was introduced. Based on the context, the testClientGetTimeout should check the value of `Client#getTimeout` when `ipc.client.rpc-timeout.ms` is set to 0. (-1 is expected if ipc.client.ping is true (default)). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] iwasakims commented on pull request #2727: HADOOP-17552. Change ipc.client.rpc-timeout.ms from 0 to 120000 by default to avoid potential hang
iwasakims commented on pull request #2727: URL: https://github.com/apache/hadoop/pull/2727#issuecomment-791872984 @functioner You should address the checkstyle warning. I think we don't need the comment. ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java:61: public static final int IPC_CLIENT_RPC_TIMEOUT_DEFAULT = 12; // 120 seconds: Line is longer than 80 characters (found 81). [LineLength] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
