[GitHub] [hadoop] liever18 commented on pull request #4220: HADOOP-18216. io.file.buffer.size must be greater than zero
liever18 commented on PR #4220: URL: https://github.com/apache/hadoop/pull/4220#issuecomment-1110948706 > Hi @steveloughran and @liever18 Sorry for late comments. I found that this pr just update comments, right? Is it better to improve the logic to guard the illegal configuration? Thanks. Do you think prepending precondition check to this code [IOUtils.java](https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java#L93) would solve the problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] liever18 commented on pull request #4220: HADOOP-18216. io.file.buffer.size must be greater than zero
liever18 commented on PR #4220: URL: https://github.com/apache/hadoop/pull/4220#issuecomment-1109754227 > i am about to merge this. should i give the credit to Jingxuan Fu? yeap! "Jingxuan Fu" is my jira's account. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] liever18 commented on pull request #4220: HADOOP-18216. io.file.buffer.size must be greater than zero
liever18 commented on PR #4220: URL: https://github.com/apache/hadoop/pull/4220#issuecomment-1108076933 thanks @steveloughran for your review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
