[GitHub] [hadoop] mukund-thakur commented on issue #1838: HADOOP-16711 Add way to skip verifyBuckets check in S3A fs init()

2020-02-19 Thread GitBox
mukund-thakur commented on issue #1838: HADOOP-16711 Add way to skip 
verifyBuckets check in S3A fs init()
URL: https://github.com/apache/hadoop/pull/1838#issuecomment-588400930
 
 
   > Two tests are failing. Will debug. Also will rebase from trunk and fix 
merge conflicts.
   Fixed merge conflicts. Above tests are succeeding now. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] mukund-thakur commented on issue #1838: HADOOP-16711 Add way to skip verifyBuckets check in S3A fs init()

2020-02-19 Thread GitBox
mukund-thakur commented on issue #1838: HADOOP-16711 Add way to skip 
verifyBuckets check in S3A fs init()
URL: https://github.com/apache/hadoop/pull/1838#issuecomment-588323865
 
 
   Two tests are failing. Will debug. Also will rebase from trunk and fix merge 
conflicts. 
   
   > [INFO] Running org.apache.hadoop.fs.contract.s3a.ITestS3AContractRootDir
   [ERROR] Tests run: 9, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 
48.592 s <<< FAILURE! - in 
org.apache.hadoop.fs.contract.s3a.ITestS3AContractRootDir
   [ERROR] 
testListEmptyRootDirectory(org.apache.hadoop.fs.contract.s3a.ITestS3AContractRootDir)
  Time elapsed: 15.053 s  <<< FAILURE!
   java.lang.AssertionError: 
   Expected no results from listLocatedStatus(/), but got 1 elements:
   S3ALocatedFileStatus{path=s3a://mthakur-data/fork-0002; isDirectory=true; 
modification_time=1582129763970; access_time=0; owner=mthakur; group=mthakur; 
permission=rwxrwxrwx; isSymlink=false; hasAcl=false; isEncrypted=true; 
isErasureCoded=false}[eTag='', versionId='']
at org.junit.Assert.fail(Assert.java:88)
at 
org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.assertNoElements(AbstractContractRootDirectoryTest.java:218)
at 
org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.testListEmptyRootDirectory(AbstractContractRootDirectoryTest.java:202)
at 
org.apache.hadoop.fs.contract.s3a.ITestS3AContractRootDir.testListEmptyRootDirectory(ITestS3AContractRootDir.java:82)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)
   [ERROR] 
testSimpleRootListing(org.apache.hadoop.fs.contract.s3a.ITestS3AContractRootDir)
  Time elapsed: 0.819 s  <<< FAILURE!
   java.lang.AssertionError: 
   listStatus(/) vs listLocatedStatus(/) with 
   listStatus =S3AFileStatus{path=s3a://mthakur-data/test; isDirectory=true; 
modification_time=0; access_time=0; owner=mthakur; group=mthakur; 
permission=rwxrwxrwx; isSymlink=false; hasAcl=false; isEncrypted=true; 
isErasureCoded=false} isEmptyDirectory=FALSE eTag=null versionId=null 
listLocatedStatus = S3ALocatedFileStatus{path=s3a://mthakur-data/fork-0002; 
isDirectory=true; modification_time=1582129765040; access_time=0; 
owner=mthakur; group=mthakur; permission=rwxrwxrwx; isSymlink=false; 
hasAcl=false; isEncrypted=true; isErasureCoded=false}[eTag='', versionId='']
   S3ALocatedFileStatus{path=s3a://mthakur-data/test; isDirectory=true; 
modification_time=1582129765040; access_time=0; owner=mthakur; group=mthakur; 
permission=rwxrwxrwx; isSymlink=false; hasAcl=false; isEncrypted=true; 
isErasureCoded=false}[eTag='', versionId=''] expected:<1> but was:<2>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at 
org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.testSimpleRootListing(AbstractContractRootDirectoryTest.java:235)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runner

[GitHub] [hadoop] mukund-thakur commented on issue #1838: HADOOP-16711 Add way to skip verifyBuckets check in S3A fs init()

2020-02-12 Thread GitBox
mukund-thakur commented on issue #1838: HADOOP-16711 Add way to skip 
verifyBuckets check in S3A fs init()
URL: https://github.com/apache/hadoop/pull/1838#issuecomment-585086587
 
 
   All review comments addressed. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] mukund-thakur commented on issue #1838: HADOOP-16711 Add way to skip verifyBuckets check in S3A fs init()

2020-02-11 Thread GitBox
mukund-thakur commented on issue #1838: HADOOP-16711 Add way to skip 
verifyBuckets check in S3A fs init()
URL: https://github.com/apache/hadoop/pull/1838#issuecomment-584804743
 
 
   
   > if closing the `fs` value triggers failures in superclass cleanup, then 
you are sharing an FS instance between test cases. (i.e you are actually 
picking up the last one created). 
   That is fixed now. That was a mistake from my side. Closing "fs" is not 
causing any problem in superclass cleanup now. 
   One other thing to notice here is there is only one test case where the 'fs' 
is actually created. All others are just failure scenarios.
   
   > If you disable caching you should get a new one, which you can then close 
safely
   Already disabled file system caching.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org