[GitHub] [hadoop] riyakhdl commented on a diff in pull request #4960: YARN-6766 HelperMethod added in AppsBlock class

2022-10-07 Thread GitBox 


riyakhdl commented on code in PR #4960:
URL: https://github.com/apache/hadoop/pull/4960#discussion_r990219411


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java:
##
@@ -129,6 +129,12 @@ protected Boolean hasAccess(RMApp app, HttpServletRequest 
hsr) {
 return true;
   }
 
+  private static String printAppInfo(long appInfoFunc) {

Review Comment:
   yes I agree, will do the changes.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] riyakhdl commented on a diff in pull request #4960: YARN-6766 HelperMethod added in AppsBlock class

2022-10-05 Thread GitBox 


riyakhdl commented on code in PR #4960:
URL: https://github.com/apache/hadoop/pull/4960#discussion_r985277193


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java:
##
@@ -128,8 +128,15 @@ protected Boolean hasAccess(RMApp app, HttpServletRequest 
hsr) {
 }
 return true;
   }
-
-
+  private long appInfoFunc;
+  public String printData(long appInfoFunc) {
+this.appInfoFunc=appInfoFunc;

Review Comment:
   Was doing this to resolve the error : 'appInfoFunc' hides a field. 
[HiddenField]



##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java:
##
@@ -128,8 +128,15 @@ protected Boolean hasAccess(RMApp app, HttpServletRequest 
hsr) {
 }
 return true;
   }
-
-
+  private long appInfoFunc;
+  public String printData(long appInfoFunc) {
+this.appInfoFunc=appInfoFunc;

Review Comment:
   Was doing this to resolve the error : 'appInfoFunc' hides a field. 
[HiddenField]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org