[GitHub] [hadoop] sauraank commented on a diff in pull request #4965: HADOOP-18156. Address JavaDoc warnings in classes like MarkerTool, S3ObjectAttributes, etc

[GitBox]

sauraank commented on code in PR #4965:
URL: https://github.com/apache/hadoop/pull/4965#discussion_r993296981


##
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/DirMarkerTracker.java:
##
@@ -34,20 +34,20 @@
  * Tracks directory markers which have been reported in object listings.
  * This is needed for auditing and cleanup, including during rename
  * operations.
- * 
+ *

Review Comment:
   Thanks Steve! Will work on your recommended changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] sauraank commented on a diff in pull request #4965: HADOOP-18156. Address JavaDoc warnings in classes like MarkerTool, S3ObjectAttributes, etc

[GitBox]

sauraank commented on code in PR #4965:
URL: https://github.com/apache/hadoop/pull/4965#discussion_r991125644


##
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java:
##
@@ -960,43 +960,64 @@ public static final class ScanArgsBuilder {
 /** Consider only markers in nonauth paths as errors. */
 private boolean nonAuth = false;
 
-/** Source FS; must be or wrap an S3A FS. */
+/** Source FS; must be or wrap an S3A FS.

Review Comment:
   Started all the comments from new line MarkerTool.java. Thanks Mukund and 
Danny for the feedback.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org