[GitHub] [hadoop] slfan1989 commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler
slfan1989 commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1575969505 @leixm Thank you for your contribution! I will merge this PR into the trunk branch. @ashutoshcipher @aajisaka If you have any new suggestions, feel free to bring them up anytime. Thanks again for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler
slfan1989 commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1569562918 @leixm Thanks for the contribution! LGTM. @aajisaka @ashutoshcipher Can you help to review this PR again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4797: YARN-11277. trigger log-dir deletion by size for NonAggregatingLogHandler
slfan1989 commented on PR #4797: URL: https://github.com/apache/hadoop/pull/4797#issuecomment-1226681435 @leixm Fix CheckStyle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
