[GitHub] [hadoop] slfan1989 commented on pull request #4928: HADOOP-18360. Update commons-csv from 1.0 to 1.9.0.
slfan1989 commented on PR #4928: URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1277156262 @ayushtkn Thank you very much for your help to review the code and merge the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4928: HADOOP-18360. Update commons-csv from 1.0 to 1.9.0.
slfan1989 commented on PR #4928: URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1277066147 @ayushtkn Thanks a lot for your help reviewing the code, I double checked the commons-csv version upgrade (1.0 to 1.9.0) and it should work. The junit test error has nothing to do with the upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4928: HADOOP-18360. Update commons-csv from 1.0 to 1.9.0.
slfan1989 commented on PR #4928: URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1272784477 > Thank you very much for your help reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4928: HADOOP-18360. Update commons-csv from 1.0 to 1.9.0.
slfan1989 commented on PR #4928: URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1272339219 @ayushtkn Can you help review this pr? I think an upgrade is still necessary. For the deprecated method, I also made a replacement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4928: HADOOP-18360. Update commons-csv from 1.0 to 1.9.0.
slfan1989 commented on PR #4928: URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1264773924 @ayushtkn Can you help review this pr? I think an upgrade is still necessary. For the deprecated method, I also made a replacement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
