steveloughran commented on a change in pull request #2133:
URL: https://github.com/apache/hadoop/pull/2133#discussion_r467936082
##
File path:
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java
##
@@ -177,6 +177,44 @@ public void testPreserveStatus() throws IOException {
conf.unset(DistCpConstants.CONF_LABEL_PRESERVE_STATUS);
}
+ }
+ @Test
Review comment:
add newline
##
File path:
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java
##
@@ -160,10 +160,10 @@ public void testPreserveStatus() throws IOException {
context.setTargetPathExists(false);
CopyListing listing = new GlobbedCopyListing(conf, CREDENTIALS);
- Path listingFile = new Path("/tmp1/" + String.valueOf(rand.nextLong()));
+ Path listingFile = new Path("/tmp1/" + rand.nextLong());
Review comment:
do the same on lines 168 and 206
##
File path:
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java
##
@@ -177,6 +177,44 @@ public void testPreserveStatus() throws IOException {
conf.unset(DistCpConstants.CONF_LABEL_PRESERVE_STATUS);
}
+ }
+ @Test
+ public void testPreserveStatusWithAtomicCommit() throws IOException {
+TaskAttemptContext taskAttemptContext = getTaskAttemptContext(config);
+JobContext jobContext = new
JobContextImpl(taskAttemptContext.getConfiguration(),
+taskAttemptContext.getTaskAttemptID().getJobID());
+Configuration conf = jobContext.getConfiguration();
+String sourceBase;
+String workBase;
+String targetBase;
+FileSystem fs = null;
+try {
+ OutputCommitter committer = new CopyCommitter(null, taskAttemptContext);
+ fs = FileSystem.get(conf);
+ FsPermission sourcePerm = new FsPermission((short) 511);
+ FsPermission initialPerm = new FsPermission((short) 448);
+ sourceBase = TestDistCpUtils.createTestSetup(fs, sourcePerm);
+ workBase = TestDistCpUtils.createTestSetup(fs, initialPerm);
+ targetBase = "/tmp1/" + String.valueOf(rand.nextLong());
+ final DistCpOptions options = new DistCpOptions.Builder(
+ Collections.singletonList(new Path(sourceBase)), new
Path("/out"))
+ .preserve(FileAttribute.PERMISSION).build();
+ options.appendToConf(conf);
+ final DistCpContext context = new DistCpContext(options);
+ context.setTargetPathExists(false);
+ CopyListing listing = new GlobbedCopyListing(conf, CREDENTIALS);
+ Path listingFile = new Path("/tmp1/" + String.valueOf(rand.nextLong()));
+ listing.buildListing(listingFile, context);
+ conf.set(DistCpConstants.CONF_LABEL_TARGET_FINAL_PATH, targetBase);
Review comment:
you can do a static import for these constants if it keeps the code
cleaner
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
