[GitHub] [hadoop] steveloughran commented on a change in pull request #2411: HADOOP-17324. Don't relocate org.bouncycastle in shaded client jars

[GitBox]

steveloughran commented on a change in pull request #2411:
URL: https://github.com/apache/hadoop/pull/2411#discussion_r520671724



##
File path: 
hadoop-client-modules/hadoop-client-integration-tests/src/test/java/org/apache/hadoop/example/ITUseMiniCluster.java
##
@@ -73,13 +78,22 @@ public void clusterUp() throws IOException {
 .numDataNodes(3)
 .build();
 cluster.waitActive();
+
+conf.set("yarn.scheduler.capacity.root.queues", "default");

Review comment:
   it may be test only, but the other test suite may have its own configs 
that it wants. If we put them in the test JAR, it becomes near impossible to 
change. People will hate us (more)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] steveloughran commented on a change in pull request #2411: HADOOP-17324. Don't relocate org.bouncycastle in shaded client jars

[GitBox]

steveloughran commented on a change in pull request #2411:
URL: https://github.com/apache/hadoop/pull/2411#discussion_r519821934



##
File path: 
hadoop-client-modules/hadoop-client-integration-tests/src/test/java/org/apache/hadoop/example/ITUseMiniCluster.java
##
@@ -44,6 +44,10 @@
 import org.apache.hadoop.hdfs.web.WebHdfsTestUtil;
 import org.apache.hadoop.hdfs.web.WebHdfsConstants;
 
+import org.apache.hadoop.yarn.server.MiniYARNCluster;
+
+import static org.junit.Assert.assertTrue;

Review comment:
   unused, according to checkstyle

##
File path: 
hadoop-client-modules/hadoop-client-integration-tests/src/test/java/org/apache/hadoop/example/ITUseMiniCluster.java
##
@@ -44,6 +44,10 @@
 import org.apache.hadoop.hdfs.web.WebHdfsTestUtil;
 import org.apache.hadoop.hdfs.web.WebHdfsConstants;
 
+import org.apache.hadoop.yarn.server.MiniYARNCluster;

Review comment:
   should go straight after line 45 - no gap

##
File path: 
hadoop-client-modules/hadoop-client-integration-tests/src/test/java/org/apache/hadoop/example/ITUseMiniCluster.java
##
@@ -73,13 +78,22 @@ public void clusterUp() throws IOException {
 .numDataNodes(3)
 .build();
 cluster.waitActive();
+
+conf.set("yarn.scheduler.capacity.root.queues", "default");

Review comment:
   we leave out all of test/resources to stop log4j files, site configs etc 
getting onto the classpath of apps downstream -so making it impossible for them 
to choose their own options

##
File path: 
hadoop-client-modules/hadoop-client-integration-tests/src/test/java/org/apache/hadoop/example/ITUseMiniCluster.java
##
@@ -73,13 +78,22 @@ public void clusterUp() throws IOException {
 .numDataNodes(3)
 .build();
 cluster.waitActive();
+
+conf.set("yarn.scheduler.capacity.root.queues", "default");
+conf.setInt("yarn.scheduler.capacity.root.default.capacity", 100);
+yarnCluster = new MiniYARNCluster(getClass().getName(), 1, 1, 1, 1);
+yarnCluster.init(conf);
+yarnCluster.start();
   }
 
   @After
   public void clusterDown() {
 if (cluster != null) {
   cluster.close();
 }
+if (yarnCluster != null) {

Review comment:
   all services are closeable, so use `IOUtil.cleanupWithLogger()` & let it 
handle null checks and exceptions





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org