[GitHub] [hadoop] steveloughran commented on pull request #2742: HADOOP-16721. Improve S3A rename resilience

2021-03-10 Thread GitBox


steveloughran commented on pull request #2742:
URL: https://github.com/apache/hadoop/pull/2742#issuecomment-795612632


   ah, thanks -lovely. just tweaked the imports slightly for better 
backporting; I'll merge once the next compile is good, then do a cp and retest 
for branch-3.3. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] steveloughran commented on pull request #2742: HADOOP-16721. Improve S3A rename resilience

2021-03-10 Thread GitBox


steveloughran commented on pull request #2742:
URL: https://github.com/apache/hadoop/pull/2742#issuecomment-795576948


   testing: s3 london, most recently with `-Dparallel-tests 
-DtestsThreadCount=6 -Dmarkers=keep -Ds3guard -Ddynamo  -Dscale`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] steveloughran commented on pull request #2742: HADOOP-16721. Improve S3A rename resilience

2021-03-08 Thread GitBox


steveloughran commented on pull request #2742:
URL: https://github.com/apache/hadoop/pull/2742#issuecomment-793030939


   Testing: s3 london with markers==keep and delete, s3guard on and off.
   
   * change in error reporting of s3a FS matched with relevant changes in 
s3a.xml for contract tests.
   * skip tests verifying that you can't rename 2+ levels under a file.
   * Failures related to endpoints of common-crawl and  
ITestAssumeRole.testAssumeRoleBadInnerAuth: known and fixed in #2675. 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] steveloughran commented on pull request #2742: HADOOP-16721. Improve S3A rename resilience

2021-03-04 Thread GitBox


steveloughran commented on pull request #2742:
URL: https://github.com/apache/hadoop/pull/2742#issuecomment-790807398


   Testing with  -Dparallel-tests -DtestsThreadCount=8 -Dmarkers=keep -Dscale
   
   If the store is set to raise exceptions, a lot of tests which expect 
rename(bad options) to return false now get exceptions. One of the contract 
tests would downgrade if the raised exception was FileAlreadyExistsException 
and the contract xml said that was ok. I'm reluctant to go with a bigger patch.
   
   this PR is so that Hive and friends can get better reporting on errors, 
rather than have them lost. It will be optional



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org