[GitHub] [hadoop] steveloughran commented on pull request #2852: MAPREDUCE-7287. Distcp will delete exists file , If we use "-delete …
steveloughran commented on pull request #2852: URL: https://github.com/apache/hadoop/pull/2852#issuecomment-850622019 ``` [INFO] T E S T S [INFO] --- [INFO] Running org.apache.hadoop.fs.contract.s3a.ITestS3AContractDistCp [INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 634.789 s - in org.apache.hadoop.fs.contract.s3a.ITestS3AContractDistCp [INFO] [INFO] Results: [INFO] [INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 10:48 min [INFO] Finished at: 2021-05-28T20:14:42+01:00 [INFO] and [INFO] Running org.apache.hadoop.fs.azurebfs.contract.ITestAbfsFileSystemContractDistCp [INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 577.782 s - in org.apache.hadoop.fs.azurebfs.contract.ITestAbfsFileSystemContractDistCp [INFO] [INFO] Results: [INFO] [INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 09:47 min [INFO] Finished at: 2021-05-28T20:15:03+01:00 [INFO] ``` so: tests are happy, +1 from me, given @ayushtkn's approval of the production code. merging to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2852: MAPREDUCE-7287. Distcp will delete exists file , If we use "-delete …
steveloughran commented on pull request #2852: URL: https://github.com/apache/hadoop/pull/2852#issuecomment-850594871 let me actually check out and do the s3a and abfs tests here, given the author has gone to the effort of writing them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2852: MAPREDUCE-7287. Distcp will delete exists file , If we use "--delete …
steveloughran commented on pull request #2852: URL: https://github.com/apache/hadoop/pull/2852#issuecomment-818046355 OK, If @ayushtkn is happy, I'm happy. One thought: could we add a test for a file copy to AbstractContractDistCpTest ? This is the one we do for the object stores, and it might be good to have a file-file distcp test involving them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2852: MAPREDUCE-7287. Distcp will delete exists file , If we use "--delete …
steveloughran commented on pull request #2852: URL: https://github.com/apache/hadoop/pull/2852#issuecomment-812887968 going to have to pull in people who know more of the distcp code to review this, in particular, someone needs to understand what the code being removed is meant to be doing. Tests look excellent, BTW. @ayushtkn -you got time to look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
