[GitHub] [hadoop] steveloughran commented on pull request #5767: HADOOP-18708. Adds in CSE.
steveloughran commented on PR #5767: URL: https://github.com/apache/hadoop/pull/5767#issuecomment-1713917297 @ahmarsuhail can you rebase this -we need to get it in ASAP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #5767: HADOOP-18708. Adds in CSE.
steveloughran commented on PR #5767: URL: https://github.com/apache/hadoop/pull/5767#issuecomment-1658601723 thought: we should add a test to verify backwards compat with CSE v1. proposed: src/test/resources to include a small binary file of CSE data, which is uploaded to s3 and then downloaded on a client with CSE and the same secrets. would that work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #5767: HADOOP-18708. Adds in CSE.
steveloughran commented on PR #5767: URL: https://github.com/apache/hadoop/pull/5767#issuecomment-164358 + @mehakmeet should review this too. @ahmarsuhail : side issue. does the cse algorithm implementation complain about it being a bad algorithm, as the v1 sdk does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #5767: HADOOP-18708. Adds in CSE.
steveloughran commented on PR #5767: URL: https://github.com/apache/hadoop/pull/5767#issuecomment-1643587230 I'm thinking this move is time to revisit my refactoring plans and actually split s3afs into two layers, filesystem and store, as abfs does. we'd have all those callback interfaces done in the store class, which would also contain the threadpool, transfer manager etc -and all those `inner*()` ops in s3a fs would move down with the audit context passed in as an explicit param. lets make sure this pr is ready for it by using an interface for callbacks to create s3 client, ideally even invoke the region call. that way we can hide these classes from the details of the SDK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #5767: HADOOP-18708. Adds in CSE.
steveloughran commented on PR #5767: URL: https://github.com/apache/hadoop/pull/5767#issuecomment-1643555337 sorry, I'd missed this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
