[GitHub] [hadoop] sungpeo commented on a change in pull request #1942: MAPREDUCE-7270. TestHistoryViewerPrinter could be failed when the locale isn't English.
sungpeo commented on a change in pull request #1942: URL: https://github.com/apache/hadoop/pull/1942#discussion_r590794948 ## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestHistoryViewerPrinter.java ## @@ -43,6 +46,19 @@ private final String LINE_SEPARATOR = System.lineSeparator(); + private static Locale DEFAULT_LOCALE; Review comment: Sorry to confuse you. I worried that the result of `Locale.getDefault()` might be changed. But I get it I don't have to. I'll push the change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] sungpeo commented on a change in pull request #1942: MAPREDUCE-7270. TestHistoryViewerPrinter could be failed when the locale isn't English.
sungpeo commented on a change in pull request #1942: URL: https://github.com/apache/hadoop/pull/1942#discussion_r589162197 ## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestHistoryViewerPrinter.java ## @@ -43,6 +46,19 @@ private final String LINE_SEPARATOR = System.lineSeparator(); + private static Locale DEFAULT_LOCALE; Review comment: @liuml07 I think the static DEFAULT_LOCALE which could be stale during other test suites or settings, because, the DEFAULT_LOCALE will be set before all of the tests. What do you think about? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] sungpeo commented on a change in pull request #1942: MAPREDUCE-7270. TestHistoryViewerPrinter could be failed when the locale isn't English.
sungpeo commented on a change in pull request #1942: URL: https://github.com/apache/hadoop/pull/1942#discussion_r493178495 ## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestHistoryViewerPrinter.java ## @@ -43,6 +46,19 @@ private final String LINE_SEPARATOR = System.lineSeparator(); + private Locale defaultLocale; + + @Before Review comment: @liuml07 Okay, I will push that changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] sungpeo commented on a change in pull request #1942: MAPREDUCE-7270. TestHistoryViewerPrinter could be failed when the locale isn't English.
sungpeo commented on a change in pull request #1942: URL: https://github.com/apache/hadoop/pull/1942#discussion_r493178495 ## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestHistoryViewerPrinter.java ## @@ -43,6 +46,19 @@ private final String LINE_SEPARATOR = System.lineSeparator(); + private Locale defaultLocale; + + @Before Review comment: @liuml07 Okay, I will push that changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
