[GitHub] [hadoop] tomscut commented on pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease
tomscut commented on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1082701523 Thanks @Hexiaoqiao and @ayushtkn . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease
tomscut commented on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1079932303 > @tomscut Please check if the failed unit test is related with this changes. Hi @Hexiaoqiao , the failed unit test is unrelated to the change, and has been run locally multiple times with good results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease
tomscut commented on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1077029230 Hi @Hexiaoqiao @tasanuma @ferhui , could you also please review this? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease
tomscut commented on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1074573849 Hi @ayushtkn , I fixed the problem you mentioned, please have a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease
tomscut commented on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1073611615 > Had a quick look, prod change makes sense to me, the `datanodeManager.getDatanode(nodeID)` methods shows it can register null, if the node isn't found. > > The test is little complex and isn't showing some actual scenario. If this issue is caused by some delay or race condition, will mocking something to create some delays and so help? > > Try to get a test which shows the actual scenario, I found it really hard to follow this test. If nothing helps, the worst would be add some comments explaining things in details in the test Thank you @ayushtkn very much for your review and detailed suggestions. I will update the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease
tomscut commented on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1073569715 Hi @ayushtkn @Hexiaoqiao @ferhui , please take a look at this. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease
tomscut commented on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1069166429 Hi @ayushtkn , please take a look. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease
tomscut commented on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1067636025 Hi @jojochuang @tasanuma @ayushtkn @Hexiaoqiao @ferhui , could you please review this PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease
tomscut commented on pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#issuecomment-1064772957 Hi @jojochuang @tamaashu @ayushtkn , could you please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
