[GitHub] [hadoop] vinayakumarb commented on issue #1496: HADOOP-16560. [YARN] use protobuf-maven-plugin to generat…
vinayakumarb commented on issue #1496: HADOOP-16560. [YARN] use protobuf-maven-plugin to generat… URL: https://github.com/apache/hadoop/pull/1496#issuecomment-534406503 > The javadoc warning is from generated source? I believe we should skip the checks on the generated files? Yes, there are many javac warnings are coming from generate source. Guess some API is deprecated, but generator still uses them. (may be because of syntax=proto2). I guess that's fine. Just need to make sure, we dont use any of these deprecated code in other sources. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] vinayakumarb commented on issue #1496: HADOOP-16560. [YARN] use protobuf-maven-plugin to generat…
vinayakumarb commented on issue #1496: HADOOP-16560. [YARN] use protobuf-maven-plugin to generat… URL: https://github.com/apache/hadoop/pull/1496#issuecomment-534198227 Test failures seems to be unrelated. Please re-check. javac error is mostly due to change in the location of the test proto file as mentioned above. +1 pending whitespace corrections. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
