[GitHub] [hadoop] virajjasani commented on pull request #2823: HDFS-15926 : Remove duplicate dependency of hadoop-annotations
virajjasani commented on pull request #2823: URL: https://github.com/apache/hadoop/pull/2823#issuecomment-809343337 Thanks @ayushtkn , the change directly applies to branch-3.3, 3.2, 3.1 and 2.10. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #2823: HDFS-15926 : Remove duplicate dependency of hadoop-annotations
virajjasani commented on pull request #2823: URL: https://github.com/apache/hadoop/pull/2823#issuecomment-809078398 Sure, Thanks @ayushtkn . I just scanned `hadoop-common` as well as other poms with parent defined as `hadoop-project-dist` and no one other than `hadoop-hdfs` has this dependency defined as `provided` scope, hence it is duplicate only for `hadoop-hdfs` (with same `provided` scope as defined in parent pom). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #2823: HDFS-15926 : Remove duplicate dependency of hadoop-annotations
virajjasani commented on pull request #2823: URL: https://github.com/apache/hadoop/pull/2823#issuecomment-808865841 It's coming through parent pom `hadoop-project-dist` defined [here](https://github.com/apache/hadoop/blob/e5de76a686c9870413890c8256c9fc04a72abe1b/hadoop-hdfs-project/hadoop-hdfs/pom.xml#L20-L25) It is declared [here](https://github.com/apache/hadoop/blob/trunk/hadoop-project-dist/pom.xml#L54-L58) and since it is coming from parent pom, it's duplicate for `hadoop-hdfs` pom. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #2823: HDFS-15926 : Remove duplicate dependency of hadoop-annotations
virajjasani commented on pull request #2823: URL: https://github.com/apache/hadoop/pull/2823#issuecomment-808851022 @liuml07 @ayushtkn whenever you have some cycles to take a look, this is a small change anyways. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
