[GitHub] [hadoop] virajjasani commented on pull request #2927: HDFS-15982. Deleted data using HTTP API should be saved to the trash

2021-05-04 Thread GitBox


virajjasani commented on pull request #2927:
URL: https://github.com/apache/hadoop/pull/2927#issuecomment-831772909


   Agree, new Configuration and FileSystem object creation might cost bit of 
performance and more objects for GC. I will be on lookout for any other 
alternatives. Thanks for the reviews @jojochuang @smengcl @liuml07 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] virajjasani commented on pull request #2927: HDFS-15982. Deleted data using HTTP API should be saved to the trash

2021-04-29 Thread GitBox


virajjasani commented on pull request #2927:
URL: https://github.com/apache/hadoop/pull/2927#issuecomment-829285381


   @smengcl This is hadoop-3.3 backport PR #2925 and I have kept it upto date 
while addressing review comments.
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] virajjasani commented on pull request #2927: HDFS-15982. Deleted data using HTTP API should be saved to the trash

2021-04-28 Thread GitBox


virajjasani commented on pull request #2927:
URL: https://github.com/apache/hadoop/pull/2927#issuecomment-828221673


   @smengcl would you like to take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] virajjasani commented on pull request #2927: HDFS-15982. Deleted data using HTTP API should be saved to the trash

2021-04-26 Thread GitBox


virajjasani commented on pull request #2927:
URL: https://github.com/apache/hadoop/pull/2927#issuecomment-826905704


   @liuml07 done with changes if you would like to review further.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] virajjasani commented on pull request #2927: HDFS-15982. Deleted data using HTTP API should be saved to the trash

2021-04-23 Thread GitBox


virajjasani commented on pull request #2927:
URL: https://github.com/apache/hadoop/pull/2927#issuecomment-825838746


   > Thanks for updating. I like the UI support; it's very handy.
   > 
   > If we want to close https://issues.apache.org/jira/browse/HDFS-14320 and 
move on with this patch, I think we need to update the WebHDFS doc as well 
(HttpFs is using the same API so no separate doc I assume).
   
   Oh, you mean we should update `WebHDFS.md` right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org