[GitHub] [hadoop] virajjasani commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module
virajjasani commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1576042837 Requesting review on the new PR #5717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module
virajjasani commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1574535578 Thank you @jojochuang @Apache9 `TestRouterNamenodeMonitoring` was recently updated and it is broken while resolving conflicts with this PR, here is the addendum PR to fix it: https://github.com/apache/hadoop/pull/5713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module
virajjasani commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1574208866 Thank you @Apache9! WDYT @jojochuang @steveloughran ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module
virajjasani commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1572529082 resolving merge conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module
virajjasani commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1555018381 no problem @Hexiaoqiao, thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module
virajjasani commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1536941176 FYI @Hexiaoqiao if you have bandwidth to review. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module
virajjasani commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1529974198 @goiri @tasanuma if you have bandwidth, could you please take a look? this is one of the sub-tasks for log4j 1 to 2 migration. One of the goals is to move as much core log4j usage to a new module as possible to reduce the amount of code changes required for log4j2 upgrade. Parent Jira is HADOOP-16206. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module
virajjasani commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1499384581 @steveloughran @jojochuang I have asked for reviewers on the parent Jira HADOOP-16206 but no luck so far. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module
virajjasani commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1483577856 The test failures are not relevant, they are also found on https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/1175/testReport/ and https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/1174/testReport/ (and so on) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module
virajjasani commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1483178044 I have also built tarball, deployed to a k8s cluster, started NN, DN, JN, Zkfc, RM, NM, HS daemons and the logs look good so far. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #5503: HADOOP-18207. Introduce hadoop-logging module
virajjasani commented on PR #5503: URL: https://github.com/apache/hadoop/pull/5503#issuecomment-1482085415 Checkstyle and test failures are not relevant, they are present with old code. @Apache9 @jojochuang @steveloughran could you please review this PR? This is important sub-task for log4j2 upgrade. The Jenkins build results would take ~20 hr as this change touches so many modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
