[GitHub] [hadoop] xiaoyuyao commented on pull request #2259: HADOOP-17208. LoadBalanceKMSClientProvider#deleteKey should invalidat…

2020-09-11 Thread GitBox 


xiaoyuyao commented on pull request #2259:
URL: https://github.com/apache/hadoop/pull/2259#issuecomment-691368970


   Thanks @Hexiaoqiao and @jiwq for the review. The LBKMSCP is tricky to unit 
test within MiniCluster environment. The scenario here fits better for an 
end-to-end test that requires multiple KMS server instances to work with JCEKS, 
which does not have consistency guarantee like Ranger KMS. I would suggest open 
a separate ticket to add end-to-end test for KMS-HA, some of this can be 
implemented with docker based tests under junit. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] xiaoyuyao commented on pull request #2259: HADOOP-17208. LoadBalanceKMSClientProvider#deleteKey should invalidat…

2020-09-12 Thread GitBox 


xiaoyuyao commented on pull request #2259:
URL: https://github.com/apache/hadoop/pull/2259#issuecomment-691368970







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] xiaoyuyao commented on pull request #2259: HADOOP-17208. LoadBalanceKMSClientProvider#deleteKey should invalidat…

2020-09-12 Thread GitBox 


xiaoyuyao commented on pull request #2259:
URL: https://github.com/apache/hadoop/pull/2259#issuecomment-691368970







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org