Re: [PR] HDFS-17520. [BugFix] TestDFSAdmin.testAllDatanodesReconfig and TestDFSAdmin.testDecommissionDataNodesReconfig failed [hadoop]
slfan1989 merged PR #6812: URL: https://github.com/apache/hadoop/pull/6812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
Re: [PR] HDFS-17520. [BugFix] TestDFSAdmin.testAllDatanodesReconfig and TestDFSAdmin.testDecommissionDataNodesReconfig failed [hadoop]
slfan1989 commented on PR #6812: URL: https://github.com/apache/hadoop/pull/6812#issuecomment-2106716295 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
Re: [PR] HDFS-17520. [BugFix] TestDFSAdmin.testAllDatanodesReconfig and TestDFSAdmin.testDecommissionDataNodesReconfig failed [hadoop]
hadoop-yetus commented on PR #6812: URL: https://github.com/apache/hadoop/pull/6812#issuecomment-2105927891 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 00s | | No case conflicting files found. | | +0 :ok: | spotbugs | 0m 01s | | spotbugs executables are not available. | | +0 :ok: | codespell | 0m 01s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 01s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 00s | | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 00s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 94m 54s | | trunk passed | | +1 :green_heart: | compile | 6m 43s | | trunk passed | | +1 :green_heart: | checkstyle | 5m 06s | | trunk passed | | +1 :green_heart: | mvnsite | 6m 59s | | trunk passed | | +1 :green_heart: | javadoc | 6m 10s | | trunk passed | | +1 :green_heart: | shadedclient | 156m 39s | | branch has no errors when building and testing our client artifacts. | _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 00s | | the patch passed | | +1 :green_heart: | compile | 3m 44s | | the patch passed | | +1 :green_heart: | javac | 3m 44s | | the patch passed | | +1 :green_heart: | blanks | 0m 00s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 2m 27s | | the patch passed | | +1 :green_heart: | mvnsite | 4m 28s | | the patch passed | | +1 :green_heart: | javadoc | 4m 06s | | the patch passed | | +1 :green_heart: | shadedclient | 170m 16s | | patch has no errors when building and testing our client artifacts. | _ Other Tests _ | | +1 :green_heart: | asflicense | 6m 17s | | The patch does not generate ASF License warnings. | | | | 450m 52s | | | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hadoop/pull/6812 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets | | uname | MINGW64_NT-10.0-17763 17b2ed3cc898 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys | | Build tool | maven | | Personality | /c/hadoop/dev-support/bin/hadoop.sh | | git revision | trunk / 2d929bda295e05d4b7a3194a7dc311944b662661 | | Default Java | Azul Systems, Inc.-1.8.0_332-b09 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6812/1/testReport/ | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6812/1/console | | versions | git=2.45.0.windows.1 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
Re: [PR] HDFS-17520. [BugFix] TestDFSAdmin.testAllDatanodesReconfig and TestDFSAdmin.testDecommissionDataNodesReconfig failed [hadoop]
slfan1989 commented on PR #6812: URL: https://github.com/apache/hadoop/pull/6812#issuecomment-2105740105 > @slfan1989 Master, I see you are familiar with `testDecommissionDataNodesReconfig`, please help me review it. Thanks @ZanderXu Thank you for your contribution! I will reply later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
Re: [PR] HDFS-17520. [BugFix] TestDFSAdmin.testAllDatanodesReconfig and TestDFSAdmin.testDecommissionDataNodesReconfig failed [hadoop]
ZanderXu commented on PR #6812: URL: https://github.com/apache/hadoop/pull/6812#issuecomment-2105610789 @slfan1989 Master, I see you are familiar with `testDecommissionDataNodesReconfig`, please help me review it. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[PR] HDFS-17520. [BugFix] TestDFSAdmin.testAllDatanodesReconfig and TestDFSAdmin.testDecommissionDataNodesReconfig failed [hadoop]
ZanderXu opened a new pull request, #6812: URL: https://github.com/apache/hadoop/pull/6812 TestDFSAdmin.testAllDatanodesReconfig and TestDFSAdmin.testDecommissionDataNodesReconfig failed. [HDFS-17506](https://github.com/apache/hadoop/pull/6806) encountered this failed UT and the error message like: ``` [ERROR] Tests run: 21, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 44.521 s <<< FAILURE! - in org.apache.hadoop.hdfs.tools.TestDFSAdmin [ERROR] testAllDatanodesReconfig(org.apache.hadoop.hdfs.tools.TestDFSAdmin) Time elapsed: 2.086 s <<< FAILURE! java.lang.AssertionError: Expecting: <["Reconfiguring status for node [127.0.0.1:43731]: SUCCESS: Changed property dfs.datanode.peer.stats.enabled", "From: "false"", "To: "true"", "started at Fri May 10 13:02:51 UTC 2024 and finished at Fri May 10 13:02:51 UTC 2024."]> to contain subsequence: <["SUCCESS: Changed property dfs.datanode.peer.stats.enabled", "From: "false"", "To: "true""]> at org.apache.hadoop.hdfs.tools.TestDFSAdmin.testAllDatanodesReconfig(TestDFSAdmin.java:1286) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) ``` `getReconfigurationStatusUtil` concurrently get reconfiguration status from multiple DNs. It may cause messages in out is wrong, such as: ``` Line1: Reconfiguring status for node [127.0.0.1:65229]: Reconfiguring status for node [127.0.0.1:65224]: started at Sat May 11 15:05:49 CST 2024started at Sat May 11 15:05:49 CST 2024 and finished at Sat May 11 15:05:49 CST 2024. Line2: and finished at Sat May 11 15:05:49 CST 2024. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org