[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14506564#comment-14506564 ] Allen Wittenauer edited comment on HADOOP-11746 at 4/22/15 7:29 AM: I posted this on -dev, but to copy the status update here: * So far, HADOOP-11861 was filed which is luckily an extremely easy bug to fix. * There have been a few runs which seems to indicate that *something* is destroying the artifact directory in the middle of runs…. which is very very odd and something I hadn’t seen in any of my testing. In any case, I clearly need to add some safety code here to report back that something went awry and report back which node, console, etc this happened on. Someone more familiar with the Jenkins setup might be able to shed some light on why that might happen. All of these runs appear to be on H3, so might be related? Impacted issues with this have been: - HDFS-8200 (https://builds.apache.org/job/PreCommit-HDFS-Build/10335/) - HDFS-8147 (https://builds.apache.org/job/PreCommit-HDFS-Build/10338/) - YARN-3301 (https://builds.apache.org/job/PreCommit-YARN-Build/7441/) * Some sort of good news! The new mvn site test does appear to be capable of catching issues! YARN-3410 was committed just prior to the new test code and has markdown-to-html syntax issues. HADOOP-11627 (for example) shows the results. :D was (Author: aw): I posted this on -dev, but to copy the status update here: * So far, HADOOP-11627 was filed which is luckily an extremely easy bug to fix. * There have been a few runs which seems to indicate that *something* is destroying the artifact directory in the middle of runs…. which is very very odd and something I hadn’t seen in any of my testing. In any case, I clearly need to add some safety code here to report back that something went awry and report back which node, console, etc this happened on. Someone more familiar with the Jenkins setup might be able to shed some light on why that might happen. All of these runs appear to be on H3, so might be related? Impacted issues with this have been: - HDFS-8200 (https://builds.apache.org/job/PreCommit-HDFS-Build/10335/) - HDFS-8147 (https://builds.apache.org/job/PreCommit-HDFS-Build/10338/) - YARN-3301 (https://builds.apache.org/job/PreCommit-YARN-Build/7441/) * Some sort of good news! The new mvn site test does appear to be capable of catching issues! YARN-3410 was committed just prior to the new test code and has markdown-to-html syntax issues. HADOOP-11627 (for example) shows the results. :D rewrite test-patch.sh - Key: HADOOP-11746 URL: https://issues.apache.org/jira/browse/HADOOP-11746 Project: Hadoop Common Issue Type: Test Components: build, test Affects Versions: 3.0.0 Reporter: Allen Wittenauer Assignee: Allen Wittenauer Fix For: 2.8.0 Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch, HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch, HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch, HADOOP-11746-12.patch, HADOOP-11746-13.patch, HADOOP-11746-14.patch, HADOOP-11746-15.patch, HADOOP-11746-16.patch, HADOOP-11746-17.patch, HADOOP-11746-18.patch, HADOOP-11746-19.patch, HADOOP-11746-20.patch, HADOOP-11746-21.branch-2.patch, HADOOP-11746-21.patch This code is bad and you should feel bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502467#comment-14502467 ] Allen Wittenauer edited comment on HADOOP-11746 at 4/20/15 7:51 AM: bq. I found that surprising, as compared to say -0 since in those cases the QA bot can't judge the suitability of the patch. This is actually how the old test-patch.sh works as well. I tend to agree with the -1 because if the base universe is broken, it really can't judge how well the patch is going to work either. The +1's are going to be false flags. bq. The rewrite is a great improvement. Any idea what else you want to cover before pushing? Thanks! Not really planning on more changes. Playing around with HADOOP-11843 (which upgraded shellcheck) and realizing I hadn't exercised the site tests yet popped up the problems fixed in -19. At this point, I think all the subsystems have been thoroughly worked (at least by me) so any outstanding issues will likely be edge case bugs and/or issues with the Jenkins build environment. [There are one or two more optimizations I could make in site tests, but since those run so quickly anyway, they aren't a big concern.] was (Author: aw): bq. I found that surprising, as compared to say -0 since in those cases the QA bot can't judge the suitability of the patch. This is actually how the old test-patch.sh works as well. I tend to agree with the -1 because if the base universe is broken, it really can't judge how well the patch is going to work either. The +1's are going to be false flags. bq. The rewrite is a great improvement. Any idea what else you want to cover before pushing? Thanks! Not really. Playing around with HADOOP-11843 (which upgraded shellcheck) and realizing I hadn't exercised the site tests yet popped up the problems fixed in -19. At this point, I think all the subsystems have been thoroughly worked (at least by me) so any outstanding issues will likely be edge case bugs and/or issues with the Jenkins build environment. [There are one or two more optimizations I could make in site tests, but since those run so quickly anyway, they aren't a big concern.] rewrite test-patch.sh - Key: HADOOP-11746 URL: https://issues.apache.org/jira/browse/HADOOP-11746 Project: Hadoop Common Issue Type: Test Components: build, test Affects Versions: 3.0.0 Reporter: Allen Wittenauer Assignee: Allen Wittenauer Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch, HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch, HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch, HADOOP-11746-12.patch, HADOOP-11746-13.patch, HADOOP-11746-14.patch, HADOOP-11746-15.patch, HADOOP-11746-16.patch, HADOOP-11746-17.patch, HADOOP-11746-18.patch, HADOOP-11746-19.patch This code is bad and you should feel bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502068#comment-14502068 ] Allen Wittenauer edited comment on HADOOP-11746 at 4/19/15 7:21 PM: -19: * Merged in the fixes from HADOOP-11845, otherwise rat checks fail because mvn site generates a file that violates rat * shellcheck test reports version of shellcheck * shellcheck find command was very broken * upgraded my local copy of shellcheck, which now includes some new checks. fixed errors from those new checks (mainly local blah=subshell issues) * somewhere along the way, the value of the initial cwd got screwed up. * re-arranged the findbugs code a bit to give more realistic times * if for some reason openssl or base64 throws an error, just send them to /dev/null * fixed a minor message bug in the site check was (Author: aw): -19: * Merged in the fixes from HADOOP-11845, otherwise rat checks fail because mvn site generates a file that violates rat * shellcheck test reports version of shellcheck * shellcheck find command was very broken * upgraded my local copy of shellcheck, which now includes some new checks. fixed errors from those new checks (mainly local blah=subshell issues) * somewhere along the way, the value of the initial cwd got screwed up. * re-arranged the findbugs code a bit to give more realistic times * if for some reason openssl or base64 throws an error, just send them to /dev/null rewrite test-patch.sh - Key: HADOOP-11746 URL: https://issues.apache.org/jira/browse/HADOOP-11746 Project: Hadoop Common Issue Type: Test Components: build, test Affects Versions: 3.0.0 Reporter: Allen Wittenauer Assignee: Allen Wittenauer Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch, HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch, HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch, HADOOP-11746-12.patch, HADOOP-11746-13.patch, HADOOP-11746-14.patch, HADOOP-11746-15.patch, HADOOP-11746-16.patch, HADOOP-11746-17.patch, HADOOP-11746-18.patch, HADOOP-11746-19.patch This code is bad and you should feel bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502068#comment-14502068 ] Allen Wittenauer edited comment on HADOOP-11746 at 4/19/15 7:27 PM: -19: * Merged in the fixes from HADOOP-11845, otherwise rat checks fail because mvn site generates a file that violates rat. this also enables shelldocs to actually build documentation for test-patch's API too. * shellcheck test reports version of shellcheck * shellcheck find command was very broken * upgraded my local copy of shellcheck, which now includes some new checks. fixed errors from those new checks (mainly local blah=subshell issues) * somewhere along the way, the value of the initial cwd got screwed up. * re-arranged the findbugs code a bit to give more realistic times * if for some reason openssl or base64 throws an error, just send them to /dev/null * fixed a minor message bug in the site check was (Author: aw): -19: * Merged in the fixes from HADOOP-11845, otherwise rat checks fail because mvn site generates a file that violates rat * shellcheck test reports version of shellcheck * shellcheck find command was very broken * upgraded my local copy of shellcheck, which now includes some new checks. fixed errors from those new checks (mainly local blah=subshell issues) * somewhere along the way, the value of the initial cwd got screwed up. * re-arranged the findbugs code a bit to give more realistic times * if for some reason openssl or base64 throws an error, just send them to /dev/null * fixed a minor message bug in the site check rewrite test-patch.sh - Key: HADOOP-11746 URL: https://issues.apache.org/jira/browse/HADOOP-11746 Project: Hadoop Common Issue Type: Test Components: build, test Affects Versions: 3.0.0 Reporter: Allen Wittenauer Assignee: Allen Wittenauer Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch, HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch, HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch, HADOOP-11746-12.patch, HADOOP-11746-13.patch, HADOOP-11746-14.patch, HADOOP-11746-15.patch, HADOOP-11746-16.patch, HADOOP-11746-17.patch, HADOOP-11746-18.patch, HADOOP-11746-19.patch This code is bad and you should feel bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500609#comment-14500609
]
Allen Wittenauer edited comment on HADOOP-11746 at 4/17/15 8:36 PM:
-18:
* add --modulelist and --testlist options to forcibly add modules and test
subsystems to a run. there is no way to delete, but that's probably a good
thing really.
* removed the branch restrictions since this apparently won't impact jenkins
* the check for new tests actually uses the /test/ file path against the list
of changed files in the check for new tests in unit test mode. This prevents
some false positives and should improve the count in certain/rare situations.
Prior to this, it just looked for (something)/test(something) in the actual
patch... which meant test-patch itself would be cleared. (Ironically,
test-patch.sh is now capable of testing itself, so ... yeah. test-ception.)
* in developer mode when \-\-resetrepo is used, the user output reminds that
the code the user chose to run in a destructive mode. (\-\-resetrepo is the
default in jenkins mode, obviously)
* Added code to chmod +x all directories in echo_and_redirect. This should
cover every maven run.
* Cleaned up the eclipse description.
* Checkstyle now uses the ${PROJECT_NAME} var instead of the hard coded hadoop
value, making the code more portable.
* Reworded some debug output for test subsystems when they are triggered
* verify_needed_test was missing documentation
bq. Adding audience / stability comments is a really nice touch.
Thanks. If you run shelldoc.py (after HADOOP-11845 is applied... ugh) against
the code, you'll get a markdown document of the function calls. We're currently
using this same functionality in trunk to document hadoop-functions.sh as the
'official' shell API for shell profiles.
was (Author: aw):
-18:
* add --modulelist and --testlist options to forcibly add modules and test
subsystems to a run. there is no way to delete, but that's probably a good
thing really.
* removed the branch restrictions since this apparently won't impact jenkins
* the check for new tests actually uses the /test/ file path against the list
of changed files in the check for new tests in unit test mode. This prevents
some false positives and should improve the count in certain/rare situations.
Prior to this, it just looked for (something)/test(something) in the actual
patch... which meant test-patch itself would be cleared. (Ironically,
test-patch.sh is now capable of testing itself, so ... yeah. test-ception.)
* in developer mode when --resetrepo is used, the user output reminds that the
code the user chose to run in a destructive mode. (--resetrepo is the default
in jenkins mode, obviously)
* Added code to chmod +x all directories in echo_and_redirect. This should
cover every maven run.
* Cleaned up the eclipse description.
* Checkstyle now uses the ${PROJECT_NAME} var instead of the hard coded hadoop
value, making the code more portable.
* Reworded some debug output for test subsystems when they are triggered
* verify_needed_test was missing documentation
bq. Adding audience / stability comments is a really nice touch.
Thanks. If you run shelldoc.py (after HADOOP-11845 is applied... ugh) against
the code, you'll get a markdown document of the function calls. We're currently
using this same functionality in trunk to document hadoop-functions.sh as the
'official' shell API for shell profiles.
rewrite test-patch.sh
-
Key: HADOOP-11746
URL: https://issues.apache.org/jira/browse/HADOOP-11746
Project: Hadoop Common
Issue Type: Test
Components: build, test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch,
HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch,
HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch,
HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch,
HADOOP-11746-12.patch, HADOOP-11746-13.patch, HADOOP-11746-14.patch,
HADOOP-11746-15.patch, HADOOP-11746-16.patch, HADOOP-11746-17.patch,
HADOOP-11746-18.patch
This code is bad and you should feel bad.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498673#comment-14498673 ] Allen Wittenauer edited comment on HADOOP-11746 at 4/16/15 8:41 PM: (Although, really, that's a problem with the branch detection unless we backport it to every single branch. So we probably just need to commit this to a reasonable number of branches (branch-1, branch-2, branch-2.7, trunk, ... ? ) and just be aware that someone can upload a patch that may throw things off.) was (Author: aw): (Although, really, that's a problem with the branch detection unless we backport it to every single branch. So we probably just need to commit this to a reason a reasonable number of branches (branch-1, branch-2, branch-2.7, trunk, ... ? ) and just be aware that someone can upload a patch that may throw things off.) rewrite test-patch.sh - Key: HADOOP-11746 URL: https://issues.apache.org/jira/browse/HADOOP-11746 Project: Hadoop Common Issue Type: Test Components: build, test Affects Versions: 3.0.0 Reporter: Allen Wittenauer Assignee: Allen Wittenauer Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch, HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch, HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch, HADOOP-11746-12.patch, HADOOP-11746-13.patch, HADOOP-11746-14.patch, HADOOP-11746-15.patch, HADOOP-11746-16.patch This code is bad and you should feel bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498660#comment-14498660 ] Allen Wittenauer edited comment on HADOOP-11746 at 4/16/15 8:24 PM: A few things: a) It'd be great if HADOOP-11778 was committed as well. This updates the maven checkstyle plugin so that it doesn't NPE on our code base in certain conditions, at least on trunk. It doesn't *break* the plugin, but it does mean the results may not be 100% accurate. b) We need to be aware that shellcheck isn't installed on the jenkins boxes yet. This means the shellcheck tests won't execute until that's rectified. (That plugin shouldn't error, however, since the code does try to see if it is installed first.) c) We'll likely need to commit to branch-2 anyway if we want the patch branch detection code to work. I don't know how jenkins actually uses test-patch.sh, but this code does *not* switch the branch back to trunk after it runs on another branch. This might very well be a bug, now that I think about it more. was (Author: aw): A few things: a) It'd be great if HADOOP-11778 was committed as well. This updates the checkstyle plugin so that it doesn't NPE on our code base in certain conditions, at least on trunk. It doesn't *break* the plugin, but it does mean the results may not be 100% accurate. b) We need to be aware that shellcheck isn't installed on the jenkins boxes yet. This means the shellcheck tests won't execute until that's rectified. (That plugin shouldn't error, however, since the code does try to see if it is installed first.) c) We'll likely need to commit to branch-2 anyway if we want the patch branch detection code to work. I don't know how jenkins actually uses test-patch.sh, but this code does *not* switch the branch back to trunk after it runs on another branch. This might very well be a bug, now that I think about it more. rewrite test-patch.sh - Key: HADOOP-11746 URL: https://issues.apache.org/jira/browse/HADOOP-11746 Project: Hadoop Common Issue Type: Test Components: build, test Affects Versions: 3.0.0 Reporter: Allen Wittenauer Assignee: Allen Wittenauer Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch, HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch, HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch, HADOOP-11746-12.patch, HADOOP-11746-13.patch, HADOOP-11746-14.patch, HADOOP-11746-15.patch, HADOOP-11746-16.patch This code is bad and you should feel bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487749#comment-14487749
]
Allen Wittenauer edited comment on HADOOP-11746 at 4/9/15 5:51 PM:
---
-13:
* fix an issue where a git ref may be in the future vs. the copy on disk. We
no longer do a pull --rebase, but a fetch + checkout --force in jenkins mode.
* shellcheck support beefed up, including now failing on new errors, not if the
total count was higher. Also smarter about picking up on patches that patch
shell code that are not in the normal places
* cosmetic fixes for the test table
* renamed populate_unit_table to populate_test_table to better reflect what it
is
* findbugs moved into its own optional test instead of being tied to javac so
that pom.xml, native code, etc, won't trigger a run. (This does mean that
testing findbugs itself will get missed now... but that's a very rare
occurrence...)
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 00m 00s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 00m 00s | Pre-patch trunk compilation is
healthy. |
| {color:red}-1{color} | @author | 00m 00s | The patch appears to contain 13
@author tags which the Hadoop community has agreed to not allow in code
contributions. |
| {color:green}+1{color} | whitespace | 00m 00s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | release audit | 00m 08s | The applied patch does not
increase the total number of release audit warnings. |
| {color:red}-1{color} | shellcheck | 00m 03s | The applied patch generated 6
new shellcheck issues (total was 165, now 27). |
was (Author: aw):
-13:
* fix an issue where a git ref may be in the future vs. the copy on disk. We
no longer do a pull --rebase, but a fetch + checkout --force in jenkins mode.
* shellcheck support beefed up, including now failing on new errors, not if the
total count was higher. Also smarter about picking up on patches that patch
shell code that are not in the normal places
* cosmetic fixes for the test table
* renamed populate_unit_table to populate_test_table to better reflect what it
is
* findbugs moved into its own optional test instead of being tied to javac so
that pom.xml, native code, etc, won't trigger a run. (This does mean that
testing findbugs itself will get missed now... but that's a very rare
occurrence...)
rewrite test-patch.sh
-
Key: HADOOP-11746
URL: https://issues.apache.org/jira/browse/HADOOP-11746
Project: Hadoop Common
Issue Type: Test
Components: build, test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch,
HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch,
HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch,
HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch,
HADOOP-11746-12.patch, HADOOP-11746-13.patch
This code is bad and you should feel bad.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486660#comment-14486660
]
Allen Wittenauer edited comment on HADOOP-11746 at 4/9/15 4:27 AM:
---
-12:
* add --resetrepo to simulate jenkins git repo nuker in developer mode
* don't send a jira message and abort early if the URL doesn't end in .patch
* Allow git(8 chars) or git(41 chars) as branch names for patch testing
* make it explicit in the report output if we were in branch or git ref mode
* fix some issues with checkstyle
* when using --resetrepo mode, shellcheck would erroneously flag .orig and .rej
files from previous patches since those aren't cleared by git due to .gitignore
* fix a few shellcheck warnings I had missed. (shellcheck is still mostly
ignoring dev-support. should probably fix that.)
* findbugs now gives a summary report on the console/jira output rather than
forcing folks to look at the full findbugs output (altho that is still listed
too!)
* set the TIMER default at startup to be current time rather 0 to prevent
incredibly bogus, decades long runtimes in case of early aborts
* re-order the flags in the options parser
* fix an issue with the test heuristics so that external plugins aren't
prematurely ignored
Testing itself, it says:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 00m 00s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 00m 00s | Pre-patch trunk compilation is
healthy. |
| {color:red}-1{color} | @author | 00m 00s | The patch appears to contain 13
@author tags which the Hadoop community has agreed to not allow in code
contributions. |
| {color:green}+1{color} | whitespace | 00m 00s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | release audit | 00m 09s | The applied patch does not
increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck | 00m 02s | There were no new shellcheck
issues. |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | shellcheck |
| git revision | f4b3fc5 / trunk |
| Console output | /artifact/patchprocess/console |
This message was automatically generated.
was (Author: aw):
-12:
* add --resetrepo to simulate jenkins git repo nuker in developer mode
* don't send a jira message and abort early if the URL doesn't end in .patch
* Allow git(8 chars) or git(41 chars) as branch names for patch testing
* make it explicit in the report output if we were in branch or git ref mode
* fix some issues with checkstyle
* when using --resetrepo mode, shellcheck would erroneously flag .orig and .rej
files from previous patches since those aren't cleared by git due to .gitignore
* fix a few shellcheck warnings I had missed
* findbugs now gives a summary report on the console/jira output rather than
forcing folks to look at the full findbugs output (altho that is still listed
too!)
* set the TIMER to be current time rather 0 to prevent incredibly bogus,
decades long runtimes in case of early aborts
* re-order the flags in the options parser
* fix an issue with the test heuristics so that external plugins aren't
prematurely ignored
Testing itself, it says:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 00m 00s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 00m 00s | Pre-patch trunk compilation is
healthy. |
| {color:red}-1{color} | @author | 00m 00s | The patch appears to contain 13
@author tags which the Hadoop community has agreed to not allow in code
contributions. |
| {color:green}+1{color} | whitespace | 00m 00s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | release audit | 00m 09s | The applied patch does not
increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck | 00m 02s | There were no new shellcheck
issues. |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | shellcheck |
| git revision | f4b3fc5 / trunk |
| Console output | /artifact/patchprocess/console |
This message was automatically generated.
rewrite test-patch.sh
-
Key: HADOOP-11746
URL: https://issues.apache.org/jira/browse/HADOOP-11746
Project: Hadoop Common
Issue Type: Test
Components: build, test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch,
HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch,
HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch,
HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch,
HADOOP-11746-12.patch
This
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391696#comment-14391696 ] Colin Patrick McCabe edited comment on HADOOP-11746 at 4/1/15 11:06 PM: [~busbey], have you tried out https://chrome.google.com/webstore/detail/git-patch-viewer/hkoggakcdopbgnaeeidcmopfekipkleg ? I find it really helpful for viewing diffs on JIRA. [edit: looking at this again, this may not be too helpful since this is mostly a rewrite, so having both the left and right sides is not that important.] was (Author: cmccabe): [~busbey], have you tried out https://chrome.google.com/webstore/detail/git-patch-viewer/hkoggakcdopbgnaeeidcmopfekipkleg ? I find it really helpful for viewing diffs on JIRA. rewrite test-patch.sh - Key: HADOOP-11746 URL: https://issues.apache.org/jira/browse/HADOOP-11746 Project: Hadoop Common Issue Type: Test Components: build, test Affects Versions: 3.0.0 Reporter: Allen Wittenauer Assignee: Allen Wittenauer Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch, HADOOP-11746-05.patch This code is bad and you should feel bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388061#comment-14388061 ] Allen Wittenauer edited comment on HADOOP-11746 at 3/31/15 4:39 PM: -04: * *MUCH* better branch and issue detection on patches * checkstyle sort of works now! * add missing license files * some general code cleanup * JIRA comments are now formatted correctly * console comments had some display issues fixed * Removed a lot of if jenkins this, if not jenkins this, simplifying the code paths * in addition to files, test-patch.sh now supports issues and http(s) URLs which will automatically download patches off of JIRA * give some hints about execution times while running too * fixed some issues around running tests To-do: * Add some afffettty checks. * Test on Jenkins * Do more broken patch tests * cleanup the function names, comment the code more, etc. * Any other requests? was (Author: aw): -04: * *MUCH* better branch and issue detection on patches * checkstyle sort of works now! * add missing license files * some general code cleanup * JIRA comments are now formatted correctly * console comments had some display issues fixed * Removed a lot of if jenkins this, if not jenkins this, simplifying the code paths * in addition to files, test-patch.sh now supports issues and http(s) URLs which will automatically download patches off of JIRA * give some hints about execution times while running too * fixed some issues around running tests To-do: * Test on Jenkins * Do more broken patch tests * cleanup the function names, comment the code more, etc. * Any other requests? rewrite test-patch.sh - Key: HADOOP-11746 URL: https://issues.apache.org/jira/browse/HADOOP-11746 Project: Hadoop Common Issue Type: Test Components: build, test Affects Versions: 3.0.0 Reporter: Allen Wittenauer Assignee: Allen Wittenauer Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch This code is bad and you should feel bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388901#comment-14388901 ] Allen Wittenauer edited comment on HADOOP-11746 at 3/31/15 5:41 PM: Oh, also, smart-apply.sh has the same /tmp race issues (using the exact same file name as test-patch.sh). Hooray! was (Author: aw): Oh, also, smart-apply.sh has the same /tmp race issues. Hooray! rewrite test-patch.sh - Key: HADOOP-11746 URL: https://issues.apache.org/jira/browse/HADOOP-11746 Project: Hadoop Common Issue Type: Test Components: build, test Affects Versions: 3.0.0 Reporter: Allen Wittenauer Assignee: Allen Wittenauer Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch This code is bad and you should feel bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388061#comment-14388061 ] Allen Wittenauer edited comment on HADOOP-11746 at 3/31/15 5:54 AM: -04: * *MUCH* better branch and issue detection on patches * checkstyle sort of works now! * add missing license files * some general code cleanup * JIRA comments are now formatted correctly * console comments had some display issues fixed * Removed a lot of if jenkins this, if not jenkins this, simplifying the code paths * in addition to files, test-patch.sh now supports issues and http(s) URLs which will automatically download patches off of JIRA * give some hints about execution times while running too * fixed some issues around running tests To-do: * Test on Jenkins * Do more broken patch tests * cleanup the function names, comment the code more, etc. * Any other requests? was (Author: aw): -04: * *MUCH* better branch and issue detection on patches * checkstyle sort of works now! * add missing license files * some general code cleanup * JIRA comments are now formatted correctly * console comments had some display issues fixed * Removed a lot of if jenkins this, if not jenkins this, simplifying the code paths * in addition to files, test-patch.sh now supports issues and http(s) URLs which will automatically download patches off of JIRA * give some hints about execution times while running too * fixed some issues around running tests To-do: * Test on Jenkins * Do more broken patch tests * Any other requests? rewrite test-patch.sh - Key: HADOOP-11746 URL: https://issues.apache.org/jira/browse/HADOOP-11746 Project: Hadoop Common Issue Type: Test Components: build, test Affects Versions: 3.0.0 Reporter: Allen Wittenauer Assignee: Allen Wittenauer Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch This code is bad and you should feel bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385502#comment-14385502
]
Allen Wittenauer edited comment on HADOOP-11746 at 3/28/15 8:03 PM:
Just testing:
*{color:red}-1 overall{color}*
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 09m 31s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 00m 00s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 00m 00s | The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. |
| {color:green}+1{color} | javac | 04m 34s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 06m 22s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 00m 09s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | install | 02m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 00m 24s | The patch built with
eclipse:eclipse. |
\\
|| Subsystem || Report ||
| Release Audit | /artifact/patchprocess/diffJavacWarnings.txt |
| Console output | /console |
This message was automatically generated.
was (Author: aw):
Just testing:
*{color:red}-1 overall{color}*
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 09m 31s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 00m 00s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 00m 00s | The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. |
| {color:green}+1{color} | javac | 04m 34s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 06m 22s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 00m 09s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | install | 02m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 00m 24s | The patch built with
eclipse:eclipse. |
|| Subsystem || Report ||
| Release Audit | /artifact/patchprocess/diffJavacWarnings.txt |
| Console output | /console |
This message was automatically generated.
rewrite test-patch.sh
-
Key: HADOOP-11746
URL: https://issues.apache.org/jira/browse/HADOOP-11746
Project: Hadoop Common
Issue Type: Test
Components: build, test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch,
HADOOP-11746-02.patch
This code is bad and you should feel bad.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385502#comment-14385502
]
Allen Wittenauer edited comment on HADOOP-11746 at 3/28/15 7:58 PM:
Just testing:
*{color:red}-1 overall{color}*
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 09m 31s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 00m 00s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 00m 00s | The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. |
| {color:green}+1{color} | javac | 04m 34s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 06m 22s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 00m 09s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | install | 02m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 00m 24s | The patch built with
eclipse:eclipse. |
|| Subsystem || Report ||
| Release Audit | /artifact/patchprocess/diffJavacWarnings.txt |
| Console output | /console |
This message was automatically generated.
was (Author: aw):
Just testing:
*{color:red}-1 overall{color}*
|| Vote || Subsystem || TTR || Comment ||
| {color:blue}0{color} | pre-patch | 09m 31s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 00m 00s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 00m 00s | The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. |
| {color:green}+1{color} | javac | 04m 34s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 06m 22s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 00m 09s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | install | 02m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 00m 24s | The patch built with
eclipse:eclipse. |
|| Subsystem || Report ||
| Release Audit | /artifact/patchprocess/diffJavacWarnings.txt |
| Console output | /console |
This message was automatically generated.
rewrite test-patch.sh
-
Key: HADOOP-11746
URL: https://issues.apache.org/jira/browse/HADOOP-11746
Project: Hadoop Common
Issue Type: Test
Components: build, test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch,
HADOOP-11746-02.patch
This code is bad and you should feel bad.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385502#comment-14385502
]
Allen Wittenauer edited comment on HADOOP-11746 at 3/28/15 7:57 PM:
Just testing:
*{color:red}-1 overall{color}*
|| Vote || Subsystem || TTR || Comment ||
| {color:blue}0{color} | pre-patch | 09m 31s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 00m 00s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 00m 00s | The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. |
| {color:green}+1{color} | javac | 04m 34s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 06m 22s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 00m 09s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | install | 02m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 00m 24s | The patch built with
eclipse:eclipse. |
|| Subsystem || Report ||
| Release Audit | /artifact/patchprocess/diffJavacWarnings.txt |
| Console output | /console |
This message was automatically generated.
was (Author: aw):
Just testing:
{color:red}-1 overall{color}
|| Vote || Subsystem || Comment ||
| {color:blue}0{color} | pre-patch | 09m 31s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 00m 00s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 00m 00s | The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. |
| {color:green}+1{color} | javac | 04m 34s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 06m 22s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 00m 09s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | install | 02m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 00m 24s | The patch built with
eclipse:eclipse. |
|| Subsystem || Report ||
| Release Audit | /artifact/patchprocess/diffJavacWarnings.txt |
| Console output | /console |
This message was automatically generated.
rewrite test-patch.sh
-
Key: HADOOP-11746
URL: https://issues.apache.org/jira/browse/HADOOP-11746
Project: Hadoop Common
Issue Type: Test
Components: build, test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch,
HADOOP-11746-02.patch
This code is bad and you should feel bad.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385502#comment-14385502
]
Allen Wittenauer edited comment on HADOOP-11746 at 3/28/15 8:03 PM:
Just testing:
*{color:red}-1 overall{color}*
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 09m 31s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 00m 00s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 00m 00s | The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. |
| {color:green}+1{color} | javac | 04m 34s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 06m 22s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 00m 09s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | install | 02m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 00m 24s | The patch built with
eclipse:eclipse. |
\\
|| Subsystem || Report ||
| Release Audit | /artifact/patchprocess/diffJavacWarnings.txt |
| Console output | /console |
This message was automatically generated.
was (Author: aw):
Just testing:
*{color:red}-1 overall{color}*
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 09m 31s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 00m 00s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 00m 00s | The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. |
| {color:green}+1{color} | javac | 04m 34s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 06m 22s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 00m 09s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | install | 02m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 00m 24s | The patch built with
eclipse:eclipse. |
\\
|| Subsystem || Report ||
| Release Audit | /artifact/patchprocess/diffJavacWarnings.txt |
| Console output | /console |
This message was automatically generated.
rewrite test-patch.sh
-
Key: HADOOP-11746
URL: https://issues.apache.org/jira/browse/HADOOP-11746
Project: Hadoop Common
Issue Type: Test
Components: build, test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch,
HADOOP-11746-02.patch
This code is bad and you should feel bad.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385629#comment-14385629
]
Allen Wittenauer edited comment on HADOOP-11746 at 3/29/15 5:17 AM:
Current shell-output. (Note that HADOOP-11746 is the name of the git branch
where I ran the test-patch script)
{noformat}
-1 overall
| Vote | Subsystem | Runtime | Comment
| 0 | pre-patch | 09m 30s | Pre-patch HADOOP-11746 compilation
| | | | is healthy.
| +1 |@author | 00m 00s | The patch does not contain any
| | | | @author tags.
| -1 | tests included | 00m 00s | The patch doesn't appear to include
| | | | any new or modified tests. Please
| | | | justify why no new tests are needed
| | | | for this patch. Also please list what
| | | | manual steps were performed to verify
| | | | this patch.
| +1 | javac | 04m 22s | There were no new javac warning
| | | | messages.
| +1 |javadoc | 06m 16s | There were no new javadoc warning
| | | | messages.
| -1 | release audit | 00m 09s | The applied patch generated 3
| | | | release audit warnings.
| +1 | checkstyle | 03m 04s | There were no new checkstyle
issues.
| +1 | shellcheck | 00m 02s | There were no new shellcheck
issues.
| +1 |install | 02m 31s | mvn install still works.
| +1 |eclipse:eclipse | 00m 24s | The patch built with
| | | | eclipse:eclipse.
|| Subsystem || Report ||
| Release Audit | /tmp/hadoop-test-patch/14934/patchReleaseAuditProblems.txt |
{noformat}
The current jira format has some minor issues. :( Fixing the two missing new
lines and the missing backslash results in:
(x) *{color:red}-1 overall{color}*
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 09m 30s | Pre-patch HADOOP-11746
compilation is healthy. |
| {color:green}+1{color} | @author | 00m 00s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 00m 00s | The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. |
| {color:green}+1{color} | javac | 04m 22s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 06m 16s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 00m 09s | The applied patch generated
3 release audit warnings. |
| {color:green}+1{color} | checkstyle | 03m 04s | There were no new checkstyle
issues. |
| {color:green}+1{color} | shellcheck | 00m 02s | There were no new shellcheck
issues. |
| {color:green}+1{color} | install | 02m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 00m 24s | The patch built with
eclipse:eclipse. |
\\
|| Subsystem || Report ||
| Release Audit | /artifact/patchprocess/patchReleaseAuditProblems.txt |
| Console output | /artifact/patchprocess/console |
This message was automatically generated.
was (Author: aw):
Current shell-output:
{noformat}
-1 overall
| Vote | Subsystem | Runtime | Comment
| 0 | pre-patch | 09m 30s | Pre-patch HADOOP-11746 compilation
| | | | is healthy.
| +1 |@author | 00m 00s | The patch does not contain any
| | | | @author tags.
| -1 | tests included | 00m 00s | The patch doesn't appear to include
| | | | any new or modified tests. Please
| | | | justify why no new tests are needed
| | | | for this patch. Also please list what
| | | | manual steps were performed to verify
| | | | this patch.
| +1 | javac | 04m 22s | There were no new javac warning
| | | | messages.
| +1 |javadoc | 06m 16s | There were no new javadoc warning
| | | | messages.
| -1 | release audit | 00m 09s | The applied patch generated 3
| | | | release audit warnings.
| +1 | checkstyle | 03m 04s | There were no new checkstyle
issues.
| +1 | shellcheck | 00m 02s | There were no new shellcheck
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383372#comment-14383372
]
Allen Wittenauer edited comment on HADOOP-11746 at 3/27/15 5:56 AM:
-02:
* still very little new functionality, except that --dirty-workspace is now
working for me.
* console output cleanup
* fix the /tmp default for the patch scratch space to be
/tmp/(projname)-test-patch/pid to allow for simultaneous test patch runs
* add in a timer to show how long various steps take (as requested by
[~raviprak] )
* Fix more we should have a var rather than hard code this binary issues
* just skip the findbugs test if findbugs isn't installed
* send the mvn install run to a log file rather than dumping it to the screen
* fix some of the backslash indentation problems generated by the autoformatter
Current console output now looks like:
{noformat}
w$ dev-support/test-patch.sh --dirty-workspace /tmp/H1
Running in developer mode
/tmp/Hadoop-test-patch/54448 has been created
===
===
Testing patch for H1.
===
===
-1 overall
| Vote | Subsystem | Comment
| +1 |@author | 00m 00s | The patch does not contain any
| @author tags.
| -1 | tests included | 00m 00s | The patch doesn't appear to include
| any new or modified tests. Please
| justify why no new tests are needed
| for this patch. Also please list what
| manual steps were performed to verify
| this patch.
| +1 | javac | 04m 30s | There were no new javac warning
| messages.
| +1 |javadoc | 06m 15s | There were no new javadoc warning
| messages.
| +1 |eclipse:eclipse | 00m 24s | The patch built with eclipse:eclipse.
| -1 | release audit | 00m 05s | The applied patch generated 1
release
| audit warnings.
===
===
Finished build.
===
===
{noformat}
Note the always centered text and the column wrap on the output. :D
was (Author: aw):
-02:
* still very little new functionality, except that --dirty-workspace is now
working for me.
* console output cleanup
* fix the /tmp default for the patch scratch space to be
/tmp/(projname)-test-patch/pid to allow for simultaneous test patch runs
* add in a timer to show how long various steps take (as requested by
[~raviprak] )
* Fix more we should have a var rather than hard code this binary issues
* just skip the findbugs test if findbugs isn't installed
* send the mvn install run to a log file rather than dumping it to the screen
* fix some of the backslash indentation problems generated by the autoformatter
Current console output now looks like:
{code}
w$ dev-support/test-patch.sh --dirty-workspace /tmp/H1
Running in developer mode
/tmp/Hadoop-test-patch/54448 has been created
===
===
Testing patch for H1.
===
===
-1 overall
| Vote | Subsystem | Comment
| +1 |@author | 00m 00s | The patch does not contain any
| @author tags.
| -1 | tests included | 00m 00s | The patch doesn't appear to include
| any new or modified tests. Please
| justify why no new tests are needed
| for this patch. Also please list what
| manual steps were performed to verify
| this patch.
| +1 | javac | 04m 30s | There were no new javac warning
| messages.
| +1 |javadoc | 06m 15s | There were no new javadoc
[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
[ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380948#comment-14380948 ] Allen Wittenauer edited comment on HADOOP-11746 at 3/25/15 11:03 PM: - Nah. Probably not worth it. FWIW, the biggest problems are mixing up string and arithmetic comparison operators. was (Author: aw): Nah. Probably not worth it. rewrite test-patch.sh - Key: HADOOP-11746 URL: https://issues.apache.org/jira/browse/HADOOP-11746 Project: Hadoop Common Issue Type: Test Components: build, test Affects Versions: 3.0.0 Reporter: Allen Wittenauer Assignee: Allen Wittenauer Attachments: HADOOP-11746-00.patch This code is bad and you should feel bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
